133267 2014-05-25 15:23:37 -0700 Use the right paths for website data 2014-05-25 19:39:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca darin oldest_to_newest 1011596 0 andersca 2014-05-25 15:23:37 -0700 Use the right paths for website data 1011597 1 232044 andersca 2014-05-25 15:24:45 -0700 Created attachment 232044 Patch 1011598 2 andersca 2014-05-25 15:30:51 -0700 Committed r169325: <http://trac.webkit.org/changeset/169325> 1011599 3 232044 darin 2014-05-25 15:34:36 -0700 Comment on attachment 232044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 > + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; Another possible fix would be: websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation would work too. 1011600 4 darin 2014-05-25 15:35:09 -0700 (In reply to comment #3) > unless it’s value I think I meant "valid", or "expected", here. 1011606 5 andersca 2014-05-25 18:06:00 -0700 (In reply to comment #3) > (From update of attachment 232044 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 > > + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; > > Another possible fix would be: > > websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation > > I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: > > websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation > > would work too. It would, except -[NSURL fileSystemRepresentation] isn't available on 10.8. 1011620 6 232044 darin 2014-05-25 19:39:29 -0700 Comment on attachment 232044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232044&action=review >>> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:156 >>> + webContextConfiguration.localStorageDirectory = websiteDataDirectoryURL(@"LocalStorage").absoluteURL.path.fileSystemRepresentation; >> >> Another possible fix would be: >> >> websiteDataDirectoryURL(@"LocalStorage").absoluteURL.fileSystemRepresentation >> >> I don’t think there’s any need to call “path” explicitly. And unless it’s value to have these be relative URLs, I would expect that just: >> >> websiteDataDirectoryURL(@"LocalStorage").fileSystemRepresentation >> >> would work too. > > It would, except -[NSURL fileSystemRepresentation] isn't available on 10.8. Oh, got it. 232044 2014-05-25 15:24:45 -0700 2014-05-25 19:39:29 -0700 Patch bug-133267-20140525152422.patch text/plain 4230 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTI4N2U0YWVhMTk0Y2Uw MWQ4MjRiYTYyOGE3ODg3NDI0MWJkYjYwNy4uZTZiNDMxY2QzM2JkZWUyY2JlNjVjMzBmZDY0YTcy M2I2ZjVkNjdhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE0LTA1LTI1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHRoZSByaWdo dCBwYXRocyBmb3Igd2Vic2l0ZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzMyNjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MDI3Njk4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tOgorICAgICAgICAoLVtXS1Byb2Nlc3NQ b29sIF9pbml0V2l0aENvbmZpZ3VyYXRpb246XSk6CisgICAgICAgIEdldCB0aGUgcGF0aCBvZiB0 aGUgYWJzb2x1dGUgVVJMLgorCisgICAgICAgICogVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9y YWdlRGF0YWJhc2VUcmFja2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TG9jYWxTdG9yYWdlRGF0 YWJhc2VUcmFja2VyOjpkYXRhYmFzZVBhdGgpOgorICAgICAgICBGaXggc3BlbGxpbmcgZXJyb3Iu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9u LmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOjpkaWRDYWNo ZVJlc291cmNlKToKKyAgICAgICAgRGl0dG8uCisKIDIwMTQtMDUtMjUgIFNhbSBXZWluaWcgIDxz YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBmaXggMi4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbSBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbQppbmRleCBlNWUzNzZm OGU2MTM1NGFkN2VmMTU3OGQ5MDc1NTMzYzc3ZTE2MWNmLi43MGI0ZDE5Yzk2OTcyMzUxNjhjYTFm NDNmNWNmNDNhMmIwN2UzODZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tCkBAIC0xNTMsOSArMTUzLDkgQEAgc3RhdGljIE5T VVJMICp3ZWJzaXRlRGF0YURpcmVjdG9yeVVSTChOU1N0cmluZyAqZGlyZWN0b3J5TmFtZSkKICAg ICAgICAgd2ViQ29udGV4dENvbmZpZ3VyYXRpb24uaW5qZWN0ZWRCdW5kbGVQYXRoID0gYnVuZGxl VVJMLnBhdGg7CiAgICAgfQogCi0gICAgd2ViQ29udGV4dENvbmZpZ3VyYXRpb24ubG9jYWxTdG9y YWdlRGlyZWN0b3J5ID0gd2Vic2l0ZURhdGFEaXJlY3RvcnlVUkwoQCJMb2NhbFN0b3JhZ2UiKS5h YnNvbHV0ZVN0cmluZy5maWxlU3lzdGVtUmVwcmVzZW50YXRpb247Ci0gICAgd2ViQ29udGV4dENv bmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkgPSB3ZWJzaXRlRGF0YURpcmVjdG9y eVVSTChAIldlYlNRTCIpLmFic29sdXRlU3RyaW5nLmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbjsK LSAgICB3ZWJDb250ZXh0Q29uZmlndXJhdGlvbi5pbmRleGVkREJEYXRhYmFzZURpcmVjdG9yeSA9 IHdlYnNpdGVEYXRhRGlyZWN0b3J5VVJMKEAiSW5kZXhlZERCIikuYWJzb2x1dGVTdHJpbmcuZmls ZVN5c3RlbVJlcHJlc2VudGF0aW9uOworICAgIHdlYkNvbnRleHRDb25maWd1cmF0aW9uLmxvY2Fs U3RvcmFnZURpcmVjdG9yeSA9IHdlYnNpdGVEYXRhRGlyZWN0b3J5VVJMKEAiTG9jYWxTdG9yYWdl IikuYWJzb2x1dGVVUkwucGF0aC5maWxlU3lzdGVtUmVwcmVzZW50YXRpb247CisgICAgd2ViQ29u dGV4dENvbmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkgPSB3ZWJzaXRlRGF0YURp cmVjdG9yeVVSTChAIldlYlNRTCIpLmFic29sdXRlVVJMLnBhdGguZmlsZVN5c3RlbVJlcHJlc2Vu dGF0aW9uOworICAgIHdlYkNvbnRleHRDb25maWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGly ZWN0b3J5ID0gd2Vic2l0ZURhdGFEaXJlY3RvcnlVUkwoQCJJbmRleGVkREIiKS5hYnNvbHV0ZVVS TC5wYXRoLmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbjsKIAogICAgIEFQSTo6T2JqZWN0Ojpjb25z dHJ1Y3RJbldyYXBwZXI8V2ViS2l0OjpXZWJDb250ZXh0PihzZWxmLCBzdGQ6Om1vdmUod2ViQ29u dGV4dENvbmZpZ3VyYXRpb24pKTsKICAgICBfY29udGV4dC0+c2V0SGlzdG9yeUNsaWVudChzdGQ6 Om1ha2VfdW5pcXVlPFdlYktpdDo6SGlzdG9yeUNsaWVudD4oKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1N0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJh c2VUcmFja2VyLmNwcAppbmRleCA4ZTY4OGRiZGM4ODhiZTFmOGZmYzgzMTQyN2Y0MTM2MDEyNjNk ODQ3Li4zMzg0MTEwMjU1ZjlhMTc2YjQ2ZDU1NzNmZmMwZjIwMDZiNGM0Nzg4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRy YWNrZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9TdG9yYWdlL0xvY2FsU3Rv cmFnZURhdGFiYXNlVHJhY2tlci5jcHAKQEAgLTE1OCw3ICsxNTgsNyBAQCBWZWN0b3I8TG9jYWxT dG9yYWdlRGV0YWlscz4gTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyOjpkZXRhaWxzKCkKIFN0 cmluZyBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI6OmRhdGFiYXNlUGF0aChjb25zdCBTdHJp bmcmIGZpbGVuYW1lKSBjb25zdAogewogICAgIGlmICghbWFrZUFsbERpcmVjdG9yaWVzKG1fbG9j YWxTdG9yYWdlRGlyZWN0b3J5KSkgewotICAgICAgICBMT0dfRVJST1IoIlVuYWJsZWQgdG8gY3Jl YXRlIExvY2FsU3RvcmFnZSBkYXRhYmFzZSBwYXRoICVzIiwgbV9sb2NhbFN0b3JhZ2VEaXJlY3Rv cnkudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGNyZWF0ZSBM b2NhbFN0b3JhZ2UgZGF0YWJhc2UgcGF0aCAlcyIsIG1fbG9jYWxTdG9yYWdlRGlyZWN0b3J5LnV0 ZjgoKS5kYXRhKCkpOwogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NDb25u ZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJv Y2Vzc0Nvbm5lY3Rpb24uY3BwCmluZGV4IDU2YzdmZWJmMmExYWNjM2E0NDI5Y2Q3MWI0ODcwMzgw ZmNjOTg4MjQuLjk2MWY3Mzk1MjE5NGIyZDYxNGNjZmQyYTM3Mzg3NzJhZDRiYTBiNjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nv bm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9OZXR3 b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCkBAIC05MCw3ICs5MCw3IEBAIHZvaWQgTmV0d29ya1By b2Nlc3NDb25uZWN0aW9uOjpkaWRDYWNoZVJlc291cmNlKGNvbnN0IFJlc291cmNlUmVxdWVzdCYg cmVxdWVzdCwKICAgICAKICAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBidWZmZXIgPSBoYW5kbGUu dHJ5V3JhcEluU2hhcmVkQnVmZmVyKCk7CiAgICAgaWYgKCFidWZmZXIpIHsKLSAgICAgICAgTE9H X0VSUk9SKCJVbmFibGVkIHRvIGNyZWF0ZSBTaGFyZWRCdWZmZXIgZnJvbSBTaGFyZWFibGVSZXNv dXJjZSBoYW5kbGUgZm9yIHJlc291cmNlIHVybCAlcyIsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCku dXRmOCgpLmRhdGEoKSk7CisgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGNyZWF0ZSBTaGFy ZWRCdWZmZXIgZnJvbSBTaGFyZWFibGVSZXNvdXJjZSBoYW5kbGUgZm9yIHJlc291cmNlIHVybCAl cyIsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAK