133266 2014-05-25 11:13:39 -0700 CSS JIT: Fix build error raised when CSS_SELECTOR_JIT_DEBUGGING is 1 2014-05-26 17:19:52 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki achristensen benjamin commit-queue oldest_to_newest 1011582 0 ysuzuki 2014-05-25 11:13:39 -0700 Currently, when CSS_SELECTOR_JIT_DEBUGGING is 1, build erros occur on x86_64 environment. 1011583 1 232040 ysuzuki 2014-05-25 11:15:11 -0700 Created attachment 232040 Patch 1011584 2 232040 ysuzuki 2014-05-25 11:15:49 -0700 Comment on attachment 232040 Patch Oops. upload miss. 1011585 3 232041 ysuzuki 2014-05-25 11:16:15 -0700 Created attachment 232041 Patch 1011586 4 232041 ysuzuki 2014-05-25 11:18:54 -0700 Comment on attachment 232041 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232041&action=review Added comments > Source/WebCore/cssjit/SelectorCompiler.cpp:181 > + static const Assembler::RegisterID callFrameRegister; These are declaration, not definition (C++). So referencing them with const reference (const T&) causes link error, "undefined reference to XXX". > Source/WebCore/cssjit/SelectorCompiler.cpp:267 > +const Assembler::RegisterID SelectorCodeGenerator::callFrameRegister = JSC::GPRInfo::callFrameRegister; Added definitions. > Source/WebCore/cssjit/SelectorCompiler.cpp:949 > + prologueRegister.append(callFrameRegister); Since Vector::append referencing the argument as const T&, just replacing `GPRInfo::callFrameRegister` to `JSC::GPRInfo::callFrameRegister` causes link errors. http://stackoverflow.com/questions/5391973/undefined-reference-to-static-const-int http://stackoverflow.com/questions/272900/undefined-reference-to-static-class-member http://stackoverflow.com/questions/3025997/c-defining-static-const-integer-members-in-class-definition 1011591 5 232041 darin 2014-05-25 12:49:46 -0700 Comment on attachment 232041 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232041&action=review >> Source/WebCore/cssjit/SelectorCompiler.cpp:181 >> + static const Assembler::RegisterID callFrameRegister; > > These are declaration, not definition (C++). So referencing them with const reference (const T&) causes link error, "undefined reference to XXX". I would expect to see that problem only when using an old C++ compiler; the status of these has changed in C++11. What compiler were you seeing this with? 1011611 6 ysuzuki 2014-05-25 18:17:09 -0700 (In reply to comment #5) > (From update of attachment 232041 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232041&action=review > > >> Source/WebCore/cssjit/SelectorCompiler.cpp:181 > >> + static const Assembler::RegisterID callFrameRegister; > > > > These are declaration, not definition (C++). So referencing them with const reference (const T&) causes link error, "undefined reference to XXX". > > I would expect to see that problem only when using an old C++ compiler; the status of these has changed in C++11. What compiler were you seeing this with? Oh, I didn't know that! I'm using a default compiler on Ubuntu 14.04, the result of `gcc --version` is the following. gcc (Ubuntu 4.8.2-19ubuntu1) 4.8.2 Copyright (C) 2013 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. 1011848 7 232041 commit-queue 2014-05-26 17:19:49 -0700 Comment on attachment 232041 Patch Clearing flags on attachment: 232041 Committed r169363: <http://trac.webkit.org/changeset/169363> 1011849 8 commit-queue 2014-05-26 17:19:52 -0700 All reviewed patches have been landed. Closing bug. 232040 2014-05-25 11:15:11 -0700 2014-05-25 11:15:48 -0700 Patch bug-133266-20140526031507.patch text/plain 1708 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMzY2IxNWQwYmVmZmI4 MjIxY2ZlNDYxM2FhYzM5NThkNDQ2NWM2MC4uZWM3Yjk3ZTFmMDEyMmU1YTc4YTkyY2IzYjEyZDRi Y2M0N2ExMTNlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTI0ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHByZWxv YWQgQVZBc3NldFRyYWNrIHByb3BlcnRpZXMgYmVmb3JlIGFza2luZyBmb3IgdGhlbQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToK KyAgICAgICAgKFdlYkNvcmU6OmFzc2V0VHJhY2tNZXRhZGF0YUtleU5hbWVzKTogQWRkIHByZWZl cnJlZFRyYW5zZm9ybSBhbmQgbmF0dXJhbFNpemUgdG8gdGhlIGxpc3QKKyAgICAgICAgICAgIG9m IHByb3BlcnRpZXMgd2UgcHJlbG9hZC4KKwogMjAxNC0wNS0yNCAgWnNvbHQgQm9yYmVseSAgPHpz Ym9yYmVseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBv bmUgb2YgdGhlIENTU1Byb3BlcnR5IGNvbnN0cnVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQpp bmRleCAyZDM0ZmRjYzQ2YmMyMzcwZWU1Njk0MmU5OWU1NmE3OWM2ODkzNTA5Li5kZTVlMjk5NmEw NzNkMGJiMWY1MWIwNjcxZTg1OWE1OTEwNDllZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVB VkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0K QEAgLTI1NTQsOCArMjU1NCw3IEBAIE5TQXJyYXkqIGl0ZW1LVk9Qcm9wZXJ0aWVzKCkKIAogTlNB cnJheSogYXNzZXRUcmFja01ldGFkYXRhS2V5TmFtZXMoKQogewotICAgIHN0YXRpYyBOU0FycmF5 KiBrZXlzID0gW1tOU0FycmF5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6QCJ0b3RhbFNhbXBsZURh dGFMZW5ndGgiLCBAIm1lZGlhVHlwZSIsIEAiZW5hYmxlZCIsIG5pbF07Ci0KKyAgICBzdGF0aWMg TlNBcnJheSoga2V5cyA9IFtbTlNBcnJheSBhbGxvY10gaW5pdFdpdGhPYmplY3RzOkAidG90YWxT YW1wbGVEYXRhTGVuZ3RoIiwgQCJtZWRpYVR5cGUiLCBAImVuYWJsZWQiLCBAInByZWZlcnJlZFRy YW5zZm9ybSIsIEAibmF0dXJhbFNpemUiLCBuaWxdOwogICAgIHJldHVybiBrZXlzOwogfQogCg== 232041 2014-05-25 11:16:15 -0700 2014-05-26 17:19:47 -0700 Patch bug-133266-20140526031611.patch text/plain 3745 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWM3Yjk3ZTFmMDEyMmU1 YTc4YTkyY2IzYjEyZDRiY2M0N2ExMTNlNS4uNmViMmI1OWVmODc0ODZhMzE4ZjA1ZDg1YmVjZmNh OTU2MmE1OTk3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTI1ICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIENTUyBKSVQ6IEZp eCBidWlsZCBlcnJvciByYWlzZWQgd2hlbiBDU1NfU0VMRUNUT1JfSklUX0RFQlVHR0lORyBpcyAx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMyNjYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIENT U19TRUxFQ1RPUl9KSVRfREVCVUdHSU5HIGlzIDEsIGJ1aWxkIGVycm9zIG9jY3VyIG9uIHg4Nl82 NC4KKworICAgICAgICAqIGNzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlNlbGVjdG9yQ29tcGlsZXI6OlNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVQ cm9sb2d1ZSk6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNvbXBpbGVyOjpTZWxlY3RvckNv ZGVHZW5lcmF0b3I6OmdlbmVyYXRlRXBpbG9ndWUpOgorCiAyMDE0LTA1LTI0ICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIHByZWxvYWQgQVZB c3NldFRyYWNrIHByb3BlcnRpZXMgYmVmb3JlIGFza2luZyBmb3IgdGhlbQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIuY3BwCmluZGV4IDMyNDE3N2JiNTkwZjUzZWFlNjQ2 NmFkODNlM2FhMmE2MmJiZGEzYjUuLmQzYzAzZjcxNjZkOTBkMzQ3NzE0NjgwY2YxZWY0NDI3YTIw MzI4OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAKQEAg LTQ1LDYgKzQ1LDcgQEAKICNpbmNsdWRlICJTZWxlY3RvckNoZWNrZXJUZXN0RnVuY3Rpb25zLmgi CiAjaW5jbHVkZSAiU3RhY2tBbGxvY2F0b3IuaCIKICNpbmNsdWRlICJTdHlsZWRFbGVtZW50Lmgi CisjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvR1BSSW5mby5oPgogI2luY2x1ZGUgPEphdmFTY3Jp cHRDb3JlL0xpbmtCdWZmZXIuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9NYWNyb0Fzc2Vt Ymxlci5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL1ZNLmg+CkBAIC0xNzQsOSArMTc1LDEw IEBAIGNsYXNzIFNlbGVjdG9yQ29kZUdlbmVyYXRvciB7CiAgICAgU2VsZWN0b3JDb21waWxhdGlv blN0YXR1cyBjb21waWxlKEpTQzo6Vk0qLCBKU0M6Ok1hY3JvQXNzZW1ibGVyQ29kZVJlZiYpOwog CiBwcml2YXRlOgotICAgIHN0YXRpYyBjb25zdCBBc3NlbWJsZXI6OlJlZ2lzdGVySUQgcmV0dXJu UmVnaXN0ZXIgPSBKU0M6OkdQUkluZm86OnJldHVyblZhbHVlR1BSOwotICAgIHN0YXRpYyBjb25z dCBBc3NlbWJsZXI6OlJlZ2lzdGVySUQgZWxlbWVudEFkZHJlc3NSZWdpc3RlciA9IEpTQzo6R1BS SW5mbzo6YXJndW1lbnRHUFIwOwotICAgIHN0YXRpYyBjb25zdCBBc3NlbWJsZXI6OlJlZ2lzdGVy SUQgY2hlY2tpbmdDb250ZXh0UmVnaXN0ZXIgPSBKU0M6OkdQUkluZm86OmFyZ3VtZW50R1BSMTsK KyAgICBzdGF0aWMgY29uc3QgQXNzZW1ibGVyOjpSZWdpc3RlcklEIHJldHVyblJlZ2lzdGVyOwor ICAgIHN0YXRpYyBjb25zdCBBc3NlbWJsZXI6OlJlZ2lzdGVySUQgZWxlbWVudEFkZHJlc3NSZWdp c3RlcjsKKyAgICBzdGF0aWMgY29uc3QgQXNzZW1ibGVyOjpSZWdpc3RlcklEIGNoZWNraW5nQ29u dGV4dFJlZ2lzdGVyOworICAgIHN0YXRpYyBjb25zdCBBc3NlbWJsZXI6OlJlZ2lzdGVySUQgY2Fs bEZyYW1lUmVnaXN0ZXI7CiAKICAgICB2b2lkIGNvbXB1dGVCYWNrdHJhY2tpbmdJbmZvcm1hdGlv bigpOwogICAgIHZvaWQgZ2VuZXJhdGVTZWxlY3RvckNoZWNrZXIoKTsKQEAgLTI1OSw2ICsyNjEs MTEgQEAgY2xhc3MgU2VsZWN0b3JDb2RlR2VuZXJhdG9yIHsKICNlbmRpZgogfTsKIAorY29uc3Qg QXNzZW1ibGVyOjpSZWdpc3RlcklEIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6cmV0dXJuUmVnaXN0 ZXIgPSBKU0M6OkdQUkluZm86OnJldHVyblZhbHVlR1BSOworY29uc3QgQXNzZW1ibGVyOjpSZWdp c3RlcklEIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6ZWxlbWVudEFkZHJlc3NSZWdpc3RlciA9IEpT Qzo6R1BSSW5mbzo6YXJndW1lbnRHUFIwOworY29uc3QgQXNzZW1ibGVyOjpSZWdpc3RlcklEIFNl bGVjdG9yQ29kZUdlbmVyYXRvcjo6Y2hlY2tpbmdDb250ZXh0UmVnaXN0ZXIgPSBKU0M6OkdQUklu Zm86OmFyZ3VtZW50R1BSMTsKK2NvbnN0IEFzc2VtYmxlcjo6UmVnaXN0ZXJJRCBTZWxlY3RvckNv ZGVHZW5lcmF0b3I6OmNhbGxGcmFtZVJlZ2lzdGVyID0gSlNDOjpHUFJJbmZvOjpjYWxsRnJhbWVS ZWdpc3RlcjsKKwogU2VsZWN0b3JDb21waWxhdGlvblN0YXR1cyBjb21waWxlU2VsZWN0b3IoY29u c3QgQ1NTU2VsZWN0b3IqIGxhc3RTZWxlY3RvciwgSlNDOjpWTSogdm0sIFNlbGVjdG9yQ29udGV4 dCBzZWxlY3RvckNvbnRleHQsIEpTQzo6TWFjcm9Bc3NlbWJsZXJDb2RlUmVmJiBjb2RlUmVmKQog ewogICAgIGlmICghdm0tPmNhblVzZUpJVCgpKQpAQCAtOTM5LDcgKzk0Niw3IEBAIGlubGluZSBi b29sIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVQcm9sb2d1ZSgpCiAgICAgcmV0dXJu IHRydWU7CiAjZWxpZiBDUFUoWDg2XzY0KSAmJiBDU1NfU0VMRUNUT1JfSklUX0RFQlVHR0lORwog ICAgIFZlY3RvcjxKU0M6Ok1hY3JvQXNzZW1ibGVyOjpSZWdpc3RlcklELCAxPiBwcm9sb2d1ZVJl Z2lzdGVyOwotICAgIHByb2xvZ3VlUmVnaXN0ZXIuYXBwZW5kKEdQUkluZm86OmNhbGxGcmFtZVJl Z2lzdGVyKTsKKyAgICBwcm9sb2d1ZVJlZ2lzdGVyLmFwcGVuZChjYWxsRnJhbWVSZWdpc3Rlcik7 CiAgICAgbV9wcm9sb2d1ZVN0YWNrUmVmZXJlbmNlcyA9IG1fc3RhY2tBbGxvY2F0b3IucHVzaChw cm9sb2d1ZVJlZ2lzdGVyKTsKICAgICByZXR1cm4gdHJ1ZTsKICNlbmRpZgpAQCAtOTU1LDcgKzk2 Miw3IEBAIGlubGluZSB2b2lkIFNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVFcGlsb2d1 ZSgpCiAgICAgbV9zdGFja0FsbG9jYXRvci5wb3AobV9wcm9sb2d1ZVN0YWNrUmVmZXJlbmNlcywg cHJvbG9ndWVSZWdpc3RlcnMpOwogI2VsaWYgQ1BVKFg4Nl82NCkgJiYgQ1NTX1NFTEVDVE9SX0pJ VF9ERUJVR0dJTkcKICAgICBWZWN0b3I8SlNDOjpNYWNyb0Fzc2VtYmxlcjo6UmVnaXN0ZXJJRCwg MT4gcHJvbG9ndWVSZWdpc3RlcjsKLSAgICBwcm9sb2d1ZVJlZ2lzdGVyLmFwcGVuZChHUFJJbmZv OjpjYWxsRnJhbWVSZWdpc3Rlcik7CisgICAgcHJvbG9ndWVSZWdpc3Rlci5hcHBlbmQoY2FsbEZy YW1lUmVnaXN0ZXIpOwogICAgIG1fc3RhY2tBbGxvY2F0b3IucG9wKG1fcHJvbG9ndWVTdGFja1Jl ZmVyZW5jZXMsIHByb2xvZ3VlUmVnaXN0ZXIpOwogI2VuZGlmCiB9Cg==