133265 2014-05-25 10:25:35 -0700 Remove Vector copies in ShorthandPropertyWrapper implementation and use 2014-05-26 02:27:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue dino dstockwell simon.fraser oldest_to_newest 1011576 0 zan 2014-05-25 10:25:35 -0700 Remove Vector copies in ShorthandPropertyWrapper implementation and use 1011577 1 232039 zan 2014-05-25 10:28:30 -0700 Created attachment 232039 Patch 1011675 2 232039 zan 2014-05-26 02:27:20 -0700 Comment on attachment 232039 Patch Clearing flags on attachment: 232039 Committed r169333: <http://trac.webkit.org/changeset/169333> 1011676 3 zan 2014-05-26 02:27:28 -0700 All reviewed patches have been landed. Closing bug. 232039 2014-05-25 10:28:30 -0700 2014-05-26 02:27:19 -0700 Patch bug-133265-20140525102806.patch text/plain 3381 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTMxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTI1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW1vdmUgVmVjdG9yIGNv cGllcyBpbiBTaG9ydGhhbmRQcm9wZXJ0eVdyYXBwZXIgaW1wbGVtZW50YXRpb24gYW5kIHVzZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjY1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdlL2Fu aW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaG9y dGhhbmRQcm9wZXJ0eVdyYXBwZXI6OlNob3J0aGFuZFByb3BlcnR5V3JhcHBlcik6IE1vdmUgdGhl IHBhc3NlZC1pbiBWZWN0b3IKKyAgICAgICAgaW50byB0aGUgbWVtYmVyIHZhcmlhYmxlIGluc3Rl YWQgb2YgdXNpbmcgVmVjdG9yPD46OnN3YXAoKS4KKyAgICAgICAgKFdlYkNvcmU6OlNob3J0aGFu ZFByb3BlcnR5V3JhcHBlcjo6cHJvcGVydHlXcmFwcGVycyk6IFJldHVybiBhIGNvbnN0IHJlZmVy ZW5jZSBvZiB0aGUgbWVtYmVyCisgICAgICAgIHZhcmlhYmxlIGluc3RlYWQgb2YgYSBjb25zdCB2 YWx1ZS4KKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5QW5pbWF0aW9uV3JhcHBlck1hcDo6 Q1NTUHJvcGVydHlBbmltYXRpb25XcmFwcGVyTWFwKTogTW92ZSB0aGUgVmVjdG9yCisgICAgICAg IG9iamVjdCBpbnRvIHRoZSBTaG9ydGhhbmRQcm9wZXJ0aHlXcmFwcGVyIGNvbnN0cnVjdG9yLgor ICAgICAgICAoV2ViQ29yZTo6Z2F0aGVyRW5jbG9zaW5nU2hvcnRoYW5kUHJvcGVydGllcyk6IERl cGxveSBhIHJhbmdlLWJhc2VkIGZvci1sb29wLgorCiAyMDE0LTA1LTI1ICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gV2ViQ29yZTo6VGV4dFJl c291cmNlRGVjb2Rlcjo6Y2hlY2tGb3JDU1NDaGFyc2V0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w YWdlL2FuaW1hdGlvbi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ1NTUHJvcGVydHlBbmltYXRpb24uY3BwCShyZXZp c2lvbiAxNjkzMTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9DU1NQcm9wZXJ0 eUFuaW1hdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2MCw4ICs5NjAsOCBAQCBjbGFzcyBT aG9ydGhhbmRQcm9wZXJ0eVdyYXBwZXIgOiBwdWJsaWMKIHB1YmxpYzoKICAgICBTaG9ydGhhbmRQ cm9wZXJ0eVdyYXBwZXIoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eSwgVmVjdG9yPEFuaW1hdGlvblBy b3BlcnR5V3JhcHBlckJhc2UqPiBsb25naGFuZFdyYXBwZXJzKQogICAgICAgICA6IEFuaW1hdGlv blByb3BlcnR5V3JhcHBlckJhc2UocHJvcGVydHkpCisgICAgICAgICwgbV9wcm9wZXJ0eVdyYXBw ZXJzKHN0ZDo6bW92ZShsb25naGFuZFdyYXBwZXJzKSkKICAgICB7Ci0gICAgICAgIG1fcHJvcGVy dHlXcmFwcGVycy5zd2FwKGxvbmdoYW5kV3JhcHBlcnMpOwogICAgIH0KIAogICAgIHZpcnR1YWwg Ym9vbCBpc1Nob3J0aGFuZFdyYXBwZXIoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CkBAIC05ODMs NyArOTgzLDcgQEAgcHVibGljOgogICAgICAgICAgICAgKCppdCktPmJsZW5kKGFuaW0sIGRzdCwg YSwgYiwgcHJvZ3Jlc3MpOwogICAgIH0KIAotICAgIGNvbnN0IFZlY3RvcjxBbmltYXRpb25Qcm9w ZXJ0eVdyYXBwZXJCYXNlKj4gcHJvcGVydHlXcmFwcGVycygpIGNvbnN0IHsgcmV0dXJuIG1fcHJv cGVydHlXcmFwcGVyczsgfQorICAgIGNvbnN0IFZlY3RvcjxBbmltYXRpb25Qcm9wZXJ0eVdyYXBw ZXJCYXNlKj4mIHByb3BlcnR5V3JhcHBlcnMoKSBjb25zdCB7IHJldHVybiBtX3Byb3BlcnR5V3Jh cHBlcnM7IH0KIAogcHJpdmF0ZToKICAgICBWZWN0b3I8QW5pbWF0aW9uUHJvcGVydHlXcmFwcGVy QmFzZSo+IG1fcHJvcGVydHlXcmFwcGVyczsKQEAgLTEzMzUsNyArMTMzNSw3IEBAIENTU1Byb3Bl cnR5QW5pbWF0aW9uV3JhcHBlck1hcDo6Q1NTUHJvcGUKICAgICAgICAgICAgIGxvbmdoYW5kV3Jh cHBlcnMudW5jaGVja2VkQXBwZW5kKG1fcHJvcGVydHlXcmFwcGVyc1t3cmFwcGVySW5kZXhdLmdl dCgpKTsKICAgICAgICAgfQogCi0gICAgICAgIG1fcHJvcGVydHlXcmFwcGVycy51bmNoZWNrZWRB cHBlbmQoc3RkOjptYWtlX3VuaXF1ZTxTaG9ydGhhbmRQcm9wZXJ0eVdyYXBwZXI+KHByb3BlcnR5 SUQsIGxvbmdoYW5kV3JhcHBlcnMpKTsKKyAgICAgICAgbV9wcm9wZXJ0eVdyYXBwZXJzLnVuY2hl Y2tlZEFwcGVuZChzdGQ6Om1ha2VfdW5pcXVlPFNob3J0aGFuZFByb3BlcnR5V3JhcHBlcj4ocHJv cGVydHlJRCwgc3RkOjptb3ZlKGxvbmdoYW5kV3JhcHBlcnMpKSk7CiAgICAgICAgIGluZGV4RnJv bVByb3BlcnR5SUQocHJvcGVydHlJRCkgPSBhbmltYXRhYmxlTG9uZ2hhbmRQcm9wZXJ0aWVzQ291 bnQgKyBpOwogICAgIH0KIH0KQEAgLTEzNDYsMTEgKzEzNDYsOCBAQCBzdGF0aWMgYm9vbCBnYXRo ZXJFbmNsb3NpbmdTaG9ydGhhbmRQcm9wCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIFNo b3J0aGFuZFByb3BlcnR5V3JhcHBlciogc2hvcnRoYW5kV3JhcHBlciA9IHN0YXRpY19jYXN0PFNo b3J0aGFuZFByb3BlcnR5V3JhcHBlcio+KHdyYXBwZXIpOwotCiAgICAgYm9vbCBjb250YWluZWQg PSBmYWxzZTsKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHNob3J0aGFuZFdyYXBwZXItPnBy b3BlcnR5V3JhcHBlcnMoKS5zaXplKCk7ICsraSkgewotICAgICAgICBBbmltYXRpb25Qcm9wZXJ0 eVdyYXBwZXJCYXNlKiBjdXJyV3JhcHBlciA9IHNob3J0aGFuZFdyYXBwZXItPnByb3BlcnR5V3Jh cHBlcnMoKVtpXTsKLQorICAgIGZvciAoYXV0byYgY3VycldyYXBwZXIgOiBzaG9ydGhhbmRXcmFw cGVyLT5wcm9wZXJ0eVdyYXBwZXJzKCkpIHsKICAgICAgICAgaWYgKGdhdGhlckVuY2xvc2luZ1No b3J0aGFuZFByb3BlcnRpZXMocHJvcGVydHksIGN1cnJXcmFwcGVyLCBwcm9wZXJ0eVNldCkgfHwg Y3VycldyYXBwZXItPnByb3BlcnR5KCkgPT0gcHJvcGVydHkpCiAgICAgICAgICAgICBjb250YWlu ZWQgPSB0cnVlOwogICAgIH0K