<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>133264</bug_id>
          
          <creation_ts>2014-05-25 09:54:44 -0700</creation_ts>
          <short_desc>WebPage::setComposition(), WebPageProxy::didFindStringMatches() should take Vector parameters by const reference</short_desc>
          <delta_ts>2014-05-26 02:23:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1011573</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-05-25 09:54:44 -0700</bug_when>
    <thetext>WebPage::setComposition(), WebPageProxy::didFindStringMatches() should take Vector parametery by const reference</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011574</commentid>
    <comment_count>1</comment_count>
      <attachid>232038</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-05-25 10:05:15 -0700</bug_when>
    <thetext>Created attachment 232038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011673</commentid>
    <comment_count>2</comment_count>
      <attachid>232038</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-05-26 02:23:08 -0700</bug_when>
    <thetext>Comment on attachment 232038
Patch

Clearing flags on attachment: 232038

Committed r169332: &lt;http://trac.webkit.org/changeset/169332&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011674</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2014-05-26 02:23:14 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>232038</attachid>
            <date>2014-05-25 10:05:15 -0700</date>
            <delta_ts>2014-05-26 02:23:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-133264-20140525100450.patch</filename>
            <type>text/plain</type>
            <size>4741</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTMxOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA1LTI1ICBaYW4gRG9i
ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJQYWdlOjpzZXRDb21w
b3NpdGlvbigpLCBXZWJQYWdlUHJveHk6OmRpZEZpbmRTdHJpbmdNYXRjaGVzKCkgc2hvdWxkIHRh
a2UgVmVjdG9yIHBhcmFtZXRlcnMgYnkgY29uc3QgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMyNjQKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUYWtpbmcgdGhlIFZlY3RvciBwYXJhbWV0
ZXJzIGluIHRoZSB0d28gbWV0aG9kcyAoaW52b2tlZCB0aHJvdWdoIHRoZSBJUEMgbWVzc2FnZSBo
YW5kbGluZykKKyAgICAgICAgYnkgdmFsdWUgY2F1c2VzIHVubmVjZXNzYXJ5IGNvcGllcy4gVGhl
IG1ldGhvZHMgZG9uJ3QgbW9kaWZ5IHRoZSBvYmplY3RzIGFuZCBkb24ndCB3YW50CisgICAgICAg
IG9yIG5lZWQgZnJlc2ggY29waWVzLCBoZW5jZSB0aGV5IHNob3VsZCB0YWtlIGluIGNvbnN0IHJl
ZmVyZW5jZXMgdG8gVmVjdG9yIG9iamVjdHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFn
ZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRGaW5kU3RyaW5n
TWF0Y2hlcyk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAgICAq
IFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn
ZTo6c2V0Q29tcG9zaXRpb24pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl
Lmg6CisKIDIwMTQtMDUtMjQgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K
IAogICAgICAgICBQb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZSBpbgpJbmRleDogU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDE2OTMxNykKKysrIFNv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC0zMzc5LDcgKzMzNzksNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkRmluZFN0cmluZyhjb25z
dCBTCiAgICAgbV9maW5kQ2xpZW50LT5kaWRGaW5kU3RyaW5nKHRoaXMsIHN0cmluZywgbWF0Y2hD
b3VudCwgbWF0Y2hJbmRleCk7CiB9CiAKLXZvaWQgV2ViUGFnZVByb3h5OjpkaWRGaW5kU3RyaW5n
TWF0Y2hlcyhjb25zdCBTdHJpbmcmIHN0cmluZywgVmVjdG9yPFZlY3RvcjxXZWJDb3JlOjpJbnRS
ZWN0Pj4gbWF0Y2hSZWN0cywgaW50MzJfdCBmaXJzdEluZGV4QWZ0ZXJTZWxlY3Rpb24pCit2b2lk
IFdlYlBhZ2VQcm94eTo6ZGlkRmluZFN0cmluZ01hdGNoZXMoY29uc3QgU3RyaW5nJiBzdHJpbmcs
IGNvbnN0IFZlY3RvcjxWZWN0b3I8V2ViQ29yZTo6SW50UmVjdD4+JiBtYXRjaFJlY3RzLCBpbnQz
Ml90IGZpcnN0SW5kZXhBZnRlclNlbGVjdGlvbikKIHsKICAgICBWZWN0b3I8UmVmUHRyPEFQSTo6
T2JqZWN0Pj4gbWF0Y2hlczsKICAgICBtYXRjaGVzLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkobWF0
Y2hSZWN0cy5zaXplKCkpOwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ
cm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv
eHkuaAkocmV2aXNpb24gMTY5MzE3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh
Z2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC04NTMsNyArODUzLDcgQEAgcHVibGljOgogICAg
IHZvaWQgc2V0RmluZEluZGljYXRvcihjb25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmIHNlbGVjdGlv
blJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLCBjb25zdCBWZWN0b3I8V2ViQ29yZTo6RmxvYXRSZWN0
PiYgdGV4dFJlY3RzSW5TZWxlY3Rpb25SZWN0Q29vcmRpbmF0ZXMsIGZsb2F0IGNvbnRlbnRJbWFn
ZVNjYWxlRmFjdG9yLCBjb25zdCBTaGFyZWFibGVCaXRtYXA6OkhhbmRsZSYgY29udGVudEltYWdl
SGFuZGxlLCBib29sIGZhZGVPdXQsIGJvb2wgYW5pbWF0ZSk7CiAgICAgdm9pZCBkaWRGaW5kU3Ry
aW5nKGNvbnN0IFN0cmluZyYsIHVpbnQzMl90IG1hdGNoQ291bnQsIGludDMyX3QgbWF0Y2hJbmRl
eCk7CiAgICAgdm9pZCBkaWRGYWlsVG9GaW5kU3RyaW5nKGNvbnN0IFN0cmluZyYpOwotICAgIHZv
aWQgZGlkRmluZFN0cmluZ01hdGNoZXMoY29uc3QgU3RyaW5nJiwgVmVjdG9yPFZlY3RvcjxXZWJD
b3JlOjpJbnRSZWN0Pj4gbWF0Y2hSZWN0cywgaW50MzJfdCBmaXJzdEluZGV4QWZ0ZXJTZWxlY3Rp
b24pOworICAgIHZvaWQgZGlkRmluZFN0cmluZ01hdGNoZXMoY29uc3QgU3RyaW5nJiwgY29uc3Qg
VmVjdG9yPFZlY3RvcjxXZWJDb3JlOjpJbnRSZWN0Pj4mIG1hdGNoUmVjdHMsIGludDMyX3QgZmly
c3RJbmRleEFmdGVyU2VsZWN0aW9uKTsKIAogICAgIHZvaWQgZ2V0Q29udGVudHNBc1N0cmluZyhQ
YXNzUmVmUHRyPFN0cmluZ0NhbGxiYWNrPik7CiAgICAgdm9pZCBnZXRCeXRlY29kZVByb2ZpbGUo
UGFzc1JlZlB0cjxTdHJpbmdDYWxsYmFjaz4pOwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv
Y2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dl
YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkocmV2aXNpb24gMTY5MzE3KQorKysgU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC00MTU2LDcgKzQxNTYsNyBAQCB2b2lkIFdlYlBhZ2U6OmNvbmZpcm1Db21wb3NpdGlvbihjb25z
dCBTCiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpFZGl0b3JTdGF0ZUNoYW5nZWQo
ZWRpdG9yU3RhdGUoKSkpOwogfQogCi12b2lkIFdlYlBhZ2U6OnNldENvbXBvc2l0aW9uKGNvbnN0
IFN0cmluZyYgdGV4dCwgVmVjdG9yPENvbXBvc2l0aW9uVW5kZXJsaW5lPiB1bmRlcmxpbmVzLCB1
aW50NjRfdCBzZWxlY3Rpb25TdGFydCwgdWludDY0X3Qgc2VsZWN0aW9uTGVuZ3RoLCB1aW50NjRf
dCByZXBsYWNlbWVudFN0YXJ0LCB1aW50NjRfdCByZXBsYWNlbWVudExlbmd0aCkKK3ZvaWQgV2Vi
UGFnZTo6c2V0Q29tcG9zaXRpb24oY29uc3QgU3RyaW5nJiB0ZXh0LCBjb25zdCBWZWN0b3I8Q29t
cG9zaXRpb25VbmRlcmxpbmU+JiB1bmRlcmxpbmVzLCB1aW50NjRfdCBzZWxlY3Rpb25TdGFydCwg
dWludDY0X3Qgc2VsZWN0aW9uTGVuZ3RoLCB1aW50NjRfdCByZXBsYWNlbWVudFN0YXJ0LCB1aW50
NjRfdCByZXBsYWNlbWVudExlbmd0aCkKIHsKICAgICBGcmFtZSogdGFyZ2V0RnJhbWUgPSB0YXJn
ZXRGcmFtZUZvckVkaXRpbmcodGhpcyk7CiAgICAgaWYgKCF0YXJnZXRGcmFtZSB8fCAhdGFyZ2V0
RnJhbWUtPnNlbGVjdGlvbigpLnNlbGVjdGlvbigpLmlzQ29udGVudEVkaXRhYmxlKCkpIHsKSW5k
ZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAkocmV2aXNp
b24gMTY5MzE3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu
aAkod29ya2luZyBjb3B5KQpAQCAtNTUzLDcgKzU1Myw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiAj
aWYgUExBVEZPUk0oR1RLKQotICAgIHZvaWQgc2V0Q29tcG9zaXRpb24oY29uc3QgU3RyaW5nJiB0
ZXh0LCBWZWN0b3I8V2ViQ29yZTo6Q29tcG9zaXRpb25VbmRlcmxpbmU+IHVuZGVybGluZXMsIHVp
bnQ2NF90IHNlbGVjdGlvblN0YXJ0LCB1aW50NjRfdCBzZWxlY3Rpb25FbmQsIHVpbnQ2NF90IHJl
cGxhY2VtZW50UmFuZ2VTdGFydCwgdWludDY0X3QgcmVwbGFjZW1lbnRSYW5nZUxlbmd0aCk7Cisg
ICAgdm9pZCBzZXRDb21wb3NpdGlvbihjb25zdCBTdHJpbmcmIHRleHQsIGNvbnN0IFZlY3RvcjxX
ZWJDb3JlOjpDb21wb3NpdGlvblVuZGVybGluZT4mIHVuZGVybGluZXMsIHVpbnQ2NF90IHNlbGVj
dGlvblN0YXJ0LCB1aW50NjRfdCBzZWxlY3Rpb25FbmQsIHVpbnQ2NF90IHJlcGxhY2VtZW50UmFu
Z2VTdGFydCwgdWludDY0X3QgcmVwbGFjZW1lbnRSYW5nZUxlbmd0aCk7CiAgICAgdm9pZCBjb25m
aXJtQ29tcG9zaXRpb24oY29uc3QgU3RyaW5nJiB0ZXh0LCBpbnQ2NF90IHNlbGVjdGlvblN0YXJ0
LCBpbnQ2NF90IHNlbGVjdGlvbkxlbmd0aCk7CiAgICAgdm9pZCBjYW5jZWxDb21wb3NpdGlvbigp
OwogI2VuZGlmCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>