133263 2014-05-25 09:24:58 -0700 Remove remaining Vector<> copies in WebCore accessibility code 2014-07-01 04:29:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white oldest_to_newest 1011569 0 zan 2014-05-25 09:24:58 -0700 Remove remaining Vector<> copies in WebCore accessibility code 1011571 1 232037 zan 2014-05-25 09:47:44 -0700 Created attachment 232037 Patch 1011572 2 commit-queue 2014-05-25 09:50:24 -0700 Attachment 232037 did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3112: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebCore/accessibility/AccessibilityObject.h:236: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1019601 3 232037 zan 2014-07-01 04:29:49 -0700 Comment on attachment 232037 Patch Clearing flags on attachment: 232037 Committed r170634: <http://trac.webkit.org/changeset/170634> 1019602 4 zan 2014-07-01 04:29:58 -0700 All reviewed patches have been landed. Closing bug. 232037 2014-05-25 09:47:44 -0700 2014-07-01 04:29:49 -0700 Patch bug-133263-20140525094719.patch text/plain 7293 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTMxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA1LTI1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW1vdmUgcmVtYWluaW5n IFZlY3Rvcjw+IGNvcGllcyBpbiBXZWJDb3JlIGFjY2Vzc2liaWxpdHkgY29kZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FY T2JqZWN0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6bm90aWZp Y2F0aW9uUG9zdFRpbWVyRmlyZWQpOiBEb24ndCBjb3B5IHRoZSBWZWN0b3IgbWVtYmVyIGFuZAor ICAgICAgICB0aGVuIGNsZWFyIGl0IC0tIG1vdmUgaXQgaW50byB0aGUgbG9jYWwgdmFyaWFibGUg aW5zdGVhZC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjphcmlhTGFi ZWxlZEJ5VGV4dCk6IE1vdmUgdGhlIGF4RWxlbWVudHMgVmVjdG9yIGludG8KKyAgICAgICAgdGhl IEFjY2Vzc2liaWxpdHlUZXh0IGNvbnN0cnVjdG9yLgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNz aWJpbGl0eU5vZGVPYmplY3Q6OnN0cmluZ1ZhbHVlKTogQ3JlYXRlIGEgY29uc3QgcmVmZXJlbmNl IHRvIHRoZSBWZWN0b3Igb2YKKyAgICAgICAgSFRNTFNlbGVjdEVsZW1lbnQncyBsaXN0IGl0ZW1z IGluc3RlYWQgb2YgY29weWluZyBpdC4KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlPYmplY3QuaDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlUZXh0OjpBY2Nl c3NpYmlsaXR5VGV4dCk6IFRha2UgdGhlIFZlY3RvciBwYXJhbWV0ZXIgYnkgbm9uLWNvbnN0Cisg ICAgICAgIHZhbHVlIGFuZCBtb3ZlIGl0IGludG8gdGhlIG1lbWJlciB2YXJpYWJsZS4KKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOiAKKyAgICAg ICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN0cmluZ1ZhbHVlKTogQ3Jl YXRlIGEgY29uc3QgcmVmZXJlbmNlIHRvIHRoZSBWZWN0b3IKKyAgICAgICAgb2YgSFRNTFNlbGVj dEVsZW1lbnQncyBsaXN0IGl0ZW1zIGluc3RlYWQgb2YgY29weWluZyBpdC4KKyAgICAgICAgKFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFyaWFTZWxlY3RlZFJvd3MpOiBXcmFw IHRoZSBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3IKKyAgICAgICAgaXRlcmF0aW9uIGluIGEg bGFtYmRhLiBVc2UgaXQgdG8gaXRlcmF0ZSBvdmVyIGVpdGhlciB0aGUgbmV3bHktY29uc3RydWN0 ZWQgVmVjdG9yIChpbiBjYXNlCisgICAgICAgIHRoZSBvYmplY3QgaGFzIHRoZSB0cmVlIHJvbGUp IG9yIHRoZSByZWZlcmVuY2UgdG8gdGhlIHZlY3RvciByZXR1cm5lZCBieQorICAgICAgICBBY2Nl c3NpYmlsaXR5VGFibGU6OnJvd3MoKSAoaW4gY2FzZSB0aGUgb2JqZWN0IGlzIGFuIEFjY2Vzc2li aWxpdHlUYWJsZSBpbnN0YW5jZSkuCisKIDIwMTQtMDUtMjQgIEVyaWMgQ2FybHNvbiAgPGVyaWMu Y2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gcHJlbG9hZCBBVkFzc2V0VHJhY2sg cHJvcGVydGllcyBiZWZvcmUgYXNraW5nIGZvciB0aGVtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAJKHJldmlzaW9uIDE2OTMxNykKKysr IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTY5MSw4ICs2OTEsNyBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6Om5vdGlmaWNhdGlv blBvc3RUaW1lCiAgICAgCiAgICAgLy8gSW4gRFJULCBwb3N0aW5nIG5vdGlmaWNhdGlvbnMgaGFz IGEgdGVuZGVuY3kgdG8gaW1tZWRpYXRlbHkgcXVldWUgdXAgb3RoZXIgbm90aWZpY2F0aW9ucywg d2hpY2ggY2FuIGxlYWQgdG8gdW5leHBlY3RlZCBiZWhhdmlvcgogICAgIC8vIHdoZW4gdGhlIG5v dGlmaWNhdGlvbiBsaXN0IGlzIGNsZWFyZWQgYXQgdGhlIGVuZC4gSW5zdGVhZCBjb3B5IHRoaXMg bGlzdCBhdCB0aGUgc3RhcnQuCi0gICAgYXV0byBub3RpZmljYXRpb25zID0gbV9ub3RpZmljYXRp b25zVG9Qb3N0OwotICAgIG1fbm90aWZpY2F0aW9uc1RvUG9zdC5jbGVhcigpOworICAgIGF1dG8g bm90aWZpY2F0aW9ucyA9IHN0ZDo6bW92ZShtX25vdGlmaWNhdGlvbnNUb1Bvc3QpOwogICAgIAog ICAgIGZvciAoY29uc3QgYXV0byYgbm90ZSA6IG5vdGlmaWNhdGlvbnMpIHsKICAgICAgICAgQWNj ZXNzaWJpbGl0eU9iamVjdCogb2JqID0gbm90ZS5maXJzdC5nZXQoKTsKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmpl Y3QuY3BwCShyZXZpc2lvbiAxNjkzMTcpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQzOCw3ICsx NDM4LDcgQEAgdm9pZCBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6YXJpYUxhYmVsZQogICAgICAg ICAgICAgYXhFbGVtZW50cy5hcHBlbmQoYXhFbGVtZW50KTsKICAgICAgICAgfQogICAgICAgICAK LSAgICAgICAgdGV4dE9yZGVyLmFwcGVuZChBY2Nlc3NpYmlsaXR5VGV4dChhcmlhTGFiZWxlZEJ5 LCBBbHRlcm5hdGl2ZVRleHQsIGF4RWxlbWVudHMpKTsKKyAgICAgICAgdGV4dE9yZGVyLmFwcGVu ZChBY2Nlc3NpYmlsaXR5VGV4dChhcmlhTGFiZWxlZEJ5LCBBbHRlcm5hdGl2ZVRleHQsIHN0ZDo6 bW92ZShheEVsZW1lbnRzKSkpOwogICAgIH0KIH0KICAgICAKQEAgLTE3ODcsNyArMTc4Nyw3IEBA IFN0cmluZyBBY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdDo6c3RyaW5nVmEKICAgICBpZiAobm9kZS0+ aGFzVGFnTmFtZShzZWxlY3RUYWcpKSB7CiAgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50KiBzZWxl Y3RFbGVtZW50ID0gdG9IVE1MU2VsZWN0RWxlbWVudChub2RlKTsKICAgICAgICAgaW50IHNlbGVj dGVkSW5kZXggPSBzZWxlY3RFbGVtZW50LT5zZWxlY3RlZEluZGV4KCk7Ci0gICAgICAgIGNvbnN0 IFZlY3RvcjxIVE1MRWxlbWVudCo+IGxpc3RJdGVtcyA9IHNlbGVjdEVsZW1lbnQtPmxpc3RJdGVt cygpOworICAgICAgICBjb25zdCBWZWN0b3I8SFRNTEVsZW1lbnQqPiYgbGlzdEl0ZW1zID0gc2Vs ZWN0RWxlbWVudC0+bGlzdEl0ZW1zKCk7CiAgICAgICAgIGlmIChzZWxlY3RlZEluZGV4ID49IDAg JiYgc3RhdGljX2Nhc3Q8c2l6ZV90PihzZWxlY3RlZEluZGV4KSA8IGxpc3RJdGVtcy5zaXplKCkp IHsKICAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgb3ZlcnJpZGRlbkRlc2NyaXB0aW9u ID0gbGlzdEl0ZW1zW3NlbGVjdGVkSW5kZXhdLT5mYXN0R2V0QXR0cmlidXRlKGFyaWFfbGFiZWxB dHRyKTsKICAgICAgICAgICAgIGlmICghb3ZlcnJpZGRlbkRlc2NyaXB0aW9uLmlzTnVsbCgpKQpJ bmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 T2JqZWN0LmgJKHJldmlzaW9uIDE2OTMxNykKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzAsMTAgKzIzMCwx MCBAQCBzdHJ1Y3QgQWNjZXNzaWJpbGl0eVRleHQgewogICAgICwgdGV4dFNvdXJjZShzKQogICAg IHsgfQogCi0gICAgQWNjZXNzaWJpbGl0eVRleHQoY29uc3QgU3RyaW5nJiB0LCBjb25zdCBBY2Nl c3NpYmlsaXR5VGV4dFNvdXJjZSYgcywgY29uc3QgVmVjdG9yPFJlZlB0cjxBY2Nlc3NpYmlsaXR5 T2JqZWN0Pj4gZWxlbWVudHMpCisgICAgQWNjZXNzaWJpbGl0eVRleHQoY29uc3QgU3RyaW5nJiB0 LCBjb25zdCBBY2Nlc3NpYmlsaXR5VGV4dFNvdXJjZSYgcywgVmVjdG9yPFJlZlB0cjxBY2Nlc3Np YmlsaXR5T2JqZWN0Pj4gZWxlbWVudHMpCiAgICAgOiB0ZXh0KHQpCiAgICAgLCB0ZXh0U291cmNl KHMpCi0gICAgLCB0ZXh0RWxlbWVudHMoZWxlbWVudHMpCisgICAgLCB0ZXh0RWxlbWVudHMoc3Rk Ojptb3ZlKGVsZW1lbnRzKSkKICAgICB7IH0KIAogICAgIEFjY2Vzc2liaWxpdHlUZXh0KGNvbnN0 IFN0cmluZyYgdCwgY29uc3QgQWNjZXNzaWJpbGl0eVRleHRTb3VyY2UmIHMsIGNvbnN0IFJlZlB0 cjxBY2Nlc3NpYmlsaXR5T2JqZWN0PiBlbGVtZW50KQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3Bw CShyZXZpc2lvbiAxNjkzMTcpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDMsNyArNzQzLDcg QEAgU3RyaW5nIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN0cmluZwogICAgICAgICAvLyBU aGlzIGhhcyB0byBiZSBvdmVycmlkZGVuIGluIHRoZSBjYXNlIHdoZXJlIHRoZSBzZWxlY3RlZCBp dGVtIGhhcyBhbiBBUklBIGxhYmVsLgogICAgICAgICBIVE1MU2VsZWN0RWxlbWVudCogc2VsZWN0 RWxlbWVudCA9IHRvSFRNTFNlbGVjdEVsZW1lbnQobV9yZW5kZXJlci0+bm9kZSgpKTsKICAgICAg ICAgaW50IHNlbGVjdGVkSW5kZXggPSBzZWxlY3RFbGVtZW50LT5zZWxlY3RlZEluZGV4KCk7Ci0g ICAgICAgIGNvbnN0IFZlY3RvcjxIVE1MRWxlbWVudCo+IGxpc3RJdGVtcyA9IHNlbGVjdEVsZW1l bnQtPmxpc3RJdGVtcygpOworICAgICAgICBjb25zdCBWZWN0b3I8SFRNTEVsZW1lbnQqPiYgbGlz dEl0ZW1zID0gc2VsZWN0RWxlbWVudC0+bGlzdEl0ZW1zKCk7CiAgICAgICAgIGlmIChzZWxlY3Rl ZEluZGV4ID49IDAgJiYgc3RhdGljX2Nhc3Q8c2l6ZV90PihzZWxlY3RlZEluZGV4KSA8IGxpc3RJ dGVtcy5zaXplKCkpIHsKICAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmluZyYgb3ZlcnJpZGRl bkRlc2NyaXB0aW9uID0gbGlzdEl0ZW1zW3NlbGVjdGVkSW5kZXhdLT5mYXN0R2V0QXR0cmlidXRl KGFyaWFfbGFiZWxBdHRyKTsKICAgICAgICAgICAgIGlmICghb3ZlcnJpZGRlbkRlc2NyaXB0aW9u LmlzTnVsbCgpKQpAQCAtMzA5NywxMyArMzA5Nyw2IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRl ck9iamVjdDo6YXJpYUxpdmUKICAgICAKIHZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6 YXJpYVNlbGVjdGVkUm93cyhBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIHJlc3VsdCkKIHsK LSAgICAvLyBHZXQgYWxsIHRoZSByb3dzLiAKLSAgICBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0 b3IgYWxsUm93czsKLSAgICBpZiAoaXNUcmVlKCkpCi0gICAgICAgIGFyaWFUcmVlUm93cyhhbGxS b3dzKTsKLSAgICBlbHNlIGlmIChpc0FjY2Vzc2liaWxpdHlUYWJsZSgpICYmIHRvQWNjZXNzaWJp bGl0eVRhYmxlKHRoaXMpLT5zdXBwb3J0c1NlbGVjdGVkUm93cygpKQotICAgICAgICBhbGxSb3dz ID0gdG9BY2Nlc3NpYmlsaXR5VGFibGUodGhpcyktPnJvd3MoKTsKLQogICAgIC8vIERldGVybWlu ZSB3aGljaCByb3dzIGFyZSBzZWxlY3RlZC4KICAgICBib29sIGlzTXVsdGkgPSBpc011bHRpU2Vs ZWN0YWJsZSgpOwogCkBAIC0zMTE1LDEzICszMTA4LDIyIEBAIHZvaWQgQWNjZXNzaWJpbGl0eVJl bmRlck9iamVjdDo6YXJpYVNlbGUKICAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBm b3IgKGNvbnN0IGF1dG8mIHJvdyA6IGFsbFJvd3MpIHsKLSAgICAgICAgaWYgKHJvdy0+aXNTZWxl Y3RlZCgpKSB7Ci0gICAgICAgICAgICByZXN1bHQuYXBwZW5kKHJvdyk7Ci0gICAgICAgICAgICBp ZiAoIWlzTXVsdGkpCi0gICAgICAgICAgICAgICAgYnJlYWs7CisgICAgLy8gR2V0IGFsbCB0aGUg cm93cy4KKyAgICBhdXRvIHJvd3NJdGVyYXRpb24gPSBbJl0oY29uc3QgQWNjZXNzaWJpbGl0eUNo aWxkcmVuVmVjdG9yJiByb3dzKSB7CisgICAgICAgIGZvciAoYXV0byYgcm93IDogcm93cykgewor ICAgICAgICAgICAgaWYgKHJvdy0+aXNTZWxlY3RlZCgpKSB7CisgICAgICAgICAgICAgICAgcmVz dWx0LmFwcGVuZChyb3cpOworICAgICAgICAgICAgICAgIGlmICghaXNNdWx0aSkKKyAgICAgICAg ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KLSAgICB9CisgICAg fTsKKyAgICBpZiAoaXNUcmVlKCkpIHsKKyAgICAgICAgQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVj dG9yIGFsbFJvd3M7CisgICAgICAgIGFyaWFUcmVlUm93cyhhbGxSb3dzKTsKKyAgICAgICAgcm93 c0l0ZXJhdGlvbihhbGxSb3dzKTsKKyAgICB9IGVsc2UgaWYgKGlzQWNjZXNzaWJpbGl0eVRhYmxl KCkgJiYgdG9BY2Nlc3NpYmlsaXR5VGFibGUodGhpcyktPnN1cHBvcnRzU2VsZWN0ZWRSb3dzKCkp CisgICAgICAgIHJvd3NJdGVyYXRpb24odG9BY2Nlc3NpYmlsaXR5VGFibGUodGhpcyktPnJvd3Mo KSk7CiB9CiAgICAgCiB2b2lkIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFyaWFMaXN0Ym94 U2VsZWN0ZWRDaGlsZHJlbihBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIHJlc3VsdCkK