133261 2014-05-24 19:29:07 -0700 Object.prototype.toString() should use cached strings for null/undefined. 2014-05-26 06:38:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133283 1 kling kling commit-queue ggaren oldest_to_newest 1011546 0 kling 2014-05-24 19:29:07 -0700 Object.prototype.toString() should use cached strings for null/undefined. 1011547 1 232028 kling 2014-05-24 19:29:35 -0700 Created attachment 232028 Patch 1011555 2 232028 commit-queue 2014-05-24 20:51:13 -0700 Comment on attachment 232028 Patch Clearing flags on attachment: 232028 Committed r169316: <http://trac.webkit.org/changeset/169316> 1011556 3 commit-queue 2014-05-24 20:51:16 -0700 All reviewed patches have been landed. Closing bug. 232028 2014-05-24 19:29:35 -0700 2014-05-24 20:51:13 -0700 Patch bug-133261.diff text/plain 5259 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ0ODg4ZGIuLjQ4YzZlNzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE0LTA1LTI0ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBPYmplY3QucHJvdG90eXBlLnRvU3RyaW5n KCkgc2hvdWxkIHVzZSBjYWNoZWQgc3RyaW5ncyBmb3IgbnVsbC91bmRlZmluZWQuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzMyNjE+CisKKyAgICAgICAgTm9ybWFsbHksIHdoZW4g Y2FsbGluZyBPYmplY3QucHJvdG90eXBlLnRvU3RyaW5nKCkgb24gYSByZWd1bGFyIG9iamVjdCwK KyAgICAgICAgd2UnZCBjYWNoZSB0aGUgcmVzdWx0IG9mIHRoZSBzdHJpbmdpZmljYXRpb24gb24g dGhlIG9iamVjdCdzIHN0cnVjdHVyZSwKKyAgICAgICAgbWFraW5nIHJlcGVhdGVkIGNhbGxzIGZh c3QuCisKKyAgICAgICAgRm9yIG51bGwgYW5kIHVuZGVmaW5lZCwgd2Ugd2VyZSBub3QgYXMgc21h cnQuIFdlJ2QgaW5zdGVhZCBjb25zdHJ1Y3QgYQorICAgICAgICBuZXcgc3RyaW5nIHdpdGggZWl0 aGVyICJbb2JqZWN0IE51bGxdIiBvciAiW29iamVjdCBVbmRlZmluZWRdIiBlYWNoIHRpbWUuCisK KyAgICAgICAgVGhpcyB3YXMgZXhwb3NlZCBieSBEcm9tYWVvJ3MgSlMgbGlicmFyeSB0ZXN0cywg d2hlcmUgc29tZSBwcm90b3R5cGUuanMKKyAgICAgICAgc3VidGVzdHMgZ2VuZXJhdGUgbWlsbGlv bnMgb2Ygc3RyaW5ncyB0aGlzIHdheS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdHdvIFZN LXBlcm1hbmVudCBjYWNoZWQgc3RyaW5ncyB0byB0aGUgU21hbGxTdHJpbmdzLgorICAgICAgICBM b29rcyBsaWtlIH4xMCUgc3BlZWQtdXAgb24gRHJvbWFlby9qc2xpYi10cmF2ZXJzZS1wcm90b3R5 cGUuaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcnVudGltZS9PYmplY3RQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpvYmplY3RQcm90 b0Z1bmNUb1N0cmluZyk6CisgICAgICAgICogcnVudGltZS9TbWFsbFN0cmluZ3MuY3BwOgorICAg ICAgICAoSlNDOjpTbWFsbFN0cmluZ3M6OlNtYWxsU3RyaW5ncyk6CisgICAgICAgIChKU0M6OlNt YWxsU3RyaW5nczo6aW5pdGlhbGl6ZUNvbW1vblN0cmluZ3MpOgorICAgICAgICAoSlNDOjpTbWFs bFN0cmluZ3M6OnZpc2l0U3Ryb25nUmVmZXJlbmNlcyk6CisgICAgICAgICogcnVudGltZS9TbWFs bFN0cmluZ3MuaDoKKyAgICAgICAgKEpTQzo6U21hbGxTdHJpbmdzOjpudWxsT2JqZWN0U3RyaW5n KToKKyAgICAgICAgKEpTQzo6U21hbGxTdHJpbmdzOjp1bmRlZmluZWRPYmplY3RTdHJpbmcpOgor CiAyMDE0LTA1LTIzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIG9wZXJhdGlvbkNhbGxHZXR0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PYmplY3RQcm90b3R5cGUuY3BwCmluZGV4IDdkYWYwZDYuLmVjZDMz OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdFByb3Rv dHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0UHJvdG90 eXBlLmNwcApAQCAtMjE1LDcgKzIxNSw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwg b2JqZWN0UHJvdG9GdW5jVG9TdHJpbmcoRXhlY1N0YXRlKiBleGVjKQogICAgIFZNJiB2bSA9IGV4 ZWMtPnZtKCk7CiAgICAgSlNWYWx1ZSB0aGlzVmFsdWUgPSBleGVjLT50aGlzVmFsdWUoKS50b1Ro aXMoZXhlYywgU3RyaWN0TW9kZSk7CiAgICAgaWYgKHRoaXNWYWx1ZS5pc1VuZGVmaW5lZE9yTnVs bCgpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTm9udHJpdmlhbFN0cmluZygm dm0sIFN0cmluZyh0aGlzVmFsdWUuaXNVbmRlZmluZWQoKSA/IEFTQ0lJTGl0ZXJhbCgiW29iamVj dCBVbmRlZmluZWRdIikgOiBBU0NJSUxpdGVyYWwoIltvYmplY3QgTnVsbF0iKSkpKTsKKyAgICAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZSh0aGlzVmFsdWUuaXNVbmRlZmluZWQoKSA/IHZtLnNt YWxsU3RyaW5ncy51bmRlZmluZWRPYmplY3RTdHJpbmcoKSA6IHZtLnNtYWxsU3RyaW5ncy5udWxs T2JqZWN0U3RyaW5nKCkpOwogICAgIEpTT2JqZWN0KiB0aGlzT2JqZWN0ID0gdGhpc1ZhbHVlLnRv T2JqZWN0KGV4ZWMpOwogCiAgICAgSlNTdHJpbmcqIHJlc3VsdCA9IHRoaXNPYmplY3QtPnN0cnVj dHVyZSh2bSktPm9iamVjdFRvU3RyaW5nVmFsdWUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TbWFsbFN0cmluZ3MuY3BwCmluZGV4IDU0Y2VmOTcuLmE0YmRiMGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU21hbGxTdHJpbmdzLmNwcApAQCAtNjcs NiArNjcsOCBAQCBTbWFsbFN0cmluZ3M6OlNtYWxsU3RyaW5ncygpCiAjZGVmaW5lIEpTQ19DT01N T05fU1RSSU5HU19BVFRSSUJVVEVfSU5JVElBTElaRShuYW1lKSAsIG1fIyNuYW1lKDApCiAgICAg SlNDX0NPTU1PTl9TVFJJTkdTX0VBQ0hfTkFNRShKU0NfQ09NTU9OX1NUUklOR1NfQVRUUklCVVRF X0lOSVRJQUxJWkUpCiAjdW5kZWYgSlNDX0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9JTklUSUFM SVpFCisgICAgLCBtX251bGxPYmplY3RTdHJpbmcobnVsbHB0cikKKyAgICAsIG1fdW5kZWZpbmVk T2JqZWN0U3RyaW5nKG51bGxwdHIpCiB7CiAgICAgQ09NUElMRV9BU1NFUlQoc2luZ2xlQ2hhcmFj dGVyU3RyaW5nQ291bnQgPT0gc2l6ZW9mKG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5ncykgLyBzaXpl b2YobV9zaW5nbGVDaGFyYWN0ZXJTdHJpbmdzWzBdKSwgSXNOdW1DaGFyYWN0ZXJzQ29uc3RJblN5 bmNXaXRoQ2xhc3NVc2FnZSk7CiAKQEAgLTgyLDYgKzg0LDggQEAgdm9pZCBTbWFsbFN0cmluZ3M6 OmluaXRpYWxpemVDb21tb25TdHJpbmdzKFZNJiB2bSkKICNkZWZpbmUgSlNDX0NPTU1PTl9TVFJJ TkdTX0FUVFJJQlVURV9JTklUSUFMSVpFKG5hbWUpIGluaXRpYWxpemUoJnZtLCBtXyMjbmFtZSwg I25hbWUpOwogICAgIEpTQ19DT01NT05fU1RSSU5HU19FQUNIX05BTUUoSlNDX0NPTU1PTl9TVFJJ TkdTX0FUVFJJQlVURV9JTklUSUFMSVpFKQogI3VuZGVmIEpTQ19DT01NT05fU1RSSU5HU19BVFRS SUJVVEVfSU5JVElBTElaRQorICAgIGluaXRpYWxpemUoJnZtLCBtX251bGxPYmplY3RTdHJpbmcs ICJbb2JqZWN0IE51bGxdIik7CisgICAgaW5pdGlhbGl6ZSgmdm0sIG1fdW5kZWZpbmVkT2JqZWN0 U3RyaW5nLCAiW29iamVjdCBVbmRlZmluZWRdIik7CiB9CiAKIHZvaWQgU21hbGxTdHJpbmdzOjp2 aXNpdFN0cm9uZ1JlZmVyZW5jZXMoU2xvdFZpc2l0b3ImIHZpc2l0b3IpCkBAIC05Miw2ICs5Niw4 IEBAIHZvaWQgU21hbGxTdHJpbmdzOjp2aXNpdFN0cm9uZ1JlZmVyZW5jZXMoU2xvdFZpc2l0b3Im IHZpc2l0b3IpCiAjZGVmaW5lIEpTQ19DT01NT05fU1RSSU5HU19BVFRSSUJVVEVfVklTSVQobmFt ZSkgdmlzaXRvci5hcHBlbmRVbmJhcnJpZXJlZFBvaW50ZXIoJm1fIyNuYW1lKTsKICAgICBKU0Nf Q09NTU9OX1NUUklOR1NfRUFDSF9OQU1FKEpTQ19DT01NT05fU1RSSU5HU19BVFRSSUJVVEVfVklT SVQpCiAjdW5kZWYgSlNDX0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9WSVNJVAorICAgIHZpc2l0 b3IuYXBwZW5kVW5iYXJyaWVyZWRQb2ludGVyKCZtX251bGxPYmplY3RTdHJpbmcpOworICAgIHZp c2l0b3IuYXBwZW5kVW5iYXJyaWVyZWRQb2ludGVyKCZtX3VuZGVmaW5lZE9iamVjdFN0cmluZyk7 CiB9CiAKIFNtYWxsU3RyaW5nczo6flNtYWxsU3RyaW5ncygpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCmluZGV4IDBlODY0NmEuLmUzZDM5ODEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCkBAIC04Niw2ICs4 Niw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBKU0NfQ09NTU9OX1NUUklOR1NfRUFDSF9O QU1FKEpTQ19DT01NT05fU1RSSU5HU19BQ0NFU1NPUl9ERUZJTklUSU9OKQogI3VuZGVmIEpTQ19D T01NT05fU1RSSU5HU19BQ0NFU1NPUl9ERUZJTklUSU9OCiAKKyAgICAgICAgSlNTdHJpbmcqIG51 bGxPYmplY3RTdHJpbmcoKSBjb25zdCB7IHJldHVybiBtX251bGxPYmplY3RTdHJpbmc7IH0KKyAg ICAgICAgSlNTdHJpbmcqIHVuZGVmaW5lZE9iamVjdFN0cmluZygpIGNvbnN0IHsgcmV0dXJuIG1f dW5kZWZpbmVkT2JqZWN0U3RyaW5nOyB9CisKICAgICBwcml2YXRlOgogICAgICAgICBzdGF0aWMg Y29uc3QgdW5zaWduZWQgc2luZ2xlQ2hhcmFjdGVyU3RyaW5nQ291bnQgPSBtYXhTaW5nbGVDaGFy YWN0ZXJTdHJpbmcgKyAxOwogCkBAIC05OCw2ICsxMDEsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICNk ZWZpbmUgSlNDX0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9ERUNMQVJBVElPTihuYW1lKSBKU1N0 cmluZyogbV8jI25hbWU7CiAgICAgICAgIEpTQ19DT01NT05fU1RSSU5HU19FQUNIX05BTUUoSlND X0NPTU1PTl9TVFJJTkdTX0FUVFJJQlVURV9ERUNMQVJBVElPTikKICN1bmRlZiBKU0NfQ09NTU9O X1NUUklOR1NfQVRUUklCVVRFX0RFQ0xBUkFUSU9OCisgICAgICAgIEpTU3RyaW5nKiBtX251bGxP YmplY3RTdHJpbmc7CisgICAgICAgIEpTU3RyaW5nKiBtX3VuZGVmaW5lZE9iamVjdFN0cmluZzsK ICAgICAgICAgSlNTdHJpbmcqIG1fc2luZ2xlQ2hhcmFjdGVyU3RyaW5nc1tzaW5nbGVDaGFyYWN0 ZXJTdHJpbmdDb3VudF07CiAgICAgICAgIE93blB0cjxTbWFsbFN0cmluZ3NTdG9yYWdlPiBtX3N0 b3JhZ2U7CiAgICAgfTsK