133254 2014-05-23 20:55:16 -0700 Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree 2014-05-24 13:41:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin simon.fraser thorton oldest_to_newest 1011471 0 simon.fraser 2014-05-23 20:55:16 -0700 Rename ScrollingTreeScrollingNode's m_scrollPosition to make it clear that it's the value committed from the state tree 1011473 1 232015 simon.fraser 2014-05-23 20:56:33 -0700 Created attachment 232015 Patch 1011474 2 simon.fraser 2014-05-23 20:56:59 -0700 Sits on top of an earlier patch. 1011476 3 232015 thorton 2014-05-23 21:01:01 -0700 Comment on attachment 232015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232015&action=review > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:62 > + m_lastCommittedcrollPosition = state.scrollPosition(); where did the s go 1011534 4 simon.fraser 2014-05-24 13:41:15 -0700 https://trac.webkit.org/r169313 232015 2014-05-23 20:56:33 -0700 2014-05-23 21:01:00 -0700 Patch bug-133254-20140523205610.patch text/plain 3353 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDViODgxOWM5OTI0ZDJj ZDk2YTAwZmY5NmUwOTBiNDc0ZDYyMzQyYy4uY2ZhNDBhMzBjYmMzOGQ4MTQ3MDNmOGU3MTQ0Y2Jm ZTY0ZDA3ZmI5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE0LTA1LTIzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJlbmFtZSBTY3Jv bGxpbmdUcmVlU2Nyb2xsaW5nTm9kZSdzIG1fc2Nyb2xsUG9zaXRpb24gdG8gbWFrZSBpdCBjbGVh ciB0aGF0IGl0J3MgdGhlIHZhbHVlIGNvbW1pdHRlZCBmcm9tIHRoZSBzdGF0ZSB0cmVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMyNTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFNjcm9sbGlu Z1RyZWVTY3JvbGxpbmdOb2RlOjpzY3JvbGxQb3NpdGlvbigpIHB1cmUgdmlydHVhbCwgYW5kIHJl bmFtZQorICAgICAgICB0aGUgbWVtYmVyIHZhcmlhYmxlIGFuZCBhc3NvY2lhdGVkIGdldHRlciB0 byBtYWtlIGl0IGNsZWFyIHRoYXQgdGhleSByZWxhdGUKKyAgICAgICAgdG8gdGhlIGxhc3QgY29t bWl0dGVkIHNjcm9sbCBwb3NpdGlvbi4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ1RyZWVTY3JvbGxpbmdOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1Ry ZWVTY3JvbGxpbmdOb2RlOjp1cGRhdGVCZWZvcmVDaGlsZHJlbik6CisgICAgICAgICogcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlOjpsYXN0Q29tbWl0dGVkU2Nyb2xsUG9zaXRpb24p OgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OnNjcm9sbFBv c2l0aW9uKTogRGVsZXRlZC4KKworMjAxNC0wNS0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBTaGFyZSBzb21lIG1vcmUgU2Nyb2xsaW5nVHJlZVNj cm9sbGluZ05vZGUgY29kZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTMzMjQ4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmNwcAppbmRleCBjZjgzNzVjMDE4 MTQ3NGU3MGRlZjNjYTdiYjQ3NjMyMjQ3OGEzYmY4Li5hMGIzMjJhMjRjNzNmODc5NTY0MzY0OTll NGEwNjgwYTgyMTgxMjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUuY3BwCkBAIC01OSw3ICs1OSw3 IEBAIHZvaWQgU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGU6OnVwZGF0ZUJlZm9yZUNoaWxkcmVu KGNvbnN0IFNjcm9sbGluZ1N0YXRlTm9kZSYKICAgICB9CiAKICAgICBpZiAoc3RhdGUuaGFzQ2hh bmdlZFByb3BlcnR5KFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZTo6U2Nyb2xsUG9zaXRpb24p KQotICAgICAgICBtX3Njcm9sbFBvc2l0aW9uID0gc3RhdGUuc2Nyb2xsUG9zaXRpb24oKTsKKyAg ICAgICAgbV9sYXN0Q29tbWl0dGVkY3JvbGxQb3NpdGlvbiA9IHN0YXRlLnNjcm9sbFBvc2l0aW9u KCk7CiAKICAgICBpZiAoc3RhdGUuaGFzQ2hhbmdlZFByb3BlcnR5KFNjcm9sbGluZ1N0YXRlU2Ny b2xsaW5nTm9kZTo6U2Nyb2xsT3JpZ2luKSkKICAgICAgICAgbV9zY3JvbGxPcmlnaW4gPSBzdGF0 ZS5zY3JvbGxPcmlnaW4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5nTm9kZS5oCmluZGV4IDhhMDFmNWYxOGY4NGQ3 ZTVjYzM0NDU2ZGY4ZDU3YjRhNDQ1Y2MyM2EuLmRjZmVkZmMwNmJiNzZjN2IzOGZlM2U5Mjc0ZWUz ZmQxNmNiOGVjYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1RyZWVTY3JvbGxpbmdOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUuaApAQCAtNjQsNyArNjQsOSBAQCBwcm90 ZWN0ZWQ6CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0U2Nyb2xsTGF5ZXJQb3NpdGlvbihjb25zdCBG bG9hdFBvaW50JikgPSAwOwogCi0gICAgdmlydHVhbCBGbG9hdFBvaW50IHNjcm9sbFBvc2l0aW9u KCkgY29uc3QgeyByZXR1cm4gbV9zY3JvbGxQb3NpdGlvbjsgfQorICAgIHZpcnR1YWwgRmxvYXRQ b2ludCBzY3JvbGxQb3NpdGlvbigpIGNvbnN0ID0gMDsKKworICAgIEZsb2F0UG9pbnQgbGFzdENv bW1pdHRlZFNjcm9sbFBvc2l0aW9uKCkgY29uc3QgeyByZXR1cm4gbV9sYXN0Q29tbWl0dGVkY3Jv bGxQb3NpdGlvbjsgfQogICAgIGNvbnN0IEZsb2F0U2l6ZSYgc2Nyb2xsYWJsZUFyZWFTaXplKCkg Y29uc3QgeyByZXR1cm4gbV9zY3JvbGxhYmxlQXJlYVNpemU7IH0KICAgICBjb25zdCBGbG9hdFNp emUmIHRvdGFsQ29udGVudHNTaXplKCkgY29uc3QgeyByZXR1cm4gbV90b3RhbENvbnRlbnRzU2l6 ZTsgfQogICAgIGNvbnN0IEludFBvaW50JiBzY3JvbGxPcmlnaW4oKSBjb25zdCB7IHJldHVybiBt X3Njcm9sbE9yaWdpbjsgfQpAQCAtODcsNyArODksNyBAQCBwcml2YXRlOgogICAgIEZsb2F0U2l6 ZSBtX3Njcm9sbGFibGVBcmVhU2l6ZTsKICAgICBGbG9hdFNpemUgbV90b3RhbENvbnRlbnRzU2l6 ZTsKICAgICBGbG9hdFNpemUgbV90b3RhbENvbnRlbnRzU2l6ZUZvclJ1YmJlckJhbmQ7Ci0gICAg RmxvYXRQb2ludCBtX3Njcm9sbFBvc2l0aW9uOyAvLyBGSVhNRTogdGhpcyBpcyB0aGUgY29tbWl0 dGVkIHNjcm9sbCBwb3NpdGlvbi4KKyAgICBGbG9hdFBvaW50IG1fbGFzdENvbW1pdHRlZGNyb2xs UG9zaXRpb247CiAgICAgSW50UG9pbnQgbV9zY3JvbGxPcmlnaW47CiAgICAgCiAgICAgU2Nyb2xs YWJsZUFyZWFQYXJhbWV0ZXJzIG1fc2Nyb2xsYWJsZUFyZWFQYXJhbWV0ZXJzOwo=