133253 2014-05-23 20:50:18 -0700 REGRESSION: Rubberbanding out jumps to top left corner on google.com 2014-05-23 22:50:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ian webkit-unassigned benjamin commit-queue oldest_to_newest 1011469 0 ian 2014-05-23 20:50:18 -0700 <rdar://problem/17025664> REGRESSION: Rubberbanding out jumps to top left corner on google.com 1011470 1 232014 ian 2014-05-23 20:54:42 -0700 Created attachment 232014 proposed patch 1011472 2 commit-queue 2014-05-23 20:56:24 -0700 Attachment 232014 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:946: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1011475 3 ian 2014-05-23 20:58:56 -0700 I haven't actually tested this yet. It works fine in Safari, though. Feel free to test it yourself before reviewing, or you can wait for me to finish updating my tree and building. 1011482 4 232014 benjamin 2014-05-23 21:29:53 -0700 Comment on attachment 232014 proposed patch Great find. I'll fix the style and land manually. 1011483 5 ian 2014-05-23 21:32:51 -0700 I finally finished building. Seems to work! 1011484 6 ian 2014-05-23 21:33:32 -0700 (In reply to comment #4) > (From update of attachment 232014 [details]) > Great find. I'll fix the style and land manually. Sounds good, thanks! 1011485 7 benjamin 2014-05-23 21:37:26 -0700 Committed r169304: <http://trac.webkit.org/changeset/169304> 1011490 8 benjamin 2014-05-23 22:50:36 -0700 It works great :) 232014 2014-05-23 20:54:42 -0700 2014-05-23 21:29:52 -0700 proposed patch 133253.patch text/plain 1746 ian ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0MzIzZTFiZS4uYTQyYThhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTA1LTIzICBJYW4gSGVuZGVyc29uICA8aWFuaEBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTjogUnViYmVyYmFuZGluZyBvdXQganVtcHMgdG8gdG9wIGxlZnQgY29ybmVy IG9uIGdvb2dsZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEzMzI1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTcwMjU2NjQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHNjcm9sbFZpZXdXaWxs RW5kRHJhZ2dpbmc6d2l0aFZlbG9jaXR5OnRhcmdldENvbnRlbnRPZmZzZXQ6XSk6CisgICAgICAg IEF2b2lkIGRlY2VsZXJhdGlvbiBkdXJpbmcgem9vbWluZyB0byB3b3JrIGFyb3VuZCBhIFVJS2l0 IGJ1Zy4KKwogMjAxNC0wNS0yMyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OIChpT1MgV2ViS2l0Mik6IHJlcXVlc3RBbmltYXRpb25G cmFtZSBmaXJlcyBtb3JlIHRoYW4gb25jZSBiZXR3ZWVuIGxheWVyIHRyZWUgY29tbWl0cwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCA1 OTk1YjcxLi44ZjA0MDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbQpAQCAtOTM1LDYgKzkzNSwxNCBAQCAtICh2b2lkKV9kaWRGaW5pc2hT Y3JvbGxpbmcKICAgICBbX2NvbnRlbnRWaWV3IGRpZEZpbmlzaFNjcm9sbGluZ107CiB9CiAKKy0g KHZvaWQpc2Nyb2xsVmlld1dpbGxFbmREcmFnZ2luZzooVUlTY3JvbGxWaWV3ICopc2Nyb2xsVmll dyB3aXRoVmVsb2NpdHk6KENHUG9pbnQpdmVsb2NpdHkgdGFyZ2V0Q29udGVudE9mZnNldDooaW5v dXQgQ0dQb2ludCAqKXRhcmdldENvbnRlbnRPZmZzZXQKK3sKKyAgICAvLyBXb3JrIGFyb3VuZCA8 cmRhcjovL3Byb2JsZW0vMTYzNzQ3NTM+IGJ5IGF2b2lkaW5nIGRlY2VsZXJhdGlvbiB3aGlsZQor ICAgIC8vIHpvb21pbmcuICBXZSdsbCBhbmltYXRlIHRvIHRoZSByaWdodCBwbGFjZSBvbmNlIHRo ZSB6b29tIGZpbmlzaGVzLgorICAgIGlmIChbc2Nyb2xsVmlldyBpc1pvb21pbmddKQorICAgICAg ICAqdGFyZ2V0Q29udGVudE9mZnNldCA9IFtzY3JvbGxWaWV3IGNvbnRlbnRPZmZzZXRdOworfQor CiAtICh2b2lkKXNjcm9sbFZpZXdEaWRFbmREcmFnZ2luZzooVUlTY3JvbGxWaWV3ICopc2Nyb2xs VmlldyB3aWxsRGVjZWxlcmF0ZTooQk9PTClkZWNlbGVyYXRlCiB7CiAgICAgLy8gSWYgd2UncmUg ZGVjZWxlcmF0aW5nLCBzY3JvbGwgb2Zmc2V0IHdpbGwgYmUgdXBkYXRlZCB3aGVuIHNjcm9sbFZp ZXdEaWRGaW5pc2hEZWNlbGVyYXRpbmc6IGlzIGNhbGxlZC4K