133240 2014-05-23 16:25:41 -0700 [Mac] preload AVAssetTrack properties before asking for them 2014-05-25 00:00:46 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1011402 0 eric.carlson 2014-05-23 16:25:41 -0700 r168979 started checking AVAssetTrack preferredTransform and naturalSize, so we should preload them along with the other track properties we use. 1011403 1 eric.carlson 2014-05-23 16:26:21 -0700 <rdar://problem/17022444> 1011404 2 232001 eric.carlson 2014-05-23 16:28:55 -0700 Created attachment 232001 Proposed patch. 1011406 3 commit-queue 2014-05-23 16:30:58 -0700 Attachment 232001 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2558: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1011444 4 232001 jer.noble 2014-05-23 18:31:28 -0700 Comment on attachment 232001 Proposed patch. r=me 1011560 5 232030 eric.carlson 2014-05-24 23:24:42 -0700 Created attachment 232030 Patch for landing. 1011562 6 232030 commit-queue 2014-05-25 00:00:46 -0700 Comment on attachment 232030 Patch for landing. Clearing flags on attachment: 232030 Committed r169317: <http://trac.webkit.org/changeset/169317> 232001 2014-05-23 16:28:55 -0700 2014-05-23 18:31:28 -0700 Proposed patch. patch_2.txt text/plain 1685 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTI4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHByZWxvYWQg QVZBc3NldFRyYWNrIHByb3BlcnRpZXMgYmVmb3JlIGFza2luZyBmb3IgdGhlbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjQwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1t OgorICAgICAgICAoV2ViQ29yZTo6YXNzZXRUcmFja01ldGFkYXRhS2V5TmFtZXMpOiBBZGQgcHJl ZmVycmVkVHJhbnNmb3JtIGFuZCBuYXR1cmFsU2l6ZSB0byB0aGUgbGlzdAorICAgICAgICAgICAg b2YgcHJvcGVydGllcyB3ZSBwcmVsb2FkLgorCiAyMDE0LTA1LTIzICBFbnJpY2EgQ2FzdWNjaSAg PGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGludmFsaWQgQVNTRVJUIGluIHdv cmRSYW5nZUZvclBvc2l0aW9uLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5t bQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCShyZXZpc2lv biAxNjkyNzUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCSh3b3JraW5nIGNv cHkpCkBAIC0yNTU0LDcgKzI1NjIsMTIgQEAgTlNBcnJheSogaXRlbUtWT1Byb3BlcnRpZXMoKQog CiBOU0FycmF5KiBhc3NldFRyYWNrTWV0YWRhdGFLZXlOYW1lcygpCiB7Ci0gICAgc3RhdGljIE5T QXJyYXkqIGtleXMgPSBbW05TQXJyYXkgYWxsb2NdIGluaXRXaXRoT2JqZWN0czpAInRvdGFsU2Ft cGxlRGF0YUxlbmd0aCIsIEAibWVkaWFUeXBlIiwgQCJlbmFibGVkIiwgbmlsXTsKKyAgICBzdGF0 aWMgTlNBcnJheSoga2V5cyA9IFtbTlNBcnJheSBhbGxvY10gaW5pdFdpdGhPYmplY3RzOkAidG90 YWxTYW1wbGVEYXRhTGVuZ3RoIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBAIm1lZGlh VHlwZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgQCJlbmFibGVkIiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBAInByZWZlcnJlZFRyYW5zZm9ybSIsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQCJuYXR1cmFsU2l6ZSIsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbmlsXTsKIAogICAgIHJldHVybiBrZXlzOwogfQo= 232030 2014-05-24 23:24:42 -0700 2014-05-25 00:00:46 -0700 Patch for landing. patch_3.txt text/plain 1536 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTI4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIHByZWxvYWQg QVZBc3NldFRyYWNrIHByb3BlcnRpZXMgYmVmb3JlIGFza2luZyBmb3IgdGhlbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjQwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgSmVyIE5vYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OmFzc2V0VHJhY2tNZXRhZGF0YUtleU5hbWVzKTogQWRkIHByZWZlcnJl ZFRyYW5zZm9ybSBhbmQgbmF0dXJhbFNpemUgdG8gdGhlIGxpc3QKKyAgICAgICAgICAgIG9mIHBy b3BlcnRpZXMgd2UgcHJlbG9hZC4KKwogMjAxNC0wNS0yMyAgRW5yaWNhIENhc3VjY2kgIDxlbnJp Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBpbnZhbGlkIEFTU0VSVCBpbiB3b3JkUmFu Z2VGb3JQb3NpdGlvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9u L29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQkocmV2aXNpb24gMTY5 Mjc1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQkod29ya2luZyBjb3B5KQpA QCAtMjU1NCw4ICsyNTYyLDcgQEAgTlNBcnJheSogaXRlbUtWT1Byb3BlcnRpZXMoKQogCiBOU0Fy cmF5KiBhc3NldFRyYWNrTWV0YWRhdGFLZXlOYW1lcygpCiB7Ci0gICAgc3RhdGljIE5TQXJyYXkq IGtleXMgPSBbW05TQXJyYXkgYWxsb2NdIGluaXRXaXRoT2JqZWN0czpAInRvdGFsU2FtcGxlRGF0 YUxlbmd0aCIsIEAibWVkaWFUeXBlIiwgQCJlbmFibGVkIiwgbmlsXTsKLQorICAgIHN0YXRpYyBO U0FycmF5KiBrZXlzID0gW1tOU0FycmF5IGFsbG9jXSBpbml0V2l0aE9iamVjdHM6QCJ0b3RhbFNh bXBsZURhdGFMZW5ndGgiLCBAIm1lZGlhVHlwZSIsIEAiZW5hYmxlZCIsIEAicHJlZmVycmVkVHJh bnNmb3JtIiwgQCJuYXR1cmFsU2l6ZSIsIG5pbF07CiAgICAgcmV0dXJuIGtleXM7CiB9CiAK