133232 2014-05-23 13:57:23 -0700 Remove invalid ASSERT in wordRangeForPosition 2014-05-23 14:33:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica oldest_to_newest 1011343 0 enrica 2014-05-23 13:57:23 -0700 In WK2 for iOS this function is called on every selection change. The selection could be set by Javascript in an element that is not visible. In that case we won't be able to create a VisiblePosition and wordRangeForPosition should not ASSERT that the VisiblePosition is not null, but rather perform an early return if it is null. 1011345 1 231981 enrica 2014-05-23 14:00:51 -0700 Created attachment 231981 Patch 1011365 2 enrica 2014-05-23 14:33:19 -0700 Committed revision 169280. 231981 2014-05-23 14:00:51 -0700 2014-05-23 14:20:07 -0700 Patch noassert.txt text/plain 1684 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTI3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTIzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGludmFsaWQgQVNT RVJUIGluIHdvcmRSYW5nZUZvclBvc2l0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW4gV0syIGZvciBpT1MgdGhpcyBmdW5jdGlvbiBpcyBjYWxs ZWQgb24gZXZlcnkgc2VsZWN0aW9uIGNoYW5nZS4KKyAgICAgICAgVGhlIHNlbGVjdGlvbiBjb3Vs ZCBiZSBzZXQgYnkgSmF2YXNjcmlwdCBpbiBhbiBlbGVtZW50IHRoYXQgaXMgbm90IHZpc2libGUu CisgICAgICAgIEluIHRoYXQgY2FzZSB3ZSB3b24ndCBiZSBhYmxlIHRvIGNyZWF0ZSBhIFZpc2li bGVQb3NpdGlvbiB0aGVyZWZvcmUgd29yZFJhbmdlRm9yUG9zaXRpb24KKyAgICAgICAgc2hvdWxk IG5vdCBBU1NFUlQgdGhhdCB0aGUgVmlzaWJsZVBvc2l0aW9uIGlzIG5vdCBudWxsLCBidXQgcmF0 aGVyCisgICAgICAgIHBlcmZvcm0gYW4gZWFybHkgcmV0dXJuIGlmIGl0IGlzIG51bGwuCisKKyAg ICAgICAgKiBlZGl0aW5nL1Zpc2libGVVbml0cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp3b3Jk UmFuZ2VGcm9tUG9zaXRpb24pOgorCiAyMDE0LTA1LTIzICBNYW51ZWwgUmVnbyBDYXNhc25vdmFz ICA8cmVnb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFVzZSBncmlk Um93Q291bnQoKSBhbmQgZ3JpZENvbHVtbkNvdW50KCkgd2hlbiBwb3NzaWJsZQpJbmRleDogU291 cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvVmlzaWJsZVVuaXRzLmNwcAkocmV2aXNpb24gMTY5MjU5KQorKysg U291cmNlL1dlYkNvcmUvZWRpdGluZy9WaXNpYmxlVW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xODM1LDcgKzE4MzUsOSBAQCBVQ2hhcjMyIGNoYXJhY3RlckJlZm9yZVBvc2l0aW9uKGNvbnN0 IFZpCiAKIFBhc3NSZWZQdHI8UmFuZ2U+IHdvcmRSYW5nZUZyb21Qb3NpdGlvbihjb25zdCBWaXNp YmxlUG9zaXRpb24mIHBvc2l0aW9uKQogewotICAgIEFTU0VSVChwb3NpdGlvbi5pc05vdE51bGwo KSk7CisgICAgLy8gVGhlIHNlbGVjdGlvbiBjb3VsZCBiZSBpbiBhIG5vbiB2aXNpYmxlIGVsZW1l bnQgYW5kIHdlIGRvbid0IGhhdmUgYSBWaXNpYmxlUG9zaXRpb24uCisgICAgaWYgKHBvc2l0aW9u LmlzTnVsbCgpKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIFJlZlB0cjxSYW5nZT4g cmFuZ2UgPSBlbmNsb3NpbmdUZXh0VW5pdE9mR3JhbnVsYXJpdHkocG9zaXRpb24sIFdvcmRHcmFu dWxhcml0eSwgRGlyZWN0aW9uQmFja3dhcmQpOwogCg==