133221 2014-05-23 09:58:35 -0700 navigator object needs to have properties directly on the instance object 2016-02-16 13:08:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154304 InRadar P2 Normal --- 1 oliver oliver ap cdumez cgarcia commit-queue dbates mhahnenberg mitz oldest_to_newest 1011266 0 oliver 2014-05-23 09:58:35 -0700 navigator object needs to have properties directly on the instance object 1011267 1 231970 oliver 2014-05-23 10:02:16 -0700 Created attachment 231970 Patch 1011269 2 231970 mark.lam 2014-05-23 10:05:00 -0700 Comment on attachment 231970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review r=me with comment fix. > Source/WebCore/ChangeLog:9 > + as there were a few compatability issues when on the prototype. s/compatability/compatibility/ 1011271 3 231970 ap 2014-05-23 10:07:02 -0700 Comment on attachment 231970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231970&action=review >> Source/WebCore/ChangeLog:9 >> + as there were a few compatability issues when on the prototype. > > s/compatability/compatibility/ Is there a way to discover what the issues were (perhaps a Radar?) 1011273 4 oliver 2014-05-23 10:08:52 -0700 Committed r169260: <http://trac.webkit.org/changeset/169260> 1011277 5 oliver 2014-05-23 10:10:12 -0700 rdar://16332749 1011309 6 mhahnenberg 2014-05-23 11:10:32 -0700 (In reply to comment #4) > Committed r169260: <http://trac.webkit.org/changeset/169260> This appears to have broken the following tests on the WK2 bots: fast/dom/Geolocation/enabled.html js/dom/delete-syntax.html Here's a link to the test results: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169260%20(5917)/results.html Here's a link to the history of test results: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=25 231970 2014-05-23 10:02:16 -0700 2014-05-23 10:07:02 -0700 Patch bug-133221-20140523100152.patch text/plain 1544 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhhNzliOTdmZDViZDJl MTRkOGZlZTBmYWY5OThlNTUzMWY3ZmZkYS4uZDM2ZjkzNDc5MTk3NGIxOTYwZGMyZjgwZjc4NTY3 MGRhMWQzMjYyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTIzICBPbGl2 ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAgICAgTmF2aWdhdG9yIG9iamVjdCBu ZWVkcyB0byBoYXZlIHByb3BlcnRpZXMgZGlyZWN0bHkgb24gdGhlIGluc3RhbmNlIG9iamVjdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMjIxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRmxhZyB0aGUg TmF2aWdhdG9yIG9iamVjdCBhcyByZXF1aXJpbmcgcHJvcGVydGllcyB0byBiZSBvbiB0aGUgaW5z dGFuY2UKKyAgICAgICAgYXMgdGhlcmUgd2VyZSBhIGZldyBjb21wYXRhYmlsaXR5IGlzc3VlcyB3 aGVuIG9uIHRoZSBwcm90b3R5cGUuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEludGVyZmFjZVJlcXVpcmVzQXR0cmlidXRlc09uSW5z dGFuY2UpOgorCiAyMDE0LTA1LTIzICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5nOiBNYWtlIHdlYmtpdC1ib3gtc2hhZG93IHBhaW50 aW5nIHN1YnBpeGVsIGF3YXJlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCBlMGI1NzUzNmMzMmY1MGY1YzgwYzQ2YTlkZTMy MzZhOGM3N2FjZGM4Li4zYTY3YTRjY2EyNjdlZWU0NTUzNjMwYzQzMzk4NmEzOTRlZGE4YjA1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbQpAQCAtNjIzLDYgKzYyMyw3IEBAIHN1YiBJbnRlcmZhY2VSZXF1aXJlc0F0dHJpYnV0ZXNP bkluc3RhbmNlCiAgICAgIyBGSVhNRTogVGhlc2UgdHdvIHNob3VsZCBiZSBmaXhlZCBieSByZW1v dmluZyB0aGUgY3VzdG9tIG92ZXJyaWRlIG9mIG1lc3NhZ2UsIGV0YwogICAgIHJldHVybiAxIGlm ICRpbnRlcmZhY2VOYW1lID1+ICJFeGNlcHRpb24iOwogICAgIHJldHVybiAxIGlmICRpbnRlcmZh Y2VOYW1lID1+ICJFcnJvciI7CisgICAgcmV0dXJuIDEgaWYgJGludGVyZmFjZU5hbWUgPX4gIk5h dmlnYXRvciI7CiAKICAgICByZXR1cm4gMSBpZiBJc0RPTUdsb2JhbE9iamVjdCgkaW50ZXJmYWNl KTsKIAo=