133213 2014-05-23 05:09:52 -0700 [CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible 2014-05-23 13:31:54 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue esprehn+autocc glenn jfernandez kondapallykalyan svillar oldest_to_newest 1011224 0 rego 2014-05-23 05:09:52 -0700 We're not being consistent in RenderGrid code and sometimes we use m_grid.size() and other gridRowCount() (and the same for columns). This is a simple patch to use gridRowCount() and gridColumnCount() always when it's possible. Which will make the code more descriptive and easier to understand. BTW, a similar patch has already landed in Blink: https://codereview.chromium.org/235713003/ 1011227 1 231958 rego 2014-05-23 05:19:32 -0700 Created attachment 231958 Patch 1011242 2 231958 svillar 2014-05-23 08:13:01 -0700 Comment on attachment 231958 Patch Nice cleanup 1011336 3 231958 commit-queue 2014-05-23 13:31:51 -0700 Comment on attachment 231958 Patch Clearing flags on attachment: 231958 Committed r169277: <http://trac.webkit.org/changeset/169277> 1011337 4 commit-queue 2014-05-23 13:31:54 -0700 All reviewed patches have been landed. Closing bug. 231958 2014-05-23 05:19:32 -0700 2014-05-23 13:31:51 -0700 Patch bug-133213-20140523141908.patch text/plain 2814 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRhNTZkNjBkZDQwZGIx YWMwMzk2NzQxOTQwZDA5MmYxY2JjNWMwMy4uYWYwYWRhNjk5ZDc4ZjExNzJjMzQwZDUwZTc3NDhm NTEwMGZmY2E1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA1LTIzICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIFVzZSBncmlkUm93Q291bnQoKSBhbmQgZ3JpZENvbHVtbkNvdW50KCkgd2hlbiBw b3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMzMjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIGdyaWRSb3dDb3VudCgpIGFuZCBncmlkQ29sdW1uQ291bnQoKSBpbnN0ZWFkIG9mIG1fZ3Jp ZC5zaXplKCkgYW5kCisgICAgICAgIG1fZ3JpZFswXS5zaXplKCkgdG8gbWFrZSB0aGUgY29kZSBt b3JlIGRlc2NyaXB0aXZlIGFuZCBlYXNpZXIgdG8KKyAgICAgICAgdW5kZXJzdGFuZC4KKworICAg ICAgICBObyBuZXcgdGVzdHMgKE5vIGNoYW5nZSBpbiBiZWhhdmlvcikuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpn cm93R3JpZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjpwbGFjZUF1dG9NYWpvckF4 aXNJdGVtT25HcmlkKToKKwogMjAxNC0wNS0yMiAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0Bv dXRsb29rLmNvbT4KIAogICAgICAgICBbQ3VybF0gQ3Jhc2ggd2hlbiBleGNlZWRpbmcgbWF4aW11 bSBjYWNoZSBsaW1pdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJHcmlkLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAppbmRl eCA4Y2QxNTY0MWIzODM0OGMwNDk3ZTFlOWI3MWRiNWE1ZTM5YmI3MGQ1Li5kYTM2YzI5NTcyNzIy ZDg5NDJlODc0NWIzZDZlNTZkZjllOTExNTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckdyaWQuY3BwCkBAIC02MzAsMTMgKzYzMCwxMyBAQCBib29sIFJlbmRlckdyaWQ6OnRyYWNr c0FyZVdpZGVyVGhhbk1pblRyYWNrQnJlYWR0aChHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGly ZQogdm9pZCBSZW5kZXJHcmlkOjpncm93R3JpZChHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGly ZWN0aW9uKQogewogICAgIGlmIChkaXJlY3Rpb24gPT0gRm9yQ29sdW1ucykgewotICAgICAgICBj b25zdCBzaXplX3Qgb2xkQ29sdW1uU2l6ZSA9IG1fZ3JpZFswXS5zaXplKCk7Ci0gICAgICAgIGZv ciAoc2l6ZV90IHJvdyA9IDA7IHJvdyA8IG1fZ3JpZC5zaXplKCk7ICsrcm93KQorICAgICAgICBj b25zdCBzaXplX3Qgb2xkQ29sdW1uU2l6ZSA9IGdyaWRDb2x1bW5Db3VudCgpOworICAgICAgICBm b3IgKHNpemVfdCByb3cgPSAwOyByb3cgPCBncmlkUm93Q291bnQoKTsgKytyb3cpCiAgICAgICAg ICAgICBtX2dyaWRbcm93XS5ncm93KG9sZENvbHVtblNpemUgKyAxKTsKICAgICB9IGVsc2Ugewot ICAgICAgICBjb25zdCBzaXplX3Qgb2xkUm93U2l6ZSA9IG1fZ3JpZC5zaXplKCk7CisgICAgICAg IGNvbnN0IHNpemVfdCBvbGRSb3dTaXplID0gZ3JpZFJvd0NvdW50KCk7CiAgICAgICAgIG1fZ3Jp ZC5ncm93KG9sZFJvd1NpemUgKyAxKTsKLSAgICAgICAgbV9ncmlkW29sZFJvd1NpemVdLmdyb3co bV9ncmlkWzBdLnNpemUoKSk7CisgICAgICAgIG1fZ3JpZFtvbGRSb3dTaXplXS5ncm93KGdyaWRD b2x1bW5Db3VudCgpKTsKICAgICB9CiB9CiAKQEAgLTc3Niw4ICs3NzYsOCBAQCB2b2lkIFJlbmRl ckdyaWQ6OnBsYWNlQXV0b01ham9yQXhpc0l0ZW1PbkdyaWQoUmVuZGVyQm94KiBncmlkSXRlbSkK ICAgICB9CiAKICAgICAvLyBXZSBkaWRuJ3QgZmluZCBhbiBlbXB0eSBncmlkIGFyZWEgc28gd2Ug bmVlZCB0byBjcmVhdGUgYW4gZXh0cmEgbWFqb3IgYXhpcyBsaW5lIGFuZCBpbnNlcnQgb3VyIGdy aWRJdGVtIGluIGl0LgotICAgIGNvbnN0IHNpemVfdCBjb2x1bW5JbmRleCA9IChhdXRvUGxhY2Vt ZW50TWFqb3JBeGlzRGlyZWN0aW9uKCkgPT0gRm9yQ29sdW1ucykgPyBtX2dyaWRbMF0uc2l6ZSgp IDogbWlub3JBeGlzSW5kZXg7Ci0gICAgY29uc3Qgc2l6ZV90IHJvd0luZGV4ID0gKGF1dG9QbGFj ZW1lbnRNYWpvckF4aXNEaXJlY3Rpb24oKSA9PSBGb3JDb2x1bW5zKSA/IG1pbm9yQXhpc0luZGV4 IDogbV9ncmlkLnNpemUoKTsKKyAgICBjb25zdCBzaXplX3QgY29sdW1uSW5kZXggPSAoYXV0b1Bs YWNlbWVudE1ham9yQXhpc0RpcmVjdGlvbigpID09IEZvckNvbHVtbnMpID8gZ3JpZENvbHVtbkNv dW50KCkgOiBtaW5vckF4aXNJbmRleDsKKyAgICBjb25zdCBzaXplX3Qgcm93SW5kZXggPSAoYXV0 b1BsYWNlbWVudE1ham9yQXhpc0RpcmVjdGlvbigpID09IEZvckNvbHVtbnMpID8gbWlub3JBeGlz SW5kZXggOiBncmlkUm93Q291bnQoKTsKICAgICBncm93R3JpZChhdXRvUGxhY2VtZW50TWFqb3JB eGlzRGlyZWN0aW9uKCkpOwogICAgIGluc2VydEl0ZW1JbnRvR3JpZChncmlkSXRlbSwgcm93SW5k ZXgsIGNvbHVtbkluZGV4KTsKIH0K