133199 2014-05-22 19:44:28 -0700 reset m_havePreparedToPlay when changing media engines. 2014-05-23 11:02:47 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 jeremyj-wk jeremyj-wk calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj sergio oldest_to_newest 1011123 0 jeremyj-wk 2014-05-22 19:44:28 -0700 reset m_havePreparedToPlay when changing media engines. 1011125 1 231932 jeremyj-wk 2014-05-22 19:49:21 -0700 Created attachment 231932 Patch 1011126 2 jeremyj-wk 2014-05-22 19:51:12 -0700 Is it better to reset this property or to call prepare() on the newly created player? 1011127 3 jeremyj-wk 2014-05-22 19:51:57 -0700 radar://16755602 1011300 4 231932 commit-queue 2014-05-23 11:02:42 -0700 Comment on attachment 231932 Patch Clearing flags on attachment: 231932 Committed r169264: <http://trac.webkit.org/changeset/169264> 1011301 5 commit-queue 2014-05-23 11:02:47 -0700 All reviewed patches have been landed. Closing bug. 231932 2014-05-22 19:49:21 -0700 2014-05-23 11:02:42 -0700 Patch bug-133199-20140522194857.patch text/plain 1479 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZjNmZhOTBmYTM5MzFi YzllYTQ0NDJlOGJmN2I4YjU5NDhkY2VlNy4uMDgyNTAwYjI1OThmMWVmZDFjODY2YjU0NzQ5Zjdj NjI4YmE0MzUzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTIyICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICByZXNldCBtX2hhdmVQcmVw YXJlZFRvUGxheSB3aGVuIGNoYW5naW5nIG1lZGlhIGVuZ2luZXMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMxOTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIHBsYXkgcmVxdWVzdCBjb21lcyBp biBiZWZvcmUgdGhlIG1lZGlhIHBsYXllciBpcyBjcmVhdGVkLCBtX2hhdmVQcmVwYXJlZFRvUGxh eQorICAgICAgICBpcyBzZXQgdG8gdHJ1ZS4gQnV0IHdoZW4gdGhlIHBsYXllciBpcyBjcmVhdGVk LCB0aGlzIHByZXZlbnRzIHRoZSBuZXcgcGxheWVyIGZyb20KKyAgICAgICAgZ2V0dGluZyB0aGUg cHJlcGFyZSBjYWxsLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlhUGxheWVyRW5naW5lVXBkYXRl ZCk6IHNldCBtX2hhdmVQcmVwYXJlZFRvUGxheSBmYWxzZS4KKwogMjAxNC0wNS0yMiAgSmVyIE5v YmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTVNFXSBTdG9yZWQgc2FtcGxl cyBhcmUgbm90IGZyZWVkIHdoZW4gU291cmNlQnVmZmVyIGlzIHJlbW92ZWQgZnJvbSBNZWRpYVNv dXJjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggOTJjMzdi Y2YwYzA4NGIxNDI5YjRlMDNiMTVmMDkwNGM4NDlmNDA3ZC4uM2M1ZjQwYTZiYjFjMjYzOWMzNTRm ZjY3MjNhODA4YmI2ZWRmODIwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCkBAIC00MjMxLDYgKzQyMzEsOCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlh UGxheWVyRW5naW5lVXBkYXRlZChNZWRpYVBsYXllciopCiAgICAgbV9kcm9wcGVkVmlkZW9GcmFt ZXMgPSAwOwogI2VuZGlmCiAKKyAgICBtX2hhdmVQcmVwYXJlZFRvUGxheSA9IGZhbHNlOworCiAj aWYgUExBVEZPUk0oSU9TKQogICAgIGlmICghbV9wbGF5ZXIpCiAgICAgICAgIHJldHVybjsK