133193 2014-05-22 17:01:59 -0700 Potential null dereference in WebFrameLoaderClient::dispatchDidFailProvisionalLoad() 2014-05-27 14:00:57 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jhoneycutt jhoneycutt aestes ap beidson commit-queue ddkilzer webkit-bug-importer oldest_to_newest 1011083 0 jhoneycutt 2014-05-22 17:01:59 -0700 WebFrameLoaderClient::dispatchDidFailProvisionalLoad() calls the InjectedBundleLoaderClient's didFailProvisionalLoadWithErrorForFrame() before sending a message to the UI process that a provisional load has failed. It's possible for the provisional document loader to become null while calling into the InjectedBundleLoaderClient (as is the case with the WebKitTestRunner's injected bundle), leading to a null dereference when trying to send the DidFailProvisionalLoadForFrame message. 1011084 1 231921 jhoneycutt 2014-05-22 17:07:02 -0700 Created attachment 231921 Patch 1011257 2 231921 beidson 2014-05-23 09:43:05 -0700 Comment on attachment 231921 Patch Any way to API test this? 1011435 3 jhoneycutt 2014-05-23 17:34:05 -0700 (In reply to comment #2) > (From update of attachment 231921 [details]) > Any way to API test this? Yes, I think so. I'm working on that now. 1011553 4 231921 commit-queue 2014-05-24 20:31:26 -0700 Comment on attachment 231921 Patch Clearing flags on attachment: 231921 Committed r169315: <http://trac.webkit.org/changeset/169315> 1011554 5 commit-queue 2014-05-24 20:31:29 -0700 All reviewed patches have been landed. Closing bug. 1012061 6 webkit-bug-importer 2014-05-27 14:00:52 -0700 <rdar://problem/17042850> 231921 2014-05-22 17:07:02 -0700 2014-05-24 20:31:26 -0700 Patch 0002-Potential-null-dereference-in.patch text/plain 4129 jhoneycutt RnJvbSAwZDIxMmU1NzgyODNmMDhjZDRiMTYyOWUwNDZhMjE0ZTdiNjdjMGQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogVGh1LCAyMiBNYXkgMjAxNCAxNzowNToyNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMi8y XSBQb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZSBpbgogV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRp c3BhdGNoRGlkRmFpbFByb3Zpc2lvbmFsTG9hZCgpCiA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzMzE5Mz4KCldlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERp ZEZhaWxQcm92aXNpb25hbExvYWQoKSBjYWxscyB0aGUKSW5qZWN0ZWRCdW5kbGVMb2FkZXJDbGll bnQncyBkaWRGYWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yRm9yRnJhbWUoKQpiZWZvcmUgc2Vu ZGluZyBhIG1lc3NhZ2UgdG8gdGhlIFVJIHByb2Nlc3MgdGhhdCBhIHByb3Zpc2lvbmFsIGxvYWQg aGFzCmZhaWxlZC4gSXQncyBwb3NzaWJsZSBmb3IgdGhlIHByb3Zpc2lvbmFsIGRvY3VtZW50IGxv YWRlciB0byBiZWNvbWUKbnVsbCB3aGlsZSBjYWxsaW5nIGludG8gdGhlIEluamVjdGVkQnVuZGxl TG9hZGVyQ2xpZW50IChhcyBpcyB0aGUgY2FzZQp3aXRoIHRoZSBXZWJLaXRUZXN0UnVubmVyJ3Mg aW5qZWN0ZWQgYnVuZGxlKSwgbGVhZGluZyB0byBhIG51bGwKZGVyZWZlcmVuY2Ugd2hlbiB0cnlp bmcgdG8gc2VuZCB0aGUgRGlkRmFpbFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lCm1lc3NhZ2UuCgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CihXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50Ojpk aXNwYXRjaERpZEZhaWxQcm92aXNpb25hbExvYWQpOgpHZXQgdGhlIG5hdmlnYXRpb24gSUQgYmVm b3JlIGNhbGxpbmcgaW50byB0aGUgaW5qZWN0ZWQgYnVuZGxlLgotLS0KIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDIxICsrKysrKysrKysrKysr KysrKysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcCAgICAg ICAgIHwgIDcgKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkYzFjMDMxLi42ZjRlYWJhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTQtMDUtMjIgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFw cGxlLmNvbT4KKworICAgICAgICBQb3RlbnRpYWwgbnVsbCBkZXJlZmVyZW5jZSBpbgorICAgICAg ICBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGYWlsUHJvdmlzaW9uYWxMb2FkKCkK KyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMxOTM+ CisKKyAgICAgICAgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNoRGlkRmFpbFByb3Zpc2lv bmFsTG9hZCgpIGNhbGxzIHRoZQorICAgICAgICBJbmplY3RlZEJ1bmRsZUxvYWRlckNsaWVudCdz IGRpZEZhaWxQcm92aXNpb25hbExvYWRXaXRoRXJyb3JGb3JGcmFtZSgpCisgICAgICAgIGJlZm9y ZSBzZW5kaW5nIGEgbWVzc2FnZSB0byB0aGUgVUkgcHJvY2VzcyB0aGF0IGEgcHJvdmlzaW9uYWwg bG9hZCBoYXMKKyAgICAgICAgZmFpbGVkLiBJdCdzIHBvc3NpYmxlIGZvciB0aGUgcHJvdmlzaW9u YWwgZG9jdW1lbnQgbG9hZGVyIHRvIGJlY29tZQorICAgICAgICBudWxsIHdoaWxlIGNhbGxpbmcg aW50byB0aGUgSW5qZWN0ZWRCdW5kbGVMb2FkZXJDbGllbnQgKGFzIGlzIHRoZSBjYXNlCisgICAg ICAgIHdpdGggdGhlIFdlYktpdFRlc3RSdW5uZXIncyBpbmplY3RlZCBidW5kbGUpLCBsZWFkaW5n IHRvIGEgbnVsbAorICAgICAgICBkZXJlZmVyZW5jZSB3aGVuIHRyeWluZyB0byBzZW5kIHRoZSBE aWRGYWlsUHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUKKyAgICAgICAgbWVzc2FnZS4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEaWRGYWlsUHJvdmlzaW9uYWxMb2FkKToKKyAg ICAgICAgR2V0IHRoZSBuYXZpZ2F0aW9uIElEIGJlZm9yZSBjYWxsaW5nIGludG8gdGhlIGluamVj dGVkIGJ1bmRsZS4KKwogMjAxNC0wNS0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTY4NjI1KTogW0dUS10gQXNzZXJ0 aW9uIGZhaWx1cmUgaW4gTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xp ZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJh bWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IDFiZjEzM2EuLjM2NWIxMjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGll bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC00NTksMTUgKzQ1OSwxNiBAQCB2b2lkIFdlYkZyYW1l TG9hZGVyQ2xpZW50OjpkaXNwYXRjaERpZEZhaWxQcm92aXNpb25hbExvYWQoY29uc3QgUmVzb3Vy Y2VFcnJvciYgZQogCiAgICAgUmVmUHRyPEFQSTo6T2JqZWN0PiB1c2VyRGF0YTsKIAorICAgIHVp bnQ2NF90IG5hdmlnYXRpb25JRCA9IHN0YXRpY19jYXN0PFdlYkRvY3VtZW50TG9hZGVyKj4obV9m cmFtZS0+Y29yZUZyYW1lKCktPmxvYWRlcigpLnByb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIoKSkt Pm5hdmlnYXRpb25JRCgpOworCiAgICAgLy8gTm90aWZ5IHRoZSBidW5kbGUgY2xpZW50LgogICAg IHdlYlBhZ2UtPmluamVjdGVkQnVuZGxlTG9hZGVyQ2xpZW50KCkuZGlkRmFpbFByb3Zpc2lvbmFs TG9hZFdpdGhFcnJvckZvckZyYW1lKHdlYlBhZ2UsIG1fZnJhbWUsIGVycm9yLCB1c2VyRGF0YSk7 CiAKICAgICB3ZWJQYWdlLT5zYW5kYm94RXh0ZW5zaW9uVHJhY2tlcigpLmRpZEZhaWxQcm92aXNp b25hbExvYWQobV9mcmFtZSk7CiAKICAgICAvLyBOb3RpZnkgdGhlIFVJUHJvY2Vzcy4KLSAgICBX ZWJEb2N1bWVudExvYWRlciYgcHJvdmlzaW9uYWxMb2FkZXIgPSBzdGF0aWNfY2FzdDxXZWJEb2N1 bWVudExvYWRlciY+KCptX2ZyYW1lLT5jb3JlRnJhbWUoKS0+bG9hZGVyKCkucHJvdmlzaW9uYWxE b2N1bWVudExvYWRlcigpKTsKLSAgICB3ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJv eHk6OkRpZEZhaWxQcm92aXNpb25hbExvYWRGb3JGcmFtZShtX2ZyYW1lLT5mcmFtZUlEKCksIHBy b3Zpc2lvbmFsTG9hZGVyLm5hdmlnYXRpb25JRCgpLCBlcnJvciwgSW5qZWN0ZWRCdW5kbGVVc2Vy TWVzc2FnZUVuY29kZXIodXNlckRhdGEuZ2V0KCkpKSk7Ci0gICAgCisgICAgd2ViUGFnZS0+c2Vu ZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWRGYWlsUHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUo bV9mcmFtZS0+ZnJhbWVJRCgpLCBuYXZpZ2F0aW9uSUQsIGVycm9yLCBJbmplY3RlZEJ1bmRsZVVz ZXJNZXNzYWdlRW5jb2Rlcih1c2VyRGF0YS5nZXQoKSkpKTsKKwogICAgIC8vIElmIHdlIGhhdmUg YSBsb2FkIGxpc3RlbmVyLCBub3RpZnkgaXQuCiAgICAgaWYgKFdlYkZyYW1lOjpMb2FkTGlzdGVu ZXIqIGxvYWRMaXN0ZW5lciA9IG1fZnJhbWUtPmxvYWRMaXN0ZW5lcigpKQogICAgICAgICBsb2Fk TGlzdGVuZXItPmRpZEZhaWxMb2FkKG1fZnJhbWUsIGVycm9yLmlzQ2FuY2VsbGF0aW9uKCkpOwot LSAKMS45LjIgKEFwcGxlIEdpdC00OSkKCg==