133183 2014-05-22 10:02:43 -0700 REGRESSION (WebKit2): Keyboard should have Search button in duckduckgo.com 2014-05-22 11:04:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica oldest_to_newest 1011002 0 enrica 2014-05-22 10:02:43 -0700 Open Safari and navigate to duckduckgo.com. Tap on the input field. The keyboard has the Go button instead of Search. 1011003 1 enrica 2014-05-22 10:04:22 -0700 <rdar://problem/17004207> 1011008 2 231894 enrica 2014-05-22 10:17:13 -0700 Created attachment 231894 Patch 1011011 3 231894 ggaren 2014-05-22 10:38:24 -0700 Comment on attachment 231894 Patch r=me Might be nice to share this code in a helper function, if it matches WK1. 1011012 4 231894 kling 2014-05-22 10:44:35 -0700 Comment on attachment 231894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231894&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1860 > + if (element->getAttribute("pattern") == "\\d*" || element->getAttribute("pattern") == "[0-9]*") This could be done slightly more efficiently: const AtomicString& pattern = element->fastGetAttribute(HTMLNames::patternAttr); if (pattern == "\\d*" || pattern == "[0-9]*") .... > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1865 > + && (element->getNameAttribute().contains("search") || element->getIdAttribute().contains("search") || element->fastGetAttribute(HTMLNames::titleAttr).string().contains("search"))) I think you can call .contains() directly on the return value from fastGetAttribute(). 1011015 5 enrica 2014-05-22 10:55:58 -0700 (In reply to comment #3) > (From update of attachment 231894 [details]) > r=me > > Might be nice to share this code in a helper function, if it matches WK1. Unfortunately the WK1 is in UIKit. 1011016 6 enrica 2014-05-22 10:56:21 -0700 (In reply to comment #4) > (From update of attachment 231894 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231894&action=review > > > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1860 > > + if (element->getAttribute("pattern") == "\\d*" || element->getAttribute("pattern") == "[0-9]*") > > This could be done slightly more efficiently: > > const AtomicString& pattern = element->fastGetAttribute(HTMLNames::patternAttr); > if (pattern == "\\d*" || pattern == "[0-9]*") > .... > > > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1865 > > + && (element->getNameAttribute().contains("search") || element->getIdAttribute().contains("search") || element->fastGetAttribute(HTMLNames::titleAttr).string().contains("search"))) > > I think you can call .contains() directly on the return value from fastGetAttribute(). Will do. thanks! 1011019 7 enrica 2014-05-22 11:04:34 -0700 Committed revision 169207. 231894 2014-05-22 10:17:13 -0700 2014-05-22 10:44:35 -0700 Patch showsearchkb.txt text/plain 2350 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTIwNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA1LTIyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAoV2ViS2l0 Mik6IEtleWJvYXJkIHNob3VsZCBoYXZlIFNlYXJjaCBidXR0b24gaW4gZHVja2R1Y2tnby5jb20u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMxODMK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3MDA0MjA3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBrZXlib2FyZCB0eXBlIHNob3VsZCBiZSBz ZWFyY2ggaWYgdGhlIGlucHV0IHR5cGUgaXMgc2VhcmNoCisgICAgICAgIG9yIGlmIGl0IGlzIHRl eHQgYW5kIGl0IGlzIGluc2lkZSBhIGZvcm0gd2l0aCBhbiBhY3Rpb24gYW5kIGVpdGhlcgorICAg ICAgICBuYW1lLCBpZCBvciB0aXRsZSBjb250YWluIHRoZSB3b3JkIHNlYXJjaC4gVGhpcyBtYXRj aGVzIHRoZQorICAgICAgICBoZXVyaXN0aWNzIHdlIGhhdmUgaW4gV0sxIGZvciBpT1MuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2U6OmdldEFzc2lzdGVkTm9kZUluZm9ybWF0aW9uKToKKwogMjAxNC0wNS0y MSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE9ubHkgZW5hYmxl IHNhbmRib3ggZXh0ZW5zaW9ucyBvbiBtYWMuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCShyZXZpc2lvbiAxNjkyMDMp CisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0J KHdvcmtpbmcgY29weSkKQEAgLTE4NTYsOCArMTg1NiwxNiBAQCB2b2lkIFdlYlBhZ2U6OmdldEFz c2lzdGVkTm9kZUluZm9ybWF0aW9uCiAgICAgICAgICAgICBpbmZvcm1hdGlvbi5lbGVtZW50VHlw ZSA9IFdLVHlwZU1vbnRoOwogICAgICAgICBlbHNlIGlmIChlbGVtZW50LT5pc1VSTEZpZWxkKCkp CiAgICAgICAgICAgICBpbmZvcm1hdGlvbi5lbGVtZW50VHlwZSA9IFdLVHlwZVVSTDsKLSAgICAg ICAgZWxzZSBpZiAoZWxlbWVudC0+aXNUZXh0KCkpCi0gICAgICAgICAgICBpbmZvcm1hdGlvbi5l bGVtZW50VHlwZSA9IGVsZW1lbnQtPmdldEF0dHJpYnV0ZSgicGF0dGVybiIpID09ICJcXGQqIiB8 fCBlbGVtZW50LT5nZXRBdHRyaWJ1dGUoInBhdHRlcm4iKSA9PSAiWzAtOV0qIiA/IFdLVHlwZU51 bWJlclBhZCA6IFdLVHlwZVRleHQ7CisgICAgICAgIGVsc2UgaWYgKGVsZW1lbnQtPmlzVGV4dCgp KSB7CisgICAgICAgICAgICBpZiAoZWxlbWVudC0+Z2V0QXR0cmlidXRlKCJwYXR0ZXJuIikgPT0g IlxcZCoiIHx8IGVsZW1lbnQtPmdldEF0dHJpYnV0ZSgicGF0dGVybiIpID09ICJbMC05XSoiKQor ICAgICAgICAgICAgICAgIGluZm9ybWF0aW9uLmVsZW1lbnRUeXBlID0gV0tUeXBlTnVtYmVyUGFk OworICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICAgICAgaW5mb3JtYXRpb24uZWxlbWVu dFR5cGUgPSBXS1R5cGVUZXh0OworICAgICAgICAgICAgICAgIGlmICghaW5mb3JtYXRpb24uZm9y bUFjdGlvbi5pc0VtcHR5KCkKKyAgICAgICAgICAgICAgICAgICAgJiYgKGVsZW1lbnQtPmdldE5h bWVBdHRyaWJ1dGUoKS5jb250YWlucygic2VhcmNoIikgfHwgZWxlbWVudC0+Z2V0SWRBdHRyaWJ1 dGUoKS5jb250YWlucygic2VhcmNoIikgfHwgZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShIVE1M TmFtZXM6OnRpdGxlQXR0cikuc3RyaW5nKCkuY29udGFpbnMoInNlYXJjaCIpKSkKKyAgICAgICAg ICAgICAgICAgICAgaW5mb3JtYXRpb24uZWxlbWVudFR5cGUgPSBXS1R5cGVTZWFyY2g7CisgICAg ICAgICAgICB9CisgICAgICAgIH0KIAogICAgICAgICBpbmZvcm1hdGlvbi5pc1JlYWRPbmx5ID0g ZWxlbWVudC0+aXNSZWFkT25seSgpOwogICAgICAgICBpbmZvcm1hdGlvbi52YWx1ZSA9IGVsZW1l bnQtPnZhbHVlKCk7Cg==