133176 2014-05-22 05:31:31 -0700 W3C test importer should catch exceptions coming from HTML/CSS conversion 2014-05-26 23:48:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf clopez commit-queue glenn oldest_to_newest 1010950 0 youennf 2014-05-22 05:31:31 -0700 Test case W3C test html/semantics/forms/the-input-element/radio-groupname-case.html breaks W3C test importer. An exception is raised within python 2.7 HTMLParser. This stops the conversion process. It may be better to catch the exception, log it and continue importing the remaining tests. 1010951 1 231877 youennf 2014-05-22 05:43:07 -0700 Created attachment 231877 Patch 1010953 2 commit-queue 2014-05-22 05:45:53 -0700 Attachment 231877 did not pass style-queue: ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:346: trailing whitespace [pep8/W291] [5] ERROR: Tools/Scripts/webkitpy/w3c/test_importer.py:350: multiple statements on one line (semicolon) [pep8/E702] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1010956 3 231880 youennf 2014-05-22 06:01:04 -0700 Created attachment 231880 Patch 1011769 4 231880 commit-queue 2014-05-26 09:11:46 -0700 Comment on attachment 231880 Patch Clearing flags on attachment: 231880 Committed r169347: <http://trac.webkit.org/changeset/169347> 1011770 5 commit-queue 2014-05-26 09:11:51 -0700 All reviewed patches have been landed. Closing bug. 1011843 6 clopez 2014-05-26 16:15:15 -0700 (In reply to comment #3) > Created an attachment (id=231880) [details] > Patch (In reply to comment #4) > (From update of attachment 231880 [details]) > Clearing flags on attachment: 231880 > > Committed r169347: <http://trac.webkit.org/changeset/169347> This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279 1011896 7 youennf 2014-05-26 23:48:21 -0700 (In reply to comment #6) > (In reply to comment #3) > > Created an attachment (id=231880) [details] [details] > > Patch > > (In reply to comment #4) > > (From update of attachment 231880 [details] [details]) > > Clearing flags on attachment: 231880 > > > > Committed r169347: <http://trac.webkit.org/changeset/169347> > > > This broke the webkitpy tests on all platforms: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/6279 Gyuyoung fixed it at http://trac.webkit.org/changeset/169369 231877 2014-05-22 05:43:07 -0700 2014-05-22 06:00:56 -0700 Patch bug-133176-20140522144243.patch text/plain 3219 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWExY2VmOWI2NzA1YjZjYzRjZjA2ODVhMzllZDgwMmVh MWVlZWFjMC4uZDYwNmRjZDg2OGNhNmZlZjk0NjE5Yzk0ZTEwZjFlYmU4YjRiYzgyOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTA1LTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIGNhdGNoIGV4Y2VwdGlvbnMg Y29taW5nIGZyb20gSFRNTC9DU1MgY29udmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRXhjZXB0aW9ucyByYWlzZWQgd2hlbiBjb252ZXJ0aW5n IEhUTUwvQ1NTIGFyZSBjYXVnaHQuCisgICAgICAgIEZpbGVzIGZvciB3aGljaCBjb252ZXJzaW9u IGZhaWxlZCBhcmUgc3RpbGwgY29waWVkIHRvIHRoZSB0YXJnZXQgZGlyZWN0b3J5LgorICAgICAg ICBFYWNoIGluZGl2aWR1YWwgY29udmVyc2lvbiBmYWlsdXJlIGlzIGxvZ2dlZC4KKyAgICAgICAg VG90YWwgY29udmVyc2lvbiBmYWlsdXJlIG51bWJlciBpcyBsb2dnZWQgYXQgdGhlIGVuZCBvZiB0 aGUgaW1wb3J0IHByb2Nlc3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0 X2ltcG9ydGVyLnB5OgorICAgICAgICAoVGVzdEltcG9ydGVyLmltcG9ydF90ZXN0cyk6CisKIDIw MTQtMDUtMTkgIEV2YSBCYWxhenNmYWx2aSAgPGV2YWIudS1zemVnZWRAcGFydG5lci5zYW1zdW5n LmNvbT4KIAogICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgc2hvdWxkIHNvcnQgdGhl IGxpc3Qgb2YgZmFpbGluZyBzdHJlc3MgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3cz Yy90ZXN0X2ltcG9ydGVyLnB5CmluZGV4IDY2OGEwMWJhY2E3YWQyZTVlODViNGJmMWY4ZjQ5ZDIy MDQxOTI2NjIuLjc0YmMyZmFmZjVhZDNlZDUxMDU4Mjk5MWFjMTdiYjVmYTY3Yzg2ZjYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtMzEwLDYgKzMx MCw3IEBAIGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICAgICAgICAgIG9zLm1h a2VkaXJzKG5ld19wYXRoKQogCiAgICAgICAgICAgICBjb3BpZWRfZmlsZXMgPSBbXQorICAgICAg ICAgICAgZmFpbGVkX2NvbnZlcnNpb25fZmlsZXMgPSBbXQogCiAgICAgICAgICAgICBmb3IgZmls ZV90b19jb3B5IGluIGRpcl90b19jb3B5Wydjb3B5X2xpc3QnXToKICAgICAgICAgICAgICAgICAj IEZJWE1FOiBTcGxpdCB0aGlzIGJsb2NrIGludG8gYSBzZXBhcmF0ZSBmdW5jdGlvbi4KQEAgLTM0 Miw3ICszNDMsMTEgQEAgY2xhc3MgVGVzdEltcG9ydGVyKG9iamVjdCk6CiAgICAgICAgICAgICAg ICAgIyBGSVhNRTogRXZlbnR1YWxseSwgc28gc2hvdWxkIGpzIHdoZW4gc3VwcG9ydCBpcyBhZGRl ZCBmb3IgdGhpcyB0eXBlIG9mIGNvbnZlcnNpb24KICAgICAgICAgICAgICAgICBtaW1ldHlwZSA9 IG1pbWV0eXBlcy5ndWVzc190eXBlKG9yaWdfZmlsZXBhdGgpCiAgICAgICAgICAgICAgICAgaWYg J2h0bWwnIGluIHN0cihtaW1ldHlwZVswXSkgb3IgJ3htbCcgaW4gc3RyKG1pbWV0eXBlWzBdKSAg b3IgJ2NzcycgaW4gc3RyKG1pbWV0eXBlWzBdKToKLSAgICAgICAgICAgICAgICAgICAgY29udmVy dGVkX2ZpbGUgPSBjb252ZXJ0X2Zvcl93ZWJraXQobmV3X3BhdGgsIGZpbGVuYW1lPW9yaWdfZmls ZXBhdGgpCisgICAgICAgICAgICAgICAgICAgIHRyeTogCisgICAgICAgICAgICAgICAgICAgICAg ICBjb252ZXJ0ZWRfZmlsZSA9IGNvbnZlcnRfZm9yX3dlYmtpdChuZXdfcGF0aCwgZmlsZW5hbWU9 b3JpZ19maWxlcGF0aCkKKyAgICAgICAgICAgICAgICAgICAgZXhjZXB0OgorICAgICAgICAgICAg ICAgICAgICAgICAgX2xvZy53YXJuKCdGYWlsZWQgY29udmVydGluZyAlcycsIG9yaWdfZmlsZXBh dGgpCisgICAgICAgICAgICAgICAgICAgICAgICBmYWlsZWRfY29udmVyc2lvbl9maWxlcy5hcHBl bmQob3JpZ19maWxlcGF0aCk7CiAKICAgICAgICAgICAgICAgICAgICAgaWYgbm90IGNvbnZlcnRl ZF9maWxlOgogICAgICAgICAgICAgICAgICAgICAgICAgc2h1dGlsLmNvcHlmaWxlKG9yaWdfZmls ZXBhdGgsIG5ld19maWxlcGF0aCkgICMgVGhlIGZpbGUgd2FzIHVubW9kaWZpZWQuCkBAIC0zNjks OCArMzc0LDExIEBAIGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICBfbG9nLmlu Zm8oJ0ltcG9ydGVkICVkIHJlZnRlc3RzJywgdG90YWxfaW1wb3J0ZWRfcmVmdGVzdHMpCiAgICAg ICAgIF9sb2cuaW5mbygnSW1wb3J0ZWQgJWQgSlMgdGVzdHMnLCB0b3RhbF9pbXBvcnRlZF9qc3Rl c3RzKQogICAgICAgICBfbG9nLmluZm8oJ0ltcG9ydGVkICVkIHBpeGVsL21hbnVhbCB0ZXN0cycs IHRvdGFsX2ltcG9ydGVkX3Rlc3RzIC0gdG90YWxfaW1wb3J0ZWRfanN0ZXN0cyAtIHRvdGFsX2lt cG9ydGVkX3JlZnRlc3RzKQorICAgICAgICBpZiBsZW4oZmFpbGVkX2NvbnZlcnNpb25fZmlsZXMp OgorICAgICAgICAgICAgX2xvZy53YXJuKCdGYWlsZWQgY29udmVydGluZyAlZCBmaWxlcyAoZmls ZXMgY29waWVkIHdpdGhvdXQgYmVpbmcgY29udmVydGVkKScsIGxlbihmYWlsZWRfY29udmVyc2lv bl9maWxlcykpCiAgICAgICAgIF9sb2cuaW5mbygnJykKICAgICAgICAgX2xvZy5pbmZvKCdQcm9w ZXJ0aWVzIG5lZWRpbmcgcHJlZml4ZXMgKGJ5IGNvdW50KTonKQorCiAgICAgICAgIGZvciBwcmVm aXhlZF9wcm9wZXJ0eSBpbiBzb3J0ZWQodG90YWxfcHJlZml4ZWRfcHJvcGVydGllcywga2V5PWxh bWJkYSBwOiB0b3RhbF9wcmVmaXhlZF9wcm9wZXJ0aWVzW3BdKToKICAgICAgICAgICAgIF9sb2cu aW5mbygnICAlczogJXMnLCBwcmVmaXhlZF9wcm9wZXJ0eSwgdG90YWxfcHJlZml4ZWRfcHJvcGVy dGllc1twcmVmaXhlZF9wcm9wZXJ0eV0pCiAK 231880 2014-05-22 06:01:04 -0700 2014-05-26 09:11:46 -0700 Patch bug-133176-20140421175940.patch text/plain 3217 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWExY2VmOWI2NzA1YjZjYzRjZjA2ODVhMzllZDgwMmVh MWVlZWFjMC4uZDYwNmRjZDg2OGNhNmZlZjk0NjE5Yzk0ZTEwZjFlYmU4YjRiYzgyOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTA1LTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24u ZnI+CisKKyAgICAgICAgVzNDIHRlc3QgaW1wb3J0ZXIgc2hvdWxkIGNhdGNoIGV4Y2VwdGlvbnMg Y29taW5nIGZyb20gSFRNTC9DU1MgY29udmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRXhjZXB0aW9ucyByYWlzZWQgd2hlbiBjb252ZXJ0aW5n IEhUTUwvQ1NTIGFyZSBjYXVnaHQuCisgICAgICAgIEZpbGVzIGZvciB3aGljaCBjb252ZXJzaW9u IGZhaWxlZCBhcmUgc3RpbGwgY29waWVkIHRvIHRoZSB0YXJnZXQgZGlyZWN0b3J5LgorICAgICAg ICBFYWNoIGluZGl2aWR1YWwgY29udmVyc2lvbiBmYWlsdXJlIGlzIGxvZ2dlZC4KKyAgICAgICAg VG90YWwgY29udmVyc2lvbiBmYWlsdXJlIG51bWJlciBpcyBsb2dnZWQgYXQgdGhlIGVuZCBvZiB0 aGUgaW1wb3J0IHByb2Nlc3MuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0 X2ltcG9ydGVyLnB5OgorICAgICAgICAoVGVzdEltcG9ydGVyLmltcG9ydF90ZXN0cyk6CisKIDIw MTQtMDUtMTkgIEV2YSBCYWxhenNmYWx2aSAgPGV2YWIudS1zemVnZWRAcGFydG5lci5zYW1zdW5n LmNvbT4KIAogICAgICAgICBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgc2hvdWxkIHNvcnQgdGhl IGxpc3Qgb2YgZmFpbGluZyBzdHJlc3MgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3cz Yy90ZXN0X2ltcG9ydGVyLnB5CmluZGV4IDY2OGEwMWJhY2E3YWQyZTVlODViNGJmMWY4ZjQ5ZDIy MDQxOTI2NjIuLjFlMzgzYTllZDQyNjI5OTdmYWVkYmU5MWYxMWJlZWI1MTMyOWIzYWQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXIucHkKKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9pbXBvcnRlci5weQpAQCAtMzEwLDYgKzMx MCw3IEBAIGNsYXNzIFRlc3RJbXBvcnRlcihvYmplY3QpOgogICAgICAgICAgICAgICAgIG9zLm1h a2VkaXJzKG5ld19wYXRoKQogCiAgICAgICAgICAgICBjb3BpZWRfZmlsZXMgPSBbXQorICAgICAg ICAgICAgZmFpbGVkX2NvbnZlcnNpb25fZmlsZXMgPSBbXQogCiAgICAgICAgICAgICBmb3IgZmls ZV90b19jb3B5IGluIGRpcl90b19jb3B5Wydjb3B5X2xpc3QnXToKICAgICAgICAgICAgICAgICAj IEZJWE1FOiBTcGxpdCB0aGlzIGJsb2NrIGludG8gYSBzZXBhcmF0ZSBmdW5jdGlvbi4KQEAgLTM0 Miw3ICszNDMsMTEgQEAgY2xhc3MgVGVzdEltcG9ydGVyKG9iamVjdCk6CiAgICAgICAgICAgICAg ICAgIyBGSVhNRTogRXZlbnR1YWxseSwgc28gc2hvdWxkIGpzIHdoZW4gc3VwcG9ydCBpcyBhZGRl ZCBmb3IgdGhpcyB0eXBlIG9mIGNvbnZlcnNpb24KICAgICAgICAgICAgICAgICBtaW1ldHlwZSA9 IG1pbWV0eXBlcy5ndWVzc190eXBlKG9yaWdfZmlsZXBhdGgpCiAgICAgICAgICAgICAgICAgaWYg J2h0bWwnIGluIHN0cihtaW1ldHlwZVswXSkgb3IgJ3htbCcgaW4gc3RyKG1pbWV0eXBlWzBdKSAg b3IgJ2NzcycgaW4gc3RyKG1pbWV0eXBlWzBdKToKLSAgICAgICAgICAgICAgICAgICAgY29udmVy dGVkX2ZpbGUgPSBjb252ZXJ0X2Zvcl93ZWJraXQobmV3X3BhdGgsIGZpbGVuYW1lPW9yaWdfZmls ZXBhdGgpCisgICAgICAgICAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICAgICAgICAg IGNvbnZlcnRlZF9maWxlID0gY29udmVydF9mb3Jfd2Via2l0KG5ld19wYXRoLCBmaWxlbmFtZT1v cmlnX2ZpbGVwYXRoKQorICAgICAgICAgICAgICAgICAgICBleGNlcHQ6CisgICAgICAgICAgICAg ICAgICAgICAgICBfbG9nLndhcm4oJ0ZhaWxlZCBjb252ZXJ0aW5nICVzJywgb3JpZ19maWxlcGF0 aCkKKyAgICAgICAgICAgICAgICAgICAgICAgIGZhaWxlZF9jb252ZXJzaW9uX2ZpbGVzLmFwcGVu ZChvcmlnX2ZpbGVwYXRoKQogCiAgICAgICAgICAgICAgICAgICAgIGlmIG5vdCBjb252ZXJ0ZWRf ZmlsZToKICAgICAgICAgICAgICAgICAgICAgICAgIHNodXRpbC5jb3B5ZmlsZShvcmlnX2ZpbGVw YXRoLCBuZXdfZmlsZXBhdGgpICAjIFRoZSBmaWxlIHdhcyB1bm1vZGlmaWVkLgpAQCAtMzY5LDgg KzM3NCwxMSBAQCBjbGFzcyBUZXN0SW1wb3J0ZXIob2JqZWN0KToKICAgICAgICAgX2xvZy5pbmZv KCdJbXBvcnRlZCAlZCByZWZ0ZXN0cycsIHRvdGFsX2ltcG9ydGVkX3JlZnRlc3RzKQogICAgICAg ICBfbG9nLmluZm8oJ0ltcG9ydGVkICVkIEpTIHRlc3RzJywgdG90YWxfaW1wb3J0ZWRfanN0ZXN0 cykKICAgICAgICAgX2xvZy5pbmZvKCdJbXBvcnRlZCAlZCBwaXhlbC9tYW51YWwgdGVzdHMnLCB0 b3RhbF9pbXBvcnRlZF90ZXN0cyAtIHRvdGFsX2ltcG9ydGVkX2pzdGVzdHMgLSB0b3RhbF9pbXBv cnRlZF9yZWZ0ZXN0cykKKyAgICAgICAgaWYgbGVuKGZhaWxlZF9jb252ZXJzaW9uX2ZpbGVzKToK KyAgICAgICAgICAgIF9sb2cud2FybignRmFpbGVkIGNvbnZlcnRpbmcgJWQgZmlsZXMgKGZpbGVz IGNvcGllZCB3aXRob3V0IGJlaW5nIGNvbnZlcnRlZCknLCBsZW4oZmFpbGVkX2NvbnZlcnNpb25f ZmlsZXMpKQogICAgICAgICBfbG9nLmluZm8oJycpCiAgICAgICAgIF9sb2cuaW5mbygnUHJvcGVy dGllcyBuZWVkaW5nIHByZWZpeGVzIChieSBjb3VudCk6JykKKwogICAgICAgICBmb3IgcHJlZml4 ZWRfcHJvcGVydHkgaW4gc29ydGVkKHRvdGFsX3ByZWZpeGVkX3Byb3BlcnRpZXMsIGtleT1sYW1i ZGEgcDogdG90YWxfcHJlZml4ZWRfcHJvcGVydGllc1twXSk6CiAgICAgICAgICAgICBfbG9nLmlu Zm8oJyAgJXM6ICVzJywgcHJlZml4ZWRfcHJvcGVydHksIHRvdGFsX3ByZWZpeGVkX3Byb3BlcnRp ZXNbcHJlZml4ZWRfcHJvcGVydHldKQogCg==