133170 2014-05-21 22:38:50 -0700 [WebKit2-EFL] Fix code style check errors in EFL API tests 2014-06-04 02:45:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified VERIFIED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1010898 0 shiva.jm 2014-05-21 22:38:50 -0700 Found below errors, when run ./Tools/Scripts/check-webkit-style on Source/WebKit2/UIProcess/API/efl/. ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:48: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:49: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.h:44: There was more than one newline at the end of the file. [whitespace/ending_newline] [5] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:38: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:39: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:42: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:43: Omit int when using unsigned [runtime/unsigned] [1] 1011148 1 231937 shiva.jm 2014-05-22 21:10:52 -0700 Created attachment 231937 Patch Omit int when using unsigned modifier, as per coding style rules. 1011670 2 231937 gyuyoung.kim 2014-05-26 02:03:19 -0700 Comment on attachment 231937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231937&action=review LGTM > Source/WebKit2/ChangeLog:3 > + [EFL] [WK2] Fix code style check errors in EFL API tests nit: an necessary space between [EFL] and [WK2]. 1011873 3 232106 shiva.jm 2014-05-26 20:48:24 -0700 Created attachment 232106 Patch for landing 1011877 4 232106 commit-queue 2014-05-26 21:33:03 -0700 Comment on attachment 232106 Patch for landing Clearing flags on attachment: 232106 Committed r169366: <http://trac.webkit.org/changeset/169366> 1011878 5 commit-queue 2014-05-26 21:33:07 -0700 All reviewed patches have been landed. Closing bug. 1013275 6 shiva.jm 2014-06-04 02:45:45 -0700 Bug is fixed, tested in version 169584. 231937 2014-05-22 21:10:52 -0700 2014-05-26 20:48:13 -0700 Patch bug-133170.patch text/plain 2655 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTI0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTIyICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRml4 IGNvZGUgc3R5bGUgY2hlY2sgZXJyb3JzIGluIEVGTCBBUEkgdGVzdHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzE3MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9taXQgaW50IHdoZW4gdXNpbmcgdW5z aWduZWQgbW9kaWZpZXIsIGFzIHBlciBjb2Rpbmcgc3R5bGUgcnVsZXMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3Bw OgorICAgICAgICAoRVdLMlVuaXRUZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpTZXRVcCk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RF bnZpcm9ubWVudC5oOgorICAgICAgICAoRVdLMlVuaXRUZXN0OjpFV0syVW5pdFRlc3RFbnZpcm9u bWVudDo6ZGVmYXVsdFdpZHRoKToKKyAgICAgICAgKEVXSzJVbml0VGVzdDo6RVdLMlVuaXRUZXN0 RW52aXJvbm1lbnQ6OmRlZmF1bHRIZWlnaHQpOgorCiAyMDE0LTA1LTIyICBCZW5qYW1pbiBQb3Vs YWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdW1dLMl0gUmVzZXQgdGhl IHNwZWNpYWwgYWN0aW9uLXRhcmdldCBvZiBXS1N5bnRoZXRpY0NsaWNrVGFwR2VzdHVyZVJlY29n bml6ZXIgb24gZGVzdHJ1Y3Rpb24KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9F V0syVW5pdFRlc3RCYXNlLmNwcAkocmV2aXNpb24gMTY5MjQyKQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDUsOCArNDUsOCBAQCBFV0syVW5pdFRlc3RCYXNlOjpFV0sy VW5pdFRlc3RCYXNlKCkKIAogdm9pZCBFV0syVW5pdFRlc3RCYXNlOjpTZXRVcCgpCiB7Ci0gICAg dW5zaWduZWQgaW50IHdpZHRoID0gZW52aXJvbm1lbnQtPmRlZmF1bHRXaWR0aCgpOwotICAgIHVu c2lnbmVkIGludCBoZWlnaHQgPSBlbnZpcm9ubWVudC0+ZGVmYXVsdEhlaWdodCgpOworICAgIHVu c2lnbmVkIHdpZHRoID0gZW52aXJvbm1lbnQtPmRlZmF1bHRXaWR0aCgpOworICAgIHVuc2lnbmVk IGhlaWdodCA9IGVudmlyb25tZW50LT5kZWZhdWx0SGVpZ2h0KCk7CiAKICNpZiBkZWZpbmVkKEhB VkVfRUNPUkVfWCkKICAgICBjb25zdCBjaGFyKiBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VX SzJVbml0VGVzdEVudmlyb25tZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RFbnZpcm9ubWVu dC5oCShyZXZpc2lvbiAxNjkyNDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEVudmlyb25tZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTM1LDEyICszNSwxMiBAQCBwdWJsaWM6CiAgICAgQ1N0cmluZyBwYXRoRm9yUmVz b3VyY2UoY29uc3QgY2hhciogcmVzb3VyY2UpOwogICAgIENTdHJpbmcgcGF0aEZvclRoZW1lKGNv bnN0IGNoYXIqIHRoZW1lKTsKIAotICAgIHZpcnR1YWwgdW5zaWduZWQgaW50IGRlZmF1bHRXaWR0 aCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmYXVsdFdpZHRoOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25l ZCBpbnQgZGVmYXVsdEhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmYXVsdEhlaWdodDsgfQor ICAgIHZpcnR1YWwgdW5zaWduZWQgZGVmYXVsdFdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV9kZWZh dWx0V2lkdGg7IH0KKyAgICB2aXJ0dWFsIHVuc2lnbmVkIGRlZmF1bHRIZWlnaHQoKSBjb25zdCB7 IHJldHVybiBtX2RlZmF1bHRIZWlnaHQ7IH0KIAogcHJpdmF0ZToKLSAgICB1bnNpZ25lZCBpbnQg bV9kZWZhdWx0V2lkdGg7Ci0gICAgdW5zaWduZWQgaW50IG1fZGVmYXVsdEhlaWdodDsKKyAgICB1 bnNpZ25lZCBtX2RlZmF1bHRXaWR0aDsKKyAgICB1bnNpZ25lZCBtX2RlZmF1bHRIZWlnaHQ7CiB9 OwogCiB9IC8vIG5hbWVzcGFjZSBFV0syVW5pdFRlc3QK 232106 2014-05-26 20:48:24 -0700 2014-05-26 21:33:03 -0700 Patch for landing bug-133170-20140527093503.patch text/plain 2628 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTM2NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTI2ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBGaXgg Y29kZSBzdHlsZSBjaGVjayBlcnJvcnMgaW4gRUZMIEFQSSB0ZXN0cy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzE3MAorCisgICAgICAgIFJldmll d2VkIGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBPbWl0IGludCB3aGVuIHVzaW5nIHVuc2ln bmVkIG1vZGlmaWVyLCBhcyBwZXIgY29kaW5nIHN0eWxlIHJ1bGVzLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcDoK KyAgICAgICAgKEVXSzJVbml0VGVzdDo6RVdLMlVuaXRUZXN0QmFzZTo6U2V0VXApOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0RW52 aXJvbm1lbnQuaDoKKyAgICAgICAgKEVXSzJVbml0VGVzdDo6RVdLMlVuaXRUZXN0RW52aXJvbm1l bnQ6OmRlZmF1bHRXaWR0aCk6CisgICAgICAgIChFV0syVW5pdFRlc3Q6OkVXSzJVbml0VGVzdEVu dmlyb25tZW50OjpkZWZhdWx0SGVpZ2h0KToKKwogMjAxNC0wNS0yMiAgR2F2aW4gQmFycmFjbG91 Z2ggIDxiYXJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgVUkgcHJvY2VzcyB3YXRj aGRvZyBvbiBpT1MgdG8gZW5zdXJlIFdlYlByb2Nlc3MgY29ubmVjdGlvbnMgY2xvc2UKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdL MlVuaXRUZXN0QmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAkocmV2aXNp b24gMTY5MzY1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5p dFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDUsOCAr NDUsOCBAQCBFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNlKCkKIAogdm9pZCBFV0sy VW5pdFRlc3RCYXNlOjpTZXRVcCgpCiB7Ci0gICAgdW5zaWduZWQgaW50IHdpZHRoID0gZW52aXJv bm1lbnQtPmRlZmF1bHRXaWR0aCgpOwotICAgIHVuc2lnbmVkIGludCBoZWlnaHQgPSBlbnZpcm9u bWVudC0+ZGVmYXVsdEhlaWdodCgpOworICAgIHVuc2lnbmVkIHdpZHRoID0gZW52aXJvbm1lbnQt PmRlZmF1bHRXaWR0aCgpOworICAgIHVuc2lnbmVkIGhlaWdodCA9IGVudmlyb25tZW50LT5kZWZh dWx0SGVpZ2h0KCk7CiAKICNpZiBkZWZpbmVkKEhBVkVfRUNPUkVfWCkKICAgICBjb25zdCBjaGFy KiBlbmdpbmUgPSAib3BlbmdsX3gxMSI7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEVudmlyb25tZW50LmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRl c3RVdGlscy9FV0syVW5pdFRlc3RFbnZpcm9ubWVudC5oCShyZXZpc2lvbiAxNjkzNjUpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJV bml0VGVzdEVudmlyb25tZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDEyICszNSwxMiBAQCBw dWJsaWM6CiAgICAgQ1N0cmluZyBwYXRoRm9yUmVzb3VyY2UoY29uc3QgY2hhciogcmVzb3VyY2Up OwogICAgIENTdHJpbmcgcGF0aEZvclRoZW1lKGNvbnN0IGNoYXIqIHRoZW1lKTsKIAotICAgIHZp cnR1YWwgdW5zaWduZWQgaW50IGRlZmF1bHRXaWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmYXVs dFdpZHRoOyB9Ci0gICAgdmlydHVhbCB1bnNpZ25lZCBpbnQgZGVmYXVsdEhlaWdodCgpIGNvbnN0 IHsgcmV0dXJuIG1fZGVmYXVsdEhlaWdodDsgfQorICAgIHZpcnR1YWwgdW5zaWduZWQgZGVmYXVs dFdpZHRoKCkgY29uc3QgeyByZXR1cm4gbV9kZWZhdWx0V2lkdGg7IH0KKyAgICB2aXJ0dWFsIHVu c2lnbmVkIGRlZmF1bHRIZWlnaHQoKSBjb25zdCB7IHJldHVybiBtX2RlZmF1bHRIZWlnaHQ7IH0K IAogcHJpdmF0ZToKLSAgICB1bnNpZ25lZCBpbnQgbV9kZWZhdWx0V2lkdGg7Ci0gICAgdW5zaWdu ZWQgaW50IG1fZGVmYXVsdEhlaWdodDsKKyAgICB1bnNpZ25lZCBtX2RlZmF1bHRXaWR0aDsKKyAg ICB1bnNpZ25lZCBtX2RlZmF1bHRIZWlnaHQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBFV0syVW5p dFRlc3QK