133127 2014-05-20 12:35:44 -0700 [Mac] do not deactivate an audio session that has running I/O 2014-05-20 13:52:54 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1010589 0 eric.carlson 2014-05-20 12:35:44 -0700 MediaSessionManager calls AudioSession::sharedSession().setActive(false) when there are no active WebAudio sessions. It should not do this if there are any Audio or Video sessions. 1010590 1 eric.carlson 2014-05-20 12:36:03 -0700 <rdar://problem/16876590> 1010591 2 231784 eric.carlson 2014-05-20 12:45:09 -0700 Created attachment 231784 Proposed patch 1010600 3 231784 jer.noble 2014-05-20 13:09:45 -0700 Comment on attachment 231784 Proposed patch r=me 1010619 4 231784 commit-queue 2014-05-20 13:52:50 -0700 Comment on attachment 231784 Proposed patch Clearing flags on attachment: 231784 Committed r169130: <http://trac.webkit.org/changeset/169130> 1010620 5 commit-queue 2014-05-20 13:52:54 -0700 All reviewed patches have been landed. Closing bug. 231784 2014-05-20 12:45:09 -0700 2014-05-20 13:52:50 -0700 Proposed patch patch_4.txt text/plain 6813 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGRvIG5vdCBk ZWFjdGl2YXRlIGFuIGF1ZGlvIHNlc3Npb24gdGhhdCBoYXMgcnVubmluZyBJL08KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9TZXR0aW5ncy5o OgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lv bkNhdGVnb3J5KTogUmVuYW1lZCBmcm9tIHNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbi4KKyAg ICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb25DYXRlZ29y eSk6IFJlbmFtZWQgZnJvbSBzaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb24uCisgICAgICAgIChXZWJD b3JlOjpTZXR0aW5nczo6c2V0U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uKTogRGVsZXRlZC4KKyAg ICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpzaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb24pOiBEZWxl dGVkLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJN YWMuY3BwOgorICAgICAgICAoTWVkaWFTZXNzaW9uTWFuYWdlcjo6dXBkYXRlU2Vzc2lvblN0YXRl KTogRG9uJ3QgZGVhY3RpdmF0ZSB0aGUgc2Vzc2lvbiBpZiB0aGVyZSBhcmUgYW55CisgICAgICAg ICAgICBWaWRlbyBvciBBdWRpbyBzZXNzaW9ucy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMu bW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD Ojphc3NldFN0YXR1cyk6IERyaXZlLWJ5IGNoYW5nZSB0byBsb2cgZXJyb3JzIAorICAgICAgICAg ICAgcmV0dXJuZWQgYnkgLXN0YXR1c09mVmFsdWVGb3JLZXk6ZXJyb3I6IGluIGRlYnVnIGJ1aWxk cy4KKwogMjAxNC0wNS0yMCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjE2OTA2NSk6IE1vdW50YWluIExpb24gcnVuLWFwaS10ZXN0cyBmYWls dXJlczogQVNTRVJUSU9OIEZBSUxFRDogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRp bmdzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCShyZXZp c2lvbiAxNjkwNTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgJKHdvcmtpbmcg Y29weSkKQEAgLTI2Myw4ICsyNjMsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0U2hv dWxkT3B0T3V0T2ZOZXR3b3JrU3RhdGVPYnNlcnZhdGlvbihib29sIGZsYWcpIHsgZ1Nob3VsZE9w dE91dE9mTmV0d29ya1N0YXRlT2JzZXJ2YXRpb24gPSBmbGFnOyB9CiAgICAgc3RhdGljIGJvb2wg c2hvdWxkT3B0T3V0T2ZOZXR3b3JrU3RhdGVPYnNlcnZhdGlvbigpIHsgcmV0dXJuIGdTaG91bGRP cHRPdXRPZk5ldHdvcmtTdGF0ZU9ic2VydmF0aW9uOyB9CiAKLSAgICBzdGF0aWMgdm9pZCBzZXRT aG91bGRNYW5hZ2VBdWRpb1Nlc3Npb24oYm9vbCBmbGFnKSB7IGdNYW5hZ2VBdWRpb1Nlc3Npb24g PSBmbGFnOyB9Ci0gICAgc3RhdGljIGJvb2wgc2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uKCkgeyBy ZXR1cm4gZ01hbmFnZUF1ZGlvU2Vzc2lvbjsgfQorICAgIHN0YXRpYyB2b2lkIHNldFNob3VsZE1h bmFnZUF1ZGlvU2Vzc2lvbkNhdGVnb3J5KGJvb2wgZmxhZykgeyBnTWFuYWdlQXVkaW9TZXNzaW9u ID0gZmxhZzsgfQorICAgIHN0YXRpYyBib29sIHNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbkNhdGVn b3J5KCkgeyByZXR1cm4gZ01hbmFnZUF1ZGlvU2Vzc2lvbjsgfQogI2VuZGlmCiAKIHByaXZhdGU6 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvTWVkaWFTZXNzaW9uTWFu YWdlck1hYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v bWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMuY3BwCShyZXZpc2lvbiAxNjkwNTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvTWVkaWFTZXNzaW9uTWFuYWdlck1hYy5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTU1LDEyICs1NSwxMiBAQCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFn ZXI6OnVwZGF0ZVNlc3Npb25TCiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKElPUykKLSAgICBpZiAo aGFzKE1lZGlhU2Vzc2lvbjo6V2ViQXVkaW8pKQorICAgIGlmIChoYXMoTWVkaWFTZXNzaW9uOjpX ZWJBdWRpbykgfHwgaGFzKE1lZGlhU2Vzc2lvbjo6VmlkZW8pIHx8IGhhcyhNZWRpYVNlc3Npb246 OkF1ZGlvKSkKICAgICAgICAgQXVkaW9TZXNzaW9uOjpzaGFyZWRTZXNzaW9uKCkuc2V0QWN0aXZl KHRydWUpOwogICAgIGVsc2UKICAgICAgICAgQXVkaW9TZXNzaW9uOjpzaGFyZWRTZXNzaW9uKCku c2V0QWN0aXZlKGZhbHNlKTsKIAotICAgIGlmICghU2V0dGluZ3M6OnNob3VsZE1hbmFnZUF1ZGlv U2Vzc2lvbigpKQorICAgIGlmICghU2V0dGluZ3M6OnNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbkNh dGVnb3J5KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChoYXMoTWVkaWFTZXNzaW9uOjpW aWRlbykgfHwgaGFzKE1lZGlhU2Vzc2lvbjo6QXVkaW8pKQpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uT2JqQy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25P YmpDLm1tCShyZXZpc2lvbiAxNjkwNTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpD Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTg5LDcgKzExODksMTIgQEAgTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uOjpBc3NldFN0YQogICAgICAgICByZXR1cm4gTWVkaWFQbGF5ZXJBVkFz c2V0U3RhdHVzRG9lc05vdEV4aXN0OwogCiAgICAgZm9yIChOU1N0cmluZyAqa2V5TmFtZSBpbiBh c3NldE1ldGFkYXRhS2V5TmFtZXMoKSkgewotICAgICAgICBBVktleVZhbHVlU3RhdHVzIGtleVN0 YXR1cyA9IFttX2F2QXNzZXQuZ2V0KCkgc3RhdHVzT2ZWYWx1ZUZvcktleTprZXlOYW1lIGVycm9y Om5pbF07CisgICAgICAgIE5TRXJyb3IgKmVycm9yID0gbmlsOworICAgICAgICBBVktleVZhbHVl U3RhdHVzIGtleVN0YXR1cyA9IFttX2F2QXNzZXQuZ2V0KCkgc3RhdHVzT2ZWYWx1ZUZvcktleTpr ZXlOYW1lIGVycm9yOiZlcnJvcl07CisjaWYgIUxPR19ESVNBQkxFRAorICAgICAgICBpZiAoZXJy b3IpCisgICAgICAgICAgICBMT0coTWVkaWEsICJNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRp b246OmFzc2V0U3RhdHVzIC0gc3RhdHVzT2ZWYWx1ZUZvcktleSBmYWlsZWQgZm9yICVzLCBlcnJv ciA9ICVzIiwgW2tleU5hbWUgVVRGOFN0cmluZ10sIFtbZXJyb3IgbG9jYWxpemVkRGVzY3JpcHRp b25dIFVURjhTdHJpbmddKTsKKyNlbmRpZgogCiAgICAgICAgIGlmIChrZXlTdGF0dXMgPCBBVktl eVZhbHVlU3RhdHVzTG9hZGVkKQogICAgICAgICAgICAgcmV0dXJuIE1lZGlhUGxheWVyQVZBc3Nl dFN0YXR1c0xvYWRpbmc7Ly8gQXQgbGVhc3Qgb25lIGtleSBpcyBub3QgbG9hZGVkIHlldC4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEyNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA1LTIwICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdIGRvIG5vdCBkZWFj dGl2YXRlIGFuIGF1ZGlvIHNlc3Npb24gdGhhdCBoYXMgcnVubmluZyBJL08KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdl L1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdlKTogU2V0dGlu Z3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbiByZW5hbWVkIHRvIAorICAgICAgICAgICAg c2V0U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uQ2F0ZWdvcnksIGRlYWwgd2l0aCBpdC4KKwogMjAx NC0wNS0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSRUdSRVNTSU9OIChyMTY5MDYzKSBGaXhlZCBhbmQgc3RpY2t5IG5vZGVzIG1pc3BsYWNlZCBv biBzY3JvbGxpbmcgc29tZXRpbWVzCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCShyZXZpc2lvbiAxNjkwNTQpCisrKyBTb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMyMCw3 ICszMjAsNyBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBhZ2VJRCwgY29uc3QgCiAgICAg U2V0dGluZ3M6OnNldERlZmF1bHRNaW5ET01UaW1lckludGVydmFsKDAuMDA0KTsKIAogI2lmIFBM QVRGT1JNKElPUykKLSAgICBTZXR0aW5nczo6c2V0U2hvdWxkTWFuYWdlQXVkaW9TZXNzaW9uKHRy dWUpOworICAgIFNldHRpbmdzOjpzZXRTaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb25DYXRlZ29yeSh0 cnVlKTsKICNlbmRpZgogCiAgICAgUGFnZTo6UGFnZUNsaWVudHMgcGFnZUNsaWVudHM7CkluZGV4 OiBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9tYWMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjkxMjQpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wNS0yMCAgRXJp YyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBkbyBu b3QgZGVhY3RpdmF0ZSBhbiBhdWRpbyBzZXNzaW9uIHRoYXQgaGFzIHJ1bm5pbmcgSS9PCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMxMjcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcvV2Vi Vmlldy5tbToKKyAgICAgICAgKC1bV2ViVmlldyBfY29tbW9uSW5pdGlhbGl6YXRpb25XaXRoRnJh bWVOYW1lOmdyb3VwTmFtZTpdKTogU2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lv bgorICAgICAgICAgICAgcmVuYW1lZCB0byBzZXRTaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb25DYXRl Z29yeSwgZGVhbCB3aXRoIGl0LgorCiAyMDE0LTA1LTE5ICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgZGlmZmVyZW50IEFwcEtpdCBBUEkgZm9yIGltYWdl IGNvbnRyb2wgbWVudXMuCkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShy ZXZpc2lvbiAxNjkwNTQpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0J KHdvcmtpbmcgY29weSkKQEAgLTkwMyw3ICs5MDMsNyBAQCAtICh2b2lkKV9jb21tb25Jbml0aWFs aXphdGlvbldpdGhGcmFtZU5hCiAKICNpZiBQTEFURk9STShJT1MpCiAgICAgICAgIGlmIChhcHBs aWNhdGlvbklzTW9iaWxlU2FmYXJpKCkpCi0gICAgICAgICAgICBTZXR0aW5nczo6c2V0U2hvdWxk TWFuYWdlQXVkaW9TZXNzaW9uKHRydWUpOworICAgICAgICAgICAgU2V0dGluZ3M6OnNldFNob3Vs ZE1hbmFnZUF1ZGlvU2Vzc2lvbkNhdGVnb3J5KHRydWUpOwogI2VuZGlmCiAKICAgICAgICAgZGlk T25lVGltZUluaXRpYWxpemF0aW9uID0gdHJ1ZTsK