133125 2014-05-20 10:21:23 -0700 Use a per app directory structure for website data 2014-05-23 15:50:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca mhahnenberg mitz oldest_to_newest 1010547 0 andersca 2014-05-20 10:21:23 -0700 Use a per app directory distructure for website data 1010550 1 231775 andersca 2014-05-20 10:25:23 -0700 Created attachment 231775 Patch 1010608 2 231775 thorton 2014-05-20 13:23:10 -0700 Comment on attachment 231775 Patch r=me too (especially if you fix the differently-scoped-same-name NSURL *url which always makes me slightly nervous) 1011000 3 231892 andersca 2014-05-22 09:45:04 -0700 Created attachment 231892 Patch 1011308 4 231892 mitz 2014-05-23 11:10:16 -0700 Comment on attachment 231892 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231892&action=review > Source/WebKit2/ChangeLog:9 > + Put Website data in subdirectories of ~/Library/WebKit/<bundle ID>/WebsiteData. website > Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:125 > + if (![[NSFileManager defaultManager] createDirectoryAtURL:url withIntermediateDirectories:YES attributes:nil error:nullptr]) > + RELEASE_ASSERT_NOT_REACHED(); It doesn’t seem appropriate to assert that directory creation didn’t fail. Certain external conditions, such as permissions on intermediate directories, can make the assertion false. 1011320 5 andersca 2014-05-23 12:00:22 -0700 Committed r169271: <http://trac.webkit.org/changeset/169271> 1011391 6 mhahnenberg 2014-05-23 15:50:42 -0700 (In reply to comment #5) > Committed r169271: <http://trac.webkit.org/changeset/169271> This looks like it broke the following API tests on the WK2 debug bots: WKNavigation.DidFailProvisionalNavigation WKNavigation.LoadRequest WKNavigation.NavigationDelegate _WKDownload.CancelDownload _WKDownload.ConvertResponseToDownload _WKDownload.DownloadDelegate _WKDownload.DownloadMissingResource _WKDownload.DownloadRequest _WKDownload.OriginatingWebView For backtraces of the crashes, see: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/builds/4851/steps/run-api-tests/logs/stdio For a history of when these failures started, see: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29?numbuilds=25 231775 2014-05-20 10:25:23 -0700 2014-05-22 09:45:02 -0700 Patch bug-133125-20140520102504.patch text/plain 3387 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2I0N2YzOTIzZTFmNzc0 ZmVmZjEzODEzY2U4MGViODhlNGE4YTYyOC4uODFiZjBjYzA2NWFlZWJmNWUxMDAzNDcxNmY2N2Rm Njk2OTFjOTc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA1LTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIGEgcGVyIGFw cCBkaXJlY3RvcnkgZGlzdHJ1Y3R1cmUgZm9yIHdlYnNpdGUgZGF0YQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMTI1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xNjgzMDE0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQdXQgV2Vic2l0ZSBkYXRhIGluIHN1YmRpcmVjdG9yaWVzIG9mIH4vTGlicmFy eS9XZWJLaXQvPGJ1bmRsZSBJRD4vV2Vic2l0ZURhdGEuCisgICAgICAgIFdlIHVzZSAiTG9jYWxT dG9yYWdlIiwgIldlYlNRTCIsIGFuZCAiSW5kZXhlZERCIiBzdWJkaXJlY3Rvcmllcy4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbToKKyAgICAgICAgKHdl YnNpdGVEYXRhRGlyZWN0b3J5VVJMKToKKyAgICAgICAgKC1bV0tQcm9jZXNzUG9vbCBfaW5pdFdp dGhDb25maWd1cmF0aW9uOl0pOgorCisyMDE0LTA1LTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgRml4IGEgaGVhZGVyIGNvbW1lbnQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyMwogICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTY5NzM3ODM+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW0KaW5kZXggOGYwMTdjZjc0N2QzNmZhMGMyYTZl NWZmMWIzNjVjYmMzNGRkY2E4Ny4uMGNiM2I3OWNlMzI2YWVmM2I2N2E1Y2FiNjk2OWJiNjMzYjcw YWIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1By b2Nlc3NQb29sLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQ cm9jZXNzUG9vbC5tbQpAQCAtMTA0LDYgKzEwNCwyOSBAQCBlbnVtIDogTlNVSW50ZWdlciB7CiAK IEBpbXBsZW1lbnRhdGlvbiBXS1Byb2Nlc3NQb29sIChXS1ByaXZhdGUpCiAKK3N0YXRpYyBOU1VS TCAqd2Vic2l0ZURhdGFEaXJlY3RvcnlVUkwoTlNTdHJpbmcgKmRpcmVjdG9yeU5hbWUpCit7Cisg ICAgc3RhdGljIGRpc3BhdGNoX29uY2VfdCBvbmNlVG9rZW47CisgICAgc3RhdGljIE5TVVJMICp3 ZWJzaXRlRGF0YVVSTDsKKworICAgIGRpc3BhdGNoX29uY2UoJm9uY2VUb2tlbiwgXnsKKyAgICAg ICAgTlNVUkwgKnVybCA9IFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gVVJMRm9yRGly ZWN0b3J5Ok5TTGlicmFyeURpcmVjdG9yeSBpbkRvbWFpbjpOU1VzZXJEb21haW5NYXNrIGFwcHJv cHJpYXRlRm9yVVJMOm51bGxwdHIgY3JlYXRlOk5PIGVycm9yOm51bGxwdHJdOworICAgICAgICBp ZiAoIXVybCkKKyAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisKKyAg ICAgICAgdXJsID0gW3VybCBVUkxCeUFwcGVuZGluZ1BhdGhDb21wb25lbnQ6QCJXZWJLaXQiIGlz RGlyZWN0b3J5OllFU107CisgICAgICAgIHVybCA9IFt1cmwgVVJMQnlBcHBlbmRpbmdQYXRoQ29t cG9uZW50OltbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gYnVuZGxlSWRlbnRpZmllcl0gaXNEaXJlY3Rv cnk6WUVTXTsKKworICAgICAgICB3ZWJzaXRlRGF0YVVSTCA9IFtbdXJsIFVSTEJ5QXBwZW5kaW5n UGF0aENvbXBvbmVudDpAIldlYnNpdGVEYXRhIiBpc0RpcmVjdG9yeTpZRVNdIHJldGFpbl07Cisg ICAgfSk7CisKKyAgICBOU1VSTCAqdXJsID0gW3dlYnNpdGVEYXRhVVJMIFVSTEJ5QXBwZW5kaW5n UGF0aENvbXBvbmVudDpkaXJlY3RvcnlOYW1lIGlzRGlyZWN0b3J5OllFU107CisgICAgaWYgKCFb W05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGNyZWF0ZURpcmVjdG9yeUF0VVJMOnVybCB3 aXRoSW50ZXJtZWRpYXRlRGlyZWN0b3JpZXM6WUVTIGF0dHJpYnV0ZXM6bmlsIGVycm9yOm51bGxw dHJdKQorICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOworCisgICAgcmV0dXJu IHVybDsKK30KKwogLSAoaW5zdGFuY2V0eXBlKV9pbml0V2l0aENvbmZpZ3VyYXRpb246KF9XS1By b2Nlc3NQb29sQ29uZmlndXJhdGlvbiAqKWNvbmZpZ3VyYXRpb24KIHsKICAgICBpZiAoIShzZWxm ID0gW3N1cGVyIGluaXRdKSkKQEAgLTEyNSw4ICsxNDgsOSBAQCBlbnVtIDogTlNVSW50ZWdlciB7 CiAgICAgICAgIHdlYkNvbnRleHRDb25maWd1cmF0aW9uLmluamVjdGVkQnVuZGxlUGF0aCA9IGJ1 bmRsZVVSTC5wYXRoOwogICAgIH0KIAotICAgIC8vIEZJWE1FOiBUaGVzZSBhcmUgbGVnYWN5IGNv bmZpZ3VyYXRpb24gZGVmYXVsdHMgYW5kIHNob3VsZCBub3QgYmUgYXBwbGllZCB3aGVuIGNyZWF0 aW5nIGEgV0tQcm9jZXNzUG9vbC4KLSAgICBXZWJLaXQ6OldlYkNvbnRleHQ6OmFwcGx5UGxhdGZv cm1TcGVjaWZpY0NvbmZpZ3VyYXRpb25EZWZhdWx0cyh3ZWJDb250ZXh0Q29uZmlndXJhdGlvbik7 CisgICAgd2ViQ29udGV4dENvbmZpZ3VyYXRpb24ubG9jYWxTdG9yYWdlRGlyZWN0b3J5ID0gd2Vi c2l0ZURhdGFEaXJlY3RvcnlVUkwoQCJMb2NhbFN0b3JhZ2UiKS5maWxlU3lzdGVtUmVwcmVzZW50 YXRpb247CisgICAgd2ViQ29udGV4dENvbmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3Rv cnkgPSB3ZWJzaXRlRGF0YURpcmVjdG9yeVVSTChAIldlYlNRTCIpLmZpbGVTeXN0ZW1SZXByZXNl bnRhdGlvbjsKKyAgICB3ZWJDb250ZXh0Q29uZmlndXJhdGlvbi5pbmRleGVkREJEYXRhYmFzZURp cmVjdG9yeSA9IHdlYnNpdGVEYXRhRGlyZWN0b3J5VVJMKEAiSW5kZXhlZERCIikuZmlsZVN5c3Rl bVJlcHJlc2VudGF0aW9uOwogCiAgICAgQVBJOjpPYmplY3Q6OmNvbnN0cnVjdEluV3JhcHBlcjxX ZWJLaXQ6OldlYkNvbnRleHQ+KHNlbGYsIHN0ZDo6bW92ZSh3ZWJDb250ZXh0Q29uZmlndXJhdGlv bikpOwogICAgIF9jb250ZXh0LT5zZXRIaXN0b3J5Q2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8V2Vi S2l0OjpIaXN0b3J5Q2xpZW50PigpKTsK 231892 2014-05-22 09:45:04 -0700 2014-05-23 11:10:15 -0700 Patch bug-133125-20140522094440.patch text/plain 3351 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTA3ZmM1ODU0MzMwMzUz NTIwYjAyMTY1ZDViZjE1ODk3NTI3MmI0Yy4uMzUxZjM1ODE4ZTQ1MDA5MTQ1NDA4NGRhOTI4OTVh NzJhY2FhOWRkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGEgcGVyIGFw cCBkaXJlY3Rvcnkgc3RydWN0dXJlIGZvciB3ZWJzaXRlIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyNQorICAgICAgICA8cmRhcjovL3By b2JsZW0vMTY4MzAxNDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUHV0IFdlYnNpdGUgZGF0YSBpbiBzdWJkaXJlY3RvcmllcyBvZiB+L0xpYnJhcnkv V2ViS2l0LzxidW5kbGUgSUQ+L1dlYnNpdGVEYXRhLgorICAgICAgICBXZSB1c2UgIkxvY2FsU3Rv cmFnZSIsICJXZWJTUUwiLCBhbmQgIkluZGV4ZWREQiIgc3ViZGlyZWN0b3JpZXMuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bvb2wubW06CisgICAgICAgICh3ZWJz aXRlRGF0YURpcmVjdG9yeVVSTCk6CisgICAgICAgICgtW1dLUHJvY2Vzc1Bvb2wgX2luaXRXaXRo Q29uZmlndXJhdGlvbjpdKToKKwogMjAxNC0wNS0yMSAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIE9ubHkgZW5hYmxlIHNhbmRib3ggZXh0ZW5zaW9ucyBvbiBtYWMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vz c1Bvb2wubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJvY2Vzc1Bv b2wubW0KaW5kZXggOGYwMTdjZjc0N2QzNmZhMGMyYTZlNWZmMWIzNjVjYmMzNGRkY2E4Ny4uMTdi ZjdkMjA0MDMwOGUwMDEyY2FkNTJhMjAxYmU2M2E3MDY5YTk1MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1Byb2Nlc3NQb29sLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcm9jZXNzUG9vbC5tbQpAQCAtMTA0LDYg KzEwNCwyOSBAQCBlbnVtIDogTlNVSW50ZWdlciB7CiAKIEBpbXBsZW1lbnRhdGlvbiBXS1Byb2Nl c3NQb29sIChXS1ByaXZhdGUpCiAKK3N0YXRpYyBOU1VSTCAqd2Vic2l0ZURhdGFEaXJlY3RvcnlV UkwoTlNTdHJpbmcgKmRpcmVjdG9yeU5hbWUpCit7CisgICAgc3RhdGljIGRpc3BhdGNoX29uY2Vf dCBvbmNlVG9rZW47CisgICAgc3RhdGljIE5TVVJMICp3ZWJzaXRlRGF0YVVSTDsKKworICAgIGRp c3BhdGNoX29uY2UoJm9uY2VUb2tlbiwgXnsKKyAgICAgICAgTlNVUkwgKnVybCA9IFtbTlNGaWxl TWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gVVJMRm9yRGlyZWN0b3J5Ok5TTGlicmFyeURpcmVjdG9y eSBpbkRvbWFpbjpOU1VzZXJEb21haW5NYXNrIGFwcHJvcHJpYXRlRm9yVVJMOm51bGxwdHIgY3Jl YXRlOk5PIGVycm9yOm51bGxwdHJdOworICAgICAgICBpZiAoIXVybCkKKyAgICAgICAgICAgIFJF TEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisKKyAgICAgICAgdXJsID0gW3VybCBVUkxCeUFw cGVuZGluZ1BhdGhDb21wb25lbnQ6QCJXZWJLaXQiIGlzRGlyZWN0b3J5OllFU107CisgICAgICAg IHVybCA9IFt1cmwgVVJMQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OltbTlNCdW5kbGUgbWFpbkJ1 bmRsZV0gYnVuZGxlSWRlbnRpZmllcl0gaXNEaXJlY3Rvcnk6WUVTXTsKKworICAgICAgICB3ZWJz aXRlRGF0YVVSTCA9IFtbdXJsIFVSTEJ5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIldlYnNpdGVE YXRhIiBpc0RpcmVjdG9yeTpZRVNdIHJldGFpbl07CisgICAgfSk7CisKKyAgICBOU1VSTCAqdXJs ID0gW3dlYnNpdGVEYXRhVVJMIFVSTEJ5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpkaXJlY3RvcnlO YW1lIGlzRGlyZWN0b3J5OllFU107CisgICAgaWYgKCFbW05TRmlsZU1hbmFnZXIgZGVmYXVsdE1h bmFnZXJdIGNyZWF0ZURpcmVjdG9yeUF0VVJMOnVybCB3aXRoSW50ZXJtZWRpYXRlRGlyZWN0b3Jp ZXM6WUVTIGF0dHJpYnV0ZXM6bmlsIGVycm9yOm51bGxwdHJdKQorICAgICAgICBSRUxFQVNFX0FT U0VSVF9OT1RfUkVBQ0hFRCgpOworCisgICAgcmV0dXJuIHVybDsKK30KKwogLSAoaW5zdGFuY2V0 eXBlKV9pbml0V2l0aENvbmZpZ3VyYXRpb246KF9XS1Byb2Nlc3NQb29sQ29uZmlndXJhdGlvbiAq KWNvbmZpZ3VyYXRpb24KIHsKICAgICBpZiAoIShzZWxmID0gW3N1cGVyIGluaXRdKSkKQEAgLTEy NSw4ICsxNDgsOSBAQCBlbnVtIDogTlNVSW50ZWdlciB7CiAgICAgICAgIHdlYkNvbnRleHRDb25m aWd1cmF0aW9uLmluamVjdGVkQnVuZGxlUGF0aCA9IGJ1bmRsZVVSTC5wYXRoOwogICAgIH0KIAot ICAgIC8vIEZJWE1FOiBUaGVzZSBhcmUgbGVnYWN5IGNvbmZpZ3VyYXRpb24gZGVmYXVsdHMgYW5k IHNob3VsZCBub3QgYmUgYXBwbGllZCB3aGVuIGNyZWF0aW5nIGEgV0tQcm9jZXNzUG9vbC4KLSAg ICBXZWJLaXQ6OldlYkNvbnRleHQ6OmFwcGx5UGxhdGZvcm1TcGVjaWZpY0NvbmZpZ3VyYXRpb25E ZWZhdWx0cyh3ZWJDb250ZXh0Q29uZmlndXJhdGlvbik7CisgICAgd2ViQ29udGV4dENvbmZpZ3Vy YXRpb24ubG9jYWxTdG9yYWdlRGlyZWN0b3J5ID0gd2Vic2l0ZURhdGFEaXJlY3RvcnlVUkwoQCJM b2NhbFN0b3JhZ2UiKS5hYnNvbHV0ZVN0cmluZy5maWxlU3lzdGVtUmVwcmVzZW50YXRpb247Cisg ICAgd2ViQ29udGV4dENvbmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkgPSB3ZWJz aXRlRGF0YURpcmVjdG9yeVVSTChAIldlYlNRTCIpLmFic29sdXRlU3RyaW5nLmZpbGVTeXN0ZW1S ZXByZXNlbnRhdGlvbjsKKyAgICB3ZWJDb250ZXh0Q29uZmlndXJhdGlvbi5pbmRleGVkREJEYXRh YmFzZURpcmVjdG9yeSA9IHdlYnNpdGVEYXRhRGlyZWN0b3J5VVJMKEAiSW5kZXhlZERCIikuYWJz b2x1dGVTdHJpbmcuZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uOwogCiAgICAgQVBJOjpPYmplY3Q6 OmNvbnN0cnVjdEluV3JhcHBlcjxXZWJLaXQ6OldlYkNvbnRleHQ+KHNlbGYsIHN0ZDo6bW92ZSh3 ZWJDb250ZXh0Q29uZmlndXJhdGlvbikpOwogICAgIF9jb250ZXh0LT5zZXRIaXN0b3J5Q2xpZW50 KHN0ZDo6bWFrZV91bmlxdWU8V2ViS2l0OjpIaXN0b3J5Q2xpZW50PigpKTsK