133121 2014-05-20 07:21:40 -0700 REGRESSION (r169065): Mountain Lion run-api-tests failures: ASSERTION FAILED: Uncaught exception - -[NSRegularLegacyScrollerImp setPresentationValue:]: unrecognized selector sent to instance 0x7ff51aa38000 2014-05-20 12:32:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer bdakin ap bdakin simon.fraser thorton oldest_to_newest 1010486 0 ddkilzer 2014-05-20 07:21:40 -0700 Six tests fail due to an assertion on Mountain Lion debug builds: Note: Google Test filter = AcceptsFirstMouse.WebKit2 [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from AcceptsFirstMouse [ RUN ] AcceptsFirstMouse.WebKit2 2014-05-20 05:42:46.798 WebProcess[64421:303] -[NSRegularLegacyScrollerImp setPresentationValue:]: unrecognized selector sent to instance 0x7fe03220d700 ASSERTION FAILED: Uncaught exception - -[NSRegularLegacyScrollerImp setPresentationValue:]: unrecognized selector sent to instance 0x7fe03220d700 0 /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/mac/BlockExceptions.mm(36) : void ReportBlockedObjCException(NSException *) 1 0x10ee8de40 WTFCrash 2 0x106a0035d ReportBlockedObjCException(NSException*) 3 0x1082de1cd WebCore::ScrollbarThemeMac::setPaintCharacteristicsForScrollbar(WebCore::ScrollbarThemeClient*) 4 0x1082de218 WebCore::ScrollbarThemeMac::paint(WebCore::ScrollbarThemeClient*, WebCore::GraphicsContext*, WebCore::IntRect const&) 5 0x1082d48b7 WebCore::Scrollbar::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) 6 0x108089319 WebCore::paintScrollbar(WebCore::Scrollbar*, WebCore::GraphicsContext&, WebCore::IntRect const&) 7 0x1080890f0 WebCore::RenderLayerCompositor::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, unsigned int, WebCore::FloatRect const&) 8 0x1071b4428 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&) 9 0x1071c314c WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&) 10 0x1071c319f non-virtual thunk to WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&) 11 0x1087a3783 WebCore::drawLayerContents(CGContext*, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow>&) 12 0x1087a3dc4 -[WebLayer drawInContext:] 13 0x7fff95ab3df0 CABackingStoreUpdate_ 14 0x7fff95ab2aa6 CA::Layer::display_() 15 0x1087a4266 -[WebSimpleLayer display] 16 0x7fff95ab2425 CA::Layer::display_if_needed(CA::Transaction*) 17 0x7fff95ab1c3f CA::Layer::layout_and_display_if_needed(CA::Transaction*) 18 0x7fff95aa7417 CA::Context::commit_transaction(CA::Transaction*) 19 0x7fff95aa71e7 CA::Transaction::commit() 20 0x7fff95aa7003 CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) 21 0x7fff902db417 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 22 0x7fff902db381 __CFRunLoopDoObservers 23 0x7fff902b6104 CFRunLoopRunSpecific 24 0x7fff8ed5ceb4 RunCurrentEventLoopInMode 25 0x7fff8ed5cc52 ReceiveNextEventCommon 26 0x7fff8ed5cae3 BlockUntilNextEventMatchingListInMode 27 0x7fff90a85533 _DPSNextEvent 28 0x7fff90a84df2 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 29 0x7fff90a7c1a3 -[NSApplication run] 30 0x1048bfeaf WebKit::WebContentProcessMainDelegate::startRunLoop() 31 0x1048beeaf int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebContentProcessMainDelegate>(int, char**) /Volumes/Data/slave/mountainlion-debug/build/Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:57: Failure Value of: [[view hitTest:pointInsideSelection] acceptsFirstMouse:mouseEventInsideSelection] Actual: false Expected: true [ FAILED ] AcceptsFirstMouse.WebKit2 (2626 ms) [----------] 1 test from AcceptsFirstMouse (2626 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2626 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] AcceptsFirstMouse.WebKit2 1 FAILED TEST YOU HAVE 5 DISABLED TESTS Tests that failed: AcceptsFirstMouse.WebKit2 Tests that timed out: WebKit2.NewFirstVisuallyNonEmptyLayoutFrames WebKit2.ResizeReversePaginatedWebView WebKit2.ScrollByLineCommands WebKit2.ScrollPinningBehaviors WebKit2.SpacebarScrolling <http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/14043/steps/run-api-tests/logs/stdio> 1010487 1 ddkilzer 2014-05-20 07:26:30 -0700 This regression occurred when run-api-tests was broken on Mountain Lion due to Bug 132954, which caused breakage starting in r169042 until it was fixed in r169078. 1010488 2 ddkilzer 2014-05-20 07:34:28 -0700 http://trac.webkit.org/log/trunk/?rev=169078&stop_rev=169041 1010491 3 ddkilzer 2014-05-20 07:41:39 -0700 Looks like a regression from r169065: Bug 133077: Scrollbars display incorrectly after switching between fast and slow scrolling mode, affects Find and real sites ​<https://bugs.webkit.org/show_bug.cgi?id=133077> <rdar://problem/16888608> <http://trac.webkit.org/changeset/169065> Beth, should the call to -setPresentationValue: not be called on Mountain Lion, or does NSRegularLegacyScrollerImp need a stub method implemented that does nothing? 1010573 4 bdakin 2014-05-20 11:20:49 -0700 (In reply to comment #3) > Looks like a regression from r169065: > > Bug 133077: Scrollbars display incorrectly after switching between fast and slow scrolling mode, affects Find and real sites > ​<https://bugs.webkit.org/show_bug.cgi?id=133077> > <rdar://problem/16888608> > <http://trac.webkit.org/changeset/169065> > > Beth, should the call to -setPresentationValue: not be called on Mountain Lion, or does NSRegularLegacyScrollerImp need a stub method implemented that does nothing? I think we should just not call it for Mountain Lion. I can post a patch shortly. 1010576 5 231779 bdakin 2014-05-20 11:47:07 -0700 Created attachment 231779 Patch 1010579 6 231781 bdakin 2014-05-20 11:59:05 -0700 Created attachment 231781 Patch The other ifdef will work, but this one is better and it matches the ifdef in Scrollbar::supportsUpdateOnSecondaryThread(). 1010588 7 bdakin 2014-05-20 12:32:03 -0700 Thanks Tim! http://trac.webkit.org/changeset/169124 231779 2014-05-20 11:47:07 -0700 2014-05-20 11:59:05 -0700 Patch for-review.txt text/plain 1544 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTIwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTY5MDY1KTog TW91bnRhaW4gTGlvbiBydW4tYXBpLXRlc3RzIGZhaWx1cmVzOiBBU1NFUlRJT04gRkFJTEVEOiAK KyAgICAgICAgVW5jYXVnaHQgZXhjZXB0aW9uIC0gLVtOU1JlZ3VsYXJMZWdhY3lTY3JvbGxlcklt cCBzZXRQcmVzZW50YXRpb25WYWx1ZTpdOiAKKyAgICAgICAgdW5yZWNvZ25pemVkIHNlbGVjdG9y IHNlbnQgdG8gaW5zdGFuY2UgMHg3ZmY1MWFhMzgwMDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OnNldFBhaW50Q2hhcmFj dGVyaXN0aWNzRm9yU2Nyb2xsYmFyKToKKwogMjAxNC0wNS0yMCAgUmFkdSBTdGF2aWxhICA8c3Rh dmlsYUBhZG9iZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0NTUyBSZWdpb25zXSBDb250 ZW50IGZsb3dlZCBkaXJlY3RseSBpbnRvIHRoZSBmbG93IHRocmVhZCB0aGF0IGVuZHMgdXAgaW4g dGhlIHNlY29uZCByZWdpb24gaXMgbm90IHByb3Blcmx5IHJlcGFpbnRlZApJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQkocmV2aXNp b24gMTY5MTIxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1l TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NzksNyArNDc5LDkgQEAgdm9pZCBTY3JvbGxiYXJU aGVtZU1hYzo6c2V0UGFpbnRDaGFyYWN0ZQogICAgIFtwYWludGVyIHNldEVuYWJsZWQ6c2Nyb2xs YmFyLT5lbmFibGVkKCldOwogICAgIFtwYWludGVyIHNldEJvdW5kc1NpemU6c2Nyb2xsYmFyLT5m cmFtZVJlY3QoKS5zaXplKCldOwogICAgIFtwYWludGVyIHNldERvdWJsZVZhbHVlOnZhbHVlXTsK KyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwOTAKICAgICBbcGFpbnRl ciBzZXRQcmVzZW50YXRpb25WYWx1ZTp2YWx1ZV07CisjZW5kaWYKICAgICBbcGFpbnRlciBzZXRL bm9iUHJvcG9ydGlvbjpwcm9wb3J0aW9uXTsKICAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05T OwogfQo= 231781 2014-05-20 11:59:05 -0700 2014-05-20 12:23:34 -0700 Patch for-review-2.txt text/plain 1590 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTIwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTY5MDY1KTog TW91bnRhaW4gTGlvbiBydW4tYXBpLXRlc3RzIGZhaWx1cmVzOiBBU1NFUlRJT04gRkFJTEVEOiAK KyAgICAgICAgVW5jYXVnaHQgZXhjZXB0aW9uIC0gLVtOU1JlZ3VsYXJMZWdhY3lTY3JvbGxlcklt cCBzZXRQcmVzZW50YXRpb25WYWx1ZTpdOiAKKyAgICAgICAgdW5yZWNvZ25pemVkIHNlbGVjdG9y IHNlbnQgdG8gaW5zdGFuY2UgMHg3ZmY1MWFhMzgwMDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzEyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFj Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6OnNldFBhaW50Q2hhcmFj dGVyaXN0aWNzRm9yU2Nyb2xsYmFyKToKKwogMjAxNC0wNS0yMCAgUmFkdSBTdGF2aWxhICA8c3Rh dmlsYUBhZG9iZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0NTUyBSZWdpb25zXSBDb250 ZW50IGZsb3dlZCBkaXJlY3RseSBpbnRvIHRoZSBmbG93IHRocmVhZCB0aGF0IGVuZHMgdXAgaW4g dGhlIHNlY29uZCByZWdpb24gaXMgbm90IHByb3Blcmx5IHJlcGFpbnRlZApJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQkocmV2aXNp b24gMTY5MTIxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1l TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NzksNyArNDc5LDkgQEAgdm9pZCBTY3JvbGxiYXJU aGVtZU1hYzo6c2V0UGFpbnRDaGFyYWN0ZQogICAgIFtwYWludGVyIHNldEVuYWJsZWQ6c2Nyb2xs YmFyLT5lbmFibGVkKCldOwogICAgIFtwYWludGVyIHNldEJvdW5kc1NpemU6c2Nyb2xsYmFyLT5m cmFtZVJlY3QoKS5zaXplKCldOwogICAgIFtwYWludGVyIHNldERvdWJsZVZhbHVlOnZhbHVlXTsK KyNpZiBFTkFCTEUoQVNZTkNfU0NST0xMSU5HKSAmJiBQTEFURk9STShNQUMpICYmIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMDAwCiAgICAgW3BhaW50ZXIgc2V0UHJlc2Vu dGF0aW9uVmFsdWU6dmFsdWVdOworI2VuZGlmCiAgICAgW3BhaW50ZXIgc2V0S25vYlByb3BvcnRp b246cHJvcG9ydGlvbl07CiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIH0K