<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>13312</bug_id>
          
          <creation_ts>2007-04-09 11:14:33 -0700</creation_ts>
          <short_desc>portable implementation of &lt;canvas&gt; element</short_desc>
          <delta_ts>2008-09-30 20:27:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mike Reed">mikerreed</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gavin.sharp</cc>
    
    <cc>mrowe</cc>
    
    <cc>staikos</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>15319</commentid>
    <comment_count>0</comment_count>
    <who name="Mike Reed">mikerreed</who>
    <bug_when>2007-04-09 11:14:33 -0700</bug_when>
    <thetext>This patch extends GraphicsContext.h to have the necessary entry points to implement &lt;canvas&gt;. The patch is done by #else clauses whereever there was #if PLATFORM(CG) specific code used for &lt;canvas&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15320</commentid>
    <comment_count>1</comment_count>
      <attachid>13993</attachid>
    <who name="Mike Reed">mikerreed</who>
    <bug_when>2007-04-09 11:19:16 -0700</bug_when>
    <thetext>Created attachment 13993
patch.txt and a new platform header PlatformGraphics.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15277</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-04-09 16:43:57 -0700</bug_when>
    <thetext>Can you please attach the change as a diff created with svn-create-patch (in WebKitTools/Scripts) rather than a zip file?  A ChangeLog entry should also be included (use prepare-ChangeLog to generate a template).  If you would like this patch to be reviewed and landed, you should select the &quot;review ?&quot; flag after attaching the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15257</commentid>
    <comment_count>3</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2007-04-09 16:48:14 -0700</bug_when>
    <thetext>(This hasn&apos;t been flagged for review, but I should point out that this would not be appropriate for landing until after the stabilization period is over.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>12719</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-04-25 05:03:06 -0700</bug_when>
    <thetext>Mike, are you able to attach an updated patch in the correct format?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>12724</commentid>
    <comment_count>5</comment_count>
      <attachid>13993</attachid>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2007-04-25 05:40:16 -0700</bug_when>
    <thetext>Comment on attachment 13993
patch.txt and a new platform header PlatformGraphics.h

The big issue here is the addition of many new methods to GraphicsContext with no implementations.  This will break all non-CoreGraphics builds, and at the very least these should be stubbed out.  A ChangeLog entry and the necessary project file changes would also be great.

Besides that there are some minor code style issues I noticed while skimming the patch: the local variable &quot;pg&quot; in CanvasGradient::platformGradient seems unnecessary and the placement of braces is incorrect, the declaration of &quot;count&quot; has been manually lined up with &quot;data&quot;, one of the changes in HTMLCanvasElement.cpp adds unnecessary braces.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>5342</commentid>
    <comment_count>6</comment_count>
    <who name="George Staikos">staikos</who>
    <bug_when>2007-07-06 10:51:17 -0700</bug_when>
    <thetext>Would like to get this one moving along again.  The current situation is quite ugly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>57549</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2007-10-01 09:43:35 -0700</bug_when>
    <thetext>This could easily go on the feature-branch, once the patch is dusted off again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>93490</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-09-30 20:27:37 -0700</bug_when>
    <thetext>Mike, this has all been done in the latest sources.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>13993</attachid>
            <date>2007-04-09 11:19:16 -0700</date>
            <delta_ts>2007-04-25 05:40:16 -0700</delta_ts>
            <desc>patch.txt and a new platform header PlatformGraphics.h</desc>
            <filename>patch.zip</filename>
            <type>text/plain</type>
            <size>5023</size>
            <attacher name="Mike Reed">mikerreed</attacher>
            
              <data encoding="base64">UEsDBBQACAAIAJZwiTYAAAAAAAAAAAAAAAAJABAAcGF0Y2gudHh0VVgMAH+AGkY7gBpG9gH2Ae0c
aXPbNvbz+lcg6UxKyrQuWz4TN44du95NYo+VTtvZ2cnAJCRxQ5FckLSszbq/fd8DSBC8ZNo52t2p
Pkg8HoB34V0AdO477Haf/MyujwPOescz6k/Zm2C69uLzP2sbGxvVnv9icHbjRm7gk2F/t79prq2v
r9eBLQL+0fWnxA7Cpbn28iXZGFibZH1gbe2Rly/X1of9/s5Gf2ujv0cIZ8wh5Pnc/cg4Xr+czqnr
de1gfri2vrZO0s8VjMwWAHq9JO8uXl2c/EqMi4vL8ROzq4P9fHT17vzd2T7AkPevx+/J8dH49Zgc
nZy8PiEXV+T4x6N3Z69P9CbHnNGYke+YFzFiezSJWETigFDPCxYknjHy3Kb+DY0OCfPYnPkxvr1m
xJ2H6b3rk5jxeZR3GkxEyzDgMb32GDnjNJy5dnQc+DG7jbuzLnk/cyNiC6YRJ4Ax/SAGboQetZlo
zG7dKAY25r3agcPIJODk8s3R+9OLq7fG8ZlpAXCQTGfwQ2MASTyHzGgYMp94QBi3SBTId0CR6CLv
MKTxLIIekVQUWIw4+WyRI76gyy45BxIjaA4dRcl0ygCtGyb7RNIB10kSJ1zreMEIh17FO9dhFBkC
gwE6fm/KqeNKtsWBgChxhzguZ3bsLYnxzySK8149UBKgwAu4ifyD4ReCXM7mASAUBXOWcZ46DigL
jMKXYQADRd28m/xKlwG0ABoJ8D8GFs9JFDLbnbg2mTHqME4mLrDDBh5Cv5cpUIZ4d1bqUwDDL4zM
fMQEKJ0BI2q6j5chc9gkAjZnCoWiyJQu75izfyXAGOhrgXKwZ6IptptIwaWEoKhsm4Uxcyxyjq/8
j2ROlxlrqnr1nTvpfQd4uhMyDxyh/WFy7QFyCl3JhCjVL9B+5rlz1wcFE1MShS0VKIg0NRAIZnJO
VUv2VJi1HTKL517vWFB8lqpH1w7D/RzGSO3M/n4RrHxvtmrz22MahbnUK63qSZg1QVzKuXAPjSlU
6XYVsqrFbw9vkpFX06YW90birlDlOahDOp+HJ410wltO7Xi1HFKgFrRUR97fh6noPbRNFPPgI3vM
SFdguB432mNaOpwuzud0yhqFNY6XHiuz/3T4atVIos3+PvgQbzkWuB0Lm9uyySmwodIgRerH92/f
yBavpalr1IwKJCgodZtUpAbaFn79BDiU86yIUabw6JGEGe9V3DTArxE9XDnyHQ5G7Gcm7F0MoRB5
HvIALl4uwDjH6Hidrs/iwzWylg1ViF7+mqD1JWeU2y7trp0Xw7gGQ/jFg7qGcUoh3rAY4jU2qgZ8
m31rm6zD9y5GfMAK8DGFsAWf+LaXgE98fgRq49o0hmHHjN+4Not6Nc+6M/CGIk6Dn6zx04rMnkLX
wpnhsD6dsyjEkColgnyS+O0iflsSP7LapRh24EcxOfUCKdF9Mv+Ar6hnTCAoYhCCzT+EfSPsy6uB
EQ7EVRQHYTSGUIo5GqRHo3gMb4y+WccW/IjGMxjCnyJURnT2quyIZE8pzZ/WyJ0gcWsbSRx9Lokx
T5op5H2Dy2d8YPA/AtWjLaR6u2/t1VFd8vuGKVrWo3N8NpbIXEHcTyNmKOzMgwJy0Nqoomfmpqak
ouApINO5LJNT08VBTuAdaLPIpPaG1haBFGpgDbeQRLCJFTInru8IZk+8AKLkG+olTBIFJirhviaP
A9n1OvLgSYEJ62UMO5VxKiKBVp8k3dXG4ZS8qBHjQRYJIhvf/fTmDXnxAmBT9n3Ssx9UUUFRhzg0
ptCdoT80U93r4ksDhZQ1RR6RvJ8Ebl9kmtqN3H8zAa3BC4nKCaDJET+CiopAIbDNCL4SrXSp9uVM
kTNHzhVLEGBJXHRMc61qPeAb12eUVwYMmwepCoEgy1OIO/mTaop4fIf6LvQQ3OEd6fWUWW3jv2bf
xHvNHu67ZrWeayg813CF50pTNgKBW2LHuaHo6DZjclDjrKqJYytvNRLedCRxqoWqxTP76FipqCd9
ZJSMWcPcrUz0Ax3v7JMxBKM/NC4p+jsjRH9n70ugr4xwG7TrrI1CW+g63K9QYS1N+5o6rA3TWokL
bapavCs0Zrfg/OvTSeOY2jPmiDSiWQo5JwWg8L3CMRekkENlnaNBN60i0xHOzgc1tGstEuAshAD+
FyP9lWTtbSJZeyPduzfkvPf4djFc7tkL1K3071ka2tK9Z9hUOyipohylyosKvzYOIQ9kEwMrKtCJ
CAq29zAoGOxsWcOR4MxZOgpOmRKbZGIkb8XEy6ZxXQzQ6xDy/uLkQlI7MElII6zokCxnQrcsinYB
FwU4LDdNEcAGxhKM4hnxGZNVpYjJ0qadcI5eZ05j7t6KClYUWIqjCybqVdhM1KJwSL2ZAXhSf2mS
IksR1o1FvdONYXyfoCDwGtChPmRfies5ahQqylGBzyzkvaxmRnmVzcB6LKIg07Yg4Wo4My0mDk3y
DnGkkOChkr7Hqt88K9KeMJt6ApsFE9iAJnMWIQGqogxj4FQPJuSpH2xIVX+6tt7p5dFXKrdOWYzl
mZaHXnogVVE78uwZKalZOdASjzvExR8RJxWUTzwuRlcwnqt1VQ0zsrFXBzIZJaIvq9jXYz/KjpAf
JF37+5qs9rNn4xjCHXuGD7/wwL+2Htisjb8qTKyEYy3811eNwNQgD/Zd9fHXQMRfg69fOXhsMCYC
RMgzHxvNpK4nD8WkGzTTDOdTVfQC4IDcNYY8ykhUrMJB2fcCBvl07hDdEddgoL0+UDnotuDA9vYK
DuAn5O4NeJr9VdyQA2o8KRN9P8k1M+QeksWYRdrKGF0HgZcbj4MVc6y+2v01J1z9iK1nX1Pz6lTc
2hFFsh1rsLdC1ZMIW+UvsRb7Du8OGmKKKIbJadeE66XVAEOrLXcgt4Cf3MkVU7kOxiMO+BcBtXE4
1fIU3ZoKqB/Ez8ZhNakBu4yOU5rYEppK34rLES2QzCcnjXMUw3yGFvJtgPkBv3P81FwuoJd7gOb1
gaY3RqVejoYAb828/icfGIXnsr4Hk3ocU/ujMUj1ZEskeFujXWswQE25CVxnBVq4UGJoRgA/aulA
t1y5zUxbpwAzw87Zk74yzKxF0UwW5SP4D/gbZnf+AfGQCyRTlquKNAA4yjOxQF5ogg9SuAW0xuUF
A591r4PElzmqLVGRfW0cTjKUEcyq6HhkWmWNisy6wt/Wjqjnbu1tWYPNFkyWq0q1bJaLOisZrUC+
EKslNo9n9ilW+JC3RDAaO69hewosQbquP8EdEEbeoef67GfXgWE6pN8dTcyyKGVLTXpRzodHyq+Y
3SGDshAcryGZC+xkLqwP6AoHuwnz/D4AwIvFuIYf4TXuWDmh0ew6oNx5BfNyAb/HwRwQdq9dz42X
byEnAaHJ8GVTVMhHo732k1Vw97HzVTSuUyKL4DaPLzRrcwXBTqGBemDcWmRpgYwdlN+MudNZXBF8
iok+aUVbfP4Zk3a0PUAur4/24He79ayFoSVTdPVW+pxrcQ9S0JR9RRVOm5jKBVejr16PnJ7/8vY1
+BTcThLilh+Rt2a+M3qSq27tRNZ8mGZlGiyMBFAzSmOuIqdUdnmMNVnVfXsxrutivFdiLMbyZLBI
F1tSPZM3Utuyu2sv4XIS7mzvWjtYn9tsZ8zVQr9kY67sUZBwW5ALDALyOUr/fXDCMO+5dG+BnUbE
7SttouWNHRbFq5s6EqCiZFlLwaxa9YIOFdJGXQHBUsNbGhWWJuWpF1xTDw1ZELlxuSoH+iv2FEWM
zSO5NYyS62RKJu4tASO7YJ7XVaBgTL+PRf1plu7qi2JHbqjD0gyYUIVOr4ANZIuiZrUkFALeyKae
rAfJ0pVSu3tpVaRKYdxLZ3sFzIdujOoyBbzNLrIqsYzwd3d3ZUH1YVp4l83qUjV1VS21VoM0Hl5M
JpHNGfMzL6G8YGEjB7L0mWKlpqU645pzNrUr5mumaWqQ1pmZ1mLFupQwGFoR5KkdQeLFI8ZlAUMV
RxbxpHdJIxDl5DLmWANZmY/hIunp8FVqxhLfjfNEJk1ODNyAY+ArCKCGo5FZTkUaUsTCJiHtJl2+
BW8BtD5Lt3ZKzdxNC/27Jb1s2JxkiCJOMUTBj2GITsnhIdmFuIr0b09PTfSbo1G3b9XAS/AWgHnH
w61KzzWLakLJpfaK8E1HXn5L8usqNiIU4Ix+1GIsud1h0BcLPYP+3h+WU/MP1Atn9FEs0Qbp90/F
xyT/ETvYjKxf8vw5YPxgvu1YgyEwbrCbVjcex7k8ijpJ97jGMy62Y2dWcMMFMxSiNYX5Vd7pfHR5
3l1VHsNPnpMxDF0KGCnu1QTX4FgA+g27YZ51jxA+FW/xg9YA22MkLZitOtNL/+2kOKcQkZ29OjKw
D4vo37ogTbPc9V07kYqlJhxg/3cVDmDQXjYcd2cjV8HX4QXEhuw+MbXksuQpDGBaSnYwirrDocwa
1rfn9fHbX/8GzBYTaUvU6wej1QZIbQo1Ui7/L5nqHPnPMNQjsXQ92Nn8w/KpvfKVGfL1zPR2X5rp
3eFqM30P334HM51j9Ec00mUJ3meZ/9cNc1tpfK5ZLvP1Ubb4Eaa4Ltep3Wz/dTKe2qFa5D0N7WoO
EO4o8znoKzvQdEjAyDWmpih5ohLmsFYLwvpaCIdXbprSap0WUt/C+2JFU1aAi2msqU/qsCEDLjey
SN/SqptcTc67av0R+I5sGw6GWoLf4rDEmuIY7uTDhC6j0FZPMjLL+IExwo01pUlrXLvxnIYZ4Qdr
RZlk3ZehirvLKgNVtpNIQio8XFhklrGp3A3MW6zqGIKlY9wMvAAnmfiy1pOWDmfaox9lCfmeckOL
0yVffC62GHP1pGzVQU1tQiwpwLeYm+UaxLvAR1A8TyqKEKUKRTpkc31i9Y4NrfrQYqdupjrlntLn
QqReoZuj86uL1Ab1xQrcYNC3dpoXxLOPmGqoaa89zw2jrNZx7otp+0w3IgoUsLhht5eBt5wGvoEb
0z/ExE/ml+IIq0XUKQ0ai0cdS25UiGZ4LPPIj13quRRr5fLgRdMKvPLDnQ5BjyULovJEKnPkQpxc
1scXQYh7aainVgZwr19a+rc0OHWOuLSBnTMbhODbDDf69RYz5udrDL20n0iUV+Wp3fRUcHmHIR50
ZpXd8RRXxGJxNJVCvwGhC7oswgxMUd/Nzx1P8usnYKwSzys2GMoGKWoIn13Wgm9KcBkDpweiy8hr
5856+bUQvFog1tZCreruCKuyE0EPylCSMiX8U5a/oyy15eLPlWbNvBQrm3/K8hvOS7l2nVtdYbq/
3OT8U6DffnI2iFSuemiLxQ+UcVHaV3K9pO7vJDxxXGsjY0yX/AQk1R4INIkQ4TJIUGZFVjiBz8jC
Bdvuxt3iKzzVdoLH4yCt/iTucKOFg3m9SGplSityTXJHQsbl32TUM65xr17zAbRykPKM4IG0mqeD
z9tqrR39UzT/ffQPS1RF1Jm31nKRp/3+n+RSOolYLxfJP97/ErIoSTfr+5vIucQYacHrpFdh2YO0
JLVPVe3IN2k+WDlWyFVtHa05JqEf03gch9MzCHj44CrxGJnht1V5fIPfbXicYVZnJ4scVmU+xdgJ
teOALwmeIAqEa+KZFGRNQFn6zEuVinDyn3mul/nhGiGIBVPniDDDIkFWGuiSY2zC5aGfKAQtc/Ef
jwCtktSYx+LM9aaDS/nXlmtMNZQG/30k5VTsOcA/xqF+AIC84shWK0gpb+2QhsIHzpF0RxJeFne/
ZdI4lrwTmknVgS7Jf8nT+t675CSjM8HdIt6yEpOksksjjewAl+Li2J27HuUZy86z7TLXSSzrwvin
SRHu2Sl2C/Dpxi3RbzrKhAdzYse38qLwB1y406dkj/HQmdxBgiqAG6stcVYMIqQoSuaoM+IvpvBP
sOSffimp4n80cTWsOtfFnBLxy7q/t2oQrCoCVGRYlXV8mzlU9Q8oKpbpqC1GbWxCUy/PtE01WoVF
aU2PHHGbpIU0YkBYJvTkOuCgBxtoWhNxTPB4PDYJ/otXtsUwkmEYtqJSePNAFH5L5RAZrMEgpbqJ
1GOYBTw+8qdorvCe4uU4pL5eVln7L1BLBwj2vH5rrxEAACNPAABQSwMEFAAIAAgA222JNgAAAAAA
AAAAAAAAABIAEABQbGF0Zm9ybUdyYXBoaWNzLmhVWAwAf4AaRg18Gkb2AQAAbY+xagMxEER7fcXA
dSbYH+A2JK2L9EGnHXELutWhlYv7e+tMQkLIljPD25lJswkzbiX2XNv63uK2aPJPCdPQ1fifFS4n
4GNRR9ZCGCmOXtH3jQetNghTiY3oC/2H8VYrfF/nWvwFXg93DxiXomEmGjMbLVGgdrjY7nPRhIVR
2M54ZY9afGQXNTkS6/M9rPYnaEDUUrnLN+Kr5DmcLmFUcv89SJTWr3/0W+ydza4hTDTRHMIDUEsH
CFOpIOe0AAAAJgEAAFBLAQIVAxQACAAIAJZwiTb2vH5rrxEAACNPAAAJAAwAAAAAAAAAAECkgQAA
AABwYXRjaC50eHRVWAgAf4AaRjuAGkZQSwECFQMUAAgACADbbYk2U6kg57QAAAAmAQAAEgAMAAAA
AAAAAABAJIH2EQAAUGxhdGZvcm1HcmFwaGljcy5oVVgIAH+AGkYNfBpGUEsFBgAAAAACAAIAjwAA
APoSAAAAAA==
</data>
<flag name="review"
          id="5754"
          type_id="1"
          status="-"
          setter="mrowe"
    />
          </attachment>
      

    </bug>

</bugzilla>