133116 2014-05-20 04:10:01 -0700 Double-tap zoom does not take obscuring insets into account 2014-05-20 06:57:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned benjamin enrica oldest_to_newest 1010451 0 koivisto 2014-05-20 04:10:01 -0700 We zoom as if there was nothing obscuring the view. 1010452 1 koivisto 2014-05-20 04:10:31 -0700 <rdar://problem/16765604> 1010473 2 231765 koivisto 2014-05-20 06:23:48 -0700 Created attachment 231765 patch 1010477 3 koivisto 2014-05-20 06:57:36 -0700 https://trac.webkit.org/r169109 231765 2014-05-20 06:23:48 -0700 2014-05-20 06:42:26 -0700 patch zoom-to-rect-2.patch text/plain 3683 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEwNSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEb3VibGUtdGFwIHpvb20gZG9l cyBub3QgdGFrZSBvYnNjdXJpbmcgaW5zZXRzIGludG8gYWNjb3VudAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMTE2CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xNjc2NTYwND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAo LVtXS1dlYlZpZXcgX3pvb21Ub1JlY3Q6V2ViQ29yZTo6YXRTY2FsZTpvcmlnaW46V2ViQ29yZTo6 XSk6CisgICAgICAgIAorICAgICAgICAgICAgQ29tcHV0ZSB0aGUgem9vbSB0YXJnZXQgdGFraW5n IGluc2V0cyBpbnRvIGFjY291bnQuCisKIDIwMTQtMDUtMTkgIEdhdmluIEJhcnJhY2xvdWdoICA8 YmFyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0Mi9pT1M6IHBhcmVudGVkIHZp ZXcgc2hvdWxkIGJlIGNvbnNpZGVyZWQgaGlkZGVuIGlmIGFwcCBpcyBiYWNrZ3JvdW5kZWQKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CShyZXZpc2lvbiAxNjkwMTUpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNTY3LDE5ICs1NjcsMzEgQEAgLSAodm9p ZClfem9vbVRvUG9pbnQ6KFdlYkNvcmU6OkZsb2F0UG9pbgogCiAtICh2b2lkKV96b29tVG9SZWN0 OihXZWJDb3JlOjpGbG9hdFJlY3QpdGFyZ2V0UmVjdCBhdFNjYWxlOihkb3VibGUpc2NhbGUgb3Jp Z2luOihXZWJDb3JlOjpGbG9hdFBvaW50KW9yaWdpbgogewotICAgIFdlYkNvcmU6OkZsb2F0U2l6 ZSB1bm9ic2N1cmVkQ29udGVudFNpemUoW3NlbGYgX2NvbnRlbnRSZWN0Rm9yVXNlckludGVyYWN0 aW9uXS5zaXplKTsKLSAgICBXZWJDb3JlOjpGbG9hdFNpemUgdGFyZ2V0UmVjdFNpemVBZnRlclpv b20gPSB0YXJnZXRSZWN0LnNpemUoKTsKLSAgICB0YXJnZXRSZWN0U2l6ZUFmdGVyWm9vbS5zY2Fs ZShzY2FsZSk7Ci0KLSAgICAvLyBDZW50ZXIgdGhlIHRhcmdldCByZWN0IGluIHRoZSBzY3JvbGwg dmlldy4KLSAgICAvLyBJZiB0aGUgdGFyZ2V0IGRvZXNuJ3QgZml0IGluIHRoZSBzY3JvbGwgdmll dywgY2VudGVyIG9uIHRoZSBnZXN0dXJlIGxvY2F0aW9uIGluc3RlYWQuCi0gICAgV2ViQ29yZTo6 RmxvYXRQb2ludCB6b29tQ2VudGVyID0gdGFyZ2V0UmVjdC5jZW50ZXIoKTsKLQotICAgIGlmICh0 YXJnZXRSZWN0U2l6ZUFmdGVyWm9vbS53aWR0aCgpID4gdW5vYnNjdXJlZENvbnRlbnRTaXplLndp ZHRoKCkpCi0gICAgICAgIHpvb21DZW50ZXIuc2V0WChvcmlnaW4ueCgpKTsKLSAgICBpZiAodGFy Z2V0UmVjdFNpemVBZnRlclpvb20uaGVpZ2h0KCkgPiB1bm9ic2N1cmVkQ29udGVudFNpemUuaGVp Z2h0KCkpCi0gICAgICAgIHpvb21DZW50ZXIuc2V0WShvcmlnaW4ueSgpKTsKKyAgICAvLyBGSU1Y RTogU29tZSBvZiB0aGlzIGNvdWxkIGJlIHNoYXJlZCB3aXRoIF9zY3JvbGxUb1JlY3QuCisgICAg Y29uc3QgZG91YmxlIHZpc2libGVSZWN0U2NhbGVDaGFuZ2UgPSBjb250ZW50Wm9vbVNjYWxlKHNl bGYpIC8gc2NhbGU7CisgICAgY29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0IHZpc2libGVSZWN0KFtz ZWxmIGNvbnZlcnRSZWN0OnNlbGYuYm91bmRzIHRvVmlldzpfY29udGVudFZpZXcuZ2V0KCldKTsK KyAgICBjb25zdCBXZWJDb3JlOjpGbG9hdFJlY3QgdW5vYnNjdXJlZFJlY3QoW3NlbGYgX2NvbnRl bnRSZWN0Rm9yVXNlckludGVyYWN0aW9uXSk7CisKKyAgICBjb25zdCBXZWJDb3JlOjpGbG9hdFNp emUgdG9wTGVmdE9ic2N1cmVkSW5zZXRBZnRlclpvb20oKHVub2JzY3VyZWRSZWN0Lm1pblhNaW5Z Q29ybmVyKCkgLSB2aXNpYmxlUmVjdC5taW5YTWluWUNvcm5lcigpKSAqIHZpc2libGVSZWN0U2Nh bGVDaGFuZ2UpOworICAgIGNvbnN0IFdlYkNvcmU6OkZsb2F0U2l6ZSBib3R0b21SaWdodE9ic2N1 cmVkSW5zZXRBZnRlclpvb20oKHZpc2libGVSZWN0Lm1heFhNYXhZQ29ybmVyKCkgLSB1bm9ic2N1 cmVkUmVjdC5tYXhYTWF4WUNvcm5lcigpKSAqIHZpc2libGVSZWN0U2NhbGVDaGFuZ2UpOworCisg ICAgY29uc3QgV2ViQ29yZTo6RmxvYXRTaXplIHVub2JzY3VyZWRTaXplQWZ0ZXJab29tID0gdW5v YnNjdXJlZFJlY3Quc2l6ZSgpICogdmlzaWJsZVJlY3RTY2FsZUNoYW5nZTsKKworICAgIC8vIENl bnRlciB0byB0aGUgdGFyZ2V0IHJlY3QuCisgICAgV2ViQ29yZTo6RmxvYXRQb2ludCB1bm9ic2N1 cmVkT2Zmc2V0QWZ0ZXJab29tID0gdGFyZ2V0UmVjdC5sb2NhdGlvbigpIC0gKHVub2JzY3VyZWRT aXplQWZ0ZXJab29tIC0gdGFyZ2V0UmVjdC5zaXplKCkpICogMC41OworCisgICAgLy8gQ2VudGVy IHRvIHRoZSB0YXAgcG9pbnQgaW5zdGVhZCBpbiBjYXNlIHRoZSB0YXJnZXQgcmVjdCB3b24ndCBm aXQgaW4gYSBkaXJlY3Rpb24uCisgICAgaWYgKHRhcmdldFJlY3Qud2lkdGgoKSA+IHVub2JzY3Vy ZWRTaXplQWZ0ZXJab29tLndpZHRoKCkpCisgICAgICAgIHVub2JzY3VyZWRPZmZzZXRBZnRlclpv b20uc2V0WChvcmlnaW4ueCgpIC0gdW5vYnNjdXJlZFNpemVBZnRlclpvb20ud2lkdGgoKSAvIDIp OworICAgIGlmICh0YXJnZXRSZWN0LmhlaWdodCgpID4gdW5vYnNjdXJlZFNpemVBZnRlclpvb20u aGVpZ2h0KCkpCisgICAgICAgIHVub2JzY3VyZWRPZmZzZXRBZnRlclpvb20uc2V0WShvcmlnaW4u eSgpIC0gdW5vYnNjdXJlZFNpemVBZnRlclpvb20uaGVpZ2h0KCkgLyAyKTsKKworICAgIC8vIFdl IGhhdmUgY29tcHV0ZWQgd2hlcmUgd2Ugd2FudCB0aGUgdW5vYnNjdXJlZCB2aXNpYmxlIHJlY3Qg dG8gYmUuIE5vdyBhZGp1c3QgZm9yIHRoZSBvYnNjdXJpbmcgaW5zZXRzLgorICAgIFdlYkNvcmU6 OkZsb2F0UmVjdCB2aXNpYmxlUmVjdEFmdGVyWm9vbSh1bm9ic2N1cmVkT2Zmc2V0QWZ0ZXJab29t LCB1bm9ic2N1cmVkU2l6ZUFmdGVyWm9vbSk7CisgICAgdmlzaWJsZVJlY3RBZnRlclpvb20ubW92 ZSgtdG9wTGVmdE9ic2N1cmVkSW5zZXRBZnRlclpvb20pOworICAgIHZpc2libGVSZWN0QWZ0ZXJa b29tLmV4cGFuZCh0b3BMZWZ0T2JzY3VyZWRJbnNldEFmdGVyWm9vbSArIGJvdHRvbVJpZ2h0T2Jz Y3VyZWRJbnNldEFmdGVyWm9vbSk7CiAKKyAgICBXZWJDb3JlOjpGbG9hdFBvaW50IHpvb21DZW50 ZXIgPSB2aXNpYmxlUmVjdEFmdGVyWm9vbS5jZW50ZXIoKTsKICAgICBbc2VsZiBfem9vbVRvUG9p bnQ6em9vbUNlbnRlciBhdFNjYWxlOnNjYWxlXTsKIH0KIAo=