133110 2014-05-20 00:41:29 -0700 [WK2] Fixed layout size of UIProcess isn't sync with WebProcess while viewport meta tag is changed. 2014-05-20 00:42:52 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 gyuyoung.kim gyuyoung.kim oldest_to_newest 1010424 0 gyuyoung.kim 2014-05-20 00:41:29 -0700 When viewport attribute is updated, WebPage::sendViewportAttributesChanged() changes fixed layout size of WebCore(ScrollView). However, it doesn't update fixed layout size with new fixed layout size for UIProcess. It can cause that UIProcess API (e.g. WKPageSetFixedLayoutSize()) can't change fixed layout size because WebPageProxy::m_fixedLayoutSize wasn't updated. void WebPage::sendViewportAttributesChanged() { ... // This also takes care of the relayout. setFixedLayoutSize(roundedIntSize(attr.layoutSize)); ... } void WebPage::setFixedLayoutSize(const IntSize& size) { FrameView* view = mainFrameView(); ... view->setFixedLayoutSize(size); => Change WebCore's fixed layout size ! ... } If WebPageProxy::m_fixedLayoutSize wasn't updated, WKPageSetFixedLayoutSize() can't update fixed layout size for WebCore. void WebPageProxy::setFixedLayoutSize(const IntSize& size) { ... if (size == m_fixedLayoutSize) return; m_fixedLayoutSize = size; m_process->send(Messages::WebPage::SetFixedLayoutSize(size), m_pageID); } 1010425 1 231756 gyuyoung.kim 2014-05-20 00:42:52 -0700 Created attachment 231756 WIP 231756 2014-05-20 00:42:52 -0700 2014-05-20 00:42:52 -0700 WIP bug-133110-20140520164228.patch text/plain 1460 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDE5MDNlZDQ2NmJjYzI2 NWQzMTJjNDRmYThhYjRjZDIzYzUxODNhZC4uYTEyNjQ2OWNjNWRmYjIxNTEzMzU2OGJiNGE4NzJh MjdhMzFkZWNkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1LTIwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4 ZWQgbGF5b3V0IHNpemUgb2YgVUlQcm9jZXNzIGlzbid0IHN5bmMgd2l0aCBXZWJQcm9jZXNzIHdo aWxlIHZpZXdwb3J0IG1ldGEgdGFnIGlzIGNoYW5nZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzExMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVz KToKKwogMjAxNC0wNS0xOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWJLaXQyL2lPUzogcGFyZW50ZWQgdmlldyBzaG91bGQgYmUgY29uc2lk ZXJlZCBoaWRkZW4gaWYgYXBwIGlzIGJhY2tncm91bmRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA3ZjdkYTJhOWEyMDhhNDhiMWE0OTMzOGRhOTgwNGU4 ZmVlNDIwZDQ3Li4yNDMxMDcyMTA1NmVmMTRjMGE1NGZkYjQ3ZGNmZTVhOWZhMmIzZDI5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtMzA2Nyw2ICszMDY3 LDkgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFJlbmRlckZyYW1lKGNvbnN0IFdlYkNvcmU6Oklu dFNpemUmIGNvbnRlbnRzU2l6ZSwgY29uc3QgV2UKIAogdm9pZCBXZWJQYWdlUHJveHk6OmRpZENo YW5nZVZpZXdwb3J0UHJvcGVydGllcyhjb25zdCBWaWV3cG9ydEF0dHJpYnV0ZXMmIGF0dHIpCiB7 CisgICAgaWYgKG1fdXNlRml4ZWRMYXlvdXQgJiYgbV9maXhlZExheW91dFNpemUgIT0gcm91bmRl ZEludFNpemUoYXR0ci5sYXlvdXRTaXplKSkKKyAgICAgICAgbV9maXhlZExheW91dFNpemUgPSBy b3VuZGVkSW50U2l6ZShhdHRyLmxheW91dFNpemUpOworCiAgICAgbV9wYWdlQ2xpZW50LmRpZENo YW5nZVZpZXdwb3J0UHJvcGVydGllcyhhdHRyKTsKIH0KIAo=