133103 2014-05-19 18:34:21 -0700 operationOptimize() should defer the GC for a while 2014-05-19 19:04:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg mmirman msaboff oliver webkit-bug-importer oldest_to_newest 1010385 0 mark.lam 2014-05-19 18:34:21 -0700 Currently, operationOptimize() only defers the GC until its end. As a result, a GC may be triggered before we return from operationOptimize(), and it may jettison the optimize codeBlock that we're planning to OSR enter into when we return from this function. This is because the OSR entry on-ramp code hasn't been executed yet, and hence, there is not yet a reference to this new codeBlock from the stack, and there won't be until we've had a chance to return out of operationOptimize() and run the OSR entry on-ramp code. This issue can be fixed by using DeferGCForAWhile instead of DeferGC. This ensures that the GC will be deferred until after the OSR entry on-ramp can be executed. 1010386 1 mark.lam 2014-05-19 18:35:52 -0700 <rdar://problem/16738067> 1010391 2 231747 mark.lam 2014-05-19 18:58:18 -0700 Created attachment 231747 the patch. 1010393 3 mark.lam 2014-05-19 19:04:45 -0700 Thanks. Landed in r169094: <http://trac.webkit.org/r169094> 231747 2014-05-19 18:58:18 -0700 2014-05-19 19:01:10 -0700 the patch. bug-133103.patch text/plain 3176 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY5MDkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTA1LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBv cGVyYXRpb25PcHRpbWl6ZSgpIHNob3VsZCBkZWZlciB0aGUgR0MgZm9yIGEgd2hpbGUuCisgICAg ICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMzMxMDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBvcGVyYXRpb25PcHRpbWl6ZSgp IG9ubHkgZGVmZXJzIHRoZSBHQyB1bnRpbCBpdHMgZW5kLiAgQXMgYSByZXN1bHQsCisgICAgICAg IGEgR0MgbWF5IGJlIHRyaWdnZXJlZCBqdXN0IGJlZm9yZSB3ZSByZXR1cm4gZnJvbSBvcGVyYXRp b25PcHRpbWl6ZSgpLCBhbmQgaXQgbWF5CisgICAgICAgIGpldHRpc29uIHRoZSBvcHRpbWl6ZSBj b2RlQmxvY2sgdGhhdCB3ZSdyZSBwbGFubmluZyB0byBPU1IgZW50ZXIgaW50byB3aGVuIHdlCisg ICAgICAgIHJldHVybiBmcm9tIHRoaXMgZnVuY3Rpb24uICBUaGlzIGlzIGJlY2F1c2UgdGhlIE9T UiBlbnRyeSBvbi1yYW1wIGNvZGUgaGFzbid0CisgICAgICAgIGJlZW4gZXhlY3V0ZWQgeWV0LCBh bmQgaGVuY2UsIHRoZXJlIGlzIG5vdCB5ZXQgYSByZWZlcmVuY2UgdG8gdGhpcyBuZXcgY29kZUJs b2NrCisgICAgICAgIGZyb20gdGhlIHN0YWNrLCBhbmQgdGhlcmUgd29uJ3QgYmUgdW50aWwgd2Un dmUgaGFkIGEgY2hhbmNlIHRvIHJldHVybiBvdXQgb2YKKyAgICAgICAgb3BlcmF0aW9uT3B0aW1p emUoKSB0byBydW4gdGhlIE9TUiBlbnRyeSBvbi1yYW1wIGNvZGUuCisKKyAgICAgICAgVGhpcyBp c3N1ZSBpcyBub3cgZml4ZWQgYnkgdXNpbmcgRGVmZXJHQ0ZvckFXaGlsZSBpbnN0ZWFkIG9mIERl ZmVyR0MuICBUaGlzCisgICAgICAgIGVuc3VyZXMgdGhhdCB0aGUgR0Mgd2lsbCBiZSBkZWZlcnJl ZCB1bnRpbCBhZnRlciB0aGUgT1NSIGVudHJ5IG9uLXJhbXAgY2FuIGJlCisgICAgICAgIGV4ZWN1 dGVkLgorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgorCiAyMDE0LTA1LTE5ICBU YW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmluZyBzb21lIGNo ZWNrLXdlYmtpdC1zdHlsZSB3YXJuaW5ncyBmcm9tIC4vZGZnCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAJKHJldmlzaW9uIDE2OTA4OSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEwMTksMjUgKzEwMTksMjEgQEAgU2xvd1BhdGhSZXR1cm5UeXBlIEpJVF9PUEVSQVRJT04g b3BlcmF0aQogICAgIFZNJiB2bSA9IGV4ZWMtPnZtKCk7CiAgICAgTmF0aXZlQ2FsbEZyYW1lVHJh Y2VyIHRyYWNlcigmdm0sIGV4ZWMpOwogCi0gICAgLy8gRGVmZXIgR0Mgc28gdGhhdCBpdCBkb2Vz bid0IHJ1biBiZXR3ZWVuIHdoZW4gd2UgZW50ZXIgaW50byB0aGlzIHNsb3cgcGF0aCBhbmQKLSAg ICAvLyB3aGVuIHdlIGZpZ3VyZSBvdXQgdGhlIHN0YXRlIG9mIG91ciBjb2RlIGJsb2NrLiBUaGlz IHByZXZlbnRzIGEgbnVtYmVyIG9mCi0gICAgLy8gYXdrd2FyZCByZWVudHJhbmN5IHNjZW5hcmlv cywgaW5jbHVkaW5nOgorICAgIC8vIERlZmVyIEdDIGZvciBhIHdoaWxlIHNvIHRoYXQgaXQgZG9l c24ndCBydW4gYmV0d2VlbiB3aGVuIHdlIGVudGVyIGludG8gdGhpcworICAgIC8vIHNsb3cgcGF0 aCBhbmQgd2hlbiB3ZSBmaWd1cmUgb3V0IHRoZSBzdGF0ZSBvZiBvdXIgY29kZSBibG9jay4gVGhp cyBwcmV2ZW50cworICAgIC8vIGEgbnVtYmVyIG9mIGF3a3dhcmQgcmVlbnRyYW5jeSBzY2VuYXJp b3MsIGluY2x1ZGluZzoKICAgICAvLwogICAgIC8vIC0gVGhlIG9wdGltaXplZCB2ZXJzaW9uIG9m IG91ciBjb2RlIGJsb2NrIGJlaW5nIGpldHRpc29uZWQgYnkgR0MgcmlnaHQgYWZ0ZXIKLSAgICAv LyAgIHdlIGNvbmNsdWRlZCB0aGF0IHdlIHdhbnRlZCB0byB1c2UgaXQuCisgICAgLy8gICB3ZSBj b25jbHVkZWQgdGhhdCB3ZSB3YW50ZWQgdG8gdXNlIGl0LCBidXQgaGF2ZSBub3QgcGxhbnRlZCBp dCBpbnRvIHRoZSBKUworICAgIC8vICAgc3RhY2sgeWV0LgogICAgIC8vCiAgICAgLy8gLSBBbiBv cHRpbWl6ZWQgdmVyc2lvbiBvZiBvdXIgY29kZSBibG9jayBiZWluZyBpbnN0YWxsZWQganVzdCBh cyB3ZSBkZWNpZGVkCiAgICAgLy8gICB0aGF0IGl0IHdhc24ndCByZWFkeSB5ZXQuCiAgICAgLy8K LSAgICAvLyBUaGlzIHN0aWxsIGxlYXZlcyB0aGUgZm9sbG93aW5nOiBhbnl0aW1lIHdlIHJldHVy biBmcm9tIGN0aV9vcHRpbWl6ZSwgd2UgbWF5Ci0gICAgLy8gR0MsIGFuZCB0aGUgR0MgbWF5IGVp dGhlciBqZXR0aXNvbiB0aGUgb3B0aW1pemVkIHZlcnNpb24gb2Ygb3VyIGNvZGUgYmxvY2ssCi0g ICAgLy8gb3IgaXQgbWF5IGluc3RhbGwgdGhlIG9wdGltaXplZCB2ZXJzaW9uIG9mIG91ciBjb2Rl IGJsb2NrIGV2ZW4gdGhvdWdoIHdlCi0gICAgLy8gY29uY2x1ZGVkIHRoYXQgaXQgd2Fzbid0IHJl YWR5IHlldC4KLSAgICAvLwogICAgIC8vIE5vdGUgdGhhdCBqZXR0aXNvbmluZyB3b24ndCBoYXBw ZW4gaWYgd2UgYWxyZWFkeSBpbml0aWF0ZWQgT1NSLCBiZWNhdXNlIGluCiAgICAgLy8gdGhhdCBj YXNlIHdlIHdvdWxkIGhhdmUgYWxyZWFkeSBwbGFudGVkIHRoZSBvcHRpbWl6ZWQgY29kZSBibG9j ayBpbnRvIHRoZSBKUwogICAgIC8vIHN0YWNrLgotICAgIERlZmVyR0MgZGVmZXJHQyh2bS5oZWFw KTsKKyAgICBEZWZlckdDRm9yQVdoaWxlIGRlZmVyR0Modm0uaGVhcCk7CiAgICAgCiAgICAgQ29k ZUJsb2NrKiBjb2RlQmxvY2sgPSBleGVjLT5jb2RlQmxvY2soKTsKIAo=