133099 2014-05-19 17:35:59 -0700 WebKit2/iOS: parented view should be considered hidden if app is backgrounded 2014-05-19 19:23:14 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough simon.fraser oldest_to_newest 1010369 0 barraclough 2014-05-19 17:35:59 -0700 . 1010376 1 231743 barraclough 2014-05-19 17:58:54 -0700 Created attachment 231743 Fix 1010380 2 231743 simon.fraser 2014-05-19 18:09:41 -0700 Comment on attachment 231743 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review > Source/WebKit2/ChangeLog:3 > + WebKit2/iOS: view is not visible if app is not foreground. Please update from the bugzilla. Is there a relevant radar? > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111 > bool PageClientImpl::isViewWindowActive() isViewsWindowActive? > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114 > + return isViewVisible(); Not clear what the implications of isViewWindowActive are. 1010389 3 barraclough 2014-05-19 18:55:52 -0700 (In reply to comment #2) > (From update of attachment 231743 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231743&action=review > > > Source/WebKit2/ChangeLog:3 > > + WebKit2/iOS: view is not visible if app is not foreground. > > Please update from the bugzilla. fixed > Is there a relevant radar? fixed > > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:111 > > bool PageClientImpl::isViewWindowActive() > > isViewsWindowActive? I'll follow up in a separate change (per our discussion I'll probably remove outright). > > Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm:114 > > + return isViewVisible(); > > Not clear what the implications of isViewWindowActive are. Agreed! - filed https://bugs.webkit.org/show_bug.cgi?id=133098 to track this. 1010395 4 barraclough 2014-05-19 19:23:14 -0700 Transmitting file data ... Committed revision 169095. 231743 2014-05-19 17:58:54 -0700 2014-05-19 18:09:40 -0700 Fix 133099.1.patch text/plain 4501 barraclough SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTA4OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA1LTE5ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdDIvaU9T OiB2aWV3IGlzIG5vdCB2aXNpYmxlIGlmIGFwcCBpcyBub3QgZm9yZWdyb3VuZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA5OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9Q YWdlQ2xpZW50SW1wbElPUy5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6Omlz Vmlld1dpbmRvd0FjdGl2ZSk6CisgICAgICAgICAgICAtIGltcGxlbWVudGVkIGluIHRlcm1zIG9m IGlzVmlld1Zpc2libGUuCisgICAgICAgICAgICAtIEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMDk4CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJ bXBsOjppc1ZpZXdGb2N1c2VkKToKKyAgICAgICAgICAgIC0gaW1wbGVtZW50ZWQgaW4gdGVybXMg b2YgaXNWaWV3V2luZG93QWN0aXZlLgorICAgICAgICAgICAgLSBGSVhNRTogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA5OAorICAgICAgICAoV2ViS2l0OjpQYWdl Q2xpZW50SW1wbDo6aXNWaWV3VmlzaWJsZSk6CisgICAgICAgICAgICAtIHRha2UgVUlBcHBsaWNh dGlvbiBhcHBsaWNhdGlvblN0YXRlIGludG8gYWNjb3VudCBpbiBkZXRlcm1pbmluZyB2aXNpYmls aXR5LgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6aXNWaWV3VmlzaWJsZU9yT2Nj bHVkZWQpOgorICAgICAgICAgICAgLSBpbXBsZW1lbnRlZCBpbiB0ZXJtcyBvZiBpc1ZpZXdWaXNp YmxlLgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6aXNWaXN1YWxseUlkbGUpOgor ICAgICAgICAgICAgLSBpbXBsZW1lbnRlZCBpbiB0ZXJtcyBvZiBpc1ZpZXdWaXNpYmxlLgorICAg ICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBpbml0V2l0aEZyYW1lOmNvbnRleHQ6V2ViS2l0Ojpjb25maWd1cmF0aW9uOldlYktp dDo6d2ViVmlldzpdKToKKyAgICAgICAgICAgIC0gcmVnaXN0ZXIgZm9yIFVJQXBwbGljYXRpb25E aWRFbnRlckJhY2tncm91bmROb3RpZmljYXRpb24uCisgICAgICAgICgtW1dLQ29udGVudFZpZXcg X2FwcGxpY2F0aW9uRGlkRW50ZXJCYWNrZ3JvdW5kOl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9hcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91bmQ6XSk6CisgICAgICAgICAgICAtIHdo ZW4gdGhlIGFwcGxpY2F0aW9uIHN0YXRlIGNoYW5nZXMgYWxsIGZsYWdzIGV4Y2VwdCBJc0luV2lu ZG93IG1heSBiZSBhZmZlY3RlZC4KKwogMjAxNC0wNS0xOSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBh cHBsZS5jb20+CiAKICAgICAgICAgVGVsZXBob25lTnVtYmVyT3ZlcmxheUNvbnRyb2xsZXIgc2hv dWxkIHVzZSBhIG1vZGVybiBsb29wIGZvciB0ZXh0IHF1YWQgYm91bmRpbmcgCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0JKHJl dmlzaW9uIDE2ODkxOCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVu dEltcGxJT1MubW0JKHdvcmtpbmcgY29weSkKQEAgLTExMCwxNyArMTEwLDE5IEBAIEludFNpemUg UGFnZUNsaWVudEltcGw6OnZpZXdTaXplKCkKIAogYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3 V2luZG93QWN0aXZlKCkKIHsKLSAgICByZXR1cm4gW21fd2ViVmlldyB3aW5kb3ddOworICAgIC8v IEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMDk4Cisg ICAgcmV0dXJuIGlzVmlld1Zpc2libGUoKTsKIH0KIAogYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNW aWV3Rm9jdXNlZCgpCiB7Ci0gICAgcmV0dXJuIFttX3dlYlZpZXcgd2luZG93XTsKKyAgICAvLyBG SVhNRTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA5OAorICAg IHJldHVybiBpc1ZpZXdXaW5kb3dBY3RpdmUoKTsKIH0KIAogYm9vbCBQYWdlQ2xpZW50SW1wbDo6 aXNWaWV3VmlzaWJsZSgpCiB7Ci0gICAgcmV0dXJuIFttX3dlYlZpZXcgd2luZG93XTsKKyAgICBy ZXR1cm4gW21fd2ViVmlldyB3aW5kb3ddICYmIFtVSUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxpY2F0 aW9uXS5hcHBsaWNhdGlvblN0YXRlICE9IFVJQXBwbGljYXRpb25TdGF0ZUJhY2tncm91bmQ7CiB9 CiAKIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld0luV2luZG93KCkKQEAgLTEzMCwxMiArMTMy LDEyIEBAIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld0luV2luZG93KCkKIAogYm9vbCBQYWdl Q2xpZW50SW1wbDo6aXNWaWV3VmlzaWJsZU9yT2NjbHVkZWQoKQogewotICAgIHJldHVybiBbbV93 ZWJWaWV3IHdpbmRvd107CisgICAgcmV0dXJuIGlzVmlld1Zpc2libGUoKTsKIH0KIAogYm9vbCBQ YWdlQ2xpZW50SW1wbDo6aXNWaXN1YWxseUlkbGUoKQogewotICAgIHJldHVybiAhW21fd2ViVmll dyB3aW5kb3ddOworICAgIHJldHVybiAhaXNWaWV3VmlzaWJsZSgpOwogfQogCiB2b2lkIFBhZ2VD bGllbnRJbXBsOjpwcm9jZXNzRGlkRXhpdCgpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tCShyZXZpc2lvbiAxNjg5MTgpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAg LTIwOCw2ICsyMDgsOCBAQCAtIChpbnN0YW5jZXR5cGUpaW5pdFdpdGhGcmFtZTooQ0dSZWN0KWZy CiAKICAgICBzZWxmLmxheWVyLmhpdFRlc3RzQXNPcGFxdWUgPSBZRVM7CiAKKyAgICBbW05TTm90 aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6 QHNlbGVjdG9yKF9hcHBsaWNhdGlvbkRpZEVudGVyQmFja2dyb3VuZDopIG5hbWU6VUlBcHBsaWNh dGlvbkRpZEVudGVyQmFja2dyb3VuZE5vdGlmaWNhdGlvbiBvYmplY3Q6W1VJQXBwbGljYXRpb24g c2hhcmVkQXBwbGljYXRpb25dXTsKKwogICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVs dENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxlY3RvcjpAc2VsZWN0b3IoX2FwcGxpY2F0aW9u V2lsbEVudGVyRm9yZWdyb3VuZDopIG5hbWU6VUlBcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91 bmROb3RpZmljYXRpb24gb2JqZWN0OltVSUFwcGxpY2F0aW9uIHNoYXJlZEFwcGxpY2F0aW9uXV07 CiAKICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIGFkZE9ic2VydmVy OnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKF9hcHBsaWNhdGlvbldpbGxSZXNpZ25BY3RpdmU6KSBu YW1lOlVJQXBwbGljYXRpb25XaWxsUmVzaWduQWN0aXZlTm90aWZpY2F0aW9uIG9iamVjdDpbVUlB cHBsaWNhdGlvbiBzaGFyZWRBcHBsaWNhdGlvbl1dOwpAQCAtNTAyLDkgKzUwNCwxNSBAQCAtICh2 b2lkKV9hcHBsaWNhdGlvbldpbGxSZXNpZ25BY3RpdmU6KE5TCiAgICAgX3BhZ2UtPmFwcGxpY2F0 aW9uV2lsbFJlc2lnbkFjdGl2ZSgpOwogfQogCistICh2b2lkKV9hcHBsaWNhdGlvbkRpZEVudGVy QmFja2dyb3VuZDooTlNOb3RpZmljYXRpb24qKW5vdGlmaWNhdGlvbgoreworICAgIF9wYWdlLT52 aWV3U3RhdGVEaWRDaGFuZ2UoVmlld1N0YXRlOjpBbGxGbGFncyAmIH5WaWV3U3RhdGU6OklzSW5X aW5kb3cpOworfQorCiAtICh2b2lkKV9hcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91bmQ6KE5T Tm90aWZpY2F0aW9uKilub3RpZmljYXRpb24KIHsKICAgICBfcGFnZS0+YXBwbGljYXRpb25XaWxs RW50ZXJGb3JlZ3JvdW5kKCk7CisgICAgX3BhZ2UtPnZpZXdTdGF0ZURpZENoYW5nZShWaWV3U3Rh dGU6OkFsbEZsYWdzICYgflZpZXdTdGF0ZTo6SXNJbldpbmRvdyk7CiB9CiAKIC0gKHZvaWQpX2Fw cGxpY2F0aW9uRGlkQmVjb21lQWN0aXZlOihOU05vdGlmaWNhdGlvbiopbm90aWZpY2F0aW9uCg==