133089 2014-05-19 15:55:01 -0700 [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim 2014-05-19 17:44:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 129535 1 ddkilzer ddkilzer commit-queue darin dbates ddkilzer dfarler oldest_to_newest 1010322 0 ddkilzer 2014-05-19 15:55:01 -0700 If both '--sdk SDKROOT' and '--sim' are specified on the command line, we would remove the '--sdk' arguments, but leave '--sim', potentially passing it along to xcodebuild causing a build failure. This happens when 'old-run-webkit-tests --release --sim' invokes build-dumprendertree when DumpRenderTree hasn't been built yet. 1010324 1 ddkilzer 2014-05-19 15:58:40 -0700 This is technically a regression from r168910: [iOS] Support TestWebKitAPI in the iOS Simulator <http://webkit.org/b/129535> 1010326 2 231731 ddkilzer 2014-05-19 16:00:23 -0700 Created attachment 231731 Patch v1 1010371 3 231731 commit-queue 2014-05-19 17:44:31 -0700 Comment on attachment 231731 Patch v1 Clearing flags on attachment: 231731 Committed r169088: <http://trac.webkit.org/changeset/169088> 1010372 4 commit-queue 2014-05-19 17:44:34 -0700 All reviewed patches have been landed. Closing bug. 231731 2014-05-19 16:00:23 -0700 2014-05-19 17:44:31 -0700 Patch v1 bug-133089-20140519155906.patch text/plain 1949 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGJiNjRmNzE3NmY3ZDRlY2JmYmU4OWQ2M2VhY2IxMWU4 YmYxZjNjOS4uOTM5Y2M5MzhlYjQ4NGQ4MGM2YTk2M2YxN2JjNzAzZjMyMWJlZWM4MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDE0LTA1LTE5ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgW2lPU10gUkVHUkVTU0lPTiAocjE2ODkxMCk6IHdlYmtpdGRpcnMucG06IEJlIG1vcmUg Zm9yZ2l2aW5nIHdoZW4gcGFyc2luZyAtLXNkaywgLS1kZXZpY2UgYW5kIC0tc2ltCisgICAgICAg IDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMzA4OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGRldGVybWluZVhjb2RlU0RLKTogSWYgYm90aCAnLS1zZGsgU0RLUk9PVCcgYW5kICctLXNpbScg YXJlCisgICAgICAgIHNwZWNpZmllZCBvbiB0aGUgY29tbWFuZCBsaW5lLCB3ZSB3b3VsZCByZW1v dmUgdGhlICctLXNkaycKKyAgICAgICAgYXJndW1lbnRzLCBidXQgbGVhdmUgJy0tc2ltJywgcG90 ZW50aWFsbHkgcGFzc2luZyBpdCBhbG9uZyB0bworICAgICAgICB4Y29kZWJ1aWxkIGNhdXNpbmcg YSBidWlsZCBmYWlsdXJlLiAgVGhpcyBoYXBwZW5zIHdoZW4KKyAgICAgICAgJ29sZC1ydW4td2Vi a2l0LXRlc3RzIC0tcmVsZWFzZSAtLXNpbScgaW52b2tlcworICAgICAgICBidWlsZC1kdW1wcmVu ZGVydHJlZSB3aGVuIER1bXBSZW5kZXJUcmVlIGhhc24ndCBiZWVuIGJ1aWx0IHlldC4KKworMjAx NC0wNS0xOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFJF R1JFU1NJT04gKHIxNjkwNDIpOiBGaXggcnVuLWFwaS10ZXN0cyBvbiBNb3VudGFpbiBMaW9uCiAg ICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMjk1ND4KIApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IDRiN2FiNThlOWQyMzc0ZTY0NDUxYjBlYTE0MzRhMzAzYmUzNTA3YWQuLjJjODIwOTlkMWM1MTI3 YWM0NjhmZmMwNjY3NWE3Yjg4ODg4YjNhOGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTM5OCwxMSAr Mzk4LDEzIEBAIHN1YiBkZXRlcm1pbmVYY29kZVNESwogICAgIG15ICRzZGs7CiAgICAgaWYgKGNo ZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVkdldHRpbmdWYWx1ZSgiLS1zZGsiLCBcJHNk aykpIHsKICAgICAgICAgJHhjb2RlU0RLID0gJHNkazsKLSAgICB9IGVsc2lmIChjaGVja0ZvckFy Z3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tZGV2aWNlIikpIHsKLSAgICAgICAgJHhjb2RlU0RL ID0gJ2lwaG9uZW9zLmludGVybmFsJzsKLSAgICB9IGVsc2lmIChjaGVja0ZvckFyZ3VtZW50QW5k UmVtb3ZlRnJvbUFSR1YoIi0tc2ltIikgfHwKKyAgICB9CisgICAgaWYgKGNoZWNrRm9yQXJndW1l bnRBbmRSZW1vdmVGcm9tQVJHVigiLS1kZXZpY2UiKSkgeworICAgICAgICAkeGNvZGVTREsgfHw9 ICdpcGhvbmVvcy5pbnRlcm5hbCc7CisgICAgfQorICAgIGlmIChjaGVja0ZvckFyZ3VtZW50QW5k UmVtb3ZlRnJvbUFSR1YoIi0tc2ltIikgfHwKICAgICAgICAgY2hlY2tGb3JBcmd1bWVudEFuZFJl bW92ZUZyb21BUkdWKCItLXNpbXVsYXRvciIpKSB7Ci0gICAgICAgICR4Y29kZVNESyA9ICdpcGhv bmVzaW11bGF0b3InOworICAgICAgICAkeGNvZGVTREsgfHw9ICdpcGhvbmVzaW11bGF0b3InOwog ICAgIH0KIH0KIAo=