133088 2014-05-19 15:48:45 -0700 Make fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html reliable 2022-02-28 04:13:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ap dbates mjs sam oldest_to_newest 1010318 0 ddkilzer 2014-05-19 15:48:45 -0700 When running fast/dom/remove-element-with-{id|name}-that-was-inserted-on-DOMNodeRemoved.html on iOS WebKit with the WebThread, we need to make sure to wait until the second inserted script has run. 1010319 1 231728 ddkilzer 2014-05-19 15:51:01 -0700 Created attachment 231728 Patch v1 1010365 2 231728 darin 2014-05-19 17:28:54 -0700 Comment on attachment 231728 Patch v1 Wouldn’t we have to do this for all tests? I’m not sure this is the right solution to this problem. Can’t we fix it in DumpRenderTree instead? 1010379 3 231728 ap 2014-05-19 18:06:28 -0700 Comment on attachment 231728 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231728&action=review > LayoutTests/ChangeLog:11 > + - Use waitUntilDone()/notifyDone() to make the tests reliable on > + iOS with the WebThread enabled. I think that there is nothing special about iOS DumpRendreTree here - these tests have a setTimeout that races with parsing. They could fail on OS X as well. 1010492 4 ddkilzer 2014-05-20 07:47:42 -0700 Committed r169111: <http://trac.webkit.org/changeset/169111> 231728 2014-05-19 15:51:01 -0700 2022-02-28 04:13:12 -0800 Patch v1 bug-133088-20140519154944.patch text/plain 3581 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTA4ODAzOWE0YjBhMjAxYWM3MDI0 ZTE5MzA5MjFjMjBkMGJmOTBiNy4uYjJiMTc0YTZlNmFlNGM0YWYzYjg0ODNiYmIyMjM2NTkxMTRj MjUyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTE5ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gTWFrZSBmYXN0L2RvbS9yZW1vdmUt ZWxlbWVudC13aXRoLXtpZHxuYW1lfS10aGF0LXdhcy1pbnNlcnRlZC1vbi1ET01Ob2RlUmVtb3Zl ZC5odG1sIHJlbGlhYmxlCisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMzA4OD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9t L3JlbW92ZS1lbGVtZW50LXdpdGgtaWQtdGhhdC13YXMtaW5zZXJ0ZWQtb24tRE9NTm9kZVJlbW92 ZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2RvbS9yZW1vdmUtZWxlbWVudC13aXRoLW5hbWUtdGhh dC13YXMtaW5zZXJ0ZWQtb24tRE9NTm9kZVJlbW92ZWQuaHRtbDoKKyAgICAgICAgLSBVc2Ugd2Fp dFVudGlsRG9uZSgpL25vdGlmeURvbmUoKSB0byBtYWtlIHRoZSB0ZXN0cyByZWxpYWJsZSBvbgor ICAgICAgICAgIGlPUyB3aXRoIHRoZSBXZWJUaHJlYWQgZW5hYmxlZC4KKwogMjAxNC0wNS0xOSAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGxpdCBz Y3JvbGxpbmcgdHJlZSBTY3JvbGxpbmdOb2RlcyBpbnRvIEZyYW1lU2Nyb2xsaW5nTm9kZXMgYW5k IE92ZXJmbG93U2Nyb2xsaW5nTm9kZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L3JlbW92ZS1lbGVtZW50LXdpdGgtaWQtdGhhdC13YXMtaW5zZXJ0ZWQtb24tRE9NTm9kZVJlbW92 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3JlbW92ZS1lbGVtZW50LXdpdGgtaWQtdGhh dC13YXMtaW5zZXJ0ZWQtb24tRE9NTm9kZVJlbW92ZWQuaHRtbAppbmRleCBhOGRmMmQxNjc3NWQ3 NDY0ZGIwNzA2MGJlNWFlMjVhNGEwNDdlOTk5Li5mMGQ0ZmM5NjcyNTEyY2U3MTM4YjFjMWRhY2M1 NmY0M2Y5YTJkMzBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9yZW1vdmUtZWxl bWVudC13aXRoLWlkLXRoYXQtd2FzLWluc2VydGVkLW9uLURPTU5vZGVSZW1vdmVkLmh0bWwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVtb3ZlLWVsZW1lbnQtd2l0aC1pZC10aGF0LXdhcy1p bnNlcnRlZC1vbi1ET01Ob2RlUmVtb3ZlZC5odG1sCkBAIC00LDggKzQsMTAgQEAKIDxib2R5IGlk PSJkZWNsYXJhdGl2ZUJvZHkiPjwvYm9keT4KIDwhLS0gTm90aWNlIGEgPHNjcmlwdD4gaXMgb25s eSBleGVjdXRlZCBvbmNlLiAtLT4KIDxzY3JpcHQ+Ci1pZiAod2luZG93LnRlc3RSdW5uZXIpCitp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAg ICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK30KIAogdmFyIHNhdmVkRG9jdW1lbnRFbGVt ZW50OwogZnVuY3Rpb24gYXBwZW5kQm9keUVsZW1lbnRUb1NhdmVkRG9jdW1lbnQoKQpAQCAtMjcs NSArMjksNyBAQCB3aW5kb3cuc2V0VGltZW91dChpbnNlcnRTYXZlZERvY3VtZW50LCAwKTsKIDwh LS0gVGhpcyBtdXN0IGJlIGluIGl0cyBvd24gPHNjcmlwdD4gc28gdGhhdCB3ZSBleGVjdXRlIGl0 IChmb3IgdGhlIGZpcnN0IHRpbWUpIHdoZW4gd2UgcmUtaW5zZXJ0IGl0IGludG8gdGhlIGRvY3Vt ZW50IGluIGluc2VydFNhdmVkRG9jdW1lbnQoKS4gLS0+CiA8c2NyaXB0IGlkPSJzY3JpcHQyIj4K IGRvY3VtZW50LndyaXRlKCJQQVNTLCByZW1vdmVkIGVsZW1lbnQsIHdpdGggSFRNTCBhdHRyaWJ1 dGUgaWQsIHdoaWNoIHdhcyBpbnNlcnRlZCBvbiBldmVudCBET01Ob2RlUmVtb3ZlZC4iKTsgLy8g RGVzdHJveXMgdGhlIGVudGlyZSBkb2N1bWVudCwgaW5jbHVkaW5nIDxib2R5IGlkPSJkZWNsYXJh dGl2ZUJvZHkiPiBhbmQgPGJvZHkgaWQ9InByb2dyYW1tYXRpY0JvZHkiPi4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKIDwvc2NyaXB0PgogPC9o dG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vcmVtb3ZlLWVsZW1lbnQtd2l0 aC1uYW1lLXRoYXQtd2FzLWluc2VydGVkLW9uLURPTU5vZGVSZW1vdmVkLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9yZW1vdmUtZWxlbWVudC13aXRoLW5hbWUtdGhhdC13YXMtaW5zZXJ0ZWQt b24tRE9NTm9kZVJlbW92ZWQuaHRtbAppbmRleCBiMWRjMjdkNjgzMmIwMzQ5MGRlZmE3ZDAwYjA4 ZWM0YjA2NDQ0MjBkLi4xODViNTZlMDU2YjRmNTBhZTkwZmY2YzUwZDk5YTFlOTRjM2M4YWVhIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9yZW1vdmUtZWxlbWVudC13aXRoLW5hbWUt dGhhdC13YXMtaW5zZXJ0ZWQtb24tRE9NTm9kZVJlbW92ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9yZW1vdmUtZWxlbWVudC13aXRoLW5hbWUtdGhhdC13YXMtaW5zZXJ0ZWQtb24t RE9NTm9kZVJlbW92ZWQuaHRtbApAQCAtNCw4ICs0LDEwIEBACiA8Ym9keSBkYXRhLWRlYnVnLW5h bWU9ImRlY2xhcmF0aXZlQm9keSI+PC9ib2R5PiA8IS0tIFRoaXMgZWxlbWVudCBpc24ndCBuZWNl c3NhcnksIGJ1dCBtYWtlcyBpdCBzdHJhaWdodGZvcndhcmQgdG8gcmVhc29uIGFib3V0IHRoZSB0 ZXN0IHdoZW4gZGVidWdnaW5nIGl0LiAtLT4KIDwhLS0gTm90aWNlIGEgPHNjcmlwdD4gaXMgb25s eSBleGVjdXRlZCBvbmNlLiAtLT4KIDxzY3JpcHQ+Ci1pZiAod2luZG93LnRlc3RSdW5uZXIpCitp ZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAg ICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK30KIAogdmFyIHNhdmVkRG9jdW1lbnRFbGVt ZW50OwogZnVuY3Rpb24gYXBwZW5kQm9keUVsZW1lbnRUb1NhdmVkRG9jdW1lbnQoKQpAQCAtMzYs NSArMzgsNyBAQCBmb3IgKHZhciBpID0gMDsgaSA8IGVsZW1lbnRzLmxlbmd0aDsgKytpKQogLy8g Zm9sbG93aW5nIGxpbmUgdG8gaXRzIG93biA8c2NyaXB0PiBhbmQgYWx0ZXJpbmcgdGhlIGV4ZWN1 dGlvbiB0aW1lIG9mIHRoaXMgcGFnZSAoc2F5LCBieSBzdGVwcGluZyB0aHJvdWdoIGNvZGUgaW4g YSBXZWJDb3JlIGRlYnVnIHNlc3Npb24pCiAvLyB0ZW5kcyB0byBhZmZlY3QgdGhlIHJlc3VsdCBv ZiB8ZWxlbWVudHN8IChzZWUgcmVtYXJrIFsxXSkuCiBkb2N1bWVudC53cml0ZSgiUEFTUywgcmVt b3ZlZCBlbGVtZW50LCB3aXRoIEhUTUwgYXR0cmlidXRlIG5hbWUsIHdoaWNoIHdhcyBpbnNlcnRl ZCBvbiBldmVudCBET01Ob2RlUmVtb3ZlZC4iKTsKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAg ICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKIDwvc2NyaXB0PgogPC9odG1sPgo=