133087 2014-05-19 15:04:10 -0700 Use different AppKit API for image control menus 2014-05-19 15:41:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue thorton oldest_to_newest 1010310 0 beidson 2014-05-19 15:04:10 -0700 Use different AppKit API for image control menus <rdar://problem/16807828> 1010312 1 231725 beidson 2014-05-19 15:07:41 -0700 Created attachment 231725 Patch v1 1010315 2 231725 commit-queue 2014-05-19 15:41:48 -0700 Comment on attachment 231725 Patch v1 Clearing flags on attachment: 231725 Committed r169079: <http://trac.webkit.org/changeset/169079> 1010316 3 commit-queue 2014-05-19 15:41:50 -0700 All reviewed patches have been landed. Closing bug. 231725 2014-05-19 15:07:41 -0700 2014-05-19 15:41:48 -0700 Patch v1 patch text/plain 3484 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBkNGI3YzRjLi5mNDlmYTc2NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTE5ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxl LmNvbT4KKworICAgICAgICBVc2UgZGlmZmVyZW50IEFwcEtpdCBBUEkgZm9yIGltYWdlIGNvbnRy b2wgbWVudXMuCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjgwNzgyOD4gYW5kIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgaW1hZ2UgY29udHJvbCBtZW51cywg dXNlIHBvcFVwTWVudVBvc2l0aW9uaW5nSXRlbTogaW5zdGVhZCBvZiBwb3BVcENvbnRleHRNZW51 OgorICAgICAgICAKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVu dC5oOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tOgor ICAgICAgICAoV2ViQ29udGV4dE1lbnVDbGllbnQ6OmNvbnRleHRNZW51Rm9yRXZlbnQpOgorICAg ICAgICAoV2ViQ29udGV4dE1lbnVDbGllbnQ6OnNob3dDb250ZXh0TWVudSk6CisKIDIwMTQtMDUt MTkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFNldCBXZWJLaXRT dXBwcmVzc2VzSW5jcmVtZW50YWxSZW5kZXJpbmdLZXkgdG8gTk8gYnkgZGVmYXVsdCBvbiBib3Ro IE1hYyBhbmQgaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9y dC9XZWJDb250ZXh0TWVudUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBv cnQvV2ViQ29udGV4dE1lbnVDbGllbnQuaAppbmRleCAxNzBiNGQ1Li41YTdiMjJkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNvbnRleHRNZW51 Q2xpZW50LmgKQEAgLTY1LDcgKzY1LDcgQEAgcHVibGljOgogICAgIFdlYlZpZXcgKndlYlZpZXco KSB7IHJldHVybiBtX3dlYlZpZXc7IH0KICAgICAgICAgCiBwcml2YXRlOgotICAgIE5TTWVudSAq Y29udGV4dE1lbnVGb3JFdmVudChOU0V2ZW50ICosIE5TVmlldyAqKTsKKyAgICBOU01lbnUgKmNv bnRleHRNZW51Rm9yRXZlbnQoTlNFdmVudCAqLCBOU1ZpZXcgKiwgYm9vbCYgaXNTZXJ2aWNlc01l bnUpOwogCiAgICAgYm9vbCBjbGllbnRGbG9hdFJlY3RGb3JOb2RlKFdlYkNvcmU6Ok5vZGUmLCBX ZWJDb3JlOjpGbG9hdFJlY3QmKSBjb25zdDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9t YWMvV2ViQ29yZVN1cHBvcnQvV2ViQ29udGV4dE1lbnVDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQppbmRleCA4ODczMWZm Li45NGI5NjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJDb250ZXh0TWVudUNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3Vw cG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbQpAQCAtNDYwLDggKzQ2MCwxMCBAQCBOU0ltYWdl ICpXZWJDb250ZXh0TWVudUNsaWVudDo6cmVuZGVyZWRJbWFnZUZvckNvbnRyb2xsZWRJbWFnZSgp IGNvbnN0CiAjZW5kaWYKIAogCi1OU01lbnUgKldlYkNvbnRleHRNZW51Q2xpZW50Ojpjb250ZXh0 TWVudUZvckV2ZW50KE5TRXZlbnQgKmV2ZW50LCBOU1ZpZXcgKnZpZXcpCitOU01lbnUgKldlYkNv bnRleHRNZW51Q2xpZW50Ojpjb250ZXh0TWVudUZvckV2ZW50KE5TRXZlbnQgKmV2ZW50LCBOU1Zp ZXcgKnZpZXcsIGJvb2wmIGlzU2VydmljZXNNZW51KQogeworICAgIGlzU2VydmljZXNNZW51ID0g ZmFsc2U7CisKICAgICBQYWdlKiBwYWdlID0gW21fd2ViVmlldyBwYWdlXTsKICAgICBpZiAoIXBh Z2UpCiAgICAgICAgIHJldHVybiBuaWw7CkBAIC00NzYsNyArNDc4LDggQEAgTlNNZW51ICpXZWJD b250ZXh0TWVudUNsaWVudDo6Y29udGV4dE1lbnVGb3JFdmVudChOU0V2ZW50ICpldmVudCwgTlNW aWV3ICp2aWV3KQogCiAgICAgICAgIGJvb2wgaXNDb250ZW50RWRpdGFibGUgPSBwYWdlLT5jb250 ZXh0TWVudUNvbnRyb2xsZXIoKS5jb250ZXh0KCkuaGl0VGVzdFJlc3VsdCgpLmlubmVyTm9kZSgp LT5pc0NvbnRlbnRFZGl0YWJsZSgpOwogICAgICAgICBtX3NoYXJpbmdTZXJ2aWNlUGlja2VyQ29u dHJvbGxlciA9IGFkb3B0TlMoW1tXZWJTaGFyaW5nU2VydmljZVBpY2tlckNvbnRyb2xsZXIgYWxs b2NdIGluaXRXaXRoRGF0YTooTlNEYXRhICopY2ZEYXRhLmdldCgpIGluY2x1ZGVFZGl0b3JTZXJ2 aWNlczppc0NvbnRlbnRFZGl0YWJsZSBtZW51Q2xpZW50OnRoaXNdKTsKLSAgICAgICAgCisKKyAg ICAgICAgaXNTZXJ2aWNlc01lbnUgPSB0cnVlOwogICAgICAgICByZXR1cm4gW21fc2hhcmluZ1Nl cnZpY2VQaWNrZXJDb250cm9sbGVyIG1lbnVdOwogICAgIH0KICNlbmRpZgpAQCAtNTAxLDggKzUw NCwxMyBAQCB2b2lkIFdlYkNvbnRleHRNZW51Q2xpZW50OjpzaG93Q29udGV4dE1lbnUoKQogICAg IE5TRXZlbnQqIGV2ZW50ID0gW05TRXZlbnQgbW91c2VFdmVudFdpdGhUeXBlOk5TUmlnaHRNb3Vz ZURvd24gbG9jYXRpb246cG9pbnQgbW9kaWZpZXJGbGFnczowIHRpbWVzdGFtcDowIHdpbmRvd051 bWJlcjpbW3ZpZXcgd2luZG93XSB3aW5kb3dOdW1iZXJdIGNvbnRleHQ6MCBldmVudE51bWJlcjow IGNsaWNrQ291bnQ6MSBwcmVzc3VyZToxXTsKIAogICAgIC8vIFNob3cgdGhlIGNvbnRleHR1YWwg bWVudSBmb3IgdGhpcyBldmVudC4KLSAgICBpZiAoTlNNZW51ICptZW51ID0gY29udGV4dE1lbnVG b3JFdmVudChldmVudCwgdmlldykpCi0gICAgICAgIFtOU01lbnUgcG9wVXBDb250ZXh0TWVudTpt ZW51IHdpdGhFdmVudDpldmVudCBmb3JWaWV3OnZpZXddOworICAgIGJvb2wgaXNTZXJ2aWNlc01l bnU7CisgICAgaWYgKE5TTWVudSAqbWVudSA9IGNvbnRleHRNZW51Rm9yRXZlbnQoZXZlbnQsIHZp ZXcsIGlzU2VydmljZXNNZW51KSkgeworICAgICAgICBpZiAoaXNTZXJ2aWNlc01lbnUpCisgICAg ICAgICAgICBbbWVudSBwb3BVcE1lbnVQb3NpdGlvbmluZ0l0ZW06bmlsIGF0TG9jYXRpb246W3Zp ZXcgY29udmVydFBvaW50OnBvaW50IHRvVmlldzpuaWxdIGluVmlldzp2aWV3XTsKKyAgICAgICAg ZWxzZQorICAgICAgICAgICAgW05TTWVudSBwb3BVcENvbnRleHRNZW51Om1lbnUgd2l0aEV2ZW50 OmV2ZW50IGZvclZpZXc6dmlld107CisgICAgfQogfQogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfQ09O VFJPTFMpCg==