133072 2014-05-19 09:51:35 -0700 http/tests/navigation/forward-to-fragment-fires-onload.html asserts 2014-05-28 15:48:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All REOPENED P2 Normal --- 1 jonowells andersca aestes andersca ap commit-queue oldest_to_newest 1010208 0 jonowells 2014-05-19 09:51:35 -0700 Paths to js-test-pre.js and js-test-post.js appear to be incorrect. 1010210 1 231697 jonowells 2014-05-19 10:01:21 -0700 Created attachment 231697 Patch 1010211 2 231697 aestes 2014-05-19 10:10:37 -0700 Comment on attachment 231697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231697&action=review > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:11 > -description('Tests that loading is not stopped by going forward to a fragment.'); > +description("Tests to see that loading is not stopped by going forward to a fragment."); I wouldn't change these to double quotes. It'll just make it harder for someone to blame this file later on. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:17 > - if (window.localStorage.stage == 'three') { > - console.log('3. Got back to start. Going forward to page 2.'); > - window.localStorage.stage = 'four'; > + if (window.localStorage.stage == "three") { > + console.log("3. Got back to start. Going forward to page 2."); > + window.localStorage.stage = "four"; Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:19 > - } else if (window.localStorage.stage == 'six') { > + } else if (window.localStorage.stage == "six") { Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:27 > - console.log('Starting test.'); > - window.localStorage.stage = 'one'; > + console.log("Starting test."); > + window.localStorage.stage = "one"; Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:30 > - window.location.href = 'resources/forward-to-fragment-fires-onload-2.html'; > + window.location.href = "resources/forward-to-fragment-fires-onload-2.html"; Ditto. 1010212 3 231698 jonowells 2014-05-19 10:12:24 -0700 Created attachment 231698 Patch 1010224 4 ap 2014-05-19 10:49:35 -0700 This test crashes on bots - is there more to the bug than the paths? http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r169042%20(17740)/http/tests/navigation/forward-to-fragment-fires-onload-crash-log.txt 1010225 5 231698 commit-queue 2014-05-19 10:51:20 -0700 Comment on attachment 231698 Patch Clearing flags on attachment: 231698 Committed r169050: <http://trac.webkit.org/changeset/169050> 1010226 6 commit-queue 2014-05-19 10:51:26 -0700 All reviewed patches have been landed. Closing bug. 1010240 7 jonowells 2014-05-19 11:27:58 -0700 I ran the tests and didn't have a crash or failure on this test anymore. However http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html has a closing </iframe> tag that seems out of place. 1010259 8 jonowells 2014-05-19 12:20:14 -0700 Reopening as crash still occurring. 1010266 9 jonowells 2014-05-19 12:48:56 -0700 I think this was caused by http://trac.webkit.org/changeset/169026. 1012307 10 ap 2014-05-28 15:48:50 -0700 The assertion was removed in <http://trac.webkit.org/changeset/169292>. As far as I can tell, that was done temporarily, and the assertion needs to be re-added. 231697 2014-05-19 10:01:21 -0700 2014-05-19 10:12:15 -0700 Patch bug-133072-20140519100058.patch text/plain 3036 jonowells U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjE4ZDZiOTA4Y2YzZDM0NDk2ZDU0 MTE4ZWQwNzYwZGQyZTA4ZTk4Yi4uNGIwNWUxNDQ5NjEzMDE1NGViN2RkYzFlNWQyMWQ5YTI1NTg5 YmMzNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA1LTE5ICBKb25vIFdlbGxzICA8am9u b3dlbGxzQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHQgaW5jbHVkZSBwYXRocyBmb3IganMt dGVzdC1wcmUuanMgYW5kIGpzLXRlc3QtcG9zdC5qcyB3ZXJlIGluY29ycmVjdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9uYXZp Z2F0aW9uL2ZvcndhcmQtdG8tZnJhZ21lbnQtZmlyZXMtb25sb2FkLmh0bWw6IEZpeGVkIHNjcmlw dCBpbmNsdWRlcy4KKwogMjAxNC0wNS0xOCAgU3ZldGxhbmEgUmVkY2hlbmtvICA8cmVkY2hlbmtv QHlhbmRleC10ZWFtLnJ1PgogCiAgICAgICAgIElucHV0IDo6c2VsZWN0aW9uIHBzZXVkbyBjbGFz cyBkb2VzIG5vdCB3b3JrIGxlYWRpbmcgdG8gaGlkZGVuIHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2ZvcndhcmQtdG8tZnJhZ21lbnQtZmly ZXMtb25sb2FkLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZm9yd2Fy ZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbAppbmRleCA0Mzk3Yzc0OTdjNmYwMGQxYmQz ODI1M2Y5YWRjMjljMTYxMDQwMWUxLi45ZjcwNGNjNjE1MjBlYjUxNjZkYWRjMTQ1ZDVjZDg1ODZh YTczZTQzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZm9y d2FyZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vZm9yd2FyZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbApA QCAtMSwzMyArMSwzMyBAQAogPCFET0NUWVBFIGh0bWw+CiA8aHRtbD4KIDxoZWFkPgotICA8c2Ny aXB0IHNyYz0iLi4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIDxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgogPGRpdiBpZD0i Y29uc29sZSI+PC9kaXY+CiAKIDxzY3JpcHQ+Ci1kZXNjcmlwdGlvbignVGVzdHMgdGhhdCBsb2Fk aW5nIGlzIG5vdCBzdG9wcGVkIGJ5IGdvaW5nIGZvcndhcmQgdG8gYSBmcmFnbWVudC4nKTsKK2Rl c2NyaXB0aW9uKCJUZXN0cyB0byBzZWUgdGhhdCBsb2FkaW5nIGlzIG5vdCBzdG9wcGVkIGJ5IGdv aW5nIGZvcndhcmQgdG8gYSBmcmFnbWVudC4iKTsKIAogb25sb2FkID0gZnVuY3Rpb24oKQogewot ICAgIGlmICh3aW5kb3cubG9jYWxTdG9yYWdlLnN0YWdlID09ICd0aHJlZScpIHsKLSAgICAgICAg Y29uc29sZS5sb2coJzMuIEdvdCBiYWNrIHRvIHN0YXJ0LiAgR29pbmcgZm9yd2FyZCB0byBwYWdl IDIuJyk7Ci0gICAgICAgIHdpbmRvdy5sb2NhbFN0b3JhZ2Uuc3RhZ2UgPSAnZm91cic7CisgICAg aWYgKHdpbmRvdy5sb2NhbFN0b3JhZ2Uuc3RhZ2UgPT0gInRocmVlIikgeworICAgICAgICBjb25z b2xlLmxvZygiMy4gR290IGJhY2sgdG8gc3RhcnQuICBHb2luZyBmb3J3YXJkIHRvIHBhZ2UgMi4i KTsKKyAgICAgICAgd2luZG93LmxvY2FsU3RvcmFnZS5zdGFnZSA9ICJmb3VyIjsKICAgICAgICAg aGlzdG9yeS5mb3J3YXJkKCk7Ci0gICAgfSBlbHNlIGlmICh3aW5kb3cubG9jYWxTdG9yYWdlLnN0 YWdlID09ICdzaXgnKSB7CisgICAgfSBlbHNlIGlmICh3aW5kb3cubG9jYWxTdG9yYWdlLnN0YWdl ID09ICJzaXgiKSB7CiAgICAgICAgIGRlbGV0ZSB3aW5kb3cubG9jYWxTdG9yYWdlLnN0YWdlOwog ICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKICAgICB9IGVsc2UgewogICAgICAgICAvLyBUbyBtYWtl IHN1cmUgdGhhdCB3ZSBoaXQgdGhpcyBicmFuY2gsIGxvZyB0aGlzIHRvIHRoZSBjb25zb2xlIHNv IHRoYXQKICAgICAgICAgLy8gaXQgc2hvd3MgdXAgaW4gZXhwZWN0ZWQgb3V0cHV0IChkZWJ1Zygp IHdpbGwgYmUgYmxvd24gYXdheSBvbmNlIHdlCiAgICAgICAgIC8vIG5hdmlnYXRlIG91dCkuCi0g ICAgICAgIGNvbnNvbGUubG9nKCdTdGFydGluZyB0ZXN0LicpOwotICAgICAgICB3aW5kb3cubG9j YWxTdG9yYWdlLnN0YWdlID0gJ29uZSc7CisgICAgICAgIGNvbnNvbGUubG9nKCJTdGFydGluZyB0 ZXN0LiIpOworICAgICAgICB3aW5kb3cubG9jYWxTdG9yYWdlLnN0YWdlID0gIm9uZSI7CiAgICAg ICAgIC8vIE5hdmlnYXRlIGluIGEgdGltZW91dCB0byBtYWtlIHN1cmUgd2UgY3JlYXRlIGEgaGlz dG9yeSBlbnRyeS4KICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKLSAgICAgICAgICAg IHdpbmRvdy5sb2NhdGlvbi5ocmVmID0gJ3Jlc291cmNlcy9mb3J3YXJkLXRvLWZyYWdtZW50LWZp cmVzLW9ubG9hZC0yLmh0bWwnOworICAgICAgICAgICAgd2luZG93LmxvY2F0aW9uLmhyZWYgPSAi cmVzb3VyY2VzL2ZvcndhcmQtdG8tZnJhZ21lbnQtZmlyZXMtb25sb2FkLTIuaHRtbCI7CiAgICAg ICAgIH0sIDApOwogICAgIH0KIH07CkBAIC0zNSw2ICszNSw2IEBAIG9ubG9hZCA9IGZ1bmN0aW9u KCkKIHZhciBqc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKIDwvc2NyaXB0PgogCi08c2NyaXB0IHNyYz0i Li4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzxzY3Jp cHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwv Ym9keT4KIDwvaHRtbD4K 231698 2014-05-19 10:12:24 -0700 2014-05-19 10:51:19 -0700 Patch bug-133072-20140519101200.patch text/plain 1577 jonowells U3VidmVyc2lvbiBSZXZpc2lvbjogMTY5MDQzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjE4ZDZiOTA4Y2YzZDM0NDk2ZDU0 MTE4ZWQwNzYwZGQyZTA4ZTk4Yi4uNGIwNWUxNDQ5NjEzMDE1NGViN2RkYzFlNWQyMWQ5YTI1NTg5 YmMzNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA1LTE5ICBKb25vIFdlbGxzICA8am9u b3dlbGxzQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JpcHQgaW5jbHVkZSBwYXRocyBmb3IganMt dGVzdC1wcmUuanMgYW5kIGpzLXRlc3QtcG9zdC5qcyB3ZXJlIGluY29ycmVjdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy9uYXZp Z2F0aW9uL2ZvcndhcmQtdG8tZnJhZ21lbnQtZmlyZXMtb25sb2FkLmh0bWw6IEZpeGVkIHNjcmlw dCBpbmNsdWRlcy4KKwogMjAxNC0wNS0xOCAgU3ZldGxhbmEgUmVkY2hlbmtvICA8cmVkY2hlbmtv QHlhbmRleC10ZWFtLnJ1PgogCiAgICAgICAgIElucHV0IDo6c2VsZWN0aW9uIHBzZXVkbyBjbGFz cyBkb2VzIG5vdCB3b3JrIGxlYWRpbmcgdG8gaGlkZGVuIHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2ZvcndhcmQtdG8tZnJhZ21lbnQtZmly ZXMtb25sb2FkLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZm9yd2Fy ZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbAppbmRleCA0Mzk3Yzc0OTdjNmYwMGQxYmQz ODI1M2Y5YWRjMjljMTYxMDQwMWUxLi5mZmY2ZGFhODY2NDAyNzhiZTgxNWQzOTIxZGE4MWJmYzE3 ZjM2Nzg3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vZm9y d2FyZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vZm9yd2FyZC10by1mcmFnbWVudC1maXJlcy1vbmxvYWQuaHRtbApA QCAtMSw3ICsxLDcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4KLSAgPHNjcmlw dCBzcmM9Ii4uLy4uL2pzLXRlc3QtcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PgogPC9oZWFkPgogPGJvZHk+CiA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KQEAgLTM1LDYgKzM1 LDYgQEAgb25sb2FkID0gZnVuY3Rpb24oKQogdmFyIGpzVGVzdElzQXN5bmMgPSB0cnVlOwogPC9z Y3JpcHQ+CiAKLTxzY3JpcHQgc3JjPSIuLi8uLi9qcy10ZXN0LXJlc291cmNlcy9qcy10ZXN0LXBv c3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXBvc3QuanMiPjwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo=