133070 2014-05-19 07:37:54 -0700 Remove unused JSC runtime options 2014-12-03 03:33:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zsborbely.u-szeged webkit-unassigned commit-queue fpizlo ggaren mark.lam msaboff ossy oldest_to_newest 1010184 0 zsborbely.u-szeged 2014-05-19 07:37:54 -0700 Remove unused JSC runtime options. 1010187 1 231691 zsborbely.u-szeged 2014-05-19 07:46:10 -0700 Created attachment 231691 Proposed patch 1010200 2 231691 ossy 2014-05-19 08:57:45 -0700 Comment on attachment 231691 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231691&action=review > Source/JavaScriptCore/runtime/Options.h:-149 > - v(bool, enableExperimentalFTLCoverage, false) \ It is unused now, but we shouldn't remove it until FTL is complete. I think JSC developers will need this to add new experimental features. > Source/JavaScriptCore/runtime/Options.h:-197 > - v(unsigned, maximumInliningDepthForMustInline, 7) \ > - v(unsigned, maximumInliningRecursionForMustInline, 3) \ These options were introduced by the cstack merge and were unused from the beginning. Were they used only for developing in the branch? 1051233 3 231691 ossy 2014-11-28 03:24:27 -0800 Comment on attachment 231691 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231691&action=review >> Source/JavaScriptCore/runtime/Options.h:-149 >> - v(bool, enableExperimentalFTLCoverage, false) \ > > It is unused now, but we shouldn't remove it until FTL is complete. > I think JSC developers will need this to add new experimental features. It is still unused. Can we remove it? >> Source/JavaScriptCore/runtime/Options.h:-197 >> - v(unsigned, maximumInliningRecursionForMustInline, 3) \ > > These options were introduced by the cstack merge and were unused from the beginning. > Were they used only for developing in the branch? After a half year later, I still can't find any use of maximumInliningDepthForMustInline and maximumInliningRecursionForMustInline in the full git history. I think they aren't used ever. Any objection against removing them? 1052109 4 231691 ossy 2014-12-03 03:26:39 -0800 Comment on attachment 231691 Proposed patch There were no objection, these option are really unused (and weren't used ever), so let's remove them, r=me. 1052110 5 231691 commit-queue 2014-12-03 03:28:18 -0800 Comment on attachment 231691 Proposed patch Rejecting attachment 231691 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 231691, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 2 (offset 13 lines). Hunk #3 succeeded at 247 (offset 15 lines). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/run-jsc-stress-tests Hunk #1 FAILED at 181. Hunk #2 succeeded at 616 (offset 65 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/run-jsc-stress-tests.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Csaba Osztrogon\xe1c']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/6467577131827200 1052113 6 ossy 2014-12-03 03:33:58 -0800 Committed r176716: <http://trac.webkit.org/changeset/176716> 231691 2014-05-19 07:46:10 -0700 2014-12-03 03:28:18 -0800 Proposed patch runtime.patch text/plain 3670 zsborbely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJhYWZlNGYuLjk1ZGE3ODUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA1LTE5ICBac29sdCBCb3JiZWx5 ICA8enNib3JiZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmVt b3ZlIHVudXNlZCBKU0MgcnVudGltZSBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE0LTA1LTE5 ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZW1vdmluZyBzb21l IGNoZWNrLXdlYmtpdC1zdHlsZSB3YXJuaW5ncyBmcm9tIC4vZGZnCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9PcHRpb25zLmgKaW5kZXggYzllODEzNC4uN2M1NzkyZSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaApAQCAtMTQ2LDcgKzE0Niw2IEBAIHR5cGVkZWYg Y29uc3QgY2hhciogb3B0aW9uU3RyaW5nOwogICAgIHYoYm9vbCwgZW5hYmxlT1NSRW50cnlUb0ZU TCwgdHJ1ZSkgXAogICAgIFwKICAgICB2KGJvb2wsIHVzZUZUTEpJVCwgdHJ1ZSkgXAotICAgIHYo Ym9vbCwgZW5hYmxlRXhwZXJpbWVudGFsRlRMQ292ZXJhZ2UsIGZhbHNlKSBcCiAgICAgdihib29s LCB1c2VGVExUQkFBLCB0cnVlKSBcCiAgICAgdihib29sLCBlbmFibGVMTFZNRmFzdElTZWwsIGZh bHNlKSBcCiAgICAgdihib29sLCB1c2VMTFZNU21hbGxDb2RlTW9kZWwsIGZhbHNlKSBcCkBAIC0x OTMsOCArMTkyLDYgQEAgdHlwZWRlZiBjb25zdCBjaGFyKiBvcHRpb25TdHJpbmc7CiAgICAgLyog RGVwdGggb2YgaW5saW5lIHN0YWNrLCBzbyAxID0gbm8gaW5saW5pbmcsIDIgPSBvbmUgbGV2ZWws IGV0Yy4gKi8gXAogICAgIHYodW5zaWduZWQsIG1heGltdW1JbmxpbmluZ0RlcHRoLCA1KSBcCiAg ICAgdih1bnNpZ25lZCwgbWF4aW11bUlubGluaW5nUmVjdXJzaW9uLCAyKSBcCi0gICAgdih1bnNp Z25lZCwgbWF4aW11bUlubGluaW5nRGVwdGhGb3JNdXN0SW5saW5lLCA3KSBcCi0gICAgdih1bnNp Z25lZCwgbWF4aW11bUlubGluaW5nUmVjdXJzaW9uRm9yTXVzdElubGluZSwgMykgXAogICAgIFwK ICAgICAvKiBNYXhpbXVtIHNpemUgb2YgYSBjYWxsZXIgZm9yIGVuYWJsaW5nIGlubGluaW5nLiBU aGlzIGlzIHB1cmVseSB0byBwcm90ZWN0IHVzICovXAogICAgIC8qIGZyb20gc3VwZXIgbG9uZyBj b21waWxlcyB0aGF0IHRha2UgYSBsb3Qgb2YgbWVtb3J5LiAqL1wKQEAgLTIzNSw3ICsyMzIsNiBA QCB0eXBlZGVmIGNvbnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICB2KHVuc2lnbmVkLCBvc3JF eGl0Q291bnRGb3JSZW9wdGltaXphdGlvbkZyb21Mb29wLCA1KSBcCiAgICAgXAogICAgIHYodW5z aWduZWQsIHJlb3B0aW1pemF0aW9uUmV0cnlDb3VudGVyTWF4LCAwKSAgXAotICAgIHYodW5zaWdu ZWQsIHJlb3B0aW1pemF0aW9uUmV0cnlDb3VudGVyU3RlcCwgMSkgXAogICAgIFwKICAgICB2KHVu c2lnbmVkLCBtaW5pbXVtT3B0aW1pemF0aW9uRGVsYXksIDEpIFwKICAgICB2KHVuc2lnbmVkLCBt YXhpbXVtT3B0aW1pemF0aW9uRGVsYXksIDUpIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YTFjZWY5Li5lNzIzODg3IDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTQtMDUtMTkgIFpzb2x0IEJvcmJlbHkgIDx6c2JvcmJlbHkudS1zemVnZWRAcGFydG5lci5zYW1z dW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIEpTQyBydW50aW1lIG9wdGlvbnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMzA3MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9y dW4tanNjLXN0cmVzcy10ZXN0czoKKwogMjAxNC0wNS0xOSAgRXZhIEJhbGF6c2ZhbHZpICA8ZXZh Yi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAgICAgIHJ1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cyBzaG91bGQgc29ydCB0aGUgbGlzdCBvZiBmYWlsaW5nIHN0cmVzcyB0ZXN0cwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cyBiL1Rvb2xzL1Nj cmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKaW5kZXggZWIyMmY2ZC4uMGFjNGVhNiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cworKysgYi9Ub29scy9TY3Jp cHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC0xODEsNyArMTgxLDcgQEAgJG51bUZhaWx1cmVz ID0gMAogRUFHRVJfT1BUSU9OUyA9IFsiLS10aHJlc2hvbGRGb3JKSVRBZnRlcldhcm1VcD0xMCIs ICItLXRocmVzaG9sZEZvckpJVFNvb249MTAiLCAiLS10aHJlc2hvbGRGb3JPcHRpbWl6ZUFmdGVy V2FybVVwPTIwIiwgIi0tdGhyZXNob2xkRm9yT3B0aW1pemVBZnRlckxvbmdXYXJtVXA9MjAiLCAi LS10aHJlc2hvbGRGb3JPcHRpbWl6ZVNvb249MjAiLCAiLS10aHJlc2hvbGRGb3JGVExPcHRpbWl6 ZUFmdGVyV2FybVVwPTIwIiwgIi0tdGhyZXNob2xkRm9yRlRMT3B0aW1pemVTb29uPTIwIl0KIE5P X0NKSVRfT1BUSU9OUyA9IFsiLS1lbmFibGVDb25jdXJyZW50SklUPWZhbHNlIiwgIi0tdGhyZXNo b2xkRm9ySklUQWZ0ZXJXYXJtVXA9MTAwIl0KIE5PX0ZUTF9PUFRJT05TID0gWyItLXVzZUZUTEpJ VD1mYWxzZSJdCi1GVExfT1BUSU9OUyA9IFsiLS11c2VGVExKSVQ9dHJ1ZSIsICItLWVuYWJsZUV4 cGVyaW1lbnRhbEZUTENvdmVyYWdlPXRydWUiXQorRlRMX09QVElPTlMgPSBbIi0tdXNlRlRMSklU PXRydWUiXQogCiAkcnVubGlzdCA9IFtdCiAKQEAgLTU1MSw3ICs1NTEsNyBAQCBkZWYgcnVuRlRM Tm9DSklUVmFsaWRhdGUKIGVuZAogCiBkZWYgcnVuRlRMTm9DSklUTm9JbmxpbmVWYWxpZGF0ZQot ICAgIHJ1bigiZnRsLW5vLWNqaXQtbm8taW5saW5lLXZhbGlkYXRlIiwgIi0tdmFsaWRhdGVHcmFw aD10cnVlIiwgIi0tbWF4aW11bUlubGluaW5nRGVwdGg9MSIsICItLW1heGltdW1JbmxpbmluZ0Rl cHRoRm9yTXVzdElubGluZT0xIiwgKihGVExfT1BUSU9OUyArIE5PX0NKSVRfT1BUSU9OUykpIGlm ICRlbmFibGVGVEwKKyAgICBydW4oImZ0bC1uby1jaml0LW5vLWlubGluZS12YWxpZGF0ZSIsICIt LXZhbGlkYXRlR3JhcGg9dHJ1ZSIsICItLW1heGltdW1JbmxpbmluZ0RlcHRoPTEiLCAqKEZUTF9P UFRJT05TICsgTk9fQ0pJVF9PUFRJT05TKSkgaWYgJGVuYWJsZUZUTAogZW5kCiAKIGRlZiBydW5G VExOb0NKSVRPU1JWYWxpZGF0aW9uCg==