133068 2014-05-19 06:43:15 -0700 Only set title on SVG documents 2014-05-20 10:21:21 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 hiremathprashants webkit-unassigned commit-queue d-r fmalita gyuyoung.kim jose.lejin krit pdr schenney sergio zimmermann oldest_to_newest 1010177 0 hiremathprashants 2014-05-19 06:43:15 -0700 We should set title on only SVG documents, HTML document should not be affected. Blink, IE and FF behaves similarly. We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision I'll update the patch soon... 1010180 1 231686 hiremathprashants 2014-05-19 07:07:07 -0700 Created attachment 231686 Patch proposed patch 1010188 2 krit 2014-05-19 07:49:25 -0700 (In reply to comment #0) > We should set title on only SVG documents, HTML document should not be affected. > > Blink, IE and FF behaves similarly. > > We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision > > I'll update the patch soon... No we shouldn't. The SVG guidance still says that <title> can be set on groups and elements. In how far <title> is still important is questionable. Until then we should maybe fix title, but not just let it apply to document. 1010521 3 231686 krit 2014-05-20 09:44:24 -0700 Comment on attachment 231686 Patch Totally misunderstood the purpose. r=me 1010542 4 231686 commit-queue 2014-05-20 10:14:05 -0700 Comment on attachment 231686 Patch Clearing flags on attachment: 231686 Committed r169118: <http://trac.webkit.org/changeset/169118> 1010543 5 commit-queue 2014-05-20 10:14:10 -0700 All reviewed patches have been landed. Closing bug. 1010546 6 krit 2014-05-20 10:21:21 -0700 Hm, I just noticed that is was back ported from Blink. These kind of things should be part of the ChangeLog and the original author should get the credits. 231686 2014-05-19 07:07:07 -0700 2014-05-20 10:14:05 -0700 Patch bug-133068-20140519193655.patch text/plain 3742 hiremathprashants SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTA0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA1LTE5ICBQcmFzaGFu dCBIaXJlbWF0aCAgPGhpcmVtYXRocHJhc2hhbnRzQGdtYWlsLmNvbT4KKworICAgICAgICBPbmx5 IHNldCB0aXRsZSBvbiBTVkcgZG9jdW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUZXN0OiBzdmcvY3VzdG9tL2h0bWxfZG9jdW1lbnRfc2V0X3Rp dGxlLmh0bWwKKworICAgICAgICAqIHN2Zy9TVkdUaXRsZUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHVGl0bGVFbGVtZW50OjppbnNlcnRlZEludG8pOgorICAgICAgICAoV2ViQ29y ZTo6U1ZHVGl0bGVFbGVtZW50OjpyZW1vdmVkRnJvbSk6CisgICAgICAgIChXZWJDb3JlOjpTVkdU aXRsZUVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZCk6CisKIDIwMTQtMDUtMTkgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBhc3NlcnRpb24gZmFpbHVyZSB3 aXRoIHNpbXBsZSBsaW5lIGxheW91dCBkZWJ1ZyBib3JkZXJzIGVuYWJsZWQuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHVGl0bGVFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9zdmcvU1ZHVGl0bGVFbGVtZW50LmNwcAkocmV2aXNpb24gMTY5MDMyKQorKysgU291 cmNlL1dlYkNvcmUvc3ZnL1NWR1RpdGxlRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQy LDI2ICs0MiwyOCBAQCBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IFNWR1RpCiAg ICAgU1ZHRWxlbWVudDo6aW5zZXJ0ZWRJbnRvKHJvb3RQYXJlbnQpOwogICAgIGlmICghcm9vdFBh cmVudC5pbkRvY3VtZW50KCkpCiAgICAgICAgIHJldHVybiBJbnNlcnRpb25Eb25lOwotICAgIC8v IEZJWE1FOiBJdCdzIHBvc3NpYmxlIHRvIHJlZ2lzdGVyIFNWR1RpdGxlRWxlbWVudCB0byBhbiBI VE1MRG9jdW1lbnQuCi0gICAgaWYgKGZpcnN0Q2hpbGQoKSkKKworICAgIGlmIChmaXJzdENoaWxk KCkgJiYgZG9jdW1lbnQoKS5pc1NWR0RvY3VtZW50KCkpIHsKICAgICAgICAgLy8gRklYTUU6IGRv ZXMgU1ZHIGhhdmUgYSB0aXRsZSB0ZXh0IGRpcmVjdGlvbj8KICAgICAgICAgZG9jdW1lbnQoKS5z ZXRUaXRsZUVsZW1lbnQoU3RyaW5nV2l0aERpcmVjdGlvbih0ZXh0Q29udGVudCgpLCBMVFIpLCB0 aGlzKTsKKyAgICB9CiAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7CiB9CiAKIHZvaWQgU1ZHVGl0 bGVFbGVtZW50OjpyZW1vdmVkRnJvbShDb250YWluZXJOb2RlJiByb290UGFyZW50KQogewogICAg IFNWR0VsZW1lbnQ6OnJlbW92ZWRGcm9tKHJvb3RQYXJlbnQpOwotICAgIGlmIChyb290UGFyZW50 LmluRG9jdW1lbnQoKSkKKyAgICBpZiAocm9vdFBhcmVudC5pbkRvY3VtZW50KCkgJiYgZG9jdW1l bnQoKS5pc1NWR0RvY3VtZW50KCkpCiAgICAgICAgIGRvY3VtZW50KCkucmVtb3ZlVGl0bGUodGhp cyk7CiB9CiAKIHZvaWQgU1ZHVGl0bGVFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoY29uc3QgQ2hp bGRDaGFuZ2UmIGNoYW5nZSkKIHsKICAgICBTVkdFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQoY2hh bmdlKTsKLSAgICBpZiAoaW5Eb2N1bWVudCgpKQorICAgIGlmIChpbkRvY3VtZW50KCkgJiYgZG9j dW1lbnQoKS5pc1NWR0RvY3VtZW50KCkpIHsKICAgICAgICAgLy8gRklYTUU6IGRvZXMgU1ZHIGhh dmUgdGl0bGUgdGV4dCBkaXJlY3Rpb24/CiAgICAgICAgIGRvY3VtZW50KCkuc2V0VGl0bGVFbGVt ZW50KFN0cmluZ1dpdGhEaXJlY3Rpb24odGV4dENvbnRlbnQoKSwgTFRSKSwgdGhpcyk7CisgICAg fQogfQogCiB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjkwNDMpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wNS0xOSAgUHJhc2hh bnQgSGlyZW1hdGggIDxoaXJlbWF0aHByYXNoYW50c0BnbWFpbC5jb20+CisKKyAgICAgICAgT25s eSBzZXQgdGl0bGUgb24gU1ZHIGRvY3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9tL2h0bWxfZG9jdW1lbnRfc2V0X3RpdGxl LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS9odG1sX2RvY3VtZW50 X3NldF90aXRsZS5odG1sOiBBZGRlZC4KKwogMjAxNC0wNS0xOCAgU3ZldGxhbmEgUmVkY2hlbmtv ICA8cmVkY2hlbmtvQHlhbmRleC10ZWFtLnJ1PgogCiAgICAgICAgIElucHV0IDo6c2VsZWN0aW9u IHBzZXVkbyBjbGFzcyBkb2VzIG5vdCB3b3JrIGxlYWRpbmcgdG8gaGlkZGVuIHNlbGVjdGlvbgpJ bmRleDogTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9odG1sX2RvY3VtZW50X3NldF90aXRsZS1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9odG1sX2RvY3Vt ZW50X3NldF90aXRsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9z dmcvY3VzdG9tL2h0bWxfZG9jdW1lbnRfc2V0X3RpdGxlLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDUgQEAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorUEFTUyBkb2N1bWVudC50aXRsZSBpcyAiIgorCkluZGV4OiBMYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL2h0bWxfZG9jdW1lbnRfc2V0X3RpdGxlLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9odG1sX2RvY3VtZW50X3NldF90aXRsZS5odG1sCShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9odG1sX2RvY3VtZW50X3NldF90 aXRsZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTYgQEAKKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPHNj cmlwdD4KKyAgZnVuY3Rpb24gcnVuVGVzdCgpCisgIHsKKyAgICBzaG91bGRCZSgnZG9jdW1lbnQu dGl0bGUnLCAnIiInKTsKKyAgfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1 blRlc3QoKSI+Cis8c3ZnPgorPHRpdGxlPlNob3VsZCBub3QgYmUgc2V0IG9uIEhUTUwgRG9jdW1l bnQ8L3RpdGxlPgorPC9zdmc+Cis8L2JvZHk+Cis8L2h0bWw+Cg==