133062 2014-05-18 22:20:58 -0700 [WebKit2] Cleanup the build from unused variable in WebProcess module 2014-06-04 02:49:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned andersca commit-queue ossy oldest_to_newest 1010144 0 shiva.jm 2014-05-18 22:20:58 -0700 Found unused variable used in WebKit2/WebProcess/UserContent/WebUserContentController.cpp during webkit-efl port build. /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:142:6: warning: unused parameter ‘scriptMessageHandlers’ [-Wunused-parameter] void WebUserContentController::addUserScriptMessageHandlers(const Vector<WebScriptMessageHandlerHandle>& scriptMessageHandlers) ^ /home/shiva.jm/webkit-git/svngitmay14/WebKit/Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:154:6: warning: unused parameter ‘identifier’ [-Wunused-parameter] void WebUserContentController::removeUserScriptMessageHandler(uint64_t identifier) 1010147 1 231675 shiva.jm 2014-05-18 22:29:47 -0700 Created attachment 231675 Patch Fix unused parameter by using UNUSED_PARAM macro 1010173 2 231675 ossy 2014-05-19 05:31:25 -0700 Comment on attachment 231675 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231675&action=review > Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:144 > + UNUSED_PARAM(scriptMessageHandlers); scriptMessageHandlers is used if ENABLE(USER_MESSAGE_HANDLERS) is true, it should be placed in the #else case, like this: #if ENABLE(USER_MESSAGE_HANDLERS) ... #else UNUSED_PARAM(scriptMessageHandlers); #endif > Source/WebKit2/WebProcess/UserContent/WebUserContentController.cpp:157 > + UNUSED_PARAM(identifier); ditto 1010400 3 231749 shiva.jm 2014-05-19 20:42:09 -0700 Created attachment 231749 Patch-Updated Updated with review comments 1010715 4 231749 commit-queue 2014-05-21 01:13:20 -0700 Comment on attachment 231749 Patch-Updated Clearing flags on attachment: 231749 Committed r169152: <http://trac.webkit.org/changeset/169152> 1010716 5 commit-queue 2014-05-21 01:13:23 -0700 All reviewed patches have been landed. Closing bug. 1013274 6 shiva.jm 2014-06-04 02:45:09 -0700 Bug is fixed, tested in version 169584. 1013277 7 ossy 2014-06-04 02:49:23 -0700 (In reply to comment #6) > Bug is fixed, tested in version 169584. Please don't change Resolved/fixed state of a bug to Verified/fixed. Resolved/fixed is the final state of the bug reports. (In reply to comment #4) > (From update of attachment 231749 [details]) > Clearing flags on attachment: 231749 > > Committed r169152: <http://trac.webkit.org/changeset/169152> It means that the bug is fixed, because the patch landed in this svn commit. There is no need for any testing / verifying after it. 231675 2014-05-18 22:29:47 -0700 2014-05-19 20:42:09 -0700 Patch bug-133062.patch text/plain 1924 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTAzNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTE4ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIENsZWFu dXAgdGhlIGJ1aWxkIGZyb20gdW51c2VkIHZhcmlhYmxlIGluIFdlYlByb2Nlc3MgbW9kdWxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwNjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdW51c2Vk IHBhcmFtZXRlciBieSB1c2luZyBVTlVTRURfUEFSQU0gbWFjcm8KKworICAgICAgICAqIFdlYlBy b2Nlc3MvVXNlckNvbnRlbnQvV2ViVXNlckNvbnRlbnRDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViVXNlckNvbnRlbnRDb250cm9sbGVyOjphZGRVc2VyU2NyaXB0TWVzc2FnZUhh bmRsZXJzKToKKyAgICAgICAgKFdlYktpdDo6V2ViVXNlckNvbnRlbnRDb250cm9sbGVyOjpyZW1v dmVVc2VyU2NyaXB0TWVzc2FnZUhhbmRsZXIpOgorCiAyMDE0LTA1LTE4ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVsYXggYW4gYXNzZXJ0aW9uIHdo ZW4gY3JlYXRpbmcgZG9jdW1lbnQgbG9hZGVycwpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9Vc2VyQ29udGVudC9XZWJVc2VyQ29udGVudENvbnRyb2xsZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvVXNlckNvbnRlbnQvV2ViVXNlckNvbnRlbnRD b250cm9sbGVyLmNwcAkocmV2aXNpb24gMTY5MDM2KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9Vc2VyQ29udGVudC9XZWJVc2VyQ29udGVudENvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0xNDEsNiArMTQxLDcgQEAgcHJpdmF0ZToKIAogdm9pZCBXZWJVc2VyQ29udGVudENv bnRyb2xsZXI6OmFkZFVzZXJTY3JpcHRNZXNzYWdlSGFuZGxlcnMoY29uc3QgVmVjdG9yPFdlYlNj cmlwdE1lc3NhZ2VIYW5kbGVySGFuZGxlPiYgc2NyaXB0TWVzc2FnZUhhbmRsZXJzKQogeworICAg IFVOVVNFRF9QQVJBTShzY3JpcHRNZXNzYWdlSGFuZGxlcnMpOwogI2lmIEVOQUJMRShVU0VSX01F U1NBR0VfSEFORExFUlMpCiAgICAgZm9yIChhdXRvJiBoYW5kbGUgOiBzY3JpcHRNZXNzYWdlSGFu ZGxlcnMpIHsKICAgICAgICAgUmVmUHRyPFdlYlVzZXJNZXNzYWdlSGFuZGxlckRlc2NyaXB0b3JQ cm94eT4gZGVzY3JpcHRvciA9IFdlYlVzZXJNZXNzYWdlSGFuZGxlckRlc2NyaXB0b3JQcm94eTo6 Y3JlYXRlKHRoaXMsIGhhbmRsZS5uYW1lLCBoYW5kbGUuaWRlbnRpZmllcik7CkBAIC0xNTMsNiAr MTU0LDcgQEAgdm9pZCBXZWJVc2VyQ29udGVudENvbnRyb2xsZXI6OmFkZFVzZXJTYwogCiB2b2lk IFdlYlVzZXJDb250ZW50Q29udHJvbGxlcjo6cmVtb3ZlVXNlclNjcmlwdE1lc3NhZ2VIYW5kbGVy KHVpbnQ2NF90IGlkZW50aWZpZXIpCiB7CisgICAgVU5VU0VEX1BBUkFNKGlkZW50aWZpZXIpOwog I2lmIEVOQUJMRShVU0VSX01FU1NBR0VfSEFORExFUlMpCiAgICAgYXV0byBpdCA9IG1fdXNlck1l c3NhZ2VIYW5kbGVyRGVzY3JpcHRvcnMuZmluZChpZGVudGlmaWVyKTsKICAgICBBU1NFUlQoaXQg IT0gbV91c2VyTWVzc2FnZUhhbmRsZXJEZXNjcmlwdG9ycy5lbmQoKSk7Cg== 231749 2014-05-19 20:42:09 -0700 2014-05-21 01:13:20 -0700 Patch-Updated bug-133062-review.patch text/plain 1741 shiva.jm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTEwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA1LTE5ICBTaGl2YWt1 bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dlYktpdDJdIENsZWFu dXAgdGhlIGJ1aWxkIGZyb20gdW51c2VkIHZhcmlhYmxlIGluIFdlYlByb2Nlc3MgbW9kdWxlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwNjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdW51c2Vk IHBhcmFtZXRlciBieSB1c2luZyBVTlVTRURfUEFSQU0gbWFjcm8KKworICAgICAgICAqIFdlYlBy b2Nlc3MvVXNlckNvbnRlbnQvV2ViVXNlckNvbnRlbnRDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViVXNlckNvbnRlbnRDb250cm9sbGVyOjphZGRVc2VyU2NyaXB0TWVzc2FnZUhh bmRsZXJzKToKKyAgICAgICAgKFdlYktpdDo6V2ViVXNlckNvbnRlbnRDb250cm9sbGVyOjpyZW1v dmVVc2VyU2NyaXB0TWVzc2FnZUhhbmRsZXIpOgorCiAyMDE0LTA1LTE5ICBHYXZpbiBCYXJyYWNs b3VnaCAgPGJhcmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdDIvaU9TOiBwYXJl bnRlZCB2aWV3IHNob3VsZCBiZSBjb25zaWRlcmVkIGhpZGRlbiBpZiBhcHAgaXMgYmFja2dyb3Vu ZGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1VzZXJDb250ZW50L1dlYlVzZXJD b250ZW50Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9Vc2VyQ29udGVudC9XZWJVc2VyQ29udGVudENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAx NjkxMDApCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1VzZXJDb250ZW50L1dlYlVzZXJD b250ZW50Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0OCw2ICsxNDgsOCBAQCB2 b2lkIFdlYlVzZXJDb250ZW50Q29udHJvbGxlcjo6YWRkVXNlclNjCiAgICAgICAgIG1fdXNlck1l c3NhZ2VIYW5kbGVyRGVzY3JpcHRvcnMuYWRkKGRlc2NyaXB0b3ItPmlkZW50aWZpZXIoKSwgZGVz Y3JpcHRvcik7CiAgICAgICAgIG1fdXNlckNvbnRlbnRDb250cm9sbGVyLT5hZGRVc2VyTWVzc2Fn ZUhhbmRsZXJEZXNjcmlwdG9yKGRlc2NyaXB0b3ItPmRlc2NyaXB0b3IoKSk7CiAgICAgfQorI2Vs c2UKKyAgICBVTlVTRURfUEFSQU0oc2NyaXB0TWVzc2FnZUhhbmRsZXJzKTsKICNlbmRpZgogfQog CkBAIC0xNTksNiArMTYxLDggQEAgdm9pZCBXZWJVc2VyQ29udGVudENvbnRyb2xsZXI6OnJlbW92 ZVVzZQogICAgIAogICAgIG1fdXNlckNvbnRlbnRDb250cm9sbGVyLT5yZW1vdmVVc2VyTWVzc2Fn ZUhhbmRsZXJEZXNjcmlwdG9yKGl0LT52YWx1ZS0+ZGVzY3JpcHRvcigpKTsKICAgICBtX3VzZXJN ZXNzYWdlSGFuZGxlckRlc2NyaXB0b3JzLnJlbW92ZShpdCk7CisjZWxzZQorICAgIFVOVVNFRF9Q QVJBTShpZGVudGlmaWVyKTsKICNlbmRpZgogfQogCg==