133047 2014-05-18 03:06:10 -0700 REGRESSION(r163712): [GTK] Misspelling and grammar underline marks are no longer drawn 2014-05-22 09:23:43 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned andersca berto darin mrobinson oldest_to_newest 1010066 0 cgarcia 2014-05-18 03:06:10 -0700 In epiphany I can see the suggestions in the context menu, so it seems the spellchecker is working, but the document marks are not correctly drawn. It works with WebKitGTK+ 2.4.x. 1010419 1 berto 2014-05-20 00:26:44 -0700 I'll take a look 1010457 2 berto 2014-05-20 04:48:06 -0700 The regression was introduced in r163712: Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters https://bugs.webkit.org/show_bug.cgi?id=128233 1010965 3 231883 cgarcia 2014-05-22 07:01:29 -0700 Created attachment 231883 Patch I've also changed the whole loop, using a for loop instead, so that we can use the current condition but to continue the loop. I think it improves the readability. 1010998 4 cgarcia 2014-05-22 09:23:43 -0700 Committed r169203: <http://trac.webkit.org/changeset/169203> 231883 2014-05-22 07:01:29 -0700 2014-05-22 09:09:03 -0700 Patch wk2-spelling.diff text/plain 6346 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MTBiYTAyLi4yY2I1NGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDUtMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MzcxMik6IFtHVEtdIE1pc3NwZWxsaW5nIGFuZCBn cmFtbWFyIHVuZGVybGluZSBtYXJrcyBhcmUgbm8gbG9uZ2VyIGRyYXduCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMwNDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdHdvIGNvbmRpdGlvbnMg Y2hhbmdlZCBieSBtaXN0YWtlIGluIHIxNjM3MTIuCisKKyAgICAgICAgKiBlZGl0aW5nL1RleHRD aGVja2luZ0hlbHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaW5kTWlzc3BlbGxpbmdzKTog RW50ZXIgdGhlIGxvb3AgYWxzbyB3aGVuIHdvcmRTdGFydCBpcyAwLgorICAgICAgICAoV2ViQ29y ZTo6VGV4dENoZWNraW5nSGVscGVyOjpmaW5kRmlyc3RNaXNzcGVsbGluZyk6IFNraXAgdGhlIHdv cmsKKyAgICAgICAgd2hlbiB0aGUgdGV4dCBpcyBhIHNpbmdsZSBjaGFyYWN0ZXIuIEFsc28gcmV3 b3JrZWQgaXQgdG8gdXNlIGEgZm9yCisgICAgICAgIGxvb3AgdG8gaW1wcm92ZSB0aGUgcmVhZGFi aWxpdHkuCisKIDIwMTQtMDUtMjIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIFRleHQgbWFya2VycyBkb24ndCBwYWludCBvbiBzaW1wbGUgbGluZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dENoZWNraW5nSGVscGVyLmNwcAppbmRleCAyNTNlYWQ3 Li5kZGM4ZTllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRDaGVja2lu Z0hlbHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0Q2hlY2tpbmdIZWxw ZXIuY3BwCkBAIC03Nyw3ICs3Nyw3IEBAIHN0YXRpYyB2b2lkIGZpbmRNaXNzcGVsbGluZ3MoVGV4 dENoZWNrZXJDbGllbnQmIGNsaWVudCwgU3RyaW5nVmlldyB0ZXh0LCBWZWN0b3I8CiAgICAgVGV4 dEJyZWFrSXRlcmF0b3IqIGl0ZXJhdG9yID0gd29yZEJyZWFrSXRlcmF0b3IodGV4dCk7CiAgICAg aWYgKCFpdGVyYXRvcikKICAgICAgICAgcmV0dXJuOwotICAgIGZvciAoaW50IHdvcmRTdGFydCA9 IHRleHRCcmVha0N1cnJlbnQoaXRlcmF0b3IpOyB3b3JkU3RhcnQgPiAwOyApIHsKKyAgICBmb3Ig KGludCB3b3JkU3RhcnQgPSB0ZXh0QnJlYWtDdXJyZW50KGl0ZXJhdG9yKTsgd29yZFN0YXJ0ID49 IDA7ICkgewogICAgICAgICBpbnQgd29yZEVuZCA9IHRleHRCcmVha05leHQoaXRlcmF0b3IpOwog ICAgICAgICBpZiAod29yZEVuZCA8IDApCiAgICAgICAgICAgICBicmVhazsKQEAgLTI0NCw1NiAr MjQ0LDUzIEBAIFRleHRDaGVja2luZ0hlbHBlcjo6flRleHRDaGVja2luZ0hlbHBlcigpCiAKIFN0 cmluZyBUZXh0Q2hlY2tpbmdIZWxwZXI6OmZpbmRGaXJzdE1pc3NwZWxsaW5nKGludCYgZmlyc3RN aXNzcGVsbGluZ09mZnNldCwgYm9vbCBtYXJrQWxsLCBSZWZQdHI8UmFuZ2U+JiBmaXJzdE1pc3Nw ZWxsaW5nUmFuZ2UpCiB7Ci0gICAgV29yZEF3YXJlSXRlcmF0b3IgaXQoKm1fcmFuZ2UpOwogICAg IGZpcnN0TWlzc3BlbGxpbmdPZmZzZXQgPSAwOwotICAgIAorCiAgICAgU3RyaW5nIGZpcnN0TWlz c3BlbGxpbmc7CiAgICAgaW50IGN1cnJlbnRDaHVua09mZnNldCA9IDA7CiAKLSAgICB3aGlsZSAo IWl0LmF0RW5kKCkpIHsKKyAgICBmb3IgKFdvcmRBd2FyZUl0ZXJhdG9yIGl0KCptX3JhbmdlKTsg IWl0LmF0RW5kKCk7IGN1cnJlbnRDaHVua09mZnNldCArPSBpdC50ZXh0KCkubGVuZ3RoKCksIGl0 LmFkdmFuY2UoKSkgewogICAgICAgICBTdHJpbmdWaWV3IHRleHQgPSBpdC50ZXh0KCk7CiAgICAg ICAgIGludCB0ZXh0TGVuZ3RoID0gdGV4dC5sZW5ndGgoKTsKIAotICAgICAgICAvLyBTa2lwIHNv bWUgd29yayBmb3Igb25lLXNwYWNlLWNoYXIgaHVua3MKLSAgICAgICAgaWYgKHRleHRMZW5ndGgg PT0gMSAmJiB0ZXh0WzBdID09ICcgJykgewotICAgICAgICAgICAgaW50IG1pc3NwZWxsaW5nTG9j YXRpb24gPSAtMTsKLSAgICAgICAgICAgIGludCBtaXNzcGVsbGluZ0xlbmd0aCA9IDA7Ci0gICAg ICAgICAgICBtX2NsaWVudC0+dGV4dENoZWNrZXIoKS0+Y2hlY2tTcGVsbGluZ09mU3RyaW5nKHRl eHQsICZtaXNzcGVsbGluZ0xvY2F0aW9uLCAmbWlzc3BlbGxpbmdMZW5ndGgpOwotCi0gICAgICAg ICAgICAvLyA1NDkwNjI3IHNob3dzIHRoYXQgdGhlcmUgd2FzIHNvbWUgY29kZSBwYXRoIGhlcmUg d2hlcmUgdGhlIFN0cmluZyBjb25zdHJ1Y3RvciBiZWxvdyBjcmFzaGVzLgotICAgICAgICAgICAg Ly8gV2UgZG9uJ3Qga25vdyBleGFjdGx5IHdoYXQgY29tYmluYXRpb24gb2YgYmFkIGlucHV0IGNh dXNlZCB0aGlzLCBzbyB3ZSdyZSBtYWtpbmcgdGhpcyBtdWNoCi0gICAgICAgICAgICAvLyBtb3Jl IHJvYnVzdCBhZ2FpbnN0IGJhZCBpbnB1dCBvbiByZWxlYXNlIGJ1aWxkcy4KLSAgICAgICAgICAg IEFTU0VSVChtaXNzcGVsbGluZ0xlbmd0aCA+PSAwKTsKLSAgICAgICAgICAgIEFTU0VSVChtaXNz cGVsbGluZ0xvY2F0aW9uID49IC0xKTsKLSAgICAgICAgICAgIEFTU0VSVCghbWlzc3BlbGxpbmdM ZW5ndGggfHwgbWlzc3BlbGxpbmdMb2NhdGlvbiA+PSAwKTsKLSAgICAgICAgICAgIEFTU0VSVCht aXNzcGVsbGluZ0xvY2F0aW9uIDwgdGV4dExlbmd0aCk7Ci0gICAgICAgICAgICBBU1NFUlQobWlz c3BlbGxpbmdMZW5ndGggPD0gdGV4dExlbmd0aCk7Ci0gICAgICAgICAgICBBU1NFUlQobWlzc3Bl bGxpbmdMb2NhdGlvbiArIG1pc3NwZWxsaW5nTGVuZ3RoIDw9IHRleHRMZW5ndGgpOwotCi0gICAg ICAgICAgICBpZiAobWlzc3BlbGxpbmdMb2NhdGlvbiA+PSAwICYmIG1pc3NwZWxsaW5nTGVuZ3Ro ID4gMCAmJiBtaXNzcGVsbGluZ0xvY2F0aW9uIDwgdGV4dExlbmd0aCAmJiBtaXNzcGVsbGluZ0xl bmd0aCA8PSB0ZXh0TGVuZ3RoICYmIG1pc3NwZWxsaW5nTG9jYXRpb24gKyBtaXNzcGVsbGluZ0xl bmd0aCA8PSB0ZXh0TGVuZ3RoKSB7Ci0gICAgICAgICAgICAgICAgLy8gQ29tcHV0ZSByYW5nZSBv ZiBtaXNzcGVsbGVkIHdvcmQKLSAgICAgICAgICAgICAgICBSZWZQdHI8UmFuZ2U+IG1pc3NwZWxs aW5nUmFuZ2UgPSBUZXh0SXRlcmF0b3I6OnN1YnJhbmdlKG1fcmFuZ2UuZ2V0KCksIGN1cnJlbnRD aHVua09mZnNldCArIG1pc3NwZWxsaW5nTG9jYXRpb24sIG1pc3NwZWxsaW5nTGVuZ3RoKTsKLQot ICAgICAgICAgICAgICAgIC8vIFJlbWVtYmVyIGZpcnN0LWVuY291bnRlcmVkIG1pc3NwZWxsaW5n IGFuZCBpdHMgb2Zmc2V0LgotICAgICAgICAgICAgICAgIGlmICghZmlyc3RNaXNzcGVsbGluZykg ewotICAgICAgICAgICAgICAgICAgICBmaXJzdE1pc3NwZWxsaW5nT2Zmc2V0ID0gY3VycmVudENo dW5rT2Zmc2V0ICsgbWlzc3BlbGxpbmdMb2NhdGlvbjsKLSAgICAgICAgICAgICAgICAgICAgZmly c3RNaXNzcGVsbGluZyA9IHRleHQuc3Vic3RyaW5nKG1pc3NwZWxsaW5nTG9jYXRpb24sIG1pc3Nw ZWxsaW5nTGVuZ3RoKS50b1N0cmluZygpOwotICAgICAgICAgICAgICAgICAgICBmaXJzdE1pc3Nw ZWxsaW5nUmFuZ2UgPSBtaXNzcGVsbGluZ1JhbmdlOwotICAgICAgICAgICAgICAgIH0KLQotICAg ICAgICAgICAgICAgIC8vIFN0b3JlIG1hcmtlciBmb3IgbWlzc3BlbGxlZCB3b3JkLgotICAgICAg ICAgICAgICAgIG1pc3NwZWxsaW5nUmFuZ2UtPnN0YXJ0Q29udGFpbmVyKCktPmRvY3VtZW50KCku bWFya2VycygpLmFkZE1hcmtlcihtaXNzcGVsbGluZ1JhbmdlLmdldCgpLCBEb2N1bWVudE1hcmtl cjo6U3BlbGxpbmcpOworICAgICAgICAvLyBTa2lwIHNvbWUgd29yayBmb3Igb25lLXNwYWNlLWNo YXIgaHVua3MuCisgICAgICAgIGlmICh0ZXh0TGVuZ3RoID09IDEgJiYgdGV4dFswXSA9PSAnICcp CisgICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICAgICAgICAgIC8vIEJhaWwgb3V0IGlm IHdlJ3JlIG1hcmtpbmcgb25seSB0aGUgZmlyc3QgbWlzc3BlbGxpbmcsIGFuZCBub3QgYWxsIGlu c3RhbmNlcy4KLSAgICAgICAgICAgICAgICBpZiAoIW1hcmtBbGwpCi0gICAgICAgICAgICAgICAg ICAgIGJyZWFrOworICAgICAgICBpbnQgbWlzc3BlbGxpbmdMb2NhdGlvbiA9IC0xOworICAgICAg ICBpbnQgbWlzc3BlbGxpbmdMZW5ndGggPSAwOworICAgICAgICBtX2NsaWVudC0+dGV4dENoZWNr ZXIoKS0+Y2hlY2tTcGVsbGluZ09mU3RyaW5nKHRleHQsICZtaXNzcGVsbGluZ0xvY2F0aW9uLCAm bWlzc3BlbGxpbmdMZW5ndGgpOworCisgICAgICAgIC8vIDU0OTA2Mjcgc2hvd3MgdGhhdCB0aGVy ZSB3YXMgc29tZSBjb2RlIHBhdGggaGVyZSB3aGVyZSB0aGUgU3RyaW5nIGNvbnN0cnVjdG9yIGJl bG93IGNyYXNoZXMuCisgICAgICAgIC8vIFdlIGRvbid0IGtub3cgZXhhY3RseSB3aGF0IGNvbWJp bmF0aW9uIG9mIGJhZCBpbnB1dCBjYXVzZWQgdGhpcywgc28gd2UncmUgbWFraW5nIHRoaXMgbXVj aAorICAgICAgICAvLyBtb3JlIHJvYnVzdCBhZ2FpbnN0IGJhZCBpbnB1dCBvbiByZWxlYXNlIGJ1 aWxkcy4KKyAgICAgICAgQVNTRVJUKG1pc3NwZWxsaW5nTGVuZ3RoID49IDApOworICAgICAgICBB U1NFUlQobWlzc3BlbGxpbmdMb2NhdGlvbiA+PSAtMSk7CisgICAgICAgIEFTU0VSVCghbWlzc3Bl bGxpbmdMZW5ndGggfHwgbWlzc3BlbGxpbmdMb2NhdGlvbiA+PSAwKTsKKyAgICAgICAgQVNTRVJU KG1pc3NwZWxsaW5nTG9jYXRpb24gPCB0ZXh0TGVuZ3RoKTsKKyAgICAgICAgQVNTRVJUKG1pc3Nw ZWxsaW5nTGVuZ3RoIDw9IHRleHRMZW5ndGgpOworICAgICAgICBBU1NFUlQobWlzc3BlbGxpbmdM b2NhdGlvbiArIG1pc3NwZWxsaW5nTGVuZ3RoIDw9IHRleHRMZW5ndGgpOworCisgICAgICAgIGlm IChtaXNzcGVsbGluZ0xvY2F0aW9uID49IDAgJiYgbWlzc3BlbGxpbmdMZW5ndGggPiAwICYmIG1p c3NwZWxsaW5nTG9jYXRpb24gPCB0ZXh0TGVuZ3RoICYmIG1pc3NwZWxsaW5nTGVuZ3RoIDw9IHRl eHRMZW5ndGggJiYgbWlzc3BlbGxpbmdMb2NhdGlvbiArIG1pc3NwZWxsaW5nTGVuZ3RoIDw9IHRl eHRMZW5ndGgpIHsKKyAgICAgICAgICAgIC8vIENvbXB1dGUgcmFuZ2Ugb2YgbWlzc3BlbGxlZCB3 b3JkCisgICAgICAgICAgICBSZWZQdHI8UmFuZ2U+IG1pc3NwZWxsaW5nUmFuZ2UgPSBUZXh0SXRl cmF0b3I6OnN1YnJhbmdlKG1fcmFuZ2UuZ2V0KCksIGN1cnJlbnRDaHVua09mZnNldCArIG1pc3Nw ZWxsaW5nTG9jYXRpb24sIG1pc3NwZWxsaW5nTGVuZ3RoKTsKKworICAgICAgICAgICAgLy8gUmVt ZW1iZXIgZmlyc3QtZW5jb3VudGVyZWQgbWlzc3BlbGxpbmcgYW5kIGl0cyBvZmZzZXQuCisgICAg ICAgICAgICBpZiAoIWZpcnN0TWlzc3BlbGxpbmcpIHsKKyAgICAgICAgICAgICAgICBmaXJzdE1p c3NwZWxsaW5nT2Zmc2V0ID0gY3VycmVudENodW5rT2Zmc2V0ICsgbWlzc3BlbGxpbmdMb2NhdGlv bjsKKyAgICAgICAgICAgICAgICBmaXJzdE1pc3NwZWxsaW5nID0gdGV4dC5zdWJzdHJpbmcobWlz c3BlbGxpbmdMb2NhdGlvbiwgbWlzc3BlbGxpbmdMZW5ndGgpLnRvU3RyaW5nKCk7CisgICAgICAg ICAgICAgICAgZmlyc3RNaXNzcGVsbGluZ1JhbmdlID0gbWlzc3BlbGxpbmdSYW5nZTsKICAgICAg ICAgICAgIH0KKworICAgICAgICAgICAgLy8gU3RvcmUgbWFya2VyIGZvciBtaXNzcGVsbGVkIHdv cmQuCisgICAgICAgICAgICBtaXNzcGVsbGluZ1JhbmdlLT5zdGFydENvbnRhaW5lcigpLT5kb2N1 bWVudCgpLm1hcmtlcnMoKS5hZGRNYXJrZXIobWlzc3BlbGxpbmdSYW5nZS5nZXQoKSwgRG9jdW1l bnRNYXJrZXI6OlNwZWxsaW5nKTsKKworICAgICAgICAgICAgLy8gQmFpbCBvdXQgaWYgd2UncmUg bWFya2luZyBvbmx5IHRoZSBmaXJzdCBtaXNzcGVsbGluZywgYW5kIG5vdCBhbGwgaW5zdGFuY2Vz LgorICAgICAgICAgICAgaWYgKCFtYXJrQWxsKQorICAgICAgICAgICAgICAgIGJyZWFrOwogICAg ICAgICB9Ci0gICAgICAgIAotICAgICAgICBjdXJyZW50Q2h1bmtPZmZzZXQgKz0gdGV4dExlbmd0 aDsKLSAgICAgICAgaXQuYWR2YW5jZSgpOwogICAgIH0KLSAgICAKKwogICAgIHJldHVybiBmaXJz dE1pc3NwZWxsaW5nOwogfQogCg==