133043 2014-05-17 23:42:52 -0700 AX: iOS: using AXAttributeCacheEnabler is too slow for every accessibilityElementAtIndex: 2014-05-19 09:31:38 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1010053 0 cfleizach 2014-05-17 23:42:52 -0700 On iOS, the attribute cache enabler is being used on every access to elementAtIndex. Sample shows that we're spending a lot of time creating and tearing down these objects. I think we need to provide the ability to enable and disable caching at a higher, more informed level, so that we can cut down on these costs. <rdar://problem/16945180> 1010054 1 231650 cfleizach 2014-05-17 23:52:28 -0700 Created attachment 231650 patch 1010070 2 231650 andersca 2014-05-18 07:23:23 -0700 Comment on attachment 231650 patch Who calls enableAttributeCaching and disableAttributeCaching, the OS? 1010071 3 cfleizach 2014-05-18 07:48:10 -0700 (In reply to comment #2) > (From update of attachment 231650 [details]) > Who calls enableAttributeCaching and disableAttributeCaching, the OS? The accessibility framework that is on the app side knows when a list of elements is requested. That framework is able to start and stop the cache for us 1010175 4 231650 mario 2014-05-19 05:48:40 -0700 Comment on attachment 231650 patch View in context: https://bugs.webkit.org/attachment.cgi?id=231650&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:346 > + m_object->axObjectCache()->startCachingComputedObjectAttributesUntilTreeMutates(); Perhaps you want to check whether axObjectCache() returns null here before using it? > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:351 > + m_object->axObjectCache()->stopCachingComputedObjectAttributes(); Same comment here 1010201 5 cfleizach 2014-05-19 09:11:35 -0700 (In reply to comment #4) > (From update of attachment 231650 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231650&action=review > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:346 > > + m_object->axObjectCache()->startCachingComputedObjectAttributesUntilTreeMutates(); > > Perhaps you want to check whether axObjectCache() returns null here before using it? > > > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:351 > > + m_object->axObjectCache()->stopCachingComputedObjectAttributes(); > > Same comment here Done. Thanks http://trac.webkit.org/changeset/169047 231650 2014-05-17 23:52:28 -0700 2014-05-19 05:48:40 -0700 patch patch text/plain 3046 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2OTAwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA1LTE3ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGlPUzogdXNpbmcg QVhBdHRyaWJ1dGVDYWNoZUVuYWJsZXIgaXMgdG9vIHNsb3cgZm9yIGV2ZXJ5IGFjY2Vzc2liaWxp dHlFbGVtZW50QXRJbmRleDoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMzA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGlPUyBBY2Nlc3NpYmlsaXR5IGNvZGUgdHJpZXMgdG8gaW1wcm92ZSBwZXJmb3Jt YW5jZSBieSBjYWNoaW5nIGF0dHJpYnV0ZXMgd2hlbiBhY2Nlc3NpbmcKKyAgICAgICAgZWxlbWVu dHMgdGhyb3VnaCB0aGUgcGxhdGZvcm0gQVBJLiBIb3dldmVyLCB0aG9zZSBBUEkgY2FsbHMgY2Fu IGJlIHVzZWQgdmVyeSBmcmVxdWVudGx5IHdoZW4gCisgICAgICAgIGl0ZXJhdGluZyBlbGVtZW50 cy4gQ3JlYXRpbmcgdGhlIEFYQXR0cmlidXRlQ2FjaGVFbmFibGVyIG9iamVjdCBhbmQgdGVhcmlu ZyBpdCBkb3duIGlzIHByb3ZpbmcKKyAgICAgICAgdG8gYmUgdGhlIGhvdHRlc3QgY29kZSBwYXRo IGluIHNhbXBsZXMgZm9yIGFjY2Vzc2liaWxpdHkgYWNjZXNzLgorCisgICAgICAgIFdlIG5lZWQg dG8gbW92ZSB0aGUgbG9naWMgZm9yIGVuYWJsaW5nL2Rpc2FibGluZyB0aGUgYXR0cmlidXRlIGNh Y2hlIHRvIGEgbGV2ZWwgdGhhdCBjYW4gbWFrZQorICAgICAgICBhIG1vcmUgaW5mb3JtZWQgZGVj aXNpb24gYWJvdXQgd2hlbiB0byBlbmFibGUvZGlzYWJsZS4KKworICAgICAgICAqIGFjY2Vzc2li aWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tOgorICAgICAgICAo LVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBlbmFibGVBdHRyaWJ1dGVDYWNoaW5nXSk6 CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGRpc2FibGVBdHRyaWJ1 dGVDYWNoaW5nXSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIGFj Y2Vzc2liaWxpdHlFbGVtZW50Q291bnRdKToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUVsZW1lbnRBdEluZGV4Ol0pOgorICAgICAgICAoLVtX ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciBpbmRleE9mQWNjZXNzaWJpbGl0eUVsZW1lbnQ6 XSk6CisKIDIwMTQtMDUtMTcgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KIAog ICAgICAgICBEb24ndCBhdHRlbXB0IHRvIHVwZGF0ZSBpZCBvciBuYW1lIGZvciBub2RlcyB0aGF0 IGFyZSBhbHJlYWR5IHJlbW92ZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv aW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVySU9TLm1tCShyZXZpc2lvbiAxNjg5OTUpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbQkod29ya2luZyBjb3B5 KQpAQCAtMzQxLDEyICszNDEsMjEgQEAKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVVuaWdub3Jl ZEFuY2VzdG9yKGF4T2JqZWN0LT53cmFwcGVyKCkpOyAgICAKIH0KIAorLSAodm9pZCllbmFibGVB dHRyaWJ1dGVDYWNoaW5nCit7CisgICAgbV9vYmplY3QtPmF4T2JqZWN0Q2FjaGUoKS0+c3RhcnRD YWNoaW5nQ29tcHV0ZWRPYmplY3RBdHRyaWJ1dGVzVW50aWxUcmVlTXV0YXRlcygpOworfQorCist ICh2b2lkKWRpc2FibGVBdHRyaWJ1dGVDYWNoaW5nCit7CisgICAgbV9vYmplY3QtPmF4T2JqZWN0 Q2FjaGUoKS0+c3RvcENhY2hpbmdDb21wdXRlZE9iamVjdEF0dHJpYnV0ZXMoKTsKK30KKwogLSAo TlNJbnRlZ2VyKWFjY2Vzc2liaWxpdHlFbGVtZW50Q291bnQKIHsKICAgICBpZiAoIVtzZWxmIF9w cmVwYXJlQWNjZXNzaWJpbGl0eUNhbGxdKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIEFYQXR0 cmlidXRlQ2FjaGVFbmFibGVyIGVuYWJsZUNhY2hlKG1fb2JqZWN0LT5heE9iamVjdENhY2hlKCkp OwogICAgIGlmIChbc2VsZiBpc0F0dGFjaG1lbnRdKQogICAgICAgICByZXR1cm4gW1tzZWxmIGF0 dGFjaG1lbnRWaWV3XSBhY2Nlc3NpYmlsaXR5RWxlbWVudENvdW50XTsKICAgICAKQEAgLTM1OCw3 ICszNjcsNiBAQAogICAgIGlmICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0pCiAg ICAgICAgIHJldHVybiBuaWw7CiAKLSAgICBBWEF0dHJpYnV0ZUNhY2hlRW5hYmxlciBlbmFibGVD YWNoZShtX29iamVjdC0+YXhPYmplY3RDYWNoZSgpKTsKICAgICBpZiAoW3NlbGYgaXNBdHRhY2ht ZW50XSkKICAgICAgICAgcmV0dXJuIFtbc2VsZiBhdHRhY2htZW50Vmlld10gYWNjZXNzaWJpbGl0 eUVsZW1lbnRBdEluZGV4OmluZGV4XTsKICAgICAKQEAgLTM3OCw3ICszODYsNiBAQAogICAgIGlm ICghW3NlbGYgX3ByZXBhcmVBY2Nlc3NpYmlsaXR5Q2FsbF0pCiAgICAgICAgIHJldHVybiBOU05v dEZvdW5kOwogICAgIAotICAgIEFYQXR0cmlidXRlQ2FjaGVFbmFibGVyIGVuYWJsZUNhY2hlKG1f b2JqZWN0LT5heE9iamVjdENhY2hlKCkpOwogICAgIGlmIChbc2VsZiBpc0F0dGFjaG1lbnRdKQog ICAgICAgICByZXR1cm4gW1tzZWxmIGF0dGFjaG1lbnRWaWV3XSBpbmRleE9mQWNjZXNzaWJpbGl0 eUVsZW1lbnQ6ZWxlbWVudF07CiAgICAgCg==