133024 2014-05-16 21:17:49 -0700 [Phone Number Detection] drop-down menu in the phone number detection box doesn't appear 2014-05-17 14:50:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham beidson bfulgham commit-queue webkit-bug-importer oldest_to_newest 1009930 0 bfulgham 2014-05-16 21:17:49 -0700 The data detector menu was not working because the 'drawRects' function was clearing the set of selected phone numbers on each draw operation. This is wrong, because the drawRect function is called for each drawing tile. Since the screen often has ~9 tiles, and the last tile is likely to not have a phone number causing the set of selected phone numbers to get cleared. 1009931 1 231620 bfulgham 2014-05-16 21:20:11 -0700 Created attachment 231620 Patch 1009932 2 bfulgham 2014-05-16 21:22:00 -0700 <rdar://problem/16917021> 1009933 3 231620 sam 2014-05-16 21:45:19 -0700 Comment on attachment 231620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review > Source/WebKit2/ChangeLog:10 > + time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active ~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much? 1009952 4 231620 bfulgham 2014-05-17 00:20:27 -0700 Comment on attachment 231620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231620&action=review >> Source/WebKit2/ChangeLog:10 >> + time we call drawRect. This gets called ~9 times per screen refresh, so end up with no active > > ~9 times? That seems like a lot. Do we have a bug tracking why we are calling drawRect here so much? Once per tile. It varies by how much of the screen is dirty, and how large the screen is. I think this is working as designed.. 1009996 5 231620 commit-queue 2014-05-17 14:50:26 -0700 Comment on attachment 231620 Patch Clearing flags on attachment: 231620 Committed r168998: <http://trac.webkit.org/changeset/168998> 1009997 6 commit-queue 2014-05-17 14:50:29 -0700 All reviewed patches have been landed. Closing bug. 231620 2014-05-16 21:20:11 -0700 2014-05-17 14:50:26 -0700 Patch bug-133024-20140516211948.patch text/plain 1742 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODk5MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtQaG9uZSBOdW1iZXIgRGV0 ZWN0aW9uXSBkcm9wLWRvd24gbWVudSBpbiB0aGUgcGhvbmUgbnVtYmVyIGRldGVjdGlvbiBib3gg ZG9lc24ndCBhcHBlYXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzMwMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvVGVsZXBob25lTnVtYmVyT3ZlcmxheUNv bnRyb2xsZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6OlRlbGVwaG9uZU51bWJlck92ZXJsYXlD b250cm9sbGVyOjpkcmF3UmVjdCk6IERvbid0IGNsZWFyIHRoZSBzZXQgb2YgZm91bmQgcGhvbmUg bnVtYmVycyBlYWNoCisgICAgICAgIHRpbWUgd2UgY2FsbCBkcmF3UmVjdC4gVGhpcyBnZXRzIGNh bGxlZCB+OSB0aW1lcyBwZXIgc2NyZWVuIHJlZnJlc2gsIHNvIGVuZCB1cCB3aXRoIG5vIGFjdGl2 ZQorICAgICAgICBwaG9uZSBudW1iZXJzIHRvIGludGVyYWN0IHdpdGguCisKIDIwMTQtMDUtMTYg IFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0dUS10gQnVpbGQg YnJlYWsgYWZ0ZXIgMTY4OTc4LgpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9UZWxlcGhvbmVOdW1iZXJPdmVybGF5Q29udHJvbGxlck1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9uZU51bWJl ck92ZXJsYXlDb250cm9sbGVyTWFjLm1tCShyZXZpc2lvbiAxNjg5NzUpCisrKyBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RlbGVwaG9uZU51bWJlck92ZXJsYXlDb250cm9s bGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02OSwxMSArNjksMTEgQEAgc3RhdGljIEludFJl Y3QgdGV4dFF1YWRzVG9Cb3VuZGluZ1JlY3RGbwogCiB2b2lkIFRlbGVwaG9uZU51bWJlck92ZXJs YXlDb250cm9sbGVyOjpkcmF3UmVjdChQYWdlT3ZlcmxheSogb3ZlcmxheSwgV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0JiBncmFwaGljc0NvbnRleHQsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGRp cnR5UmVjdCkKIHsKLSAgICBpZiAobV9jdXJyZW50U2VsZWN0aW9uUmFuZ2VzLmlzRW1wdHkoKSkK KyAgICBpZiAobV9jdXJyZW50U2VsZWN0aW9uUmFuZ2VzLmlzRW1wdHkoKSkgeworICAgICAgICBj bGVhckhpZ2hsaWdodHMoKTsKICAgICAgICAgcmV0dXJuOwotICAgIAotICAgIGNsZWFySGlnaGxp Z2h0cygpOwotICAgIAorICAgIH0KKwogICAgIENHQ29udGV4dFJlZiBjZ0NvbnRleHQgPSBncmFw aGljc0NvbnRleHQucGxhdGZvcm1Db250ZXh0KCk7CiAgICAgCiAgICAgZm9yIChhdXRvJiByYW5n ZSA6IG1fY3VycmVudFNlbGVjdGlvblJhbmdlcykgewo=