133015 2014-05-16 15:57:27 -0700 Need a way to get a WKPageRef from a WKWebView 2014-05-18 14:58:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad All RESOLVED WONTFIX P2 Normal --- 133050 1 dfarler ddkilzer andersca benjamin commit-queue ddkilzer sam simon.fraser thorton oldest_to_newest 1009880 0 dfarler 2014-05-16 15:57:27 -0700 PlatformWebView in WebKitTestRunner has public WKPageRef page() but WKWebView doesn't currently have API to provide this. 1009981 1 231634 ddkilzer 2014-05-17 08:42:23 -0700 Created attachment 231634 Patch v1 I'm sure there are layer violations (like returning a C API struct from an Objective-C class), but I'm assuming we want this to move off the deprecated WKView class first. 1010011 2 231634 benjamin 2014-05-17 17:08:13 -0700 Comment on attachment 231634 Patch v1 Cool! 1010012 3 231634 commit-queue 2014-05-17 17:39:08 -0700 Comment on attachment 231634 Patch v1 Clearing flags on attachment: 231634 Committed r169001: <http://trac.webkit.org/changeset/169001> 1010013 4 commit-queue 2014-05-17 17:39:12 -0700 All reviewed patches have been landed. Closing bug. 1010033 5 sam 2014-05-17 20:58:00 -0700 I'm worried about why this is being done. If the idea is to use WKPageRef to set up the needed clients in WKTR, that won't work, and we will really need to add an abstraction so the objective-c API can be used there. 1010042 6 benjamin 2014-05-17 22:31:18 -0700 (In reply to comment #5) > I'm worried about why this is being done. If the idea is to use WKPageRef to set up the needed clients in WKTR, that won't work, and we will really need to add an abstraction so the objective-c API can be used there. WKTR will need it to send events and some internal testing stuff. It looks like it also setup the clients in TestController::createOtherPage(). Moving away from that is gonna suck, the C API was awesome to setup cross-port tests. 1010075 7 andersca 2014-05-18 09:24:57 -0700 Yeah, this patch is wrong. I'm going to roll it out. 1010076 8 andersca 2014-05-18 09:26:42 -0700 It should not be possible to get at the C SPI from the modern API. We're trying to get rid of the modern API. 1010078 9 commit-queue 2014-05-18 09:27:09 -0700 Re-opened since this is blocked by bug 133050 1010111 10 benjamin 2014-05-18 14:41:08 -0700 (In reply to comment #7) > Yeah, this patch is wrong. I'm going to roll it out. Anders, you created this situation in the first place. Any chance you could fix testing? 1010112 11 andersca 2014-05-18 14:55:45 -0700 (In reply to comment #10) > (In reply to comment #7) > > Yeah, this patch is wrong. I'm going to roll it out. > > Anders, you created this situation in the first place. Any chance you could fix testing? Sam is interested in fixing it. In any case, I'm going to WONTFIX this since we're never going to expose the old SPI from the new API. 1010113 12 benjamin 2014-05-18 14:58:33 -0700 (In reply to comment #11) > (In reply to comment #10) > > (In reply to comment #7) > > > Yeah, this patch is wrong. I'm going to roll it out. > > > > Anders, you created this situation in the first place. Any chance you could fix testing? > > Sam is interested in fixing it. > > In any case, I'm going to WONTFIX this since we're never going to expose the old SPI from the new API. I really don't care how we expose the internals. I just want WKView to get out of the way and be able to run certain tests. 231634 2014-05-17 08:42:23 -0700 2014-05-17 17:39:08 -0700 Patch v1 bug-133015-20140517084116.patch text/plain 2090 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNlODY5N2U0NTM4YjI2 YmVmYjA4YmM2ZjA0ODM3ZGRlZWU4OGUxOC4uZjYzM2QwMzgxMzQwZGZkNWFkMjc5ZjdiNGRjZTRi MzBjNzlmMmYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTE3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHdheSB0byBn ZXQgYSBXS1BhZ2VSZWYgZnJvbSBhIFdLV2ViVmlldworICAgICAgICA8aHR0cDovL3dlYmtpdC5v cmcvYi8xMzMwMTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IF9wYWdlUmVmXSk6IEFkZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3UHJpdmF0ZS5oOgorICAgICAgICAoLVtXS1dlYlZpZXcgX3BhZ2VSZWZdKTogQWRk ZWQgZGVjbGFyYXRpb24uCisKIDIwMTQtMDUtMTUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFp bkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bV0syXSBXS1dlYlZpZXcgc2VuZHMgaW52YWxp ZCBjb250ZW50IG9mZnNldHMgYXQgdGhlIGVuZCBvZiBhbmltYXRlZCByZXNpemUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggY2I4Yzg1 NGJkYjM3NzdlMWMzMDIxN2ZmOGE5NjlhMjQxMThhYjE4MC4uNjVjOTg5NmE5NmY2YjJiMGUzYWY4 ZDhiYjkzMmEyYThiYWVlNzA3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTE0NDEsNiArMTQ0MSwxMSBAQCAtICh2b2lkKV9zZXRG b3JtRGVsZWdhdGU6KGlkIDxfV0tGb3JtRGVsZWdhdGU+KWZvcm1EZWxlZ2F0ZQogICAgICAgICBf cGFnZS0+c2V0Rm9ybUNsaWVudChudWxscHRyKTsKIH0KIAorLSAoV0tQYWdlUmVmKV9wYWdlUmVm Cit7CisgICAgcmV0dXJuIHRvQVBJKF9wYWdlLmdldCgpKTsKK30KKwogI3ByYWdtYSBtYXJrIGlP Uy1zcGVjaWZpYyBtZXRob2RzCiAKICNpZiBQTEFURk9STShJT1MpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IGFm OTQ2ZmVlMDc1ZjMyYWVkYWE3NzY1ZTEyNGRkZTA5ODQ1MGE4NGQuLjlhZTlkOTY4YzM3NmI0NTIx MGJiOWRlOWUwZGRhMmQzZDA5MjdlNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCkBAIC0yNSw2ICsyNSw4IEBACiAK ICNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXcuaD4KIAorI2ltcG9ydCA8V2ViS2l0L1dLQmFzZS5o PgorCiAjaWYgV0tfQVBJX0VOQUJMRUQKIAogdHlwZWRlZiBOU19PUFRJT05TKE5TVUludGVnZXIs IF9XS1JlbmRlcmluZ1Byb2dyZXNzRXZlbnRzKSB7CkBAIC0xNTYsNiArMTU4LDggQEAgdHlwZWRl ZiBOU19PUFRJT05TKE5TVUludGVnZXIsIF9XS0ZpbmRPcHRpb25zKSB7CiAKIEBwcm9wZXJ0eSAo bm9uYXRvbWljLCB3ZWFrLCBzZXR0ZXI9X3NldEZvcm1EZWxlZ2F0ZTopIGlkIDxfV0tGb3JtRGVs ZWdhdGU+IF9mb3JtRGVsZWdhdGU7CiAKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkg V0tQYWdlUmVmIF9wYWdlUmVmOworCiBAZW5kCiAKICNlbmRpZgo=