133010 2014-05-16 14:33:26 -0700 [WebKit2] Wake up threads blocked in waitForAndDispatchImmediately() if we lose our connection 2014-05-19 11:00:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes oldest_to_newest 1009850 0 aestes 2014-05-16 14:33:26 -0700 [WebKit2] Wake up threads blocked in waitForAndDispatchImmediately() if we lose our connection 1009852 1 231591 aestes 2014-05-16 14:36:16 -0700 Created attachment 231591 [WebKit2] Wake up threads blocked in waitForAndDispatchImmediately() if we lose our connection 1009858 2 231591 ggaren 2014-05-16 14:47:27 -0700 Comment on attachment 231591 [WebKit2] Wake up threads blocked in waitForAndDispatchImmediately() if we lose our connection View in context: https://bugs.webkit.org/attachment.cgi?id=231591&action=review r=me > Source/WebKit2/ChangeLog:27 > +2014-05-16 Andy Estes <aestes@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * Platform/IPC/Connection.cpp: > + (IPC::Connection::Connection): > + (IPC::Connection::waitForMessage): > + (IPC::Connection::connectionDidClose): > + * Platform/IPC/Connection.h: ChangeLog conflict-o. > Source/WebKit2/Platform/IPC/Connection.cpp:682 > + m_waitForMessageCondition.notify_all(); > + } It is an optimization to drop the lock *before* calling notify_all(). Otherwise, you will wake a thread and it will promptly sleep again due to failing to acquire the locked mutex. Please move the call to notify_all() out of the lock scope. 1010231 3 aestes 2014-05-19 11:00:54 -0700 Committed r169051: <http://trac.webkit.org/changeset/169051> 231591 2014-05-16 14:36:16 -0700 2014-05-16 14:47:27 -0700 [WebKit2] Wake up threads blocked in waitForAndDispatchImmediately() if we lose our connection bug-133010-20140516143553.patch text/plain 4182 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTQwMGM4NzZhNzYwMDk0 N2JkOTAyYTk0ZGQyNzcwOWRiZmQzODIxYy4uYzM4NDhlOTY3Nzg1YjMwOWZjNWEyODZlZjkzODJi ZDAwNTZlMmZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMzIEBACiAyMDE0LTA1LTE2ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBbV2ViS2l0Ml0gV2FrZSB1cCB0 aHJlYWRzIGJsb2NrZWQgaW4gd2FpdEZvckFuZERpc3BhdGNoSW1tZWRpYXRlbHkoKSBpZiB3ZSBs b3NlIG91ciBjb25uZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzMwMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJZiBhIHRocmVhZCBpcyBibG9ja2VkIG9uIG1fd2FpdEZvck1lc3NhZ2VDb25k aXRpb24gYW5kIHdlIGxvc2Ugb3VyIGNvbm5lY3Rpb24sIHRyZWF0IHRoYXQgbGlrZSB3ZSBkbyBh IHRpbWVvdXQuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5jcHA6CisgICAg ICAgIChJUEM6OkNvbm5lY3Rpb246OkNvbm5lY3Rpb24pOgorICAgICAgICAoSVBDOjpDb25uZWN0 aW9uOjp3YWl0Rm9yTWVzc2FnZSk6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OmNvbm5lY3Rp b25EaWRDbG9zZSk6CisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaDoKKworMjAx NC0wNS0xNiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBh IHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9P UFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFBsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6 Q29ubmVjdGlvbik6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OndhaXRGb3JNZXNzYWdlKToK KyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKToKKyAgICAgICAg KiBQbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oOgorCisyMDE0LTA1LTE2ICBBbmR5IEVzdGVzICA8 YWVzdGVzQGFwcGxlLmNvbT4KKwogICAgICAgICBbaU9TXSBDcmVhdGUgYSBVSVByaW50Rm9ybWF0 dGVyIGZvciBXS1dlYlZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzMzAwNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9J UEMvQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlv bi5jcHAKaW5kZXggMzIxYzEyMDFiMGQ1YzQ3NWM3YTQwNDBhOTE5NWJhMmE0ODkxMDg4NC4uYTBm ZmI2OGI5YjQwMjQ5NjBkYWIzOWU1ZGI5OGYyYWI0ODFmZDg5YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmNwcApAQCAtMjI1LDYgKzIyNSw3IEBAIENvbm5lY3Rp b246OkNvbm5lY3Rpb24oSWRlbnRpZmllciBpZGVudGlmaWVyLCBib29sIGlzU2VydmVyLCBDbGll bnQqIGNsaWVudCwgUnVuCiAgICAgLCBtX2luRGlzcGF0Y2hNZXNzYWdlQ291bnQoMCkKICAgICAs IG1faW5EaXNwYXRjaE1lc3NhZ2VNYXJrZWREaXNwYXRjaFdoZW5XYWl0aW5nRm9yU3luY1JlcGx5 Q291bnQoMCkKICAgICAsIG1fZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdlKGZhbHNlKQorICAgICwg bV9tZXNzYWdlV2FpdGluZ0ludGVycnVwdGVkQnlDbG9zZWRDb25uZWN0aW9uKGZhbHNlKQogICAg ICwgbV9zeW5jTWVzc2FnZVN0YXRlKFN5bmNNZXNzYWdlU3RhdGU6OmdldE9yQ3JlYXRlKGNsaWVu dFJ1bkxvb3ApKQogICAgICwgbV9zaG91bGRXYWl0Rm9yU3luY1JlcGxpZXModHJ1ZSkKIHsKQEAg LTQxMywxMCArNDE0LDE2IEBAIHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdlRGVjb2Rlcj4gQ29ubmVj dGlvbjo6d2FpdEZvck1lc3NhZ2UoU3RyaW5nUmVmZXJlbmNlIG1lc3NhCiAgICAgICAgIH0KIAog ICAgICAgICAvLyBOb3cgd2Ugd2FpdC4KLSAgICAgICAgaWYgKG1fd2FpdEZvck1lc3NhZ2VDb25k aXRpb24ud2FpdF9mb3IobG9jaywgdGltZW91dCkgPT0gc3RkOjpjdl9zdGF0dXM6OnRpbWVvdXQp IHsKLSAgICAgICAgICAgIC8vIFdlIHRpbWVkIG91dCwgbm93IHJlbW92ZSB0aGUgcGVuZGluZyB3 YWl0LgorICAgICAgICBzdGQ6OmN2X3N0YXR1cyBzdGF0dXMgPSBtX3dhaXRGb3JNZXNzYWdlQ29u ZGl0aW9uLndhaXRfZm9yKGxvY2ssIHRpbWVvdXQpOworICAgICAgICBpZiAoc3RhdHVzID09IHN0 ZDo6Y3Zfc3RhdHVzOjp0aW1lb3V0IHx8IG1fbWVzc2FnZVdhaXRpbmdJbnRlcnJ1cHRlZEJ5Q2xv c2VkQ29ubmVjdGlvbikgeworICAgICAgICAgICAgLy8gV2UgdGltZWQgb3V0IG9yIGxvc3Qgb3Vy IGNvbm5lY3Rpb24sIG5vdyByZW1vdmUgdGhlIHBlbmRpbmcgd2FpdC4KICAgICAgICAgICAgIG1f d2FpdEZvck1lc3NhZ2VNYXAucmVtb3ZlKG1lc3NhZ2VBbmREZXN0aW5hdGlvbik7CiAKKyAgICAg ICAgICAgIC8vIElmIHRoZXJlIGFyZSBubyBtb3JlIHdhaXRlcnMsIHJlc2V0IG1fbWVzc2FnZVdh aXRpbmdJbnRlcnJ1cHRlZEJ5Q2xvc2VkQ29ubmVjdGlvbiB3aGlsZSB3ZSBhbHJlYWR5IGhvbGQK KyAgICAgICAgICAgIC8vIHRoZSBuZWNlc3NhcnkgbG9jayBpbiBjYXNlIHRoZSBjb25uZWN0aW9u IGlzIGxhdGVyIHJlb3BlbmVkLgorICAgICAgICAgICAgaWYgKG1fd2FpdEZvck1lc3NhZ2VNYXAu aXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIG1fbWVzc2FnZVdhaXRpbmdJbnRlcnJ1cHRlZEJ5 Q2xvc2VkQ29ubmVjdGlvbiA9IGZhbHNlOworCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQogICAgIH0KQEAgLTY2OCw2ICs2NzUsMTIgQEAgdm9pZCBDb25uZWN0aW9uOjpjb25uZWN0aW9u RGlkQ2xvc2UoKQogICAgICAgICAgICAgaXRlci0+dmFsdWUtPnNlbWFwaG9yZS5zaWduYWwoKTsK ICAgICB9CiAKKyAgICB7CisgICAgICAgIHN0ZDo6bG9ja19ndWFyZDxzdGQ6Om11dGV4PiBsb2Nr KG1fd2FpdEZvck1lc3NhZ2VNdXRleCk7CisgICAgICAgIG1fbWVzc2FnZVdhaXRpbmdJbnRlcnJ1 cHRlZEJ5Q2xvc2VkQ29ubmVjdGlvbiA9IHRydWU7CisgICAgICAgIG1fd2FpdEZvck1lc3NhZ2VD b25kaXRpb24ubm90aWZ5X2FsbCgpOworICAgIH0KKwogICAgIGlmIChtX2RpZENsb3NlT25Db25u ZWN0aW9uV29ya1F1ZXVlQ2FsbGJhY2spCiAgICAgICAgIG1fZGlkQ2xvc2VPbkNvbm5lY3Rpb25X b3JrUXVldWVDYWxsYmFjayh0aGlzKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxh dGZvcm0vSVBDL0Nvbm5lY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25u ZWN0aW9uLmgKaW5kZXggODJkMzdiMmI4NGIwZjZjMDM5YTk5OTMyYWFhYTA5YzUyZGRhNmYwNy4u MTJmMzg4MGE4ZDA0YjkxNmIwMWE4ODQ0OWIxOWIyNTk0M2I4MWM0NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oCkBAIC0yMzksNiArMjM5LDcgQEAgcHJpdmF0ZToK ICAgICAKICAgICBzdGQ6OmNvbmRpdGlvbl92YXJpYWJsZSBtX3dhaXRGb3JNZXNzYWdlQ29uZGl0 aW9uOwogICAgIHN0ZDo6bXV0ZXggbV93YWl0Rm9yTWVzc2FnZU11dGV4OworICAgIGJvb2wgbV9t ZXNzYWdlV2FpdGluZ0ludGVycnVwdGVkQnlDbG9zZWRDb25uZWN0aW9uOwogICAgIEhhc2hNYXA8 c3RkOjpwYWlyPHN0ZDo6cGFpcjxTdHJpbmdSZWZlcmVuY2UsIFN0cmluZ1JlZmVyZW5jZT4sIHVp bnQ2NF90Piwgc3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VEZWNvZGVyPj4gbV93YWl0Rm9yTWVzc2Fn ZU1hcDsKIAogICAgIC8vIFJlcHJlc2VudHMgYSBzeW5jIHJlcXVlc3QgZm9yIHdoaWNoIHdlJ3Jl IHdhaXRpbmcgb24gYSByZXBseS4K