132982 2014-05-15 18:14:41 -0700 [EFL][[WK2] test_ewk2_text_checker is failed 2014-12-10 04:59:32 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 132813 1 gyuyoung.kim g.czajkowski commit-queue g.czajkowski lucas.de.marchi rniwa oldest_to_newest 1009682 0 gyuyoung.kim 2014-05-15 18:14:41 -0700 [ RUN ] EWK2TextCheckerTest.ewk_text_checker_unique_spell_document_tag /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:760: Failure Value of: callbacksExecutionStats.spellDocumentTag Actual: false Expected: true [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_unique_spell_document_tag (610 ms) [ RUN ] EWK2TextCheckerTest.ewk_text_checker_string_spelling_check_cb_set /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:781: Failure Value of: callbacksExecutionStats.spellingCheck Actual: false Expected: true [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_string_spelling_check_cb_set (689 ms) [ RUN ] EWK2TextCheckerTest.ewk_text_checker_word_guesses_get_cb_set [ OK ] EWK2TextCheckerTest.ewk_text_checker_word_guesses_get_cb_set (1191 ms) [ RUN ] EWK2TextCheckerTest.ewk_text_checker_word_learn_cb_set /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:833: Failure Value of: callbacksExecutionStats.spellingCheck Actual: false Expected: true [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_word_learn_cb_set (1195 ms) [ RUN ] EWK2TextCheckerTest.ewk_text_checker_word_ignore_cb_set /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:167: Failure Value of: text Actual: "aa" Expected: knownWord.utf8().data() Which is: "" /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:318: Failure Value of: ignoreSpellingItem Actual: false Expected: true ERR<1875>: /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:158 ewk_context_menu_item_select() safety check failed: item == NULL /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:167: Failure Value of: text Actual: "aa" Expected: knownWord.utf8().data() Which is: "" /mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:856: Failure Value of: waitUntilTrue(callbacksExecutionStats.wordIgnore) Actual: false Expected: true [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_word_ignore_cb_set (10624 ms) [----------] 18 tests from EWK2TextCheckerTest (22989 ms total) [----------] Global test environment tear-down [==========] 18 tests from 1 test case ran. (22989 ms total) [ PASSED ] 14 tests. [ FAILED ] 4 tests, listed below: [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_unique_spell_document_tag [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_string_spelling_check_cb_set [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_word_learn_cb_set [ FAILED ] EWK2TextCheckerTest.ewk_text_checker_word_ignore_cb_set 4 FAILED TESTS 1053784 1 g.czajkowski 2014-12-09 07:43:41 -0800 The reason why EFL's text checker API fails is that the input element's value change (from JS) does not invoke spell checker (unless user starts typing manually). FAIL: document.getElementById("spellTest").value = "TextThatShouldBeMarkedAsMisspelled "; PASS: document.execCommand("InsertText", false, "TextThatShouldBeMarkedAsMisspelled "); Ryosuke, is it ok that we omit spellchecking for programmatically input.value changes? It seems that it worked as those tests were passing (can not find revision as it was long time ago). FYI, Safari, Chrome EFL's MiniBrowser does not trigger spellcecking for input.value changes. 1053785 2 242919 g.czajkowski 2014-12-09 07:45:22 -0800 Created attachment 242919 test case 1054091 3 g.czajkowski 2014-12-10 01:50:52 -0800 (In reply to comment #1) > The reason why EFL's text checker API fails is that the input element's > value change (from JS) does not invoke spell checker (unless user starts > typing manually). > > FAIL: > document.getElementById("spellTest").value = > "TextThatShouldBeMarkedAsMisspelled "; > > PASS: > document.execCommand("InsertText", false, > "TextThatShouldBeMarkedAsMisspelled "); > > Ryosuke, is it ok that we omit spellchecking for programmatically > input.value changes? It seems that it worked as those tests were passing > (can not find revision as it was long time ago). > > FYI, Safari, Chrome EFL's MiniBrowser does not trigger spellcecking for > input.value changes. Created a separate bug for this issue as it looks like cross platform one (bug 139473). 1054097 4 243003 g.czajkowski 2014-12-10 02:52:17 -0800 Created attachment 243003 Patch 1054120 5 243003 commit-queue 2014-12-10 04:59:28 -0800 Comment on attachment 243003 Patch Clearing flags on attachment: 243003 Committed r177057: <http://trac.webkit.org/changeset/177057> 1054121 6 commit-queue 2014-12-10 04:59:32 -0800 All reviewed patches have been landed. Closing bug. 242919 2014-12-09 07:45:22 -0800 2014-12-09 07:45:22 -0800 test case input_type_spellcheck.html text/html 418 g.czajkowski PEhUTUw+CjxzY3JpcHQ+CmZ1bmN0aW9uIGluc2VydFRleHQoKSB7CiAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgic3BlbGxUZXN0IikuZm9jdXMoKTsKICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJzcGVsbFRlc3QiKS52YWx1ZSA9ICJUZXh0VGhhdFNob3VsZEJlTWFya2VkQXNNaXNzcGVs bGVkICI7CiAgICAKICAgIC8vIEhvd2V2ZXIsIGl0IHNwZWxsIGNoZWNrcyBkdXJpbmcgZXhlY0Nv bW1hbmQgLi4uCiAgICAvL2RvY3VtZW50LmV4ZWNDb21tYW5kKCJJbnNlcnRUZXh0IiwgZmFsc2Us ICJUZXh0VGhhdFNob3VsZEJlTWFya2VkQXNNaXNzcGVsbGVkICIpOwp9Cjwvc2NyaXB0Pgo8Qk9E WSBvbmxvYWQ9Imluc2VydFRleHQoKSI+CjxJTlBVVCB0eXBlPSJ0ZXh0IiBpZD0ic3BlbGxUZXN0 Ij4KPC9CT0RZPgo8L0hUTUw+Cg== 243003 2014-12-10 02:52:17 -0800 2014-12-10 04:59:28 -0800 Patch bug-132982-20141210115257.patch text/plain 2766 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzZlMTk0NGM4ZDIwYjg2 MDQzMGVkMTVhMjI3ODZhOWY2OWVlYTY5Ny4uNzY0NTJiYTFjYzNiZGQxNzEzYjk5YTMxNzljZWZi ZjM2YjMxMGZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTEyLTEwICBHcnpl Z29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtF RkxdW1tXSzJdIHRlc3RfZXdrMl90ZXh0X2NoZWNrZXIgaXMgZmFpbGVkCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI5ODIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNlcnQgbWlzc3BlbGxlZCB3b3Jk IHRvIHRoZSBpbnB1dCBmaWVsZCB1c2luZyBleGVjQ29tbWFuZCBpbnN0ZWFkIG9mCisgICAgICAg IGlucHV0LnZhbHVlIGF0dHJpYnV0ZSBjaGFuZ2Ugd2hpY2ggc3RvcHMgc3BlbGwgY2hlY2ssIHRy YWNrZWQgYnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzOTQ3My4KKworICAgICAgICBTaW5jZSB0ZXh0IGNoZWNrZXIgQVBJIHRlc3RzIGRvIG5vdCB2 ZXJpZnkgc3BlbGxjaGVja2VyIGl0c2VsZiAoaXQncyBiZWluZworICAgICAgICB0ZXN0ZWQgYnkg TGF5b3V0VGVzdHMvZWRpdGluZy9zcGVsbGluZykgYnV0IHJhdGhlciBvcHBvcnR1bml0eSBmb3Ig b3ZlcnJpZGluZworICAgICAgICBpdHMgZnVuY3Rpb25hbGl0eSB0aGlzIHBhdGNoIHVuc2tpcHMg dGhvc2UgdGVzdHMgaW4gb3JkZXIgdG8gQVBJIGNvdmVyYWdlLgorCisgICAgICAgICogUGxhdGZv cm1FZmwuY21ha2U6CisgICAgICAgIFVuc2tpcCB0ZXN0X2V3azJfdGV4dF9jaGVja2VyCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9yZXNvdXJjZXMvc3BlbGxpbmdfdGVzdC5o dG1sOgorICAgICAgICBVc2UgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRleHQiLCBmYWxz ZSwgImFhICIpIGluc3RlYWQgb2YKKyAgICAgICAgaW5wdXQudmFsdWUgPSAiYWEgIiB0byB0cmln Z2VyIHNwZWxsY2hlY2tlci4KKwogMjAxNC0xMi0wOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3Nz eUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVSVEJGIGFmdGVyIHIxNzcwMzIuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtRWZsLmNtYWtlCmluZGV4IDc5ODdhNTg2MjQyMDc0Nzc0ZDBiZTA5ZTFmYzMwYzM2MzIzODcz ODQuLjYyYjRiNjgzZjhhZTYzODEyZTlmY2JhYmUwZmE0YjczYTY5Y2UxMGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtRWZsLmNtYWtlCkBAIC01MTcsNiArNTE3LDcgQEAgc2V0KEVXSzJVbml0VGVzdHNfQklO QVJJRVMKICAgICB0ZXN0X2V3azJfc2V0dGluZ3MKICAgICB0ZXN0X2V3azJfc3NsCiAgICAgdGVz dF9ld2syX3N0b3JhZ2VfbWFuYWdlcgorICAgIHRlc3RfZXdrMl90ZXh0X2NoZWNrZXIKICAgICB0 ZXN0X2V3azJfdmlldwogICAgIHRlc3RfZXdrMl93aW5kb3dfZmVhdHVyZXMKICkKQEAgLTUyNiw3 ICs1MjcsNiBAQCBzZXQoRVdLMlVuaXRUZXN0c19CSU5BUklFUwogIyB3ZWJraXQub3JnL2IvMTA3 NDIyOiB0ZXN0X2V3azJfYXV0aF9yZXF1ZXN0CiAjIHdlYmtpdC5vcmcvYi8xMzI5ODA6IHRlc3Rf ZXdrMl9jb250ZXh0X21lbnUKICMgd2Via2l0Lm9yZy9iLzEzMjk4MTogdGVzdF9ld2syX2Rvd25s b2FkX2pvYgotIyB3ZWJraXQub3JnL2IvMTMyOTgyOiB0ZXN0X2V3azJfdGV4dF9jaGVja2VyCiAK IGlmIChFTkFCTEVfQVBJX1RFU1RTKQogICAgIGZvcmVhY2ggKHRlc3ROYW1lICR7RVdLMlVuaXRU ZXN0c19CSU5BUklFU30pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy9yZXNvdXJjZXMvc3BlbGxpbmdfdGVzdC5odG1sIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvcmVzb3VyY2VzL3NwZWxsaW5nX3Rlc3QuaHRtbAppbmRl eCBiZjkzODIwZjE5NmRjYTBlOTg5NGRkOTcyY2U4OWMzYzVhMDE1MjU4Li4xNWNiY2NiMDU3ZjRj ZGU3ZjNiMzdlNDk2ZjVmMDJkNGIzNDkwNzIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9yZXNvdXJjZXMvc3BlbGxpbmdfdGVzdC5odG1sCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Jlc291cmNlcy9zcGVsbGlu Z190ZXN0Lmh0bWwKQEAgLTEyLDcgKzEyLDcgQEAKICAgICAgICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJpbnB1dCIpLmZvY3VzKCk7CiAKICAgICAgICAgICAgIC8vICdTcGFjZScgbm90 aWZpZXMgV2ViS2l0IHRoYXQgd29yZCBoYXMgYmVlbiBpbnNlcnRlZC4KLSAgICAgICAgICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJpbnB1dCIpLnZhbHVlID0gImFhICI7CisgICAgICAgICAg ICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0VGV4dCIsIGZhbHNlLCAiYWEgIik7CiAgICAg ICAgIH0KICAgICA8L1NDUklQVD4KIDwvSEVBRD4K