132975 2014-05-15 16:43:20 -0700 old-run-webkit-tests: allow specifying a simulator app path 2014-05-16 09:35:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler ddkilzer oldest_to_newest 1009659 0 dfarler 2014-05-15 16:43:20 -0700 Since the iOS simulator app bundle may not already be registered with launch services (multiple relocatable Xcode.app bundles may exist on the machine), provide a command line parameter to specify exactly where the simulator app is for the first launch. 1009669 1 231544 dfarler 2014-05-15 17:22:28 -0700 Created attachment 231544 Patch 1009687 2 231544 ddkilzer 2014-05-15 18:36:58 -0700 Comment on attachment 231544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231544&action=review r=me, but consider providing a more specific default as well based on $SDKROOT. > Tools/Scripts/old-run-webkit-tests:191 > +my $simulatorApp = 'iOS Simulator'; Instead of specifying a command-line argument, why not just construct the path based on the $SDKROOT path? It's always installed at a well-known location, so we should be able to construct the path using the $SDKROOT. I'm surprised there isn't a way to find it using 'xcrun -sdk iphonesimulator', but maybe that's only for command-line executables. 1009767 3 dfarler 2014-05-16 08:46:09 -0700 Roger. I guess it would be better to do something like the following, which should provide an accurate default. I guess most people aren't switching between Xcode.app bundles on an hourly basis :). chomp(my $developerDir = $ENV{DEVELOPER_DIR} || `xcode-select --print-path`); my $simulatorApp = "$developerDir/Applications/iOS Simulator.app"; unless (-d $simulatorApp) { $simulatorApp = "$developerDir/Applications/iPhone Simulator.app"; } 1009768 4 231574 dfarler 2014-05-16 08:47:34 -0700 Created attachment 231574 Patch 1009778 5 dfarler 2014-05-16 09:35:08 -0700 Committed r168969: <http://trac.webkit.org/changeset/168969> 231544 2014-05-15 17:22:28 -0700 2014-05-16 08:47:32 -0700 Patch bug-132975-20140515172244.patch text/plain 1985 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4OTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzc3MGNkODc5MjIxYjQ1MGYzZTQxMDBkZWMyYjFjZDhi NDlhN2QwMS4uMTk0MjAzNjY4YmYyNWEzZjFmYjEzNzM5ODFiZWY2YjQ4OGFlZTk0NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA1LTE1ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICBvbGQtcnVuLXdlYmtpdC10ZXN0czogYWxsb3cgc3BlY2lmeWluZyBhIHNpbXVsYXRvciBh cHAgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyOTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAgICAob3BlbklQaG9uZVNpbXVs YXRvcik6CisgICAgICAgIEFkZCBuZXcgLS1zaW11bGF0b3ItYXBwIGNvbW1hbmQgbGluZSBwYXJh bWV0ZXIgZm9yIHNwZWNpZnlpbmcgdGhlCisgICAgICAgIGFic29sdXRlIHBhdGggdG8gdGhlIHNp bXVsYXRvciBhcHAgdG8gbGF1bmNoIGJlZm9yZSBzdGFydGluZyBhCisgICAgICAgIHNlc3Npb24u CisKIDIwMTQtMDUtMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBTdXBwb3J0IFRlc3RXZWJLaXRBUEkgaW4gdGhlIGlPUyBTaW11bGF0b3IKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IGQzOGIxZTY1NTFhYzA0NTQwMDAzNzc4ZTNh MTU5OTRiZjQwMjc0MTAuLjczMTZkMTQ3Y2UyMzk5Y2U5ZDNiYWEyN2QxNDMxMzJkMWU2YjNkM2Ig MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMTg4LDYgKzE4OCw3IEBAIG15ICR2 ZXJib3NlID0gMDsKIG15ICRzaG91bGRXYWl0Rm9ySFRUUEQgPSAwOwogbXkgJHVzZVdlYktpdFRl c3RSdW5uZXIgPSAwOwogbXkgJG5vQnVpbGREdW1wVG9vbCA9IDA7CitteSAkc2ltdWxhdG9yQXBw ID0gJ2lPUyBTaW11bGF0b3InOwogCiAjIFRoZXNlIGFyZ3VtZW50cyBhcmUgaWdub3JlZCwgYnV0 IGV4aXN0IGZvciBjb21wYXRpYmlsaXR5IHdpdGggbmV3LXJ1bi13ZWJraXQtdGVzdHMuCiBteSAk YnVpbGRlck5hbWUgPSAnJzsKQEAgLTQwNiw2ICs0MDcsNyBAQCBteSAkZ2V0T3B0aW9uc1Jlc3Vs dCA9IEdldE9wdGlvbnMoCiAgICAgJ2J1aWxkLW51bWJlcj1zJyA9PiBcJGJ1aWxkTnVtYmVyLAog ICAgICdtYXN0ZXItbmFtZT1zJyA9PiBcJG1hc3Rlck5hbWUsCiAgICAgJ3Rlc3QtcmVzdWx0cy1z ZXJ2ZXI9cycgPT4gXCR0ZXN0UmVzdWx0c1NlcnZlciwKKyAgICAnc2ltdWxhdG9yLWFwcD1zJyA9 PiBcJHNpbXVsYXRvckFwcCwKICk7CiAKIGlmICghJGdldE9wdGlvbnNSZXN1bHQgfHwgJHNob3dI ZWxwKSB7CkBAIC0xNDI3LDcgKzE0MjksNyBAQCBzdWIgb3BlbklQaG9uZVNpbXVsYXRvcigpCiAK ICAgICBteSAkZGV2aWNlTmFtZSA9IGFyY2hpdGVjdHVyZSgpIGVxICdpMzg2JyA/ICJpUGhvbmUg NSIgOiAiaVBob25lIDVzIjsKIAotICAgIHN5c3RlbSAib3BlbiIsICItYSIsICJpT1MgU2ltdWxh dG9yIiwgIi0tYXJncyIsICItU2Vzc2lvbk9uTGF1bmNoIiwgIk5PIiwgIi1TaW11bGF0ZURldmlj ZSIsICRkZXZpY2VOYW1lOworICAgIHN5c3RlbSAib3BlbiIsICItYSIsICRzaW11bGF0b3JBcHAs ICItLWFyZ3MiLCAiLVNlc3Npb25PbkxhdW5jaCIsICJOTyIsICItU2ltdWxhdGVEZXZpY2UiLCAk ZGV2aWNlTmFtZTsKIAogICAgIGRpZSAkISBpZiBleGl0U3RhdHVzKCQ/KTsKIAo= 231574 2014-05-16 08:47:34 -0700 2014-05-16 09:32:11 -0700 Patch bug-132975-20140516084754.patch text/plain 2200 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4OTE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzc3MGNkODc5MjIxYjQ1MGYzZTQxMDBkZWMyYjFjZDhi NDlhN2QwMS4uMTk0MjAzNjY4YmYyNWEzZjFmYjEzNzM5ODFiZWY2YjQ4OGFlZTk0NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA1LTE1ICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNvbT4KKworICAg ICAgICBvbGQtcnVuLXdlYmtpdC10ZXN0czogYWxsb3cgc3BlY2lmeWluZyBhIHNpbXVsYXRvciBh cHAgcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTMyOTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL29sZC1ydW4td2Via2l0LXRlc3RzOgorICAgICAgICAob3BlbklQaG9uZVNpbXVs YXRvcik6CisgICAgICAgIEFkZCBuZXcgLS1zaW11bGF0b3ItYXBwIGNvbW1hbmQgbGluZSBwYXJh bWV0ZXIgZm9yIHNwZWNpZnlpbmcgdGhlCisgICAgICAgIGFic29sdXRlIHBhdGggdG8gdGhlIHNp bXVsYXRvciBhcHAgdG8gbGF1bmNoIGJlZm9yZSBzdGFydGluZyBhCisgICAgICAgIHNlc3Npb24u CisKIDIwMTQtMDUtMTUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBTdXBwb3J0IFRlc3RXZWJLaXRBUEkgaW4gdGhlIGlPUyBTaW11bGF0b3IKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3Jp cHRzL29sZC1ydW4td2Via2l0LXRlc3RzCmluZGV4IGQzOGIxZTY1NTFhYzA0NTQwMDAzNzc4ZTNh MTU5OTRiZjQwMjc0MTAuLmE3YjY5MTM2MmNhMjZkMzgyYmQ1Zjk4NzE0Y2JhMmQ3NmIwNjU3Mzcg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvb2xkLXJ1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9v bHMvU2NyaXB0cy9vbGQtcnVuLXdlYmtpdC10ZXN0cwpAQCAtMTg4LDYgKzE4OCwxMSBAQCBteSAk dmVyYm9zZSA9IDA7CiBteSAkc2hvdWxkV2FpdEZvckhUVFBEID0gMDsKIG15ICR1c2VXZWJLaXRU ZXN0UnVubmVyID0gMDsKIG15ICRub0J1aWxkRHVtcFRvb2wgPSAwOworY2hvbXAobXkgJGRldmVs b3BlckRpciA9ICRFTlZ7REVWRUxPUEVSX0RJUn0gfHwgYHhjb2RlLXNlbGVjdCAtLXByaW50LXBh dGhgKTsKK215ICRzaW11bGF0b3JBcHAgPSAiJGRldmVsb3BlckRpci9BcHBsaWNhdGlvbnMvaU9T IFNpbXVsYXRvci5hcHAiOwordW5sZXNzICgtZCAkc2ltdWxhdG9yQXBwKSB7CisgICAgJHNpbXVs YXRvckFwcCA9ICIkZGV2ZWxvcGVyRGlyL0FwcGxpY2F0aW9ucy9pUGhvbmUgU2ltdWxhdG9yLmFw cCI7Cit9CiAKICMgVGhlc2UgYXJndW1lbnRzIGFyZSBpZ25vcmVkLCBidXQgZXhpc3QgZm9yIGNv bXBhdGliaWxpdHkgd2l0aCBuZXctcnVuLXdlYmtpdC10ZXN0cy4KIG15ICRidWlsZGVyTmFtZSA9 ICcnOwpAQCAtNDA2LDYgKzQxMSw3IEBAIG15ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9u cygKICAgICAnYnVpbGQtbnVtYmVyPXMnID0+IFwkYnVpbGROdW1iZXIsCiAgICAgJ21hc3Rlci1u YW1lPXMnID0+IFwkbWFzdGVyTmFtZSwKICAgICAndGVzdC1yZXN1bHRzLXNlcnZlcj1zJyA9PiBc JHRlc3RSZXN1bHRzU2VydmVyLAorICAgICdzaW11bGF0b3ItYXBwPXMnID0+IFwkc2ltdWxhdG9y QXBwLAogKTsKIAogaWYgKCEkZ2V0T3B0aW9uc1Jlc3VsdCB8fCAkc2hvd0hlbHApIHsKQEAgLTE0 MjcsNyArMTQzMyw3IEBAIHN1YiBvcGVuSVBob25lU2ltdWxhdG9yKCkKIAogICAgIG15ICRkZXZp Y2VOYW1lID0gYXJjaGl0ZWN0dXJlKCkgZXEgJ2kzODYnID8gImlQaG9uZSA1IiA6ICJpUGhvbmUg NXMiOwogCi0gICAgc3lzdGVtICJvcGVuIiwgIi1hIiwgImlPUyBTaW11bGF0b3IiLCAiLS1hcmdz IiwgIi1TZXNzaW9uT25MYXVuY2giLCAiTk8iLCAiLVNpbXVsYXRlRGV2aWNlIiwgJGRldmljZU5h bWU7CisgICAgc3lzdGVtICJvcGVuIiwgIi1hIiwgJHNpbXVsYXRvckFwcCwgIi0tYXJncyIsICIt U2Vzc2lvbk9uTGF1bmNoIiwgIk5PIiwgIi1TaW11bGF0ZURldmljZSIsICRkZXZpY2VOYW1lOwog CiAgICAgZGllICQhIGlmIGV4aXRTdGF0dXMoJD8pOwogCg==