<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>132960</bug_id>
          
          <creation_ts>2014-05-15 09:42:54 -0700</creation_ts>
          <short_desc>[GTK] generate-forwarding-headers.pl must run before compiling sources</short_desc>
          <delta_ts>2014-09-29 06:10:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>137207</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>132956</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Hodovan">mhodovan.u-szeged</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>berto</cc>
    
    <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>gustavo</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ossy</cc>
    
    <cc>pnormand</cc>
    
    <cc>svillar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1009565</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Hodovan">mhodovan.u-szeged</who>
    <bug_when>2014-05-15 09:42:54 -0700</bug_when>
    <thetext>Bug 132956: [WK2] Change the remaining framework includes from WebKit2 to WebKit
https://bugs.webkit.org/show_bug.cgi?id=132956


  Comment #3 From Csaba Osztrogonác 2014-05-15 08:46:55 PST
    It seems GTK&apos;s cmake system is buggy:
    Source/WebKit2/Scripts/generate-forwarding-headers.pl

    [snip]

      In file included from ../../Tools/TestWebKitAPI/gtk/main.cpp:26:0:
      ../../Tools/TestWebKitAPI/config.h:68:30: fatal error: WebKit/WebKit2_C.h: No such file or directory

      In file included from ../../Tools/TestWebKitAPI/TestsController.cpp:26:0:
      ../../Tools/TestWebKitAPI/config.h:68:30: fatal error: WebKit/WebKit2_C.h: No such file or directory

      In file included from ../../Tools/TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp:26:0:
      ../../Tools/TestWebKitAPI/config.h:68:30: fatal error: WebKit/WebKit2_C.h: No such file or directory

    [snip]

    [Creating forwarding header for WebKit/UIProcess/API/C/WebKit2_C.h]

    -----

    generate-forwarding-headers.pl must run before everything else.
    This dependency should be fixed, because it can cause flakey build failures.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1009733</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-05-16 02:05:54 -0700</bug_when>
    <thetext>I landed the patch from Bug132956, because this bug is absolutely
independent from that one - http://trac.webkit.org/changeset/168961.

As far as I thought, it caused build failures on the GTK bots:
- http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/44026
- http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/47525
- http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/42226

But the next build worked fine after the first generated the forwarding headers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1009763</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2014-05-16 07:51:50 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; But the next build worked fine after the first generated the forwarding headers.

Indeed. I just compiled webkitgtk+ here locally and it failed as you describe:

In file included from ../../Tools/TestWebKitAPI/gtk/main.cpp:26:0:
../../Tools/TestWebKitAPI/config.h:68:30: fatal error: WebKit/WebKit2_C.h: No such file or directory
 #include &lt;WebKit/WebKit2_C.h&gt;
                              ^
compilation terminated.


I retried the compilation a second time and it worked fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1010739</commentid>
    <comment_count>3</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-21 05:40:15 -0700</bug_when>
    <thetext>Does this happen with make, ninja or both?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011981</commentid>
    <comment_count>4</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-05-27 09:06:31 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Does this happen with make, ninja or both?

With build-webkit.sh this happen for sure. It&apos;s impossible to build wk by just using the build script. You need to call ninja to have the forwarding headers generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011990</commentid>
    <comment_count>5</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-05-27 09:35:56 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; &gt; Does this happen with make, ninja or both?
&gt;
&gt; With build-webkit.sh this happen for sure.

Yes but this will use make or ninja depending on what&apos;s installed. My
question is with which one you were reproducing this problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1011997</commentid>
    <comment_count>6</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2014-05-27 09:47:26 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; &gt; Does this happen with make, ninja or both?
&gt; &gt;
&gt; &gt; With build-webkit.sh this happen for sure.
&gt; 
&gt; Yes but this will use make or ninja depending on what&apos;s installed. My
&gt; question is with which one you were reproducing this problem.

It should be using ninja</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1037922</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-09-29 06:10:50 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 137207 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>