132959 2014-05-15 09:09:40 -0700 TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac 2014-05-15 10:19:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer aestes ap darin mitz sam oldest_to_newest 1009554 0 ddkilzer 2014-05-15 09:09:40 -0700 Add a Tools/TestWebKitAPI/Tests/cocoa directory and move URLExtras.mm into it. This will make the test runnable on the iOS Simulator once Bug 129535 lands to add iOS support to run-api-tests. There is much more to do in this space, but this is a start. 1009555 1 231522 ddkilzer 2014-05-15 09:14:00 -0700 Created attachment 231522 Patch v1 1009556 2 231522 mitz 2014-05-15 09:20:25 -0700 Comment on attachment 231522 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963 > + 44A82E7B19251B3500C1C8C4 /* cocoa */, I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories. 1009570 3 ddkilzer 2014-05-15 10:09:50 -0700 (In reply to comment #2) > (From update of attachment 231522 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231522&action=review > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:963 > > + 44A82E7B19251B3500C1C8C4 /* cocoa */, > > I know that we have all-lowercase mac group and directory, but in the WebKit2 project and in Source/WebKit2 we’ve been capitalizing but the Cocoa groups in the project and the Cocoa directories. Okay, will change to Cocoa. Thanks! 1009572 4 ddkilzer 2014-05-15 10:19:18 -0700 Committed r168900: <http://trac.webkit.org/changeset/168900> 231522 2014-05-15 09:14:00 -0700 2014-05-15 10:10:17 -0700 Patch v1 0001-TestWebKitAPI-URLExtras.mm-should-be-a-shared-test-f.patch text/plain 3275 ddkilzer RnJvbSBhNDBmODk3ZTlhY2JjMWZiN2NmOWFjNTk4MzdhYjVlNTI0YjgxNzRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0 ZTogVGh1LCAxNSBNYXkgMjAxNCAwOToxMDo0MiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFRlc3RX ZWJLaXRBUEk6IFVSTEV4dHJhcy5tbSBzaG91bGQgYmUgYSBzaGFyZWQgdGVzdCBmb3IgaU9TCiBh bmQgTWFjIDxodHRwOi8vd2Via2l0Lm9yZy9iLzEzMjk1OT4KClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKKiBUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvajogQWRkCmNvY29hIGRpcmVjdG9yeSB0byBwcm9qZWN0IGFuZCBtb3ZlIFVSTEV4dHJh cy5tbSBpbnRvIGl0LgoqIFRlc3RXZWJLaXRBUEkvVGVzdHMvY29jb2EvVVJMRXh0cmFzLm1tOiBS ZW5hbWVkIGZyb20gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvVVJMRXh0cmFzLm1tLgot LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgMTEgKysrKysrKysrKysKIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQ SS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIHwgMTAgKysrKysrKysrLQogVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy97bWFjID0+IGNvY29hfS9VUkxFeHRyYXMubW0gICAgICAgfCAgMAogMyBm aWxlcyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiByZW5hbWUgVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy97bWFjID0+IGNvY29hfS9VUkxFeHRyYXMubW0gKDEwMCUp CgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGYy MjAyMDYuLjZjNTk2MjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNC0wNS0xNSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCisgICAgICAgIFRlc3RXZWJLaXRBUEk6IFVSTEV4dHJhcy5tbSBz aG91bGQgYmUgYSBzaGFyZWQgdGVzdCBmb3IgaU9TIGFuZCBNYWMKKyAgICAgICAgPGh0dHA6Ly93 ZWJraXQub3JnL2IvMTMyOTU5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2o6IEFkZAorICAgICAgICBjb2NvYSBkaXJlY3RvcnkgdG8gcHJvamVjdCBhbmQg bW92ZSBVUkxFeHRyYXMubW0gaW50byBpdC4KKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L2NvY29hL1VSTEV4dHJhcy5tbTogUmVuYW1lZCBmcm9tIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvbWFjL1VSTEV4dHJhcy5tbS4KKworMjAxNC0wNS0xNSAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFtpT1NdIFN1cHBvcnQgVGVzdFdlYktpdEFQSSBpbiB0 aGUgaU9TIFNpbXVsYXRvcgogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjk1MzU+CiAg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNjIwMzUyOT4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdFdlYktpdEFQSS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5k ZXggZGNmZmJlMC4uMjRkNjJiOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTcxNiw2ICs3 MTYsMTQgQEAKIAkJCXBhdGggPSBXZWJDb3JlOwogCQkJc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsK IAkJfTsKKwkJNDRBODJFN0IxOTI1MUIzNTAwQzFDOEM0IC8qIGNvY29hICovID0geworCQkJaXNh ID0gUEJYR3JvdXA7CisJCQljaGlsZHJlbiA9ICgKKwkJCQk5M0E3RUIzQzE4RkE2M0E0MDA5RTc2 NzAgLyogVVJMRXh0cmFzLm1tICovLAorCQkJKTsKKwkJCXBhdGggPSBjb2NvYTsKKwkJCXNvdXJj ZVRyZWUgPSAiPGdyb3VwPiI7CisJCX07CiAJCUJDMDI5QjFBMTQ4NkIyMzgwMDgxN0RBOSAvKiBu cyAqLyA9IHsKIAkJCWlzYSA9IFBCWEdyb3VwOwogCQkJY2hpbGRyZW4gPSAoCkBAIC05NTIsNiAr OTYwLDcgQEAKIAkJQkNCOUVCNjYxMTIzNjZEODAwQTEzN0UwIC8qIFRlc3RzICovID0gewogCQkJ aXNhID0gUEJYR3JvdXA7CiAJCQljaGlsZHJlbiA9ICgKKwkJCQk0NEE4MkU3QjE5MjUxQjM1MDBD MUM4QzQgLyogY29jb2EgKi8sCiAJCQkJRkUyMTdFQ0IxNjQwQTU0QTAwNTI5ODhCIC8qIEphdmFT Y3JpcHRDb3JlICovLAogCQkJCUMwN0U2Q0FEMTNGRDY3NjUwMDM4QjIyQiAvKiBtYWMgKi8sCiAJ CQkJQzA4NTg3RjkxM0ZFQzM5QjAwMUVGNEU1IC8qIFRlc3RXZWJLaXRBUEkgKi8sCkBAIC0xMDAw LDcgKzEwMDksNiBAQAogCQkJCTkzOUJGRTM5MThFNTU0ODkwMDg4MzI3NSAvKiBTdHJpbmdUcnVu Y2F0b3IubW0gKi8sCiAJCQkJMzdBNjg5NUQxNDhBOUI1MDAwNTEwMEZBIC8qIFN1YnJlc291cmNl RXJyb3JDcmFzaC5tbSAqLywKIAkJCQlFNDkwMjk2NzE0RTJFM0E0MDAyQkVERDEgLyogVHlwaW5n U3R5bGVDcmFzaC5tbSAqLywKLQkJCQk5M0E3RUIzQzE4RkE2M0E0MDA5RTc2NzAgLyogVVJMRXh0 cmFzLm1tICovLAogCQkJCTUxRkJCQjRDMTUxM0Q0RTkwMDgyMjczOCAvKiBXZWJWaWV3Q2FuUGFz dGVVUkwubW0gKi8sCiAJCQkJQzJFQjJERDExNkNBQzdBQzAwOUI1MkVFIC8qIFdlYlZpZXdEaWRD cmVhdGVKYXZhU2NyaXB0Q29udGV4dC5tbSAqLywKIAkJCQkzN0UzOEMzMzE2OUI3RDAxMDA4NEMy OEMgLyogV2ViVmlld0RpZFJlbW92ZUZyYW1lRnJvbUhpZXJhcmNoeS5tbSAqLywKZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL1VSTEV4dHJhcy5tbSBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvY29jb2EvVVJMRXh0cmFzLm1tCnNpbWlsYXJpdHkgaW5kZXggMTAw JQpyZW5hbWUgZnJvbSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9VUkxFeHRyYXMubW0K cmVuYW1lIHRvIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvY29jb2EvVVJMRXh0cmFzLm1tCi0t IAoxLjguMy40IChBcHBsZSBHaXQtNDcpCgo=