132947 2014-05-15 04:27:37 -0700 Build error in Source/WebCore/fileapi/Blob.cpp 2014-05-15 09:31:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 132678 P2 Normal --- 1 tanay.c webkit-unassigned andersca ap oldest_to_newest 1009496 0 tanay.c 2014-05-15 04:27:37 -0700 Revision: 168893 Build command: build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --cmakeargs="-DENABLE_WEBKIT=OFF" --update-efl Error Text: [ 14%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/fileapi/Blob.cpp.o /home/tanay.c/webkit/Source/WebCore/fileapi/Blob.cpp: In member function ‘long long unsigned int WebCore::Blob::size() const’: /home/tanay.c/webkit/Source/WebCore/fileapi/Blob.cpp:127:69: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/fileapi/Blob.cpp.o] Error 1 make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2 Dependencies: Related to changes as part of http://trac.webkit.org/changeset/168435 1009500 1 231500 tanay.c 2014-05-15 05:15:36 -0700 Created attachment 231500 Patch 1009559 2 231500 ap 2014-05-15 09:29:46 -0700 Comment on attachment 231500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231500&action=review > Source/WebCore/fileapi/Blob.cpp:127 > + m_size = (actualSize <= std::numeric_limits<unsigned long long>::max()) ? static_cast<long long>(actualSize) : 0; The proposed code is incorrect - an unsigned long long value is always less than or equal to std::numeric_limits<unsigned long long>::max(), so comparing these makes is meaningless. The purpose of this check is to ensure that casting to a signed long long won't change the value. I think that you need something like: m_size = (actualSize <= static_cast<unsigned long long>(std::numeric_limits<long long>::max())) ? static_cast<long long>(actualSize) : 0; Or there may be some other idiom that I'm not aware of. Possibly something in CheckedArithmetic.h? 1009560 3 ap 2014-05-15 09:31:19 -0700 *** This bug has been marked as a duplicate of bug 132678 *** 231500 2014-05-15 05:15:36 -0700 2014-05-15 09:29:46 -0700 Patch bug-132947-20140515174611.patch text/plain 1435 tanay.c SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODg5NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA1LTE1ICBUYW5heSBD ICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCBlcnJvciBmaXggaW4gQmxv Yi5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz Mjk0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZmlsZWFwaS9CbG9iLmNwcDogQ2hhbmdlIGRhdGF0eXBlIHRvIHVuc2lnbmVkCisgICAgICAgIChX ZWJDb3JlOjpCbG9iOjpzaXplKToKKwogMjAxNC0wNS0xNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gQ29tcGlsZSBhbGwgaW5zdGFs bGVkIHJlc291cmNlcyBhcyBHUmVzb3VyY2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9maWxlYXBp L0Jsb2IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5jcHAJ KHJldmlzaW9uIDE2ODgzMCkKKysrIFNvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEyNCw3ICsxMjQsNyBAQCB1bnNpZ25lZCBsb25nIGxvbmcgQmxvYjo6 c2l6ZSgpIGNvbnN0CiAgICAgICAgIC8vIEZJWE1FOiBKYXZhU2NyaXB0IGNhbm5vdCByZXByZXNl bnQgc2l6ZXMgYXMgbGFyZ2UgYXMgdW5zaWduZWQgbG9uZyBsb25nLCB3ZSBuZWVkIHRvCiAgICAg ICAgIC8vIGNvbWUgdXAgd2l0aCBhbiBleGNlcHRpb24gdG8gdGhyb3cgaWYgZmlsZSBzaXplIGlz IG5vdCByZXByZXNlbnRhYmxlLgogICAgICAgICB1bnNpZ25lZCBsb25nIGxvbmcgYWN0dWFsU2l6 ZSA9IFRocmVhZGFibGVCbG9iUmVnaXN0cnk6OmJsb2JTaXplKG1faW50ZXJuYWxVUkwpOwotICAg ICAgICBtX3NpemUgPSAoYWN0dWFsU2l6ZSA8PSBzdGQ6Om51bWVyaWNfbGltaXRzPGxvbmcgbG9u Zz46Om1heCgpKSA/IHN0YXRpY19jYXN0PGxvbmcgbG9uZz4oYWN0dWFsU2l6ZSkgOiAwOworICAg ICAgICBtX3NpemUgPSAoYWN0dWFsU2l6ZSA8PSBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVk IGxvbmcgbG9uZz46Om1heCgpKSA/IHN0YXRpY19jYXN0PGxvbmcgbG9uZz4oYWN0dWFsU2l6ZSkg OiAwOwogICAgIH0KIAogICAgIHJldHVybiBzdGF0aWNfY2FzdDx1bnNpZ25lZCBsb25nIGxvbmc+ KG1fc2l6ZSk7Cg==