132940 2014-05-14 20:46:37 -0700 Tiled scrolling indicator needs to take topContentInset into account 2014-05-14 21:09:52 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue esprehn+autocc glenn jonlee kondapallykalyan sam simon.fraser thorton oldest_to_newest 1009424 0 bdakin 2014-05-14 20:46:37 -0700 Tiled scrolling indicator needs to take topContentInset into account 1009425 1 231486 bdakin 2014-05-14 20:54:02 -0700 Created attachment 231486 Patch 1009428 2 bdakin 2014-05-14 20:55:45 -0700 <rdar://problem/16922451> 1009434 3 bdakin 2014-05-14 21:09:52 -0700 Thank you! Fixed: http://trac.webkit.org/changeset/168890 231486 2014-05-14 20:54:02 -0700 2014-05-14 21:05:24 -0700 Patch for-review.txt text/plain 6827 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODg4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACisyMDE0LTA1LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUaWxlZCBzY3JvbGxpbmcgaW5kaWNh dG9yIG5lZWRzIHRvIHRha2UgdG9wQ29udGVudEluc2V0IGludG8gYWNjb3VudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyOTQwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRpbGVkIHNjcm9sbGlu ZyBpbmRpY2F0b3IgbmVlZHMgdG8gbW92ZSBkb3duIGJ5IHRoZSB2YWx1ZSBvZiB0aGUgCisgICAg ICAgIHRvcENvbnRlbnRJbnNldC4gVGhpcyBwYXRjaCBtYWtlcyB0aGF0IGhhcHBlbiBieSBjYWNo aW5nIHRoZSB0b3BDb250ZW50SW5zZXQgaW4gCisgICAgICAgIHRoZSBUaWxlQ29udHJvbGxlci4g VGhpcyBkb2VzIGZlZWwgYSBsaXR0bGUgc2lsbHkgc2luY2UgdGhlcmUgaXMgYWxyZWFkeSBhIAor ICAgICAgICBmdW5jdGlvbiBjYWxsZWQgc2V0VGlsZWRTY3JvbGxpbmdJbmRpY2F0b3JQb3NpdGlv bigpIG9uIFRpbGVkQmFja2luZy4gSG93ZXZlciwgaXQgCisgICAgICAgIHdhcyBvZnRlbiB0aGUg Y2FzZSB0aGF0IGNhbGxpbmcgdGhhdCBmdW5jdGlvbiBoYWQgbm8gZWZmZWN0IGJlY2F1c2UgbV9j b3ZlcmFnZU1hcCAKKyAgICAgICAgaGFkIG5vdCB5ZXQgYmVlbiBjcmVhdGVkLCBhbmQgdGhlbiB0 aGUgaW5mb3JtYXRpb24gd2FzIGxvc3QuIFNvIGluc3RlYWQsIHdlIGNhY2hlIAorICAgICAgICB0 aGUgdmFsdWUuCisKKyAgICAgICAgU2V0IFRpbGVkQmFja2luZ+KAmXMgY29weSBvZiB0b3BDb250 ZW50SW5zZXQgd2hlbmV2ZXIgaXQgY2hhbmdlcyBmb3IgdGhlIEZyYW1lVmlldy4KKyAgICAgICAg KiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnRvcENv bnRlbnRJbnNldERpZENoYW5nZSk6CisKKyAgICAgICAgTmV3IGZ1bmN0aW9uIHRvIHNldCB0aGUg aW5zZXQuIFVzZSB0aGUgaW5zZXQgdG8gcG9zaXRpb24gdGhlIGNvdmVyYWdlIG1hcC4KKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmcuaDoKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW06CisgICAgICAgIChXZWJDb3JlOjpUaWxl Q29udHJvbGxlcjo6VGlsZUNvbnRyb2xsZXIpOgorICAgICAgICAoV2ViQ29yZTo6VGlsZUNvbnRy b2xsZXI6OnNldFRvcENvbnRlbnRJbnNldCk6CisKKyAgICAgICAgV2hlbiB0aGUgY292ZXJhZ2Ug bWFwIGlzIGNyZWF0ZWQsIGNvbnN1bHQgdGhlIHZhbHVlIG9mIHRoZSBpbnNldC4KKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvdmVyYWdlTWFwLm1tOgorICAgICAgICAo V2ViQ29yZTo6VGlsZUNvdmVyYWdlTWFwOjpUaWxlQ292ZXJhZ2VNYXApOgorCisgICAgICAgIE9u Y2UgdGhlIGJhY2tpbmcgaGFzIGJlZW4gZW5zdXJlZCwgc2V0IHRoZSBpbnNldC4KKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlQmFja2luZyk6CisKIDIwMTQtMDUtMTQgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVyZ2UgcjEyNjc2 MjggZnJvbSBicmFuY2guCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lv biAxNjg4NTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTk0OSw2ICs5NDksOSBAQCB2b2lkIEZyYW1lVmlldzo6dG9wQ29udGVudEluc2V0 RGlkQ2hhbmdlCiAgICAgdXBkYXRlU2Nyb2xsYmFycyhzY3JvbGxPZmZzZXQoKSk7CiAgICAgaWYg KHJlbmRlclZpZXctPnVzZXNDb21wb3NpdGluZygpKQogICAgICAgICByZW5kZXJWaWV3LT5jb21w b3NpdG9yKCkuZnJhbWVWaWV3RGlkQ2hhbmdlU2l6ZSgpOworCisgICAgaWYgKFRpbGVkQmFja2lu ZyogdGlsZWRCYWNraW5nID0gdGhpcy0+dGlsZWRCYWNraW5nKCkpCisgICAgICAgIHRpbGVkQmFj a2luZy0+c2V0VG9wQ29udGVudEluc2V0KHRvcENvbnRlbnRJbnNldCgpKTsKIH0KICAgICAKIGJv b2wgRnJhbWVWaWV3OjpoYXNDb21wb3NpdGVkQ29udGVudCgpIGNvbnN0CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9UaWxlZEJhY2tpbmcuaAkocmV2aXNpb24g MTY4ODU3KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVGlsZWRCYWNraW5n LmgJKHdvcmtpbmcgY29weSkKQEAgLTUxLDYgKzUxLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwg Ym9vbCB0aWxlc1dvdWxkQ2hhbmdlRm9yVmlzaWJsZVJlY3QoY29uc3QgRmxvYXRSZWN0JikgY29u c3QgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHNldFRpbGVkU2Nyb2xsaW5nSW5kaWNhdG9yUG9z aXRpb24oY29uc3QgRmxvYXRQb2ludCYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VG9wQ29u dGVudEluc2V0KGZsb2F0KSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgcHJlcG9wdWxhdGVSZWN0 KGNvbnN0IEZsb2F0UmVjdCYpID0gMDsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLmgJKHJldmlzaW9u IDE2ODg1NykKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxl Q29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcsNiArMTI3LDggQEAgcHVibGljOgog CiAgICAgVmVjdG9yPFJlZlB0cjxQbGF0Zm9ybUNBTGF5ZXI+PiBjb250YWluZXJMYXllcnMoKTsK IAorICAgIGZsb2F0IHRvcENvbnRlbnRJbnNldCgpIGNvbnN0IHsgcmV0dXJuIG1fdG9wQ29udGVu dEluc2V0OyB9CisKIHByaXZhdGU6CiAgICAgVGlsZUNvbnRyb2xsZXIoUGxhdGZvcm1DQUxheWVy Kik7CiAKQEAgLTEzNiw2ICsxMzgsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBzZXRW aXNpYmxlUmVjdChjb25zdCBGbG9hdFJlY3QmKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIGJvb2wg dGlsZXNXb3VsZENoYW5nZUZvclZpc2libGVSZWN0KGNvbnN0IEZsb2F0UmVjdCYpIGNvbnN0IG92 ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUaWxlZFNjcm9sbGluZ0luZGljYXRvclBvc2l0 aW9uKGNvbnN0IEZsb2F0UG9pbnQmKSBvdmVycmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VG9w Q29udGVudEluc2V0KGZsb2F0KSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgcHJlcG9wdWxh dGVSZWN0KGNvbnN0IEZsb2F0UmVjdCYpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRJ c0luV2luZG93KGJvb2wpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCBzZXRUaWxlQ292ZXJh Z2UoVGlsZUNvdmVyYWdlKSBvdmVycmlkZTsKQEAgLTE5Nyw2ICsyMDAsNyBAQCBwcml2YXRlOgog ICAgIENvbG9yIG1fdGlsZURlYnVnQm9yZGVyQ29sb3I7CiAgICAgZmxvYXQgbV90aWxlRGVidWdC b3JkZXJXaWR0aDsKICAgICBTY3JvbGxpbmdNb2RlSW5kaWNhdGlvbiBtX2luZGljYXRvck1vZGU7 CisgICAgZmxvYXQgbV90b3BDb250ZW50SW5zZXQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNv bnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvbWFjL1RpbGVDb250cm9sbGVyLm1tCShyZXZpc2lvbiAxNjg4NzEpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGlsZUNvbnRyb2xsZXIubW0JKHdvcmtp bmcgY29weSkKQEAgLTY5LDYgKzY5LDcgQEAgVGlsZUNvbnRyb2xsZXI6OlRpbGVDb250cm9sbGVy KFBsYXRmb3JtQwogICAgICwgbV9oYXNUaWxlc1dpdGhUZW1wb3JhcnlTY2FsZUZhY3RvcihmYWxz ZSkKICAgICAsIG1fdGlsZURlYnVnQm9yZGVyV2lkdGgoMCkKICAgICAsIG1faW5kaWNhdG9yTW9k ZShBc3luY1Njcm9sbGluZ0luZGljYXRpb24pCisgICAgLCBtX3RvcENvbnRlbnRJbnNldCgwKQog ewogfQogCkBAIC0xOTAsNiArMTkxLDEyIEBAIGJvb2wgVGlsZUNvbnRyb2xsZXI6OnRpbGVzV291 bGRDaGFuZ2VGb3IKICAgICByZXR1cm4gdGlsZUdyaWQoKS50aWxlc1dvdWxkQ2hhbmdlRm9yVmlz aWJsZVJlY3QobmV3VmlzaWJsZVJlY3QsIG1fdmlzaWJsZVJlY3QpOwogfQogCit2b2lkIFRpbGVD b250cm9sbGVyOjpzZXRUb3BDb250ZW50SW5zZXQoZmxvYXQgdG9wQ29udGVudEluc2V0KQorewor ICAgIG1fdG9wQ29udGVudEluc2V0ID0gdG9wQ29udGVudEluc2V0OworICAgIHNldFRpbGVkU2Ny b2xsaW5nSW5kaWNhdG9yUG9zaXRpb24oRmxvYXRQb2ludCgwLCBtX3RvcENvbnRlbnRJbnNldCkp OworfQorCiB2b2lkIFRpbGVDb250cm9sbGVyOjpzZXRUaWxlZFNjcm9sbGluZ0luZGljYXRvclBv c2l0aW9uKGNvbnN0IEZsb2F0UG9pbnQmIHBvc2l0aW9uKQogewogICAgIGlmICghbV9jb3ZlcmFn ZU1hcCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxl Q292ZXJhZ2VNYXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2EvbWFjL1RpbGVDb3ZlcmFnZU1hcC5tbQkocmV2aXNpb24gMTY4ODU3KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvbWFjL1RpbGVDb3ZlcmFnZU1hcC5tbQko d29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQCBUaWxlQ292ZXJhZ2VNYXA6OlRpbGVDb3Zl cmFnZU1hcChjb25zdCBUCiAgICAgOiBtX2NvbnRyb2xsZXIoY29udHJvbGxlcikKICAgICAsIG1f bGF5ZXIoKmNvbnRyb2xsZXIucm9vdExheWVyKCkuY3JlYXRlQ29tcGF0aWJsZUxheWVyKFBsYXRm b3JtQ0FMYXllcjo6TGF5ZXJUeXBlU2ltcGxlTGF5ZXIsIHRoaXMpKQogICAgICwgbV92aXNpYmxl UmVjdEluZGljYXRvckxheWVyKCpjb250cm9sbGVyLnJvb3RMYXllcigpLmNyZWF0ZUNvbXBhdGli bGVMYXllcihQbGF0Zm9ybUNBTGF5ZXI6OkxheWVyVHlwZUxheWVyLCBudWxscHRyKSkKKyAgICAs IG1fcG9zaXRpb24oRmxvYXRQb2ludCgwLCBjb250cm9sbGVyLnRvcENvbnRlbnRJbnNldCgpKSkK IHsKICAgICBtX2xheWVyLmdldCgpLnNldE9wYWNpdHkoMC43NSk7CiAgICAgbV9sYXllci5nZXQo KS5zZXRBbmNob3JQb2ludChGbG9hdFBvaW50M0QoKSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTY4 ODU3KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTgzOCw2ICs4MzgsOSBAQCBib29sIFJlbmRlckxheWVyQ29t cG9zaXRvcjo6dXBkYXRlQmFja2luCiAjZW5kaWYKICAgICAgICAgICAgICAgICBpZiAobV9yZW5k ZXJWaWV3LmZyYW1lVmlldygpLmZyYW1lKCkuc2V0dGluZ3MoKS5iYWNrZ3JvdW5kU2hvdWxkRXh0 ZW5kQmV5b25kUGFnZSgpKQogICAgICAgICAgICAgICAgICAgICBtX3Jvb3RDb250ZW50TGF5ZXIt PnNldE1hc2tzVG9Cb3VuZHMoZmFsc2UpOworCisgICAgICAgICAgICAgICAgaWYgKFRpbGVkQmFj a2luZyogdGlsZWRCYWNraW5nID0gbGF5ZXIuYmFja2luZygpLT50aWxlZEJhY2tpbmcoKSkKKyAg ICAgICAgICAgICAgICAgICAgdGlsZWRCYWNraW5nLT5zZXRUb3BDb250ZW50SW5zZXQobV9yZW5k ZXJWaWV3LmZyYW1lVmlldygpLnRvcENvbnRlbnRJbnNldCgpKTsKICAgICAgICAgICAgIH0KIAog ICAgICAgICAgICAgLy8gVGhpcyBsYXllciBhbmQgYWxsIG9mIGl0cyBkZXNjZW5kYW50cyBoYXZl IGNhY2hlZCByZXBhaW50cyByZWN0cyB0aGF0IGFyZSByZWxhdGl2ZSB0bwo=