132937 2014-05-14 20:39:42 -0700 [iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites 2014-05-16 14:58:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 benjamin benjamin oldest_to_newest 1009417 0 benjamin 2014-05-14 20:39:42 -0700 [iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites 1009420 1 231484 benjamin 2014-05-14 20:42:36 -0700 Created attachment 231484 Patch 1009422 2 benjamin 2014-05-14 20:43:34 -0700 <rdar://problem/16710097> 1009643 3 231484 simon.fraser 2014-05-15 15:59:13 -0700 Comment on attachment 231484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231484&action=review > Source/WebKit2/ChangeLog:9 > + When responsive websites are broken, we should not keep the relative horizontal position into view, It's not clear what "When responsive websites are broken" means. Broken by us, or broken by design? "keep the position into view" doesn't make sense. 1009644 4 231484 simon.fraser 2014-05-15 16:00:48 -0700 Comment on attachment 231484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231484&action=review > Source/WebKit2/ChangeLog:3 > + [iOS][WK2] Add a heuristic to set the rigth horizontal offset on rotation for broken responsive websites "rigth" 1009650 5 231484 simon.fraser 2014-05-15 16:05:19 -0700 Comment on attachment 231484 Patch Let's remove the "broken responsive" terminology. 1009863 6 benjamin 2014-05-16 14:58:26 -0700 Committed r168982: <http://trac.webkit.org/changeset/168982> 231484 2014-05-14 20:42:36 -0700 2014-05-15 16:05:19 -0700 Patch bug-132937-20140514204213.patch text/plain 2752 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGViNWIyZjNkYjk1OTQ0 Y2FhMGVjYWE5ZjU3YmIzZjhmNTg2ZmZhOC4uOTBmNDE3NjY1YWE1YTQyOWE3OTEyNjc2MTVkZjlm MDM0M2JkMGQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA1LTE0ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdW1dLMl0g QWRkIGEgaGV1cmlzdGljIHRvIHNldCB0aGUgcmlndGggaG9yaXpvbnRhbCBvZmZzZXQgb24gcm90 YXRpb24gZm9yIGJyb2tlbiByZXNwb25zaXZlIHdlYnNpdGVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI5MzcKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzE2NzEwMDk3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gcmVzcG9uc2l2ZSB3ZWJzaXRlcyBhcmUgYnJva2VuLCB3ZSBzaG91bGQgbm90 IGtlZXAgdGhlIHJlbGF0aXZlIGhvcml6b250YWwgcG9zaXRpb24gaW50byB2aWV3LAorICAgICAg ICBtYW55IG9mIHRob3NlIHdlYnNpdGVzIGhhdmUgYWxsIHRoZSBjb250ZW50IG9uIHRoZSBsZWZ0 LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkeW5hbWljVmlld3BvcnRTaXplVXBkYXRlKToKKworMjAx NC0wNS0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAg ICBbaU9TXVtXSzJdIFRoZSB0b3AvYm90dG9tIGVkZ2VzIHNob3VsZCBub3QgYmUgc3RpY2t5IHdo ZW4gcmVzdG9yaW5nIHRoZSBzY3JvbGwgcG9zaXRpb24gZnJvbSB0aGUgZHluYW1pYyBzaXplIHVw ZGF0ZSBoaXN0b3J5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzI5MzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IDhiZjg1MTA0MGMyNjE0NmU5NGQ1YTdmZDhmZTEyMjQ4 YjQ3NTljMzUuLmYyOTYwOTk4ZTkwZGMwNjY5ZTY3YjFkYWQ5Y2UwMWYzYzEwYWQzNTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1Mu bW0KQEAgLTIwNDIsNiArMjA0MiwxOSBAQCB2b2lkIFdlYlBhZ2U6OmR5bmFtaWNWaWV3cG9ydFNp emVVcGRhdGUoY29uc3QgRmxvYXRTaXplJiBtaW5pbXVtTGF5b3V0U2l6ZSwgY29ucwogICAgICAg ICAgICAgICAgIG5ld1Vub2JzY3VyZWRDb250ZW50UmVjdC5zZXRZKDApOwogICAgICAgICAgICAg ICAgIG5ld0V4cG9zZWRDb250ZW50UmVjdC5zZXRZKDApOwogICAgICAgICAgICAgfQorCisgICAg ICAgICAgICBib29sIGxpa2VseVJlc3BvbnNpdmVEZXNpZ25WaWV3cG9ydCA9IG5ld0xheW91dFNp emUud2lkdGgoKSA9PSBtaW5pbXVtTGF5b3V0U2l6ZS53aWR0aCgpICYmIHdpdGhpbkVwc2lsb24o c2NhbGUsIDEpOworICAgICAgICAgICAgYm9vbCBjb250ZW50QmxlZWRzT3V0c2lkZUxheW91dFdp ZHRoID0gbmV3Q29udGVudFNpemUud2lkdGgoKSA+IG5ld0xheW91dFNpemUud2lkdGgoKTsKKyAg ICAgICAgICAgIGJvb2wgb3JpZ2luYWxTY3JvbGxQb3NpdGlvbldhc09uVGhlTGVmdEVkZ2UgPSB0 YXJnZXRVbm9ic2N1cmVkUmVjdC54KCkgPD0gMDsKKyAgICAgICAgICAgIGlmIChsaWtlbHlSZXNw b25zaXZlRGVzaWduVmlld3BvcnQgJiYgY29udGVudEJsZWVkc091dHNpZGVMYXlvdXRXaWR0aCAm JiBvcmlnaW5hbFNjcm9sbFBvc2l0aW9uV2FzT25UaGVMZWZ0RWRnZSkgeworICAgICAgICAgICAg ICAgIC8vIFRoaXMgaXMgYSBzcGVjaWFsIGhldXJpc3RpY3MgZm9yIGJyb2tlbiAicmVzcG9uc2l2 ZSIgZGVzaWduLiBJdCBpcyBxdWl0ZSBjb21tb24gZm9yIHJlc3BvbnNpdmUgZGVzaWduCisgICAg ICAgICAgICAgICAgLy8gdG8gaGF2ZSBjb250ZW50ICJibGVlZGluZyIgb3V0c2lkZSBvZiB0aGUg bWluaW1hbCBsYXlvdXQgd2lkdGguCisgICAgICAgICAgICAgICAgLy8gSW4gdGhvc2UgY2FzZXMs IHRoZSBkZXNpZ24gdXN1YWxseSBkb2VzIG5vdCBhZGFwdCB0byB0aGUgbmV3IHdpZHRoIGFuZCBy ZW1haW4gYXQgdGhlIG5ld0xheW91dFNpemUgZXhjZXB0IGZvciB0aGUKKyAgICAgICAgICAgICAg ICAvLyBicm9rZW4gYm94ZXMuCisgICAgICAgICAgICAgICAgLy8gSXQgaXMgd29ydGggcmV2aXNp dGluZyB0aGlzIHNwZWNpYWwgY2FzZSBhcyB3ZWIgZGV2ZWxvcGVycyBnZXQgYmV0dGVyIHdpdGgg cmVzcG9uc2l2ZSBkZXNpZ24uCisgICAgICAgICAgICAgICAgbmV3RXhwb3NlZENvbnRlbnRSZWN0 LnNldFgoMCk7CisgICAgICAgICAgICAgICAgbmV3VW5vYnNjdXJlZENvbnRlbnRSZWN0LnNldFgo MCk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0KIAogICAgICAgICBmbG9hdCBob3Jpem9udGFs QWRqdXN0bWVudCA9IDA7Cg==