132916 2014-05-14 11:10:49 -0700 Inline caching for proxies clobbers baseGPR too early 2014-05-14 13:49:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 132705 1 mhahnenberg mhahnenberg commit-queue fpizlo oldest_to_newest 1009301 0 mhahnenberg 2014-05-14 11:10:49 -0700 It clobbers it prior to the Structure checks, so if any of the checks fail then the slow path gets the target of the proxy rather than the proxy itself. We need to delay the clobbering of baseGPR until we know the inline cache is going to succeed. 1009318 1 231463 mhahnenberg 2014-05-14 13:01:25 -0700 Created attachment 231463 Patch 1009324 2 231463 commit-queue 2014-05-14 13:49:28 -0700 Comment on attachment 231463 Patch Clearing flags on attachment: 231463 Committed r168861: <http://trac.webkit.org/changeset/168861> 1009325 3 commit-queue 2014-05-14 13:49:30 -0700 All reviewed patches have been landed. Closing bug. 231463 2014-05-14 13:01:25 -0700 2014-05-14 13:49:28 -0700 Patch bug-132916-20140514125551.patch text/plain 3390 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4ODU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTA1LTE0ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSW5saW5lIGNhY2hpbmcgZm9yIHByb3hpZXMgY2xvYmJlcnMgYmFzZUdQUiB0b28g ZWFybHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz MjkxNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IGNsb2JiZXIgYmFzZUdQUiBwcmlvciB0byB0aGUgU3RydWN0dXJlIGNoZWNrcywgc28gaWYgYW55 IG9mIHRoZSBjaGVja3MgZmFpbCB0aGVuIHRoZSBzbG93IHBhdGggCisgICAgICAgIGdldHMgdGhl IHRhcmdldCBvZiB0aGUgcHJveHkgcmF0aGVyIHRoYW4gdGhlIHByb3h5IGl0c2VsZi4gV2UgbmVl ZCB0byBkZWxheSB0aGUgY2xvYmJlcmluZyBvZiBiYXNlR1BSIAorICAgICAgICB1bnRpbCB3ZSBr bm93IHRoZSBpbmxpbmUgY2FjaGUgaXMgZ29pbmcgdG8gc3VjY2VlZC4KKworICAgICAgICAqIGpp dC9SZXBhdGNoLmNwcDoKKyAgICAgICAgKEpTQzo6Z2VuZXJhdGVCeUlkU3R1Yik6CisKIDIwMTQt MDUtMTQgIE1hcnRpbiBIb2RvdmFuIDxtaG9kb3Zhbi51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcu Y29tPgogCiAgICAgICAgIEFSTSBUcmFkaXRpb25hbCBidWlsZGZpeCBhZnRlciByMTY4Nzc2LgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAxNjg4NDYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMTcsMTQgKzMxNywyMSBAQCBzdGF0aWMgdm9pZCBnZW5lcmF0ZUJ5SWRTdHViKAogICAg ICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6Ok5vdEVxdWFsLCAKICAgICAgICAgICAgIE1hY3JvQXNz ZW1ibGVyOjpBZGRyZXNzKGJhc2VHUFIsIEpTQ2VsbDo6dHlwZUluZm9UeXBlT2Zmc2V0KCkpLCAK ICAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tMzIoUHVyZUZvcndhcmRpbmdQ cm94eVR5cGUpKSk7Ci0gICAgICAgIHN0dWJKaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRk cmVzcyhiYXNlR1BSLCBKU1Byb3h5Ojp0YXJnZXRPZmZzZXQoKSksIGJhc2VGb3JHZXRHUFIpOwot ICAgIH0gZWxzZQorCisgICAgICAgIHN0dWJKaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRk cmVzcyhiYXNlR1BSLCBKU1Byb3h5Ojp0YXJnZXRPZmZzZXQoKSksIHNjcmF0Y2hHUFIpOworICAg ICAgICAKKyAgICAgICAgZmFpbHVyZUNhc2VzLmFwcGVuZChicmFuY2hTdHJ1Y3R1cmUoc3R1Ykpp dCwKKyAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpOb3RFcXVhbCwgCisgICAgICAgICAgICBN YWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhzY3JhdGNoR1BSLCBKU0NlbGw6OnN0cnVjdHVyZUlET2Zm c2V0KCkpLAorICAgICAgICAgICAgc3RydWN0dXJlKSk7CisgICAgfSBlbHNlIHsKICAgICAgICAg YmFzZUZvckdldEdQUiA9IGJhc2VHUFI7CiAKLSAgICBmYWlsdXJlQ2FzZXMuYXBwZW5kKGJyYW5j aFN0cnVjdHVyZShzdHViSml0LAotICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6Tm90RXF1YWwsIAot ICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlRm9yR2V0R1BSLCBKU0NlbGw6OnN0 cnVjdHVyZUlET2Zmc2V0KCkpLCAKLSAgICAgICAgc3RydWN0dXJlKSk7CisgICAgICAgIGZhaWx1 cmVDYXNlcy5hcHBlbmQoYnJhbmNoU3RydWN0dXJlKHN0dWJKaXQsCisgICAgICAgICAgICBNYWNy b0Fzc2VtYmxlcjo6Tm90RXF1YWwsIAorICAgICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OkFkZHJl c3MoYmFzZUZvckdldEdQUiwgSlNDZWxsOjpzdHJ1Y3R1cmVJRE9mZnNldCgpKSwgCisgICAgICAg ICAgICBzdHJ1Y3R1cmUpKTsKKyAgICB9CiAKICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jayA9IGV4 ZWMtPmNvZGVCbG9jaygpOwogICAgIGlmIChzdHJ1Y3R1cmUtPnR5cGVJbmZvKCkubmV3SW1wdXJl UHJvcGVydHlGaXJlc1dhdGNocG9pbnRzKCkpCkBAIC0zNTEsMTEgKzM1OCwyMCBAQCBzdGF0aWMg dm9pZCBnZW5lcmF0ZUJ5SWRTdHViKAogICAgIAogICAgIEdQUlJlZyBiYXNlRm9yQWNjZXNzR1BS OwogICAgIGlmIChjaGFpbikgeworICAgICAgICAvLyBXZSBjb3VsZCBoYXZlIGNsb2JiZXJlZCBz Y3JhdGNoR1BSIGVhcmxpZXIsIHNvIHdlIGhhdmUgdG8gcmVsb2FkIGZyb20gYmFzZUdQUiB0byBn ZXQgdGhlIHRhcmdldC4KKyAgICAgICAgaWYgKGxvYWRUYXJnZXRGcm9tUHJveHkpCisgICAgICAg ICAgICBzdHViSml0LmxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoYmFzZUdQUiwgSlNQ cm94eTo6dGFyZ2V0T2Zmc2V0KCkpLCBiYXNlRm9yR2V0R1BSKTsKICAgICAgICAgc3R1YkppdC5t b3ZlKE1hY3JvQXNzZW1ibGVyOjpUcnVzdGVkSW1tUHRyKHByb3RvT2JqZWN0KSwgc2NyYXRjaEdQ Uik7CiAgICAgICAgIGJhc2VGb3JBY2Nlc3NHUFIgPSBzY3JhdGNoR1BSOwotICAgIH0gZWxzZQor ICAgIH0gZWxzZSB7CisgICAgICAgIC8vIEZvciBwcm94eSBvYmplY3RzLCB3ZSBuZWVkIHRvIGRv IGFsbCB0aGUgU3RydWN0dXJlIGNoZWNrcyBiZWZvcmUgbW92aW5nIHRoZSBiYXNlR1BSIGludG8g CisgICAgICAgIC8vIGJhc2VGb3JHZXRHUFIgYmVjYXVzZSBpZiB3ZSBmYWlsIGFueSBvZiB0aGUg Y2hlY2tzIHRoZW4gd2Ugd291bGQgaGF2ZSB0aGUgd3JvbmcgdmFsdWUgaW4gYmFzZUdQUgorICAg ICAgICAvLyBvbiB0aGUgc2xvdyBwYXRoLgorICAgICAgICBpZiAobG9hZFRhcmdldEZyb21Qcm94 eSkKKyAgICAgICAgICAgIHN0dWJKaXQubW92ZShzY3JhdGNoR1BSLCBiYXNlRm9yR2V0R1BSKTsK ICAgICAgICAgYmFzZUZvckFjY2Vzc0dQUiA9IGJhc2VGb3JHZXRHUFI7Ci0gICAgCisgICAgfQor CiAgICAgR1BSUmVnIGxvYWRlZFZhbHVlR1BSID0gSW52YWxpZEdQUlJlZzsKICAgICBpZiAoa2lu ZCAhPSBDYWxsQ3VzdG9tR2V0dGVyICYmIGtpbmQgIT0gQ2FsbEN1c3RvbVNldHRlcikgewogICAg ICAgICBpZiAoa2luZCA9PSBHZXRWYWx1ZSkK