132901 2014-05-14 03:56:39 -0700 [getUserMedia] getUserMedia() errorCallback MUST be validated 2014-05-14 09:59:49 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kiran.guduru webkit-unassigned commit-queue eric.carlson glenn hta jer.noble lucas.de.marchi philipj sergio tommyw oldest_to_newest 1009220 0 kiran.guduru 2014-05-14 03:56:39 -0700 Validation for getUserMedia() errorCallback is missing. According to spec, successCallBack and errorCallBack are non-nullable and mandatory [1]. But code is validating successCallBack but missing to validate errorCallBack. [1] http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-NavigatorUserMedia-getUserMedia-void-MediaStreamConstraints-constraints-NavigatorUserMediaSuccessCallback-successCallback-NavigatorUserMediaErrorCallback-errorCallback 1009221 1 231442 kiran.guduru 2014-05-14 04:12:48 -0700 Created attachment 231442 Validation missing for getUserMedia errorCallBack Please review the patch for validating getUserMedia errorCallback. 1009277 2 231442 commit-queue 2014-05-14 09:59:45 -0700 Comment on attachment 231442 Validation missing for getUserMedia errorCallBack Clearing flags on attachment: 231442 Committed r168842: <http://trac.webkit.org/changeset/168842> 1009278 3 commit-queue 2014-05-14 09:59:49 -0700 All reviewed patches have been landed. Closing bug. 231442 2014-05-14 04:12:48 -0700 2014-05-14 09:59:45 -0700 Validation missing for getUserMedia errorCallBack patch.txt text/plain 5202 kiran.guduru SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODgzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTE0ICBLaXJhbiAg PGtpcmFuLmd1ZHVydUBzYW1zdW5nLmNvbT4KKworICAgICAgICBhbGlkYXRpb24gZm9yIGdldFVz ZXJNZWRpYSgpIGVycm9yQ2FsbGJhY2sgaXMgbWlzc2luZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjkwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwYXRjaCBhZGRzIHRoZSB2YWxpZGF0aW9u IGZvciBnZXRVc2VyTWVkaWEgZXJyb3JDYWxsQmFjaworICAgICAgICBhbmQgdGhyb3dzIFR5cGVN aXNtYXRjaEVycm9yLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbWVkaWFzdHJlYW0vZ2V0dXNlcm1l ZGlhLmh0bWwgCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL05hdmlnYXRvclVzZXJN ZWRpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOYXZpZ2F0b3JVc2VyTWVkaWE6OndlYmtpdEdl dFVzZXJNZWRpYSk6CisKIDIwMTQtMDUtMTQgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIEdJRiBhbmltYXRpb25zIGRvbid0IHJlc3RhcnQgYWZ0ZXIgc2Nyb2xs aW5nIG9uIGlPUyBXZWJLaXQxCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL05hdmlnYXRvclVzZXJNZWRpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9OYXZpZ2F0b3JVc2VyTWVkaWEuY3BwCShyZXZpc2lvbiAxNjg4 MjMpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL05hdmlnYXRvclVzZXJN ZWRpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDggKzQ4LDEwIEBAIE5hdmlnYXRvclVzZXJN ZWRpYTo6fk5hdmlnYXRvclVzZXJNZWRpYSgKIAogdm9pZCBOYXZpZ2F0b3JVc2VyTWVkaWE6Ondl YmtpdEdldFVzZXJNZWRpYShOYXZpZ2F0b3IqIG5hdmlnYXRvciwgY29uc3QgRGljdGlvbmFyeSYg b3B0aW9ucywgUGFzc1JlZlB0cjxOYXZpZ2F0b3JVc2VyTWVkaWFTdWNjZXNzQ2FsbGJhY2s+IHN1 Y2Nlc3NDYWxsYmFjaywgUGFzc1JlZlB0cjxOYXZpZ2F0b3JVc2VyTWVkaWFFcnJvckNhbGxiYWNr PiBlcnJvckNhbGxiYWNrLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKLSAgICBpZiAoIXN1Y2Nlc3ND YWxsYmFjaykKKyAgICBpZiAoIXN1Y2Nlc3NDYWxsYmFjayB8fCAhZXJyb3JDYWxsYmFjaykgewor ICAgICAgICBlYyA9IFRZUEVfTUlTTUFUQ0hfRVJSOwogICAgICAgICByZXR1cm47CisgICAgfQog CiAgICAgVXNlck1lZGlhQ29udHJvbGxlciogdXNlck1lZGlhID0gVXNlck1lZGlhQ29udHJvbGxl cjo6ZnJvbShuYXZpZ2F0b3ItPmZyYW1lKCkgPyBuYXZpZ2F0b3ItPmZyYW1lKCktPnBhZ2UoKSA6 IDApOwogICAgIGlmICghdXNlck1lZGlhKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjg4MzIpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAor MjAxNC0wNS0xNCAgS2lyYW4gIDxraXJhbi5ndWR1cnVAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg YWxpZGF0aW9uIGZvciBnZXRVc2VyTWVkaWEoKSBlcnJvckNhbGxiYWNrIGlzIG1pc3NpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI5MDEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3Qg Y2hlY2tzIGZvciBudWxsIHZhbHVlcyBpbiBnZXRVc2VyTWVkaWEgZXJyb3JDYWxsYmFjay4KKwor ICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vZ2V0dXNlcm1lZGlhLmh0bWw6CisKIDIwMTQtMDUt MTMgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdp b25zXSBBc3NlcnRpb24gZmFpbHVyZSBpbiBzb21lIGNhc2VzIHdpdGggaW5saW5lIGJsb2NrcwpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9nZXR1c2VybWVkaWEuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL2dldHVzZXJtZWRpYS5odG1s CShyZXZpc2lvbiAxNjg4MjMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL2dldHVz ZXJtZWRpYS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBACiAgICAgICAgICAg ICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCdlcnJvckFyZy5uYW1lJywgJ0NvbnN0cmFpbnRO b3RTYXRpc2ZpZWRFcnJvcicpOwogICAgICAgICAgICAgICAgIHNob3VsZEJlRXF1YWxUb1N0cmlu ZygnZXJyb3JBcmcuY29uc3RyYWludE5hbWUnLCAndmFsaWRfYnV0X3Vuc3VwcG9ydGVkXzEnKTsK IAorICAgICAgICAgICAgICAgIHNob3VsZFRocm93KCJuYXZpZ2F0b3Iud2Via2l0R2V0VXNlck1l ZGlhKHthdWRpbzp7bWFuZGF0b3J5OnsndmFsaWRfYW5kX3N1cHBvcnRlZF8xJzoxfSwgb3B0aW9u YWw6W3sndmFsaWRfYnV0X3Vuc3VwcG9ydGVkXzEnOjB9XX0sIHZpZGVvOnRydWV9LCBnb3RTdHJl YW01LCAwKTsiKTsKICAgICAgICAgICAgICAgICBzaG91bGROb3RUaHJvdygibmF2aWdhdG9yLndl YmtpdEdldFVzZXJNZWRpYSh7YXVkaW86e21hbmRhdG9yeTp7J3ZhbGlkX2FuZF9zdXBwb3J0ZWRf MSc6MX0sIG9wdGlvbmFsOlt7J3ZhbGlkX2J1dF91bnN1cHBvcnRlZF8xJzowfV19LCB2aWRlbzp0 cnVlfSwgZ290U3RyZWFtNSwgZXJyb3IpOyIpOwogICAgICAgICAgICAgfQogCkBAIC00NSw2ICs0 Niw3IEBACiAgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3N0cmVhbS5nZXRBdWRpb1RyYWNrcygp Lmxlbmd0aCcsICcxJyk7CiAgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3N0cmVhbS5nZXRWaWRl b1RyYWNrcygpLmxlbmd0aCcsICcxJyk7CiAKKyAgICAgICAgICAgICAgICBzaG91bGRUaHJvdygi bmF2aWdhdG9yLndlYmtpdEdldFVzZXJNZWRpYSh7YXVkaW86e21hbmRhdG9yeTp7J3ZhbGlkX2J1 dF91bnN1cHBvcnRlZF8xJzowfSwgb3B0aW9uYWw6W119LCB2aWRlbzp0cnVlfSwgZ290U3RyZWFt SW5FcnJvciwgbnVsbCk7Iik7CiAgICAgICAgICAgICAgICAgc2hvdWxkTm90VGhyb3coIm5hdmln YXRvci53ZWJraXRHZXRVc2VyTWVkaWEoe2F1ZGlvOnttYW5kYXRvcnk6eyd2YWxpZF9idXRfdW5z dXBwb3J0ZWRfMSc6MH0sIG9wdGlvbmFsOltdfSwgdmlkZW86dHJ1ZX0sIGdvdFN0cmVhbUluRXJy b3IsIGVycm9yMSk7Iik7CiAgICAgICAgICAgICB9CiAKQEAgLTU0LDYgKzU2LDcgQEAKICAgICAg ICAgICAgICAgICBzaG91bGRCZSgnc3RyZWFtLmdldEF1ZGlvVHJhY2tzKCkubGVuZ3RoJywgJzEn KTsKICAgICAgICAgICAgICAgICBzaG91bGRCZSgnc3RyZWFtLmdldFZpZGVvVHJhY2tzKCkubGVu Z3RoJywgJzEnKTsKIAorICAgICAgICAgICAgICAgIHNob3VsZFRocm93KCJuYXZpZ2F0b3Iud2Vi a2l0R2V0VXNlck1lZGlhKHthdWRpbzp7bWFuZGF0b3J5Ont9LCBvcHRpb25hbDpbXX0sIHZpZGVv OnRydWV9LCBnb3RTdHJlYW00LCBudWxsKTsiKTsKICAgICAgICAgICAgICAgICBzaG91bGROb3RU aHJvdygibmF2aWdhdG9yLndlYmtpdEdldFVzZXJNZWRpYSh7YXVkaW86e21hbmRhdG9yeTp7fSwg b3B0aW9uYWw6W119LCB2aWRlbzp0cnVlfSwgZ290U3RyZWFtNCwgZXJyb3IpOyIpOwogICAgICAg ICAgICAgfQogCkBAIC02Myw2ICs2Niw3IEBACiAgICAgICAgICAgICAgICAgc2hvdWxkQmUoJ3N0 cmVhbS5nZXRBdWRpb1RyYWNrcygpLmxlbmd0aCcsICcwJyk7CiAgICAgICAgICAgICAgICAgc2hv dWxkQmUoJ3N0cmVhbS5nZXRWaWRlb1RyYWNrcygpLmxlbmd0aCcsICcxJyk7CiAKKyAgICAgICAg ICAgICAgICBzaG91bGRUaHJvdygibmF2aWdhdG9yLndlYmtpdEdldFVzZXJNZWRpYSh7YXVkaW86 dHJ1ZSwgdmlkZW86dHJ1ZX0sIGdvdFN0cmVhbTMsIG51bGwpOyIpOwogICAgICAgICAgICAgICAg IHNob3VsZE5vdFRocm93KCJuYXZpZ2F0b3Iud2Via2l0R2V0VXNlck1lZGlhKHthdWRpbzp0cnVl LCB2aWRlbzp0cnVlfSwgZ290U3RyZWFtMywgZXJyb3IpOyIpOwogICAgICAgICAgICAgfQogCkBA IC03MiwxMCArNzYsMTIgQEAKICAgICAgICAgICAgICAgICBzaG91bGRCZSgnc3RyZWFtLmdldEF1 ZGlvVHJhY2tzKCkubGVuZ3RoJywgJzEnKTsKICAgICAgICAgICAgICAgICBzaG91bGRCZSgnc3Ry ZWFtLmdldFZpZGVvVHJhY2tzKCkubGVuZ3RoJywgJzAnKTsKIAorICAgICAgICAgICAgICAgIHNo b3VsZFRocm93KCJuYXZpZ2F0b3Iud2Via2l0R2V0VXNlck1lZGlhKHt2aWRlbzp0cnVlfSwgZ290 U3RyZWFtMiwgbnVsbCk7IikKICAgICAgICAgICAgICAgICBzaG91bGROb3RUaHJvdygibmF2aWdh dG9yLndlYmtpdEdldFVzZXJNZWRpYSh7dmlkZW86dHJ1ZX0sIGdvdFN0cmVhbTIsIGVycm9yKTsi KQogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBzaG91bGRUaHJvdygibmF2aWdhdG9yLndl YmtpdEdldFVzZXJNZWRpYSh7YXVkaW86ZmFsc2UsIHZpZGVvOmZhbHNlfSwgZXJyb3IsIGVycm9y KTsiKQorICAgICAgICAgICAgc2hvdWxkVGhyb3coIm5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVk aWEoe2F1ZGlvOmZhbHNlLCB2aWRlbzpmYWxzZX0sIGVycm9yLCBudWxsKTsiKQogICAgICAgICAg ICAgc2hvdWxkTm90VGhyb3coIm5hdmlnYXRvci53ZWJraXRHZXRVc2VyTWVkaWEoe2F1ZGlvOnRy dWV9LCBnb3RTdHJlYW0xLCBlcnJvcik7Iik7CiAKICAgICAgICAgICAgIHdpbmRvdy5qc1Rlc3RJ c0FzeW5jID0gdHJ1ZTsK