132900 2014-05-14 02:28:00 -0700 GIF animations don't restart after scrolling on iOS WebKit1 2014-05-14 09:24:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 1009211 0 koivisto 2014-05-14 02:28:00 -0700 a bug 1009212 1 231438 koivisto 2014-05-14 02:33:59 -0700 Created attachment 231438 patch 1009214 2 231438 kling 2014-05-14 02:37:18 -0700 Comment on attachment 231438 patch View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review OK > Source/WebKit/mac/WebView/WebView.mm:1581 > + FrameView* view = [self _mainCoreFrame]->view(); I think "FrameView *view" is the appropriate style here. 1009215 3 koivisto 2014-05-14 02:49:24 -0700 http://trac.webkit.org/changeset/168830 1009265 4 231438 darin 2014-05-14 09:24:24 -0700 Comment on attachment 231438 patch View in context: https://bugs.webkit.org/attachment.cgi?id=231438&action=review >> Source/WebKit/mac/WebView/WebView.mm:1581 >> + FrameView* view = [self _mainCoreFrame]->view(); > > I think "FrameView *view" is the appropriate style here. No, the style is right. We do that different formatting thing with * only for Objective-C types, not for C++ types like FrameView. We should probably change the rule though. The only place where we need the "X *" style is in public Objective-C headers. Inside the code it would be easier if we adopted a consistent rule. 231438 2014-05-14 02:33:59 -0700 2014-05-14 09:24:24 -0700 patch ios-webkit1-gif-restart.patch text/plain 2666 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODgyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA1LTE0ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBHSUYgYW5pbWF0aW9ucyBkb24n dCByZXN0YXJ0IGFmdGVyIHNjcm9sbGluZyBvbiBpT1MgV2ViS2l0MQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyOTAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKwogMjAx NC0wNS0xMyAgQW5kcmVpIEJ1Y3VyICA8YWJ1Y3VyQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NT IFJlZ2lvbnNdIEFzc2VydGlvbiBmYWlsdXJlIGluIHNvbWUgY2FzZXMgd2l0aCBpbmxpbmUgYmxv Y2tzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gMTY4NzQyKQorKysgU291cmNl L1dlYkNvcmUvV2ViQ29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTI0NTMsNiArMjQ1Myw3 IEBAIF9XZWJUaHJlYWRVbmxvY2tHdWFyZEZvck1haWwKIF9XZWJVSUFwcGxpY2F0aW9uRGlkQmVj b21lQWN0aXZlTm90aWZpY2F0aW9uCiBfV2ViVUlBcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91 bmROb3RpZmljYXRpb24KIF9XZWJVSUFwcGxpY2F0aW9uV2lsbFJlc2lnbkFjdGl2ZU5vdGlmaWNh dGlvbgorX19aTjdXZWJDb3JlMTBSZW5kZXJWaWV3MzVyZXN1bWVQYXVzZWRJbWFnZUFuaW1hdGlv bnNJZk5lZWRlZEV2CiBfX1pON1dlYkNvcmUxMFNjcm9sbFZpZXcxNXNldFNjcm9sbE9mZnNldEVS S05TXzhJbnRQb2ludEUKIF9fWk43V2ViQ29yZTEwU2Nyb2xsVmlldzIxc2V0RXhwb3NlZENvbnRl bnRSZWN0RVJLTlNfN0ludFJlY3RFCiBfX1pON1dlYkNvcmUxMFNjcm9sbFZpZXcyNHNldFVub2Jz Y3VyZWRDb250ZW50UmVjdEVSS05TXzdJbnRSZWN0RQpJbmRleDogU291cmNlL1dlYktpdC9tYWMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2 aXNpb24gMTY4ODI0KQorKysgU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDUtMTQgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgorCisgICAgICAgIEdJRiBhbmltYXRpb25zIGRvbid0IHJlc3RhcnQgYWZ0ZXIg c2Nyb2xsaW5nIHdpdGggaU9TIFdlYktpdDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzMjkwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTY0OTA4 NTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX2RpZEZpbmlzaFNjcm9sbGlu Z09yWm9vbWluZ10pOgorICAgICAgICAKKyAgICAgICAgICAgIENoZWNrIGlmIHRoZSBhbmltYXRp b25zIG5lZWQgdG8gYmUgcmVzdGFydGVkIGFmdGVyIHNjcm9sbGluZyBmaW5pc2hlcy4KKwogMjAx NC0wNS0wOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IEFsbG93IFJlbW90ZSBJbnNwZWN0b3IgdG8gZW50aXRsZW1lbnQgY2hl Y2sgVUlQcm9jZXNzIHRocm91Z2ggV2ViUHJvY2VzcwpJbmRleDogU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViVmlldy5tbQkocmV2aXNpb24gMTY4NzQyKQorKysgU291cmNlL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNTc4LDYgKzE1NzgsOSBAQCAtICh2 b2lkKV9kaWRGaW5pc2hTY3JvbGxpbmdPclpvb21pbmcKICAgICBfcHJpdmF0ZS0+bWFpblZpZXdJ c1Njcm9sbGluZ09yWm9vbWluZyA9IE5POwogICAgIFtzZWxmIHNldERlZmVyc0NhbGxiYWNrczpO T107CiAgICAgW1tzZWxmIG1haW5GcmFtZV0gc2V0VGltZW91dHNQYXVzZWQ6Tk9dOworICAgIEZy YW1lVmlldyogdmlldyA9IFtzZWxmIF9tYWluQ29yZUZyYW1lXS0+dmlldygpOworICAgIGlmICh2 aWV3ICYmIHZpZXctPnJlbmRlclZpZXcoKSkKKyAgICAgICAgdmlldy0+cmVuZGVyVmlldygpLT5y ZXN1bWVQYXVzZWRJbWFnZUFuaW1hdGlvbnNJZk5lZWRlZCgpOwogfQogCiAtICh2b2lkKV9zZXRS ZXNvdXJjZUxvYWRTY2hlZHVsZXJTdXNwZW5kZWQ6KEJPT0wpc3VzcGVuZAo=