132896 2014-05-13 19:39:08 -0700 [ftlopt] DFG should not exit due to inadequate profiling coverage when it can trivially fill in the profiling coverage due to variable constant inference and the better prediction modeling of typed array GetByVals 2014-05-13 21:30:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 1009160 0 fpizlo 2014-05-13 19:39:08 -0700 Patch forthcoming. 1009161 1 231427 fpizlo 2014-05-13 19:42:40 -0700 Created attachment 231427 the patch 1009163 2 231427 ggaren 2014-05-13 20:10:29 -0700 Comment on attachment 231427 the patch Do we need a js/regress test? 1009164 3 fpizlo 2014-05-13 20:11:36 -0700 (In reply to comment #2) > (From update of attachment 231427 [details]) > Do we need a js/regress test? I don't think so - this already gets a nice SunSpider win. It's hard to test convergence with a synthetic benchmark, since for very small programs, even if we recompile a few times it ends up being cheap. 1009181 4 fpizlo 2014-05-13 21:30:33 -0700 Landed in http://trac.webkit.org/changeset/168780 231427 2014-05-13 19:42:40 -0700 2014-05-13 20:10:28 -0700 the patch blah.patch text/plain 7121 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTY4NzY4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTA1LTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W2Z0bG9wdF0gREZHIHNob3VsZCBub3QgZXhpdCBkdWUgdG8gaW5hZGVxdWF0ZSBwcm9maWxpbmcg Y292ZXJhZ2Ugd2hlbiBpdCBjYW4gdHJpdmlhbGx5IGZpbGwgaW4gdGhlIHByb2ZpbGluZyBjb3Zl cmFnZSBkdWUgdG8gdmFyaWFibGUgY29uc3RhbnQgaW5mZXJlbmNlIGFuZCB0aGUgYmV0dGVyIHBy ZWRpY3Rpb24gbW9kZWxpbmcgb2YgdHlwZWQgYXJyYXkgR2V0QnlWYWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI4OTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoaXMgaXMgYSBzbGln aHQgd2luIG9uIFN1blNwaWRlciwgYnV0IGl0J3MgbWVhbnQgdG8gdWx0aW1hdGVseSBoZWxwIHVz IG9uCisgICAgICAgIGVtYmVuY2hlbi9sdWEuIFdlIGFscmVhZHkgZG8gd2VsbCBvbiB0aGF0IGJl bmNobWFyayBidXQgb3VyIGNvbnZlcmdlbmNlIGlzIHNsb3dlciB0aGFuCisgICAgICAgIEknZCBs aWtlLgorCisgICAgICAgICogZGZnL0RGR0FycmF5TW9kZS5jcHA6CisgICAgICAgIChKU0M6OkRG Rzo6QXJyYXlNb2RlOjpyZWZpbmUpOgorICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5j cHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2spOgorICAg ICAgICAqIGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBo YXNlOjpmaXh1cE5vZGUpOgorICAgICAgICAqIGRmZy9ERkdQcmVkaWN0aW9uUHJvcGFnYXRpb25Q aGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6UHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2U6 OnByb3BhZ2F0ZSk6CisKIDIwMTQtMDUtMTMgIHBlYXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0 bG9vay5jb20+CiAKICAgICAgICAgW1dpbl0gRW51bSB0eXBlIHdpdGggdmFsdWUgemVybyBpcyBj b21wYXRpYmxlIHdpdGggdm9pZCosIHBvdGVudGlhbCBjYXVzZSBvZiBjcmFzaGVzLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQXJyYXlNb2RlLmNwcAkocmV2aXNpb24gMTY4 NTIyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTgsOSArMTU4LDYgQEAgQXJyYXlNb2RlIEFycmF5TW9kZTo6cmVmaW5l KAogICAgIC8vIHNob3VsZCBqdXN0IHRydXN0IHRoZSBhcnJheSBwcm9maWxlLgogICAgIAogICAg IHN3aXRjaCAodHlwZSgpKSB7Ci0gICAgY2FzZSBBcnJheTo6VW5wcm9maWxlZDoKLSAgICAgICAg cmV0dXJuIEFycmF5TW9kZShBcnJheTo6Rm9yY2VFeGl0KTsKLSAgICAgICAgCiAgICAgY2FzZSBB cnJheTo6VW5kZWNpZGVkOgogICAgICAgICBpZiAoIXZhbHVlKQogICAgICAgICAgICAgcmV0dXJu IHdpdGhUeXBlKEFycmF5OjpGb3JjZUV4aXQpOwpAQCAtMTg5LDYgKzE4Niw3IEBAIEFycmF5TW9k ZSBBcnJheU1vZGU6OnJlZmluZSgKICAgICAgICAgICAgIHJldHVybiB3aXRoQ29udmVyc2lvbihB cnJheTo6UmFnZUNvbnZlcnQpOwogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgICAgIAorICAg IGNhc2UgQXJyYXk6OlVucHJvZmlsZWQ6CiAgICAgY2FzZSBBcnJheTo6U2VsZWN0VXNpbmdQcmVk aWN0aW9uczogewogICAgICAgICBiYXNlICY9IH5TcGVjT3RoZXI7CiAgICAgICAgIApAQCAtMjM5 LDYgKzIzNyw4IEBAIEFycmF5TW9kZSBBcnJheU1vZGU6OnJlZmluZSgKICAgICAgICAgaWYgKGlz RmxvYXQ2NEFycmF5U3BlY3VsYXRpb24oYmFzZSkpCiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0 LndpdGhUeXBlKEFycmF5OjpGbG9hdDY0QXJyYXkpOwogCisgICAgICAgIGlmICh0eXBlKCkgPT0g QXJyYXk6OlVucHJvZmlsZWQpCisgICAgICAgICAgICByZXR1cm4gQXJyYXlNb2RlKEFycmF5OjpG b3JjZUV4aXQpOwogICAgICAgICByZXR1cm4gQXJyYXlNb2RlKEFycmF5OjpHZW5lcmljKTsKICAg ICB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQ YXJzZXIuY3BwCShyZXZpc2lvbiAxNjg1MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0J5dGVDb2RlUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYzMiw3ICsyNjMyLDcg QEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6cGFyc2VCbG9jayh1bnNpZ25lZAogICAgICAgICAvLyA9 PT0gUHJvcGVydHkgYWNjZXNzIG9wZXJhdGlvbnMgPT09CiAKICAgICAgICAgY2FzZSBvcF9nZXRf YnlfdmFsOiB7Ci0gICAgICAgICAgICBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0aW9uID0gZ2V0UHJl ZGljdGlvbigpOworICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUgcHJlZGljdGlvbiA9IGdldFBy ZWRpY3Rpb25XaXRob3V0T1NSRXhpdCgpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBOb2Rl KiBiYXNlID0gZ2V0KFZpcnR1YWxSZWdpc3RlcihjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVy YW5kKSk7CiAgICAgICAgICAgICBBcnJheU1vZGUgYXJyYXlNb2RlID0gZ2V0QXJyYXlNb2RlQ29u c2lkZXJpbmdTbG93UGF0aChjdXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5hcnJheVByb2ZpbGUsIEFy cmF5OjpSZWFkKTsKQEAgLTMwNTEsMTIgKzMwNTEsMTIgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6 cGFyc2VCbG9jayh1bnNpZ25lZAogCiAgICAgICAgICAgICBVTlVTRURfUEFSQU0od2F0Y2hwb2lu dHMpOyAvLyBXZSB3aWxsIHVzZSB0aGlzIGluIHRoZSBmdXR1cmUuIEZvciBub3cgd2Ugc2V0IGl0 IGFzIGEgd2F5IG9mIGRvY3VtZW50aW5nIHRoZSBmYWN0IHRoYXQgdGhhdCdzIHdoYXQgaW5kZXgg NSBpcyBpbiBHbG9iYWxWYXIgbW9kZS4KIAotICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUgcHJl ZGljdGlvbiA9IGdldFByZWRpY3Rpb24oKTsKICAgICAgICAgICAgIEpTR2xvYmFsT2JqZWN0KiBn bG9iYWxPYmplY3QgPSBtX2lubGluZVN0YWNrVG9wLT5tX2NvZGVCbG9jay0+Z2xvYmFsT2JqZWN0 KCk7CiAKICAgICAgICAgICAgIHN3aXRjaCAocmVzb2x2ZVR5cGUpIHsKICAgICAgICAgICAgIGNh c2UgR2xvYmFsUHJvcGVydHk6CiAgICAgICAgICAgICBjYXNlIEdsb2JhbFByb3BlcnR5V2l0aFZh ckluamVjdGlvbkNoZWNrczogeworICAgICAgICAgICAgICAgIFNwZWN1bGF0ZWRUeXBlIHByZWRp Y3Rpb24gPSBnZXRQcmVkaWN0aW9uKCk7CiAgICAgICAgICAgICAgICAgR2V0QnlJZFN0YXR1cyBz dGF0dXMgPSBHZXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yKCptX3ZtLCBzdHJ1Y3R1cmUsIHVpZCk7 CiAgICAgICAgICAgICAgICAgaWYgKHN0YXR1cy5zdGF0ZSgpICE9IEdldEJ5SWRTdGF0dXM6OlNp bXBsZSB8fCBzdGF0dXMubnVtVmFyaWFudHMoKSAhPSAxKSB7CiAgICAgICAgICAgICAgICAgICAg IHNldChWaXJ0dWFsUmVnaXN0ZXIoZHN0KSwgYWRkVG9HcmFwaChHZXRCeUlkRmx1c2gsIE9wSW5m byhpZGVudGlmaWVyTnVtYmVyKSwgT3BJbmZvKHByZWRpY3Rpb24pLCBnZXQoVmlydHVhbFJlZ2lz dGVyKHNjb3BlKSkpKTsKQEAgLTMwNzgsNiArMzA3OCw3IEBAIGJvb2wgQnl0ZUNvZGVQYXJzZXI6 OnBhcnNlQmxvY2sodW5zaWduZWQKICAgICAgICAgICAgICAgICBKU1ZhbHVlIHNwZWNpZmljVmFs dWUgPQogICAgICAgICAgICAgICAgICAgICB3YXRjaHBvaW50U2V0ID8gd2F0Y2hwb2ludFNldC0+ aW5mZXJyZWRWYWx1ZSgpIDogSlNWYWx1ZSgpOwogICAgICAgICAgICAgICAgIGlmICghc3BlY2lm aWNWYWx1ZSkgeworICAgICAgICAgICAgICAgICAgICBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0aW9u ID0gZ2V0UHJlZGljdGlvbigpOwogICAgICAgICAgICAgICAgICAgICBzZXQoVmlydHVhbFJlZ2lz dGVyKGRzdCksIGFkZFRvR3JhcGgoR2V0R2xvYmFsVmFyLCBPcEluZm8ob3BlcmFuZCksIE9wSW5m byhwcmVkaWN0aW9uKSkpOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAg ICAgICB9CkBAIC0zMTA0LDYgKzMxMDUsNyBAQCBib29sIEJ5dGVDb2RlUGFyc2VyOjpwYXJzZUJs b2NrKHVuc2lnbmVkCiAgICAgICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgU3BlY3VsYXRlZFR5cGUg cHJlZGljdGlvbiA9IGdldFByZWRpY3Rpb24oKTsKICAgICAgICAgICAgICAgICBzZXQoVmlydHVh bFJlZ2lzdGVyKGRzdCksCiAgICAgICAgICAgICAgICAgICAgIGFkZFRvR3JhcGgoR2V0Q2xvc3Vy ZVZhciwgT3BJbmZvKG9wZXJhbmQpLCBPcEluZm8ocHJlZGljdGlvbiksIAogICAgICAgICAgICAg ICAgICAgICAgICAgYWRkVG9HcmFwaChHZXRDbG9zdXJlUmVnaXN0ZXJzLCBzY29wZU5vZGUpKSk7 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAJKHJl dmlzaW9uIDE2ODUyMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFz ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5Myw2ICs0OTMsMTEgQEAgcHJpdmF0ZToKICAgICAg ICAgfQogCiAgICAgICAgIGNhc2UgR2V0QnlWYWw6IHsKKyAgICAgICAgICAgIGlmICghbm9kZS0+ cHJlZGljdGlvbigpKSB7CisgICAgICAgICAgICAgICAgbV9pbnNlcnRpb25TZXQuaW5zZXJ0Tm9k ZSgKKyAgICAgICAgICAgICAgICAgICAgbV9pbmRleEluQmxvY2ssIFNwZWNOb25lLCBGb3JjZU9T UkV4aXQsIG5vZGUtPm9yaWdpbik7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKICAgICAg ICAgICAgIG5vZGUtPnNldEFycmF5TW9kZSgKICAgICAgICAgICAgICAgICBub2RlLT5hcnJheU1v ZGUoKS5yZWZpbmUoCiAgICAgICAgICAgICAgICAgICAgIG1fZ3JhcGgsIG5vZGUsCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Q cm9wYWdhdGlvblBoYXNlLmNwcAkocmV2aXNpb24gMTY4NTIyKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdQcmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM2OSwxOCArMzY5LDIzIEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgR2V0QnlWYWw6 IHsKICAgICAgICAgICAgIGlmICghbm9kZS0+Y2hpbGQxKCktPnByZWRpY3Rpb24oKSkKICAgICAg ICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAgIGlmICghbm9kZS0+Z2V0SGVhcFByZWRpY3Rp b24oKSkKLSAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIAogICAgICAgICAgICAg aWYgKG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVGbG9hdDMyQXJyYXkoKQogICAgICAg ICAgICAgICAgIHx8IG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVGbG9hdDY0QXJyYXko KSkKICAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdlUHJlZGljdGlvbihTcGVjRnVsbERv dWJsZSk7CiAgICAgICAgICAgICBlbHNlIGlmIChub2RlLT5jaGlsZDEoKS0+c2hvdWxkU3BlY3Vs YXRlVWludDMyQXJyYXkoKSkgewotICAgICAgICAgICAgICAgIGlmIChpc0ludDMyU3BlY3VsYXRp b24obm9kZS0+Z2V0SGVhcFByZWRpY3Rpb24oKSkpCisgICAgICAgICAgICAgICAgaWYgKGlzSW50 MzJTcGVjdWxhdGlvbkZvckFyaXRobWV0aWMobm9kZS0+Z2V0SGVhcFByZWRpY3Rpb24oKSkpCiAg ICAgICAgICAgICAgICAgICAgIGNoYW5nZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKFNwZWNJbnQzMik7 CiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1l cmdlUHJlZGljdGlvbihTcGVjSW50NTIpOwotICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAg ICB9IGVsc2UgaWYgKAorICAgICAgICAgICAgICAgIG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVj dWxhdGVJbnQ4QXJyYXkoKQorICAgICAgICAgICAgICAgIHx8IG5vZGUtPmNoaWxkMSgpLT5zaG91 bGRTcGVjdWxhdGVJbnQxNkFycmF5KCkKKyAgICAgICAgICAgICAgICB8fCBub2RlLT5jaGlsZDEo KS0+c2hvdWxkU3BlY3VsYXRlSW50MzJBcnJheSgpCisgICAgICAgICAgICAgICAgfHwgbm9kZS0+ Y2hpbGQxKCktPnNob3VsZFNwZWN1bGF0ZVVpbnQ4QXJyYXkoKQorICAgICAgICAgICAgICAgIHx8 IG5vZGUtPmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVVaW50MTZBcnJheSgpKQorICAgICAgICAg ICAgICAgIGNoYW5nZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKFNwZWNJbnQzMik7CisgICAgICAgICAg ICBlbHNlCiAgICAgICAgICAgICAgICAgY2hhbmdlZCB8PSBtZXJnZVByZWRpY3Rpb24obm9kZS0+ Z2V0SGVhcFByZWRpY3Rpb24oKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQo=