132891 2014-05-13 16:30:41 -0700 Web Inspector: Force developerExtrasEnabled when a remote client connects 2014-05-13 18:01:42 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1009128 0 timothy 2014-05-13 16:30:41 -0700 iOS does this currently in PageDebuggable. We need to do it on Mac too. <rdar://problem/16332868> 1009130 1 231418 timothy 2014-05-13 16:34:39 -0700 Created attachment 231418 Patch 1009136 2 231418 joepeck 2014-05-13 16:46:13 -0700 Comment on attachment 231418 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231418&action=review r=me, Ultimately we should have our own way of forcing a setting on WebCore::Settings from inside of WebCore that don't adjust the exact same bit as WebKit APIs. > Source/WebCore/page/PageDebuggable.cpp:103 > + if (m_forcedDeveloperExtrasEnabled) > + m_page.settings().setDeveloperExtrasEnabled(false); This should now flip m_forcedDeveloperExtrasEnabled back to false. 1009138 3 231422 timothy 2014-05-13 16:49:14 -0700 Created attachment 231422 Patch 1009146 4 231422 commit-queue 2014-05-13 17:22:09 -0700 Comment on attachment 231422 Patch Clearing flags on attachment: 231422 Committed r168764: <http://trac.webkit.org/changeset/168764> 1009147 5 commit-queue 2014-05-13 17:22:12 -0700 All reviewed patches have been landed. Closing bug. 1009152 6 joepeck 2014-05-13 18:01:42 -0700 Build Fix: <http://trac.webkit.org/changeset/168767> 231418 2014-05-13 16:34:39 -0700 2014-05-13 16:49:12 -0700 Patch bug-132891-20140513163415.patch text/plain 3142 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE4OTY4ZWE0MWRlOGVk MjFiMDk2NTczMzI4NTA3ZjY1OGFmNWM2Zi4uNzdmMzNkYTA4NzRjNDZhNTg2OTkzY2E5NTY1YWE1 MTlkNTIyYTcyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTEzICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBGb3JjZSBkZXZlbG9w ZXJFeHRyYXNFbmFibGVkIHdoZW4gYSByZW1vdGUgSW5zcGVjdG9yIGNsaWVudCBjb25uZWN0cy4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyODkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdl L1BhZ2VEZWJ1Z2dhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VEZWJ1Z2dhYmxlOjpQ YWdlRGVidWdnYWJsZSk6IEluaXRpYWxpemUgbV9mb3JjZWREZXZlbG9wZXJFeHRyYXNFbmFibGVk IHRvIGZhbHNlLgorICAgICAgICAoV2ViQ29yZTo6UGFnZURlYnVnZ2FibGU6OmNvbm5lY3QpOiBT ZXQgbV9mb3JjZWREZXZlbG9wZXJFeHRyYXNFbmFibGVkIGlmIHRoZSBzZXR0aW5nIGlzIGNoYW5n ZWQuCisgICAgICAgIChXZWJDb3JlOjpQYWdlRGVidWdnYWJsZTo6ZGlzY29ubmVjdCk6IFN3aXRj aCBkZXZlbG9wZXJFeHRyYXNFbmFibGVkIGJhY2sgdG8gZmFsc2UKKyAgICAgICAgaWYgbV9mb3Jj ZWREZXZlbG9wZXJFeHRyYXNFbmFibGVkIGlzIHRydWUuCisgICAgICAgICogcGFnZS9QYWdlRGVi dWdnYWJsZS5oOiBBZGRlZCBtX2ZvcmNlZERldmVsb3BlckV4dHJhc0VuYWJsZWQuCisKIDIwMTQt MDUtMDggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPUyBXSzJdIEJvdHRvbS1yZWxhdGl2ZSBwb3NpdGlvbjpmaXhlZCBlbGVtZW50cyBhcmUgbWlz cGxhY2VkIG9uIHBhZ2UgbG9hZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl RGVidWdnYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VEZWJ1Z2dhYmxlLmNwcApp bmRleCA5ODYzMjNkZTc5MmFmZjc1M2FiMjRiZmRhOTcyOWI5NTkzYTUxMDIxLi5hY2Y0ZDBmMTY3 MWJlZGZiMTdkYzU0MWJlZWQ5ZTJiNjI4ZGU1ZDZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BhZ2VEZWJ1Z2dhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VE ZWJ1Z2dhYmxlLmNwcApAQCAtNDYsNiArNDYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFBh Z2VEZWJ1Z2dhYmxlOjpQYWdlRGVidWdnYWJsZShQYWdlJiBwYWdlKQogICAgIDogbV9wYWdlKHBh Z2UpCisgICAgLCBtX2ZvcmNlZERldmVsb3BlckV4dHJhc0VuYWJsZWQoZmFsc2UpCiB7CiB9CiAK QEAgLTgxLDExICs4MiwxMSBAQCBwaWRfdCBQYWdlRGVidWdnYWJsZTo6cGFyZW50UHJvY2Vzc0lk ZW50aWZpZXIoKSBjb25zdAogCiB2b2lkIFBhZ2VEZWJ1Z2dhYmxlOjpjb25uZWN0KEluc3BlY3Rv cjo6SW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKiBjaGFubmVsKQogewotI2lmIFBMQVRGT1JNKElP UykKLSAgICAvLyBPbiBpT1MgdGhlcmUgaXMgbm8gd2F5IHRvIGVuYWJsZSAvIGRpc2FibGUgZGV2 ZWxvcGVyIGV4dHJhcy4KLSAgICAvLyBTbyB0b2dnbGUgaXQgb24gd2hlbiB3ZSBoYXZlIGEgcmVt b3RlIGluc3BlY3RvciBjb25uZWN0aW9uLgotICAgIG1fcGFnZS5zZXR0aW5ncygpLnNldERldmVs b3BlckV4dHJhc0VuYWJsZWQodHJ1ZSk7Ci0jZW5kaWYKKyAgICBpZiAoIW1fcGFnZS5zZXR0aW5n cygpLmRldmVsb3BlckV4dHJhc0VuYWJsZWQoKSkgeworICAgICAgICBtX2ZvcmNlZERldmVsb3Bl ckV4dHJhc0VuYWJsZWQgPSB0cnVlOworICAgICAgICBtX3BhZ2Uuc2V0dGluZ3MoKS5zZXREZXZl bG9wZXJFeHRyYXNFbmFibGVkKHRydWUpOworICAgIH0gZWxzZQorICAgICAgICBtX2ZvcmNlZERl dmVsb3BlckV4dHJhc0VuYWJsZWQgPSBmYWxzZTsKIAogICAgIEluc3BlY3RvckNvbnRyb2xsZXIm IGluc3BlY3RvckNvbnRyb2xsZXIgPSBtX3BhZ2UuaW5zcGVjdG9yQ29udHJvbGxlcigpOwogICAg IGluc3BlY3RvckNvbnRyb2xsZXIuc2V0SGFzUmVtb3RlRnJvbnRlbmQodHJ1ZSk7CkBAIC05OCw5 ICs5OSw4IEBAIHZvaWQgUGFnZURlYnVnZ2FibGU6OmRpc2Nvbm5lY3QoKQogICAgIGluc3BlY3Rv ckNvbnRyb2xsZXIuZGlzY29ubmVjdEZyb250ZW5kKEluc3BlY3RvckRpc2Nvbm5lY3RSZWFzb246 Okluc3BlY3RvckRlc3Ryb3llZCk7CiAgICAgaW5zcGVjdG9yQ29udHJvbGxlci5zZXRIYXNSZW1v dGVGcm9udGVuZChmYWxzZSk7CiAKLSNpZiBQTEFURk9STShJT1MpCi0gICAgbV9wYWdlLnNldHRp bmdzKCkuc2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChmYWxzZSk7Ci0jZW5kaWYKKyAgICBpZiAo bV9mb3JjZWREZXZlbG9wZXJFeHRyYXNFbmFibGVkKQorICAgICAgICBtX3BhZ2Uuc2V0dGluZ3Mo KS5zZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKGZhbHNlKTsKIH0KIAogdm9pZCBQYWdlRGVidWdn YWJsZTo6ZGlzcGF0Y2hNZXNzYWdlRnJvbVJlbW90ZUZyb250ZW5kKGNvbnN0IFN0cmluZyYgbWVz c2FnZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZURlYnVnZ2FibGUuaCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZURlYnVnZ2FibGUuaAppbmRleCBiYzFmZjY0NTg2MGQw ZTZjNWRjMThlZGEwYjIxOTJjYjhhM2Q5MDM1Li4zNmU4MjQ1NTEzYjZiNDc1NTlhNTQ3YWE5NjVl MTAwZmJkYmQxMjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VEZWJ1Z2dh YmxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlRGVidWdnYWJsZS5oCkBAIC01NSw2 ICs1NSw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBQYWdlJiBtX3BhZ2U7CisgICAgYm9v bCBtX2ZvcmNlZERldmVsb3BlckV4dHJhc0VuYWJsZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCg== 231422 2014-05-13 16:49:14 -0700 2014-05-13 17:22:09 -0700 Patch bug-132891-20140513164850.patch text/plain 3202 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTY4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE4OTY4ZWE0MWRlOGVk MjFiMDk2NTczMzI4NTA3ZjY1OGFmNWM2Zi4uOTMzNDQ4N2Y3NWZlZTg1MzZjY2MyMGI0NjdjOGFh MjBhMzVlOTBiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA1LTEzICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBGb3JjZSBkZXZlbG9w ZXJFeHRyYXNFbmFibGVkIHdoZW4gYSByZW1vdGUgSW5zcGVjdG9yIGNsaWVudCBjb25uZWN0cy4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMyODkx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICogcGFn ZS9QYWdlRGVidWdnYWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlRGVidWdnYWJsZTo6 UGFnZURlYnVnZ2FibGUpOiBJbml0aWFsaXplIG1fZm9yY2VkRGV2ZWxvcGVyRXh0cmFzRW5hYmxl ZCB0byBmYWxzZS4KKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VEZWJ1Z2dhYmxlOjpjb25uZWN0KTog U2V0IG1fZm9yY2VkRGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCBpZiB0aGUgc2V0dGluZyBpcyBjaGFu Z2VkLgorICAgICAgICAoV2ViQ29yZTo6UGFnZURlYnVnZ2FibGU6OmRpc2Nvbm5lY3QpOiBTd2l0 Y2ggZGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCBiYWNrIHRvIGZhbHNlCisgICAgICAgIGlmIG1fZm9y Y2VkRGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCBpcyB0cnVlLgorICAgICAgICAqIHBhZ2UvUGFnZURl YnVnZ2FibGUuaDogQWRkZWQgbV9mb3JjZWREZXZlbG9wZXJFeHRyYXNFbmFibGVkLgorCiAyMDE0 LTA1LTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFtpT1MgV0syXSBCb3R0b20tcmVsYXRpdmUgcG9zaXRpb246Zml4ZWQgZWxlbWVudHMgYXJlIG1p c3BsYWNlZCBvbiBwYWdlIGxvYWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZURlYnVnZ2FibGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlRGVidWdnYWJsZS5jcHAK aW5kZXggOTg2MzIzZGU3OTJhZmY3NTNhYjI0YmZkYTk3MjliOTU5M2E1MTAyMS4uNzEzMjg2Njk3 YjA4ZDVhYjUxMzkyNjYwYjYyM2RkNTc5MjlmMjY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlRGVidWdnYWJsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl RGVidWdnYWJsZS5jcHAKQEAgLTQ2LDYgKzQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBQ YWdlRGVidWdnYWJsZTo6UGFnZURlYnVnZ2FibGUoUGFnZSYgcGFnZSkKICAgICA6IG1fcGFnZShw YWdlKQorICAgICwgbV9mb3JjZWREZXZlbG9wZXJFeHRyYXNFbmFibGVkKGZhbHNlKQogewogfQog CkBAIC04MSwxMSArODIsMTEgQEAgcGlkX3QgUGFnZURlYnVnZ2FibGU6OnBhcmVudFByb2Nlc3NJ ZGVudGlmaWVyKCkgY29uc3QKIAogdm9pZCBQYWdlRGVidWdnYWJsZTo6Y29ubmVjdChJbnNwZWN0 b3I6Okluc3BlY3RvckZyb250ZW5kQ2hhbm5lbCogY2hhbm5lbCkKIHsKLSNpZiBQTEFURk9STShJ T1MpCi0gICAgLy8gT24gaU9TIHRoZXJlIGlzIG5vIHdheSB0byBlbmFibGUgLyBkaXNhYmxlIGRl dmVsb3BlciBleHRyYXMuCi0gICAgLy8gU28gdG9nZ2xlIGl0IG9uIHdoZW4gd2UgaGF2ZSBhIHJl bW90ZSBpbnNwZWN0b3IgY29ubmVjdGlvbi4KLSAgICBtX3BhZ2Uuc2V0dGluZ3MoKS5zZXREZXZl bG9wZXJFeHRyYXNFbmFibGVkKHRydWUpOwotI2VuZGlmCisgICAgaWYgKCFtX3BhZ2Uuc2V0dGlu Z3MoKS5kZXZlbG9wZXJFeHRyYXNFbmFibGVkKCkpIHsKKyAgICAgICAgbV9mb3JjZWREZXZlbG9w ZXJFeHRyYXNFbmFibGVkID0gdHJ1ZTsKKyAgICAgICAgbV9wYWdlLnNldHRpbmdzKCkuc2V0RGV2 ZWxvcGVyRXh0cmFzRW5hYmxlZCh0cnVlKTsKKyAgICB9IGVsc2UKKyAgICAgICAgbV9mb3JjZWRE ZXZlbG9wZXJFeHRyYXNFbmFibGVkID0gZmFsc2U7CiAKICAgICBJbnNwZWN0b3JDb250cm9sbGVy JiBpbnNwZWN0b3JDb250cm9sbGVyID0gbV9wYWdlLmluc3BlY3RvckNvbnRyb2xsZXIoKTsKICAg ICBpbnNwZWN0b3JDb250cm9sbGVyLnNldEhhc1JlbW90ZUZyb250ZW5kKHRydWUpOwpAQCAtOTgs OSArOTksMTAgQEAgdm9pZCBQYWdlRGVidWdnYWJsZTo6ZGlzY29ubmVjdCgpCiAgICAgaW5zcGVj dG9yQ29udHJvbGxlci5kaXNjb25uZWN0RnJvbnRlbmQoSW5zcGVjdG9yRGlzY29ubmVjdFJlYXNv bjo6SW5zcGVjdG9yRGVzdHJveWVkKTsKICAgICBpbnNwZWN0b3JDb250cm9sbGVyLnNldEhhc1Jl bW90ZUZyb250ZW5kKGZhbHNlKTsKIAotI2lmIFBMQVRGT1JNKElPUykKLSAgICBtX3BhZ2Uuc2V0 dGluZ3MoKS5zZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKGZhbHNlKTsKLSNlbmRpZgorICAgIGlm IChtX2ZvcmNlZERldmVsb3BlckV4dHJhc0VuYWJsZWQpIHsKKyAgICAgICAgbV9mb3JjZWREZXZl bG9wZXJFeHRyYXNFbmFibGVkID0gZmFsc2U7CisgICAgICAgIG1fcGFnZS5zZXR0aW5ncygpLnNl dERldmVsb3BlckV4dHJhc0VuYWJsZWQoZmFsc2UpOworICAgIH0KIH0KIAogdm9pZCBQYWdlRGVi dWdnYWJsZTo6ZGlzcGF0Y2hNZXNzYWdlRnJvbVJlbW90ZUZyb250ZW5kKGNvbnN0IFN0cmluZyYg bWVzc2FnZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZURlYnVnZ2FibGUu aCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZURlYnVnZ2FibGUuaAppbmRleCBiYzFmZjY0NTg2 MGQwZTZjNWRjMThlZGEwYjIxOTJjYjhhM2Q5MDM1Li4zNmU4MjQ1NTEzYjZiNDc1NTlhNTQ3YWE5 NjVlMTAwZmJkYmQxMjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2VEZWJ1 Z2dhYmxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlRGVidWdnYWJsZS5oCkBAIC01 NSw2ICs1NSw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBQYWdlJiBtX3BhZ2U7CisgICAg Ym9vbCBtX2ZvcmNlZERldmVsb3BlckV4dHJhc0VuYWJsZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCg==