132876 2014-05-13 11:02:18 -0700 AX: Hit testing not accounting for top content inset. 2014-05-13 15:27:15 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac (Intel) OS X 10.9 RESOLVED FIXED InRadar P1 Normal --- 1 samuel_white samuel_white commit-queue webkit-bug-importer oldest_to_newest 1009008 0 samuel_white 2014-05-13 11:02:18 -0700 WKAccessibilityWebPageObjectMac::accessibilityHitTest: is not accounting for top content inset when translating screen coords to WebKit coords. 1009010 1 samuel_white 2014-05-13 11:03:56 -0700 <rdar://problem/16777273> 1009015 2 231396 samuel_white 2014-05-13 11:09:53 -0700 Created attachment 231396 Patch. Any thoughts on testing this one? Not seeing a way to force DRT or TestRunner to HAVE a top content inset. 1009016 3 commit-queue 2014-05-13 11:11:43 -0700 Attachment 231396 did not pass style-queue: ERROR: Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:202: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1009028 4 231396 cfleizach 2014-05-13 11:45:26 -0700 Comment on attachment 231396 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=231396&action=review > Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:203 > + convertedPoint.move(0, -page->topContentInset()); is there only ever a Y contentInset? or is there also a x content inset we should account for 1009071 5 samuel_white 2014-05-13 14:08:48 -0700 (In reply to comment #4) > (From update of attachment 231396 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231396&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:203 > > + convertedPoint.move(0, -page->topContentInset()); > > is there only ever a Y contentInset? or is there also a x content inset we should account for That's a great question. The bug originated from a y-axis inset issue only and the exposed methods such as "topContentInset" have no matching bottom/left/right equivalents. I think we should focus this bug on just the top inset issue since it's the only manifestation we have thus far. 1009074 6 231396 cfleizach 2014-05-13 14:12:31 -0700 Comment on attachment 231396 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=231396&action=review >>> Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:203 >>> + convertedPoint.move(0, -page->topContentInset()); >> >> is there only ever a Y contentInset? or is there also a x content inset we should account for > > That's a great question. The bug originated from a y-axis inset issue only and the exposed methods such as "topContentInset" have no matching bottom/left/right equivalents. > > I think we should focus this bug on just the top inset issue since it's the only manifestation we have thus far. as long as there are no equivalent contentInset parameters, this seems ok 1009089 7 samuel_white 2014-05-13 14:55:36 -0700 (In reply to comment #6) > (From update of attachment 231396 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231396&action=review > > >>> Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:203 > >>> + convertedPoint.move(0, -page->topContentInset()); > >> > >> is there only ever a Y contentInset? or is there also a x content inset we should account for > > > > That's a great question. The bug originated from a y-axis inset issue only and the exposed methods such as "topContentInset" have no matching bottom/left/right equivalents. > > > > I think we should focus this bug on just the top inset issue since it's the only manifestation we have thus far. > > as long as there are no equivalent contentInset parameters, this seems ok Thanks. I'll file a bug for the invalid style failure. 1009094 8 samuel_white 2014-05-13 15:00:32 -0700 style failure bug: https://bugs.webkit.org/show_bug.cgi?id=132887 1009108 9 231396 commit-queue 2014-05-13 15:27:12 -0700 Comment on attachment 231396 Patch. Clearing flags on attachment: 231396 Committed r168745: <http://trac.webkit.org/changeset/168745> 1009109 10 commit-queue 2014-05-13 15:27:15 -0700 All reviewed patches have been landed. Closing bug. 231396 2014-05-13 11:09:53 -0700 2014-05-13 15:27:12 -0700 Patch. fix.diff text/plain 1584 samuel_white SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2ODY4OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA1LTEzICBTYW11ZWwg V2hpdGUgIDxzYW11ZWxfd2hpdGVAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBIaXQgdGVzdGlu ZyBub3QgYWNjb3VudGluZyBmb3IgdG9wIGNvbnRlbnQgaW5zZXQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzI4NzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIGFjY2Vzc2liaWxpdHlIaXRU ZXN0OiB0byBhY2NvdW50IGZvciB0b3AgY29udGVudCBpbnNldCB3aGVuIGNvbnZlcnRpbmcgZnJv bSBzY3JlZW4gY29vcmRzIHRvIFdlYktpdCBjb29yZHMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3RNYWMubW06CisgICAgICAg ICgtW1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3QgYWNjZXNzaWJpbGl0eUhpdFRlc3Q6XSk6 CisKIDIwMTQtMDUtMTIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IE1ha2UgYSBmZXcgaWNvbiBkYXRhYmFzZSBpbXByb3ZlbWVudHMKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1h Yy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3RNYWMubW0JKHJldmlzaW9uIDE2ODY1MykKKysr IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV0tBY2Nlc3NpYmlsaXR5V2Vi UGFnZU9iamVjdE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTk5LDcgKzE5OSw5IEBACiAgICAg SW50UG9pbnQgY29udmVydGVkUG9pbnQgPSBtX3BhZ2UtPnNjcmVlblRvUm9vdFZpZXcoSW50UG9p bnQocG9pbnQpKTsKICAgICBpZiAoV2ViQ29yZTo6RnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBtX3Bh Z2UtPm1haW5GcmFtZVZpZXcoKSkKICAgICAgICAgY29udmVydGVkUG9pbnQubW92ZUJ5KGZyYW1l Vmlldy0+c2Nyb2xsUG9zaXRpb24oKSk7Ci0gICAgICAgIAorICAgIGlmIChXZWJDb3JlOjpQYWdl KiBwYWdlID0gbV9wYWdlLT5jb3JlUGFnZSgpKQorICAgICAgICBjb252ZXJ0ZWRQb2ludC5tb3Zl KDAsIC1wYWdlLT50b3BDb250ZW50SW5zZXQoKSk7CisgICAgCiAgICAgcmV0dXJuIFtbc2VsZiBh Y2Nlc3NpYmlsaXR5Um9vdE9iamVjdFdyYXBwZXJdIGFjY2Vzc2liaWxpdHlIaXRUZXN0OmNvbnZl cnRlZFBvaW50XTsKIH0KICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AK